From: Kees Monshouwer <mind04@monshouwer.org>
Date: Fri, 28 Jul 2017 11:04:16 +0000 (+0200)
Subject: NOTIMP is only appropriate for an unsupported opcode
X-Git-Tag: dnsdist-1.2.0~6^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F5611%2Fhead;p=thirdparty%2Fpdns.git

NOTIMP is only appropriate for an unsupported opcode
---

diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index e4be541d29..853128404f 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -1200,7 +1200,7 @@ DNSPacket *PacketHandler::doQuestion(DNSPacket *p)
     // L<<Logger::Warning<<"Query for '"<<p->qdomain<<"' "<<p->qtype.getName()<<" from "<<p->getRemote()<< " (tcp="<<p->d_tcp<<")"<<endl;
     
     if(p->qtype.getCode()==QType::IXFR) {
-      r->setRcode(RCode::NotImp);
+      r->setRcode(RCode::Refused);
       return r;
     }
 
@@ -1214,9 +1214,9 @@ DNSPacket *PacketHandler::doQuestion(DNSPacket *p)
         return r;
     }
 
-    // we only know about qclass IN (and ANY), send NotImp for everything else.
+    // we only know about qclass IN (and ANY), send Refused for everything else.
     if(p->qclass != QClass::IN && p->qclass!=QClass::ANY) {
-      r->setRcode(RCode::NotImp);
+      r->setRcode(RCode::Refused);
       return r;
     }
 
@@ -1299,7 +1299,7 @@ DNSPacket *PacketHandler::doQuestion(DNSPacket *p)
     // this TRUMPS a cname!
     if(p->qtype.getCode() == QType::RRSIG) {
       L<<Logger::Info<<"Direct RRSIG query for "<<target<<" from "<<p->getRemote()<<endl;
-      r->setRcode(RCode::NotImp);
+      r->setRcode(RCode::Refused);
       goto sendit;
     }
 
diff --git a/regression-tests/tests/direct-rrsig/expected_result b/regression-tests/tests/direct-rrsig/expected_result
index c6e05f4038..bd42abb723 100644
--- a/regression-tests/tests/direct-rrsig/expected_result
+++ b/regression-tests/tests/direct-rrsig/expected_result
@@ -1,3 +1,3 @@
 2	.	IN	OPT	32768	
-Rcode: 4 (Not Implemented), RD: 0, QR: 1, TC: 0, AA: 1, opcode: 0
+Rcode: 5 (Query Refused), RD: 0, QR: 1, TC: 0, AA: 1, opcode: 0
 Reply to question for qname='example.com.', qtype=RRSIG