From: Jason Ish <jason.ish@oisf.net>
Date: Thu, 11 Feb 2021 22:34:34 +0000 (-0600)
Subject: github-ci: test install of library
X-Git-Tag: suricata-7.0.0-beta1~1795
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F5866%2Fhead;p=thirdparty%2Fsuricata.git

github-ci: test install of library

Add library install test to Fedora 33 build. In this case the
shared library is disable so the test makes sure it is not
installed.

Also make sure the library and headers are not installed until
explicitly installed.

Add similar to test to an Ubuntu 24.04 build without disable-shared
and check that the shared library is installed.
---

diff --git a/.github/workflows/builds.yml b/.github/workflows/builds.yml
index 5ea599284e..20954113ae 100644
--- a/.github/workflows/builds.yml
+++ b/.github/workflows/builds.yml
@@ -383,6 +383,18 @@ jobs:
         run: tar xf prep/suricata-verify.tar.gz
       - name: Running suricata-verify
         run: python3 ./suricata-verify/run.py
+      # Now install and make sure headers and libraries aren't install
+      # until requested.
+      - run: make install
+      - run: test ! -e /usr/local/lib/libsuricata_c.a
+      - run: test ! -e /usr/local/include/suricata
+      - run: make install-headers
+      - run: test -e /usr/local/include/suricata/suricata.h
+      - run: make install-library
+      - run: test -e /usr/local/lib/libsuricata_c.a
+      - run: test -e /usr/local/lib/libsuricata_rust.a
+      - run: test -e /usr/local/bin/libsuricata-config
+      - run: test ! -e /usr/local/lib/libsuricata.so
 
   fedora-32:
     name: Fedora 32 (debug, clang, asan, wshadow, rust-strict)
@@ -816,6 +828,19 @@ jobs:
         run: tar xf prep/suricata-verify.tar.gz
       - name: Running suricata-verify
         run: python3 ./suricata-verify/run.py
+      # Now install and make sure headers and libraries aren't install
+      # until requested.
+      - run: make install
+      - run: test ! -e /usr/local/lib/libsuricata_c.a
+      - run: test ! -e /usr/local/include/suricata
+      - run: make install-headers
+      - run: test -e /usr/local/include/suricata/suricata.h
+      - run: make install-library
+      - run: test -e /usr/local/lib/libsuricata_c.a
+      - run: test -e /usr/local/lib/libsuricata_rust.a
+      - run: test -e /usr/local/bin/libsuricata-config
+      - run: test -e /usr/local/lib/libsuricata.so
+      - run: test -e /usr/local/lib/$(readlink /usr/local/lib/libsuricata.so)
 
   ubuntu-20-04-too-old-rust:
     name: Ubuntu 20.04 (unsupported rust)