From: Christoph Grüninger <foss@grueninger.de>
Date: Tue, 13 May 2025 17:11:35 +0000 (+0200)
Subject: decision.c: void function should not return anything
X-Git-Tag: 0.7.33~6^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F588%2Fhead;p=thirdparty%2Flibsolv.git

decision.c: void function should not return anything

Do not call to solver_get_proof as part of return statement

Found by GCC ("ISO C forbids ‘return’ with expression, in
function returning void", pedantic).
---

diff --git a/src/decision.c b/src/decision.c
index ec9da99c..353b80c8 100644
--- a/src/decision.c
+++ b/src/decision.c
@@ -737,7 +737,10 @@ solver_get_decisionlist(Solver *solv, Id id, int flags, Queue *decisionlistq)
   Pool *pool = solv->pool;
   Map dm;
   if ((flags & SOLVER_DECISIONLIST_TYPEMASK) != SOLVER_DECISIONLIST_SOLVABLE)
-    return solver_get_proof(solv, id, flags, decisionlistq);
+  {
+    solver_get_proof(solv, id, flags, decisionlistq);
+    return;
+  }
   map_init(&dm, pool->nsolvables);
   MAPSET(&dm, id);
   getdecisionlist(solv, &dm, flags, decisionlistq);