From: Christoph Grüninger <foss@grueninger.de>
Date: Wed, 14 May 2025 19:31:56 +0000 (+0200)
Subject: pool.c: Remove identical if condition
X-Git-Tag: 0.7.33~4^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F590%2Fhead;p=thirdparty%2Flibsolv.git

pool.c: Remove identical if condition

It is always true.
Found by Cppcheck (identicalInnerCondition).
---

diff --git a/src/pool.c b/src/pool.c
index 14511def..0f989b16 100644
--- a/src/pool.c
+++ b/src/pool.c
@@ -594,8 +594,7 @@ pool_createwhatprovides(Pool *pool)
     }
   else if (!pool->addedfileprovides && pool->disttype == DISTTYPE_RPM)
     {
-      if (!pool->addedfileprovides)
-	POOL_DEBUG(SOLV_DEBUG_STATS, "WARNING: pool_addfileprovides was not called, this may result in slow operation\n");
+      POOL_DEBUG(SOLV_DEBUG_STATS, "WARNING: pool_addfileprovides was not called, this may result in slow operation\n");
       /* lazyly add file provides */
       for (i = 1; i < num; i++)
 	{