From: Victor Julien <victor@inliniac.net>
Date: Wed, 6 Nov 2013 16:25:06 +0000 (+0100)
Subject: detect: don't do rule reload during delayed detect
X-Git-Tag: suricata-2.0beta2~173
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F615%2Fhead;p=thirdparty%2Fsuricata.git

detect: don't do rule reload during delayed detect

When both rule reloads and delayed detect are enabled, make sure we don't
trigger a reload during delayed detect initialization.

Bug #1023.
---

diff --git a/src/suricata.c b/src/suricata.c
index 300f072aa9..ccd918bf25 100644
--- a/src/suricata.c
+++ b/src/suricata.c
@@ -228,6 +228,11 @@ void SignalHandlerSigusr2Disabled(int sig)
     return;
 }
 
+void SignalHandlerSigusr2DelayedDetect(int sig)
+{
+    SCLogWarning(SC_ERR_LIVE_RULE_SWAP, "Live rule reload blocked while delayed detect is still loading.");
+}
+
 void SignalHandlerSigusr2SigFileStartup(int sig)
 {
     SCLogInfo("Live rule reload not possible if -s or -S option used at runtime.");
@@ -2007,10 +2012,12 @@ int main(int argc, char **argv)
     DetectEngineRegisterAppInspectionEngines();
 
     if (suri.rule_reload) {
-        if (suri.sig_file == NULL)
-            UtilSignalHandlerSetup(SIGUSR2, SignalHandlerSigusr2Idle);
-        else
+        if (suri.sig_file != NULL)
             UtilSignalHandlerSetup(SIGUSR2, SignalHandlerSigusr2SigFileStartup);
+        else if (suri.delayed_detect)
+            UtilSignalHandlerSetup(SIGUSR2, SignalHandlerSigusr2DelayedDetect);
+        else
+            UtilSignalHandlerSetup(SIGUSR2, SignalHandlerSigusr2Idle);
     } else {
         UtilSignalHandlerSetup(SIGUSR2, SignalHandlerSigusr2Disabled);
     }
@@ -2142,6 +2149,13 @@ int main(int argc, char **argv)
             exit(EXIT_FAILURE);
         de_ctx->delayed_detect_initialized = 1;
         TmThreadActivateDummySlot();
+
+        if (suri.rule_reload) {
+            if (suri.sig_file != NULL)
+                UtilSignalHandlerSetup(SIGUSR2, SignalHandlerSigusr2SigFileStartup);
+            else
+                UtilSignalHandlerSetup(SIGUSR2, SignalHandlerSigusr2Idle);
+        }
         SCLogNotice("Signature(s) loaded, Detect thread(s) activated.");
     }