From: Nick Hammond <nick@nickhammond.com>
Date: Fri, 30 Jan 2015 22:42:00 +0000 (-0600)
Subject: Ensure that the validate function returns the full list of validations to properly... 
X-Git-Tag: v5.5.2~133^2~2^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F6241%2Fhead;p=thirdparty%2Ffoundation%2Ffoundation-sites.git

Ensure that the validate function returns the full list of validations to properly focus
---

diff --git a/js/foundation/foundation.abide.js b/js/foundation/foundation.abide.js
index 517e97a2d..58997faf6 100644
--- a/js/foundation/foundation.abide.js
+++ b/js/foundation/foundation.abide.js
@@ -242,7 +242,6 @@
         }
         validations.push(el_validations[0]);
       }
-      validations = [validations.every(function (valid) {return valid;})];
       return validations;
     },
 
diff --git a/spec/abide/abide.js b/spec/abide/abide.js
index 56adc1ad7..05564ad48 100644
--- a/spec/abide/abide.js
+++ b/spec/abide/abide.js
@@ -102,6 +102,20 @@ describe('abide:', function() {
       expect($('input[name="user_name"]')).not.toHaveData('invalid');
     });
 
+    it('should not focus hidden fields that are not required', function() {
+      $(document).foundation();
+      hidden_element = 'input[name="utf8"]';
+      first_element = 'input[name="user_name"]';
+
+      spyOnEvent(hidden_element, 'focus');
+      spyOnEvent(first_element, 'focus');
+
+      $('form').submit();
+
+      expect('focus').not.toHaveBeenTriggeredOn(hidden_element);
+      expect('focus').toHaveBeenTriggeredOn(first_element);
+    });
+
   });
 
   describe('advanced validation', function() {
diff --git a/spec/abide/basic.html b/spec/abide/basic.html
index 5000841ff..8b360e7ad 100644
--- a/spec/abide/basic.html
+++ b/spec/abide/basic.html
@@ -1,4 +1,5 @@
 <form data-abide="ajax">
+  <input name="utf8" type="hidden" value="&#x2713;" />
   <div class="name-field">
     <label>Your name <small>required</small></label>
     <input name="user_name" type="text" required pattern="[a-zA-Z]+">