From: Arne Welzel <arne.welzel@corelight.com>
Date: Wed, 4 May 2022 18:06:36 +0000 (+0200)
Subject: stacktrace-on-signal: Use kill(getpid(), sig_num)
X-Git-Tag: suricata-7.0.0-beta1~592
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F7389%2Fhead;p=thirdparty%2Fsuricata.git

stacktrace-on-signal: Use kill(getpid(), sig_num)

kill(0, ...) re-raises the signal to every processes in the process
group which may impact unrelated processes.

Concretely, in our CI pipeline, a segfaulting Suricata process killed
the test driver.
---

diff --git a/src/suricata.c b/src/suricata.c
index 24ffa0fe64..b246ce13f1 100644
--- a/src/suricata.c
+++ b/src/suricata.c
@@ -342,7 +342,7 @@ static void SignalHandlerUnexpected(int sig_num, siginfo_t *info, void *context)
 
 terminate:
     // Propagate signal to watchers, if any
-    kill(0, sig_num);
+    kill(getpid(), sig_num);
 }
 #undef UNW_LOCAL_ONLY
 #endif /* HAVE_LIBUNWIND */