From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Thu, 17 Jun 2021 11:41:58 +0000 (+0200)
Subject: mkosi: avoid mutable default arguments
X-Git-Tag: v10~17^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F743%2Fhead;p=thirdparty%2Fmkosi.git

mkosi: avoid mutable default arguments
---

diff --git a/mkosi/backend.py b/mkosi/backend.py
index f66da33f2..836efe475 100644
--- a/mkosi/backend.py
+++ b/mkosi/backend.py
@@ -361,8 +361,8 @@ def run_workspace_command(
     root: str,
     cmd: List[str],
     network: bool = False,
-    env: Dict[str, str] = {},
-    nspawn_params: List[str] = [],
+    env: Optional[Dict[str, str]] = None,
+    nspawn_params: Optional[List[str]] = None,
 ) -> None:
     cmdline = [
         "systemd-nspawn",
@@ -382,7 +382,8 @@ def run_workspace_command(
     else:
         cmdline += ["--private-network"]
 
-    cmdline += [f"--setenv={k}={v}" for k, v in env.items()]
+    if env:
+        cmdline += [f"--setenv={k}={v}" for k, v in env.items()]
 
     if nspawn_params:
         cmdline += nspawn_params