From: Kizuna-Meraki <z9@kizunameraki.de>
Date: Thu, 17 Feb 2022 20:27:01 +0000 (+0100)
Subject: Close file on error path.
X-Git-Tag: json-c-0.16-20220414~22^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F744%2Fhead;p=thirdparty%2Fjson-c.git

Close file on error path.

The file was only be closed when there was no error and
was being left open when there was an error. By moving
the close(fd) statement out of the if-clause, the file
can be close regardless if there is an error or not.
After the file is closed, it can be checked for errors.
---

diff --git a/random_seed.c b/random_seed.c
index 46229795..7945824c 100644
--- a/random_seed.c
+++ b/random_seed.c
@@ -237,13 +237,15 @@ static int get_dev_random_seed(int *seed)
 	}
 
 	ssize_t nread = read(fd, seed, sizeof(*seed));
+
+	close(fd);
+
 	if (nread != sizeof(*seed))
 	{
 		fprintf(stderr, "error short read %s: %s", dev_random_file, strerror(errno));
 		return -1;
 	}
 
-	close(fd);
 	return 0;
 }