From: Victor Julien <victor@inliniac.net>
Date: Wed, 18 Dec 2013 08:14:20 +0000 (+0100)
Subject: stream: don't send empty streammsg at stream end
X-Git-Tag: suricata-2.0rc1~212
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F759%2Fhead;p=thirdparty%2Fsuricata.git

stream: don't send empty streammsg at stream end

No longer send an empty StreamMsg through the engine on stream end,
the messages were ignored anyway.
---

diff --git a/src/stream-tcp-reassemble.c b/src/stream-tcp-reassemble.c
index 3d8222d22b..3b5e92b5ac 100644
--- a/src/stream-tcp-reassemble.c
+++ b/src/stream-tcp-reassemble.c
@@ -3057,21 +3057,7 @@ static int StreamTcpReassembleRaw (TcpReassemblyThreadCtx *ra_ctx,
         SCReturnInt(0);
 
     if (stream->seg_list == NULL) {
-        /* send an empty EOF msg if we have no segments but TCP state
-         * is beyond ESTABLISHED */
-        if (ssn->state > TCP_ESTABLISHED) {
-            StreamMsg *smsg = StreamMsgGetFromPool();
-            if (smsg == NULL) {
-                SCLogDebug("stream_msg_pool is empty");
-                SCReturnInt(-1);
-            }
-            StreamTcpSetupMsg(ssn, stream, p, smsg);
-            StreamTcpStoreStreamChunk(ssn, smsg, p, 0);
-
-        } else {
-            SCLogDebug("no segments in the list to reassemble");
-        }
-
+        SCLogDebug("no segments in the list to reassemble");
         SCReturnInt(0);
     }