From: Leo Vdw <48684914+DNS-Leo@users.noreply.github.com>
Date: Thu, 21 Mar 2019 22:01:12 +0000 (+0100)
Subject: RKEY is missing algorithm field
X-Git-Tag: rec-4.2.0-rc1~21^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F7615%2Fhead;p=thirdparty%2Fpdns.git

RKEY is missing algorithm field

This RR type is missing a data field.
draft-reid-dnsext-rkey-00 defines the data as flags (0) / protocol (1) / algorithm / key, and for these last two is refering to RFC4034

https://tools.ietf.org/html/draft-reid-dnsext-rkey-00
https://tools.ietf.org/html/rfc4034#section-2.1
---

diff --git a/pdns/dnsrecords.cc b/pdns/dnsrecords.cc
index d89419e232..d1d491d0b1 100644
--- a/pdns/dnsrecords.cc
+++ b/pdns/dnsrecords.cc
@@ -397,6 +397,7 @@ CDNSKEYRecordContent::CDNSKEYRecordContent() {}
 boilerplate_conv(RKEY, 57, 
                  conv.xfr16BitInt(d_flags); 
                  conv.xfr8BitInt(d_protocol); 
+                 conv.xfr8BitInt(d_algorithm); 
                  conv.xfrBlob(d_key);
                  )
 RKEYRecordContent::RKEYRecordContent() {}