From: Aarni Koskela <akx@iki.fi>
Date: Thu, 27 Jan 2022 14:20:34 +0000 (+0200)
Subject: Add frontend for extract directory filter
X-Git-Tag: v2.10.0~20^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F832%2Fhead;p=thirdparty%2Fbabel.git

Add frontend for extract directory filter

Co-authored-by: Kinshuk Dua <kinshukduaexam@gmail.com>
---

diff --git a/babel/messages/frontend.py b/babel/messages/frontend.py
index 2bfb46cc..41b75cec 100644
--- a/babel/messages/frontend.py
+++ b/babel/messages/frontend.py
@@ -10,6 +10,7 @@
 """
 from __future__ import print_function
 
+import fnmatch
 import logging
 import optparse
 import os
@@ -256,6 +257,20 @@ class compile_catalog(Command):
         return catalogs_and_errors
 
 
+def _make_directory_filter(ignore_patterns):
+    """
+    Build a directory_filter function based on a list of ignore patterns.
+    """
+    def cli_directory_filter(dirname):
+        basename = os.path.basename(dirname)
+        return not any(
+            fnmatch.fnmatch(basename, ignore_pattern)
+            for ignore_pattern
+            in ignore_patterns
+        )
+    return cli_directory_filter
+
+
 class extract_messages(Command):
     """Message extraction command for use in ``setup.py`` scripts.
 
@@ -320,13 +335,20 @@ class extract_messages(Command):
          'files or directories with commas(,)'),  # TODO: Support repetition of this argument
         ('input-dirs=', None,  # TODO (3.x): Remove me.
          'alias for input-paths (does allow files as well as directories).'),
+        ('ignore-dirs=', None,
+         'Patterns for directories to ignore when scanning for messages. '
+         'Separate multiple patterns with spaces (default ".* ._")'),
     ]
     boolean_options = [
         'no-default-keywords', 'no-location', 'omit-header', 'no-wrap',
         'sort-output', 'sort-by-file', 'strip-comments'
     ]
     as_args = 'input-paths'
-    multiple_value_options = ('add-comments', 'keywords')
+    multiple_value_options = (
+        'add-comments',
+        'keywords',
+        'ignore-dirs',
+    )
     option_aliases = {
         'keywords': ('--keyword',),
         'mapping-file': ('--mapping',),
@@ -359,6 +381,7 @@ class extract_messages(Command):
         self.add_comments = None
         self.strip_comments = False
         self.include_lineno = True
+        self.ignore_dirs = None
 
     def finalize_options(self):
         if self.input_dirs:
@@ -427,6 +450,13 @@ class extract_messages(Command):
         elif self.add_location == 'file':
             self.include_lineno = False
 
+        ignore_dirs = listify_value(self.ignore_dirs)
+        if ignore_dirs:
+            self.directory_filter = _make_directory_filter(self.ignore_dirs)
+        else:
+            self.directory_filter = None
+
+
     def run(self):
         mappings = self._get_mappings()
         with open(self.output_file, 'wb') as outfile:
@@ -469,7 +499,8 @@ class extract_messages(Command):
                         keywords=self.keywords,
                         comment_tags=self.add_comments,
                         callback=callback,
-                        strip_comment_tags=self.strip_comments
+                        strip_comment_tags=self.strip_comments,
+                        directory_filter=self.directory_filter,
                     )
                 for filename, lineno, message, comments, context in extracted:
                     if os.path.isfile(path):
diff --git a/tests/messages/data/project/_hidden_by_default/hidden_file.py b/tests/messages/data/project/_hidden_by_default/hidden_file.py
new file mode 100644
index 00000000..325afc95
--- /dev/null
+++ b/tests/messages/data/project/_hidden_by_default/hidden_file.py
@@ -0,0 +1,5 @@
+from gettext import gettext
+
+
+def foo():
+    print(gettext('ssshhh....'))
diff --git a/tests/messages/test_frontend.py b/tests/messages/test_frontend.py
index 50471e70..2dc53306 100644
--- a/tests/messages/test_frontend.py
+++ b/tests/messages/test_frontend.py
@@ -1431,3 +1431,26 @@ def test_extract_error_code(monkeypatch, capsys):
     if err:
         # replace hack below for py2/py3 compatibility
         assert "unknown named placeholder 'merkki'" in err.replace("u'", "'")
+
+
+@pytest.mark.parametrize("with_underscore_ignore", (False, True))
+def test_extract_ignore_dirs(monkeypatch, capsys, tmp_path, with_underscore_ignore):
+    pot_file = tmp_path / 'temp.pot'
+    monkeypatch.chdir(project_dir)
+    cmd = "extract . -o '{}' --ignore-dirs '*ignored*' ".format(pot_file)
+    if with_underscore_ignore:
+        # This also tests that multiple arguments are supported.
+        cmd += "--ignore-dirs '_*'"
+    cmdinst = configure_cli_command(cmd)
+    assert isinstance(cmdinst, extract_messages)
+    assert cmdinst.directory_filter
+    cmdinst.run()
+    pot_content = pot_file.read_text()
+
+    # The `ignored` directory is now actually ignored:
+    assert 'this_wont_normally_be_here' not in pot_content
+
+    # Since we manually set a filter, the otherwise `_hidden` directory is walked into,
+    # unless we opt in to ignore it again
+    assert ('ssshhh....' in pot_content) != with_underscore_ignore
+    assert ('_hidden_by_default' in pot_content) != with_underscore_ignore