From: Victor Julien <vjulien@oisf.net>
Date: Mon, 24 Apr 2023 08:07:01 +0000 (+0200)
Subject: packet/queue: debug validation for pkt src
X-Git-Tag: suricata-7.0.0-rc2~355
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F8754%2Fhead;p=thirdparty%2Fsuricata.git

packet/queue: debug validation for pkt src
---

diff --git a/src/packet-queue.c b/src/packet-queue.c
index e9617007c1..81c7798ef7 100644
--- a/src/packet-queue.c
+++ b/src/packet-queue.c
@@ -30,6 +30,7 @@
 #include "suricata.h"
 #include "util-var.h"
 #include "pkt-var.h"
+#include "util-validate.h"
 
 #ifdef DEBUG
 void PacketQueueValidateDebug(PacketQueue *q);
@@ -166,6 +167,7 @@ static inline void PacketEnqueueDo(PacketQueue *q, Packet *p)
 
 void PacketEnqueueNoLock(PacketQueueNoLock *qnl, Packet *p)
 {
+    DEBUG_VALIDATE_BUG_ON(p->pkt_src == 0);
     PacketQueue *q = (PacketQueue *)qnl;
     PacketEnqueueDo(q, p);
 }
@@ -206,7 +208,9 @@ static inline Packet *PacketDequeueDo (PacketQueue *q)
 Packet *PacketDequeueNoLock (PacketQueueNoLock *qnl)
 {
     PacketQueue *q = (PacketQueue *)qnl;
-    return PacketDequeueDo(q);
+    Packet *p = PacketDequeueDo(q);
+    DEBUG_VALIDATE_BUG_ON(p != NULL && p->pkt_src == 0);
+    return p;
 }
 
 Packet *PacketDequeue (PacketQueue *q)