From: Aki Tuomi <cmouse@cmouse.fi>
Date: Wed, 12 Aug 2020 12:25:13 +0000 (+0300)
Subject: dynhandler: Do not copy master value
X-Git-Tag: rec-4.4.0-beta1~25^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F8824%2Fhead;p=thirdparty%2Fpdns.git

dynhandler: Do not copy master value
---

diff --git a/pdns/dynhandler.cc b/pdns/dynhandler.cc
index dc60be2abe..5614f9c212 100644
--- a/pdns/dynhandler.cc
+++ b/pdns/dynhandler.cc
@@ -275,7 +275,7 @@ string DLNotifyRetrieveHandler(const vector<string>&parts, Utility::pid_t ppid)
     return "Domain '"+domain.toString()+"' is not a slave domain (or has no master defined)";
 
   shuffle(di.masters.begin(), di.masters.end(), pdns::dns_random_engine());
-  auto master = di.masters.front();
+  const auto& master = di.masters.front();
   Communicator.addSuckRequest(domain, master, override_master);
   g_log<<Logger::Warning<<"Retrieval request for domain '"<<domain<<"' from master '"<<master<<"' received from operator"<<endl;
   return "Added retrieval request for '"+domain.toLogString()+"' from master "+master.toLogString();