From: Greg Hudson <ghudson@mit.edu>
Date: Tue, 19 Mar 2019 15:15:26 +0000 (-0400)
Subject: Suppress krb5_cc_start_seq_get() popups in Leash
X-Git-Tag: krb5-1.18-beta1~167
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F909%2Fhead;p=thirdparty%2Fkrb5.git

Suppress krb5_cc_start_seq_get() popups in Leash

Under some circumstances (perhaps related to a February Windows 10
update), Leash can get past the krb5_cc_get_principal() step when
processing an empty MSLSA ccache, and get a KRB5_CC_NOMATCH error from
krb5_cc_start_seq_get().  Do not display a modal error dialog if this
happens.

ticket: 8790
tags: pullup
target_version: 1.17-next
---

diff --git a/src/windows/leash/KrbListTickets.cpp b/src/windows/leash/KrbListTickets.cpp
index 5dd37b05a4..62bc55ad67 100644
--- a/src/windows/leash/KrbListTickets.cpp
+++ b/src/windows/leash/KrbListTickets.cpp
@@ -222,7 +222,8 @@ do_ccache(krb5_context ctx,
     }
     code = pkrb5_cc_start_seq_get(ctx, cache, &cur);
     if (code) {
-        functionName = "krb5_cc_start_seq_get";
+        // MSLSA errors here if no TGT is found; suppress error message box
+        code = 0;
         goto cleanup;
     }
     if (*ticketInfoTail)