Ken Raeburn [Thu, 29 Jun 2006 23:51:55 +0000 (23:51 +0000)]
* kdb5_util.c (add_db_arg): New function.
(main): Use it.
* kdb5_util.h (add_db_arg): Declare it.
* kdb5_create.c (kdb5_create): Use it.
* dump.c (load_db): Use it.
Tom Yu [Thu, 29 Jun 2006 22:12:19 +0000 (22:12 +0000)]
re-order inclusions in spnego_mech.c to avoid breaking system headers
* src/lib/gssapi/spnego/spnego_mech.c: Move inclusion of
gssapiP_spnego.h to after mglueP.h. mglueP.h includes
k5-thread.h, which pulls in the pthread headers, which on at least
some Tru64 versions is vulnerable to definitions of non-reserved
macro names such as CONTEXT, which is defined in
gssapiP_spnego.h.
ticket: new
tags: pullup
target_version: 1.5
version_reported: 1.5
component: krb5-build
Ken Raeburn [Thu, 29 Jun 2006 21:29:03 +0000 (21:29 +0000)]
* lib/gssapi/Makefile.in: Merge the new target into the existing
target list with generated headers mostly in subdirectories, which
happens to be inside a "##DOS##!if 0" block, since the all-recurse
target isn't defined for Windows.
Ezra Peisach [Thu, 29 Jun 2006 13:26:42 +0000 (13:26 +0000)]
Makefile.in: Change T_STD_CONF_OBJS to only list t_std_conf.o and pull in the
rest from libkrb5. This fixes the problem of linking in init_os_ctx.o which
was trying to use the private copy_profile() that was not exported.
Also - updated dependencies - init_os_ctx.c now includes prof-int.h...
Ken Raeburn [Thu, 29 Jun 2006 01:42:42 +0000 (01:42 +0000)]
check calling conventions specified for Windows
When we're making changes on UNIX, sometimes we update the Windows
export list but forget to make sure we've annotated the function
declaration in the header file with a calling convention
specification.
This patch checks the krb5 and gssapi public headers against the
Windows export lists (which are annotated with calling-convention and
other info in comments), and flags any inconsistencies in public
interfaces.
* util/def-check.pl: Be quiet about normal stuff by default; accept a
"-v" option to be verbose. Exit with non-zero status if something
wrong is detected. Fix some problems in parsing gssapi header files.
Handle DECSCRIPTION and HEAPSIZE directives in .def files, and DATA
annotation in comments.
* include/Makefile.in (verify-calling-conventions-krb5): New target.
(all-unix): Depend on it in maintainer mode.
* lib/gssapi/Makefile.in (verify-calling-conventions-gssapi): New target.
(all-unix): Depend on it in maintainer mode.
(merged-gssapi-header.h): New target; assemble public headers into one input
file.
(clean-misc-unix): New target; delete merged-gssapi-header.h.
(clean-unix): Depend on it.
Jeffrey Altman [Wed, 28 Jun 2006 23:00:09 +0000 (23:00 +0000)]
cc_mslsa.c: The WOW64 environment on 64-bit versions of
Windows prior to Vista Beta 2 did not implement the Lsa
functions used by the MSLSA: ccache. This patch disables
the MSLSA: ccache in broken WOW64 environments by checking
the Windows version and the existence and response of the
IsWow64Process API.
Ken Raeburn [Wed, 28 Jun 2006 05:31:52 +0000 (05:31 +0000)]
allow multiple calls to krb5_get_error_message to retrieve message
(krb5int_get_error): Don't discard old message if the error codes don't match.
Try a little harder not to keep messages in the scratch buffer. Return a copy
of the message, or "out of memory" in the scratch buffer.
(krb5int_vset_error): Try a little harder not to keep messages in the scratch
buffer.
Ken Raeburn [Wed, 28 Jun 2006 05:18:38 +0000 (05:18 +0000)]
implement symbol export restrictions for Solaris
* lib.in (solaris.versions): New target. Currently no version id, just a
symbol list.
* libnover.in (solaris.versions): New target.
(clean-libs): Delete it.
* shlib.conf (*-*-solaris*): Use solaris.versions as map file.
(clean-libs): Delete it.
Ken Raeburn [Tue, 27 Jun 2006 00:00:03 +0000 (00:00 +0000)]
Revise comment on when we should switch from writing back to reading
on a TCP stream. (We don't currently, ever, and we probably should
eventually, but sometimes closing the connection is required.)
Ken Raeburn [Mon, 26 Jun 2006 23:47:03 +0000 (23:47 +0000)]
* kdc/network.c (make_toolong_error): New function.
(process_tcp_connection): If the specified length exceeds the internal limit,
stop reading and send back a FIELD_TOOLONG error.
* tests/dejagnu/krb-standalone/standalone.exp (doit): When testing TCP mode,
connect to the KDC and send a length of -1, and check that it sends back a
non-empty message.
Jeffrey Altman [Sun, 25 Jun 2006 19:21:41 +0000 (19:21 +0000)]
NetIDMgr updates
* add scrollbars to option tree pane in configuration dialog
* convert to using Microsoft's safe string library both to ensure
safe string manipulation and to avoid deprecation warnings
* disable deprecation warnings for Platform SDK header shlwapi.h
which cannot otherwise be compiled
* add kerberos 5 kvno property to tickets. display in properties
dialog and main window if column selected by user
* improve manifest handling in order to support both manifests
generated by the compiler and those hand crafted in order to
specify the correct versions of the custom control libraries.
* update khimaira message types and credential acquisition
documentation
Ken Raeburn [Sat, 24 Jun 2006 02:39:52 +0000 (02:39 +0000)]
Fix krb5_get_profile to create a new profile duplicating the list of
files from the one in the provided context, instead of constructing
and checking the file list from scratch. Uses a new function in the
profile library, not put into the public API yet.
* util/profile/prof_init.c (profile_copy): New function.
* util/profile/prof_int.h (profile_copy): Declare it.
* lib/krb5/os/Makefile.in (LOCALINCLUDES): Look in the profile source dir.
* lib/krb5/os/init_os_ctx.c (krb5_get_profile): Replace all the previous code
with a call to profile_copy.
Tom Yu [Thu, 22 Jun 2006 22:23:02 +0000 (22:23 +0000)]
* src/lib/krb5/krb/srv_rcache.c (krb5_get_server_rcache): Apply
patch from Rainer Weikusat to avoid double-free when
rc_resolve_full() fails due to misconfiguration.
Tom Yu [Thu, 22 Jun 2006 21:31:15 +0000 (21:31 +0000)]
* src/lib/kadm5/ovsec_glue.c:
* src/lib/kadm5/unit-test/init-test.c:
* src/lib/kadm5/unit-test/iter-test.c:
* src/lib/kadm5/unit-test/lock-test.c: Include string.h to avoid
implicit definitions. Patch from Michael Calmer.
Ken Raeburn [Thu, 22 Jun 2006 19:18:19 +0000 (19:18 +0000)]
(clean-unix): Use DEPTARGETS_CLEAN instead of DEPTARGETS.
(DEPTARGETS_CLEAN, DEPTARGETS_@top_srcdir@_.): New targets; define so that
DEPTARGETS_CLEAN has the DEP_VERIFY targets only at the top level.
Sam Hartman [Thu, 22 Jun 2006 18:43:20 +0000 (18:43 +0000)]
r18022@luminous: jaltman | 2006-05-19 05:18:37 -0400
Updates of portable CCAPI sources. All code compiles.
r18025@luminous: jaltman | 2006-05-20 23:48:39 -0400
Construct an outline of a sample platform specific main.c
Add ccs_serv_cleanup() routine. Currently does nothing.
Correct field names used within the authorization check.
r18026@luminous: jaltman | 2006-05-22 02:25:43 -0400
More byte order conversions in the server operations code.
r18027@luminous: jaltman | 2006-05-22 13:12:49 -0400
Source files containing common routines used by both
the client and the server.
r18028@luminous: jaltman | 2006-05-22 13:17:07 -0400
Move msg.c and marshall.c to common library.
Add dllmain.c which contains the Windows DllMain() entry
point. This must be moved later to a Windows specific
directory.
Cleanup type usage and function name references.
All that is missing now from the client DLL is a definition
of cci_perform_rpc() which is the entry point to the IPC
routine.
r18029@luminous: jaltman | 2006-05-22 13:18:27 -0400
Move generic list functions to common/generic_lists.c
so they can be used by both the client dll and the server.
r18094@luminous: jaltman | 2006-06-09 10:42:04 -0400
* corrections to windows rpc layer
* corrections to network byte order conversions
r18095@luminous: lxs | 2006-06-09 17:46:24 -0400
cci_msg_retrieve_blob(): changed argument 4 from void** to char**
to suppress the warnings from gcc.
r18096@luminous: lxs | 2006-06-09 17:55:32 -0400
moved enum cc_list_type to generic_lists.h to avoid "incomplete enum"
warnings when compiling generic_lists.c
r18097@luminous: lxs | 2006-06-09 17:56:15 -0400
Removed ancient Metrowerks tests from public headers.
r18098@luminous: lxs | 2006-06-09 17:57:20 -0400
Include string.h to get memcpy, strlen, etc on BSD OSes.
r18099@luminous: lxs | 2006-06-09 17:59:36 -0400
Added Mac OS X project file and Mach-IPC support code
r18193@luminous: jaltman | 2006-06-22 12:57:14 -0400
This commit updates lib/krb5/ccache/ccapi to support CCAPI Version 3
and above. Specify -DUSE_CCAPI_V3=1 when compiling to use CCAPI Version 3
r18194@luminous: jaltman | 2006-06-22 12:58:37 -0400
Fix parameter name in cc_credentials_iterator_t next()
Tom Yu [Wed, 21 Jun 2006 21:08:31 +0000 (21:08 +0000)]
cease export of krb5_gss_*
* src/lib/gssapi/libgssapi_krb5.exports: Cease export of krb5
mechanism entry points which were once equivalent to GSS-API entry
points. These were never public interfaces, and calling them
directly now can cause problems. Also, cease export of some
other internal symbols.
ticket: new
target_version: 1.5
tags: pullup
component: krb5-libs
Ken Raeburn [Wed, 21 Jun 2006 00:28:21 +0000 (00:28 +0000)]
(GET_HOST_BY_NAME, GET_HOST_BY_ADDR) [GETHOSTBYNAME_RETURNS_INT]: Test
the output hostent pointer as an additional way of checking for errors.
Original patch from Nalin Dahyabhai, needed some tweaking to fit in
current sources, especially as updated in ticket 3911.
Ken Raeburn [Tue, 20 Jun 2006 23:59:11 +0000 (23:59 +0000)]
getaddrinfo code uses vars outside of storage duration
The calls to gethostbyname_r and friends were wrapped in macros that declared
automatic variables for the auxiliary storage needed, but the pointers returned
by the functions would be used outside of that scope, when the storage would no
longer be valid.
Changed the macro interfaces to define new types for the auxiliary storage, and
add a new argument to the macros referring to that storage. Changed call sites
accordingly.
Ken Raeburn [Tue, 20 Jun 2006 23:27:01 +0000 (23:27 +0000)]
(kadmin_cpw): Don't crash if principal name is not given. Based on a
patch from S Rahul.
(extended_com_err_fn): If error code is zero, don't fetch an error message.
Russ Allbery [Tue, 20 Jun 2006 21:45:16 +0000 (21:45 +0000)]
In verify_krb_v4_tgt, use an unsigned KRB4_32 to store an address rather
than an unsigned long to avoid memcpying past the end of a structure on
64-bit platforms.
Russ Allbery [Mon, 19 Jun 2006 23:37:09 +0000 (23:37 +0000)]
Pass in the correct value for the first argument of select (one larger
than the largest file number in the select set) rather than some multiple
of sizeof some struct. The latter is large enough accidentally work, but
breaks on AIX.
Map IPv4-mapped IPv6 addresses back to IPv4 in krshd for the purposes of
connecting back to the remote system on AIX, since on AIX getnameinfo
returns such addresses but connect won't accept them.
Jeffrey Altman [Mon, 19 Jun 2006 17:33:36 +0000 (17:33 +0000)]
Export krb5_gss_register_acceptor_identity in KFW
krb5_gss_register_acceptor_identity is a gss krb5 extension that is
part of the public ABI. It does not have a gss_krb5_* name due to
historical reasons. Instead there is a gss_krb5_register_acceptor_identity
macro that uses this export.
Ken Raeburn [Fri, 16 Jun 2006 00:26:49 +0000 (00:26 +0000)]
Remove -lkrb5support, which should be for internal use only, from the displayed
list of libraries. This means the output is not suitable for linking against
static libraries built from the tree, but prevents us from committing to
keeping libkrb5support.1 in all future Mac shared-library builds (in addition
to the libkrb5support.0 we're stuck with for non-Mac UNIXy shared-library
builds).
Ken Raeburn [Fri, 16 Jun 2006 00:10:08 +0000 (00:10 +0000)]
ftpd's getline conflicts with current glibc headers
Reported by Ubaidul Khan on kerberos@mit this date.
GNU libc includes a function getline with an incompatible prototype.
It hasn't caused problems for MIT on RHEL 4 (glibc 2.3.4), but
apparently FC5 has a newer set of headers in which it does.
* ftpcmd.y (getline): Renamed to ftpd_getline. Declarations and callers
changed.
* ftpd.c (getline): Remove duplicate declaration.
Ken Raeburn [Thu, 15 Jun 2006 22:01:57 +0000 (22:01 +0000)]
(kadmin_startup): Properly skip "\@" and "\/" sequences when
processing principal name, rather than going into an infinite loop.
Suggested by Mark Phalan at Sun.
Ken Raeburn [Wed, 14 Jun 2006 23:44:48 +0000 (23:44 +0000)]
Some simple transformations:
Use ANSI C function definitions instead of old K&R style.
Rename local variable "res" to "clnt_res".
Cast clnt_call arguments to xdrproc_t and caddr_t.
This brings the code more in line with what current (RHEL) rpcgen would do.
Russ Allbery [Wed, 14 Jun 2006 20:31:52 +0000 (20:31 +0000)]
When NULL is passed into krb_get_in_pw_tkt, we only want to prompt once
for the password rather than passing NULL along to each string to key
function causing each to prompt independently. Modify krb_get_in_pw_tkt
to call des_read_pw_string directly and then pass the resulting password
into each string to key function as needed. Add a prototype of
des_read_pw_string to krb4int.h since it's an exported function of
libdes425 but isn't prototyped in des.h.
Russ Allbery [Tue, 13 Jun 2006 16:03:12 +0000 (16:03 +0000)]
telnet help should telnet to a host named help, not display a usage
message. Only support ?, not help, to request help with the open
command. The same change was made in netkit's telnet.
Russ Allbery [Tue, 13 Jun 2006 15:18:04 +0000 (15:18 +0000)]
POSIX allows getpwnam_r and getpwuid_r to return 0 (success) even if the
username or UID could not be found, in which case OUT will be set to
NULL. Elsewhere, code assumes that if k5_getpwnam_r or k5_getpwuid_r
returns 0, OUT is non-NULL. Check whether OUT is NULL and adjust the
return value accordingly in the k5_getpw{nam,uid}_r wrappers.
Russ Allbery [Mon, 12 Jun 2006 19:59:35 +0000 (19:59 +0000)]
Always include sys/ioctl.h in the telnet and telnetd code, even if
sys/filio.h is available. GNU/kFreeBSD has sys/filio.h but still
requires sys/ioctl.h, and sys/ioctl.h is included unconditionally
elsewhere in the code. Patch from Petr Salinger.
projects / thirdparty / krb5.git / log
