]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
3 years agov4: Convert LDAP escape / unescape xlats to new API (#4227)
Nick Porter [Wed, 15 Sep 2021 15:15:40 +0000 (16:15 +0100)] 
v4: Convert LDAP escape / unescape xlats to new API (#4227)

* Update %{ldap_escape } to new xlat api

* Add tests for %{ldap_escape: }

* Convert %{ldap_unescape: } to new xlat api

* Add tests for %{ldap_unescape: }

* Look for the current character in the "specials" list, not the first

3 years agoFix signed integer promotion in a less elegant, but more functional way.
Arran Cudbard-Bell [Wed, 15 Sep 2021 15:01:36 +0000 (10:01 -0500)] 
Fix signed integer promotion in a less elegant, but more functional way.

3 years agoAdd additional tests which expose errors in the current net to signed, negative int...
Arran Cudbard-Bell [Wed, 15 Sep 2021 14:58:58 +0000 (09:58 -0500)] 
Add additional tests which expose errors in the current net to signed, negative int code

3 years agoAdd back env_escape to rlm_exec, and add env_inherit
Arran Cudbard-Bell [Wed, 15 Sep 2021 14:58:24 +0000 (09:58 -0500)] 
Add back env_escape to rlm_exec, and add env_inherit

3 years agoAdditional tests
Arran Cudbard-Bell [Wed, 15 Sep 2021 14:33:27 +0000 (09:33 -0500)] 
Additional tests

3 years agoPrint exec environment after merging
Arran Cudbard-Bell [Wed, 15 Sep 2021 06:00:38 +0000 (01:00 -0500)] 
Print exec environment after merging

3 years agoFixup environmental variable creation
Arran Cudbard-Bell [Wed, 15 Sep 2021 05:40:27 +0000 (00:40 -0500)] 
Fixup environmental variable creation

Use a thread-local buffer for envp, and to store temporary values

Don't wrap string values in env vars in quotes

3 years agoFix spurious error
Arran Cudbard-Bell [Wed, 15 Sep 2021 05:03:16 +0000 (00:03 -0500)] 
Fix spurious error

3 years agoFix very slow reaper leak
Arran Cudbard-Bell [Wed, 15 Sep 2021 04:51:30 +0000 (23:51 -0500)] 
Fix very slow reaper leak

3 years agoAdd extra tests for time_delta (#4228)
Jorge Pereira [Tue, 14 Sep 2021 18:12:58 +0000 (15:12 -0300)] 
Add extra tests for time_delta (#4228)

3 years agotests for negative numbers, too
Alan T. DeKok [Tue, 14 Sep 2021 15:50:03 +0000 (11:50 -0400)] 
tests for negative numbers, too

3 years agohandle negative numbers
Alan T. DeKok [Tue, 14 Sep 2021 15:49:23 +0000 (11:49 -0400)] 
handle negative numbers

3 years agodon't mark signed as unsigned
Alan T. DeKok [Tue, 14 Sep 2021 15:46:56 +0000 (11:46 -0400)] 
don't mark signed as unsigned

3 years agoAdd an SNMP state dir to the directories we create in %install
Arran Cudbard-Bell [Mon, 13 Sep 2021 19:30:21 +0000 (14:30 -0500)] 
Add an SNMP state dir to the directories we create in %install

3 years ago%{_rundir} isn't equivalent to /var/run
Arran Cudbard-Bell [Mon, 13 Sep 2021 19:23:58 +0000 (14:23 -0500)] 
%{_rundir} isn't equivalent to /var/run

3 years agoCreate a state directory for net-snmp
Arran Cudbard-Bell [Mon, 13 Sep 2021 19:16:15 +0000 (14:16 -0500)] 
Create a state directory for net-snmp

3 years agoRemove the "parent" request from triggers
Arran Cudbard-Bell [Mon, 13 Sep 2021 18:32:23 +0000 (13:32 -0500)] 
Remove the "parent" request from triggers

When we first added tirggers they were mostly generated by individual requests passing through the server, but today more of the connections and management are done independent of requests.

3 years agoallow underscores as the first character of a label
Alan T. DeKok [Sun, 12 Sep 2021 19:54:22 +0000 (15:54 -0400)] 
allow underscores as the first character of a label

3 years agominor cleanups and notes
Alan T. DeKok [Sun, 12 Sep 2021 17:08:55 +0000 (13:08 -0400)] 
minor cleanups and notes

3 years agofix build issues
Alan T. DeKok [Sat, 11 Sep 2021 12:36:38 +0000 (08:36 -0400)] 
fix build issues

3 years agoadd fr_time_delta_scale(), and use it in rlm_expr
Alan T. DeKok [Fri, 10 Sep 2021 18:46:40 +0000 (14:46 -0400)] 
add fr_time_delta_scale(), and use it in rlm_expr

so that when we do calculations based on an attribute of type
"time_delta", and of precision "milliseconds", we can use
5 milliseconds as "5", and not as "0.0005"

3 years agoadd tests for time_delta
Alan T. DeKok [Fri, 10 Sep 2021 18:18:10 +0000 (14:18 -0400)] 
add tests for time_delta

3 years agoSee if we can fix rlm_sigtran mucking with SIGCHLD
Arran Cudbard-Bell [Fri, 10 Sep 2021 19:12:40 +0000 (14:12 -0500)] 
See if we can fix rlm_sigtran mucking with SIGCHLD

3 years agoadd tests for time_delta
Alan T. DeKok [Fri, 10 Sep 2021 18:18:10 +0000 (14:18 -0400)] 
add tests for time_delta

3 years agoallow variable size for dates and time deltas
Alan T. DeKok [Fri, 10 Sep 2021 18:14:14 +0000 (14:14 -0400)] 
allow variable size for dates and time deltas

not _strictly_ necessary for RADIUS, but definitely necessary
for the tests

3 years agodon't smash fields when parsing them
Alan T. DeKok [Fri, 10 Sep 2021 14:54:29 +0000 (10:54 -0400)] 
don't smash fields when parsing them

3 years agouse the new udp_queue API
Alan T. DeKok [Fri, 10 Sep 2021 12:30:34 +0000 (08:30 -0400)] 
use the new udp_queue API

the code is a little smaller

3 years agojust set SO_RCVBUF to a small value
Alan T. DeKok [Fri, 10 Sep 2021 12:30:06 +0000 (08:30 -0400)] 
just set SO_RCVBUF to a small value

and don't bother reading from the socket.

3 years agoprint an error, too
Alan T. DeKok [Thu, 9 Sep 2021 20:54:42 +0000 (16:54 -0400)] 
print an error, too

3 years agorespect SO_SNDBUF
Alan T. DeKok [Thu, 9 Sep 2021 20:33:51 +0000 (16:33 -0400)] 
respect SO_SNDBUF

3 years agocleanups and fixes
Alan T. DeKok [Thu, 9 Sep 2021 15:34:56 +0000 (11:34 -0400)] 
cleanups and fixes

bind to interface
set REUSEPORT
read and discard any replies

3 years agolet's not leak FDs
Alan T. DeKok [Thu, 9 Sep 2021 14:27:24 +0000 (10:27 -0400)] 
let's not leak FDs

3 years agoAPI to write (or enqueue) UDP packets
Alan T. DeKok [Thu, 9 Sep 2021 13:44:03 +0000 (09:44 -0400)] 
API to write (or enqueue) UDP packets

for use with "fire and forget" UDP messaging, such as DHCP relay,
RADIUS replication, etc.

3 years agoLess fragile way of defferring event FD freeing
Arran Cudbard-Bell [Thu, 9 Sep 2021 00:03:38 +0000 (19:03 -0500)] 
Less fragile way of defferring event FD freeing

3 years agoInitialise temporary event list if we're not passed one in unlang_interpret_synchronous
Arran Cudbard-Bell [Wed, 8 Sep 2021 23:42:57 +0000 (18:42 -0500)] 
Initialise temporary event list if we're not passed one in unlang_interpret_synchronous

3 years agoAdd basic trigger tests
Arran Cudbard-Bell [Wed, 8 Sep 2021 23:30:10 +0000 (18:30 -0500)] 
Add basic trigger tests

3 years agoFix logic bug in synchronous interpreter where it'd free yielded detached subrequests
Arran Cudbard-Bell [Wed, 8 Sep 2021 23:29:47 +0000 (18:29 -0500)] 
Fix logic bug in synchronous interpreter where it'd free yielded detached subrequests

3 years agoInclude triggers file in modules test
Arran Cudbard-Bell [Wed, 8 Sep 2021 23:29:25 +0000 (18:29 -0500)] 
Include triggers file in modules test

3 years agoRemove request->el
Arran Cudbard-Bell [Wed, 8 Sep 2021 23:29:07 +0000 (18:29 -0500)] 
Remove request->el

We now use the one associated with the interpreter.  Requests don't have event lists... interpreters do.  There were some instances where request->el wasn't being inherited correctly, this fixes that.

3 years agoMore event loop debugging
Arran Cudbard-Bell [Wed, 8 Sep 2021 22:54:54 +0000 (17:54 -0500)] 
More event loop debugging

3 years agoFix wrong signed/unsigned value_box set (#4223)
Arran Cudbard-Bell [Wed, 8 Sep 2021 20:51:10 +0000 (15:51 -0500)] 
Fix wrong signed/unsigned value_box set (#4223)

Co-authored-by: Jorge Pereira <jpereiran@gmail.com>
3 years agoset sequence number for Access-Request packets which contain State
Alan T. DeKok [Wed, 8 Sep 2021 19:00:38 +0000 (15:00 -0400)] 
set sequence number for Access-Request packets which contain State

3 years agoallow clients to set dedup_authenticator, too.
Alan T. DeKok [Wed, 8 Sep 2021 18:52:31 +0000 (14:52 -0400)] 
allow clients to set dedup_authenticator, too.

We should really either (a) move clients to RADIUS only, or
(b) allow for protocol-specific extensions to clients

3 years agobail from functions early
Alan T. DeKok [Wed, 8 Sep 2021 17:18:28 +0000 (13:18 -0400)] 
bail from functions early

so that the code has fewer levels of indentation, and is somewhat
easier to read

3 years agoMore trigger fixes
Arran Cudbard-Bell [Wed, 8 Sep 2021 18:48:37 +0000 (13:48 -0500)] 
More trigger fixes

3 years agoFix test module test
Arran Cudbard-Bell [Wed, 8 Sep 2021 17:41:23 +0000 (12:41 -0500)] 
Fix test module test

3 years agoStrip out code from triggers... making them better
Arran Cudbard-Bell [Wed, 8 Sep 2021 17:41:07 +0000 (12:41 -0500)] 
Strip out code from triggers... making them better

Triggers now use the same codepath for sync/async

3 years agoIf we can't setup a reaper, kill the process
Arran Cudbard-Bell [Wed, 8 Sep 2021 17:37:15 +0000 (12:37 -0500)] 
If we can't setup a reaper, kill the process

zombie children are a PITA

3 years agoFormatting
Arran Cudbard-Bell [Wed, 8 Sep 2021 17:36:52 +0000 (12:36 -0500)] 
Formatting

3 years agoAllow for reaper callbacks
Arran Cudbard-Bell [Wed, 8 Sep 2021 17:34:40 +0000 (12:34 -0500)] 
Allow for reaper callbacks

3 years agoSet sequence so that we can prioritize ongoing multi-packet sessions.
Alan T. DeKok [Wed, 8 Sep 2021 17:14:58 +0000 (13:14 -0400)] 
Set sequence so that we can prioritize ongoing multi-packet sessions.

3 years agoadd test for "foo.bar.baz = stuff"
Alan T. DeKok [Wed, 8 Sep 2021 15:46:51 +0000 (11:46 -0400)] 
add test for "foo.bar.baz = stuff"

3 years agoel might be NULL if we failed to parse the config
Alan T. DeKok [Wed, 8 Sep 2021 15:45:54 +0000 (11:45 -0400)] 
el might be NULL if we failed to parse the config

3 years agobetter name
Alan T. DeKok [Wed, 8 Sep 2021 15:42:23 +0000 (11:42 -0400)] 
better name

3 years agotests for local templates
Alan T. DeKok [Wed, 8 Sep 2021 15:39:23 +0000 (11:39 -0400)] 
tests for local templates

3 years agoallow in-line templates
Alan T. DeKok [Wed, 8 Sep 2021 15:32:40 +0000 (11:32 -0400)] 
allow in-line templates

and skip them when defining modules.

And when referencing an item, look in the template if it can't
be found in the section.

3 years agoclarify error messages
Alan T. DeKok [Wed, 8 Sep 2021 14:18:11 +0000 (10:18 -0400)] 
clarify error messages

3 years agowe need offer_duration, too
Alan T. DeKok [Wed, 8 Sep 2021 14:16:41 +0000 (10:16 -0400)] 
we need offer_duration, too

3 years agopool_name is needed by the queries.
Alan T. DeKok [Wed, 8 Sep 2021 14:08:29 +0000 (10:08 -0400)] 
pool_name is needed by the queries.

and use ${pool_name} consistently everywhere.

Apparently we don't even use this module during the tests :(

3 years agoif we reference ${skip_locked}, we must use it
Alan T. DeKok [Wed, 8 Sep 2021 14:07:35 +0000 (10:07 -0400)] 
if we reference ${skip_locked}, we must use it

3 years agofunctions here take fr_time_t, not time_t
Alan T. DeKok [Wed, 8 Sep 2021 13:48:10 +0000 (09:48 -0400)] 
functions here take fr_time_t, not time_t

3 years agowhoops, convert to time_delta
Alan T. DeKok [Wed, 8 Sep 2021 12:56:50 +0000 (08:56 -0400)] 
whoops, convert to time_delta

3 years agouse fr_time()
Alan T. DeKok [Wed, 8 Sep 2021 12:53:55 +0000 (08:53 -0400)] 
use fr_time()

3 years agonotes on time
Alan T. DeKok [Wed, 8 Sep 2021 12:52:49 +0000 (08:52 -0400)] 
notes on time

3 years agoUh... connection_spawn() takes fr_time_t, not time(NULL)
Alan T. DeKok [Wed, 8 Sep 2021 12:50:55 +0000 (08:50 -0400)] 
Uh... connection_spawn() takes fr_time_t, not time(NULL)

3 years agouse fr_time()
Alan T. DeKok [Wed, 8 Sep 2021 12:50:10 +0000 (08:50 -0400)] 
use fr_time()

3 years agouse fr_time()
Alan T. DeKok [Wed, 8 Sep 2021 12:49:25 +0000 (08:49 -0400)] 
use fr_time()

3 years agouse request->packet->timestamp instead of time(NULL)
Alan T. DeKok [Wed, 8 Sep 2021 12:47:06 +0000 (08:47 -0400)] 
use request->packet->timestamp instead of time(NULL)

3 years agouse fr_time()
Alan T. DeKok [Wed, 8 Sep 2021 12:43:39 +0000 (08:43 -0400)] 
use fr_time()

3 years agouse fr_time_t
Alan T. DeKok [Wed, 8 Sep 2021 12:39:30 +0000 (08:39 -0400)] 
use fr_time_t

3 years agouse packet timestamp as "now"
Alan T. DeKok [Wed, 8 Sep 2021 12:36:34 +0000 (08:36 -0400)] 
use packet timestamp as "now"

instead of whenever we got around to processing the request.
this is more likely to be what the user intended

3 years agouse fr_time(), which doesn't jump around when NTP changes
Alan T. DeKok [Wed, 8 Sep 2021 12:35:58 +0000 (08:35 -0400)] 
use fr_time(), which doesn't jump around when NTP changes

3 years agodon't use time(0) for consistency, use time(NULL)
Alan T. DeKok [Wed, 8 Sep 2021 12:30:58 +0000 (08:30 -0400)] 
don't use time(0) for consistency, use time(NULL)

3 years agonotes and word smithing
Alan T. DeKok [Wed, 8 Sep 2021 12:19:11 +0000 (08:19 -0400)] 
notes and word smithing

3 years agoreplace rlm_expiration with a ~10 line unlang policy
Alan T. DeKok [Wed, 8 Sep 2021 11:59:03 +0000 (07:59 -0400)] 
replace rlm_expiration with a ~10 line unlang policy

3 years agoSession-Timeout is uint32, not uint64
Alan T. DeKok [Wed, 8 Sep 2021 10:41:56 +0000 (06:41 -0400)] 
Session-Timeout is uint32, not uint64

3 years agolimit is uint64, not uint32
Alan T. DeKok [Wed, 8 Sep 2021 10:38:17 +0000 (06:38 -0400)] 
limit is uint64, not uint32

3 years agoPrint out the current ime correctly
Arran Cudbard-Bell [Tue, 7 Sep 2021 22:18:31 +0000 (17:18 -0500)] 
Print out the current ime correctly

3 years agoAdd debian SNMP package
Arran Cudbard-Bell [Tue, 7 Sep 2021 21:59:15 +0000 (16:59 -0500)] 
Add debian SNMP package

3 years agoAdd RHEL SNMP package
Arran Cudbard-Bell [Tue, 7 Sep 2021 21:50:47 +0000 (16:50 -0500)] 
Add RHEL SNMP package

3 years agoInstall the mibs in <prefix>/share/snmp/mibs
Arran Cudbard-Bell [Tue, 7 Sep 2021 21:26:24 +0000 (16:26 -0500)] 
Install the mibs in <prefix>/share/snmp/mibs

3 years agoVarious eap-aka/sim doc cleanups
Arran Cudbard-Bell [Tue, 7 Sep 2021 20:21:44 +0000 (15:21 -0500)] 
Various eap-aka/sim doc cleanups

3 years agocleanups and fixes
Alan T. DeKok [Tue, 7 Sep 2021 18:47:19 +0000 (14:47 -0400)] 
cleanups and fixes

3 years agoallow 32-bit attributes for TACACS
Alan T. DeKok [Tue, 7 Sep 2021 18:39:31 +0000 (14:39 -0400)] 
allow 32-bit attributes for TACACS

because we don't care about the numbers

3 years agoencode named attributes, too
Alan T. DeKok [Tue, 7 Sep 2021 17:22:53 +0000 (13:22 -0400)] 
encode named attributes, too

3 years agocheck at compile time for invalid assignments
Alan T. DeKok [Tue, 7 Sep 2021 15:23:42 +0000 (11:23 -0400)] 
check at compile time for invalid assignments

3 years agosign promote the input only if the underlying data type is signed
Alan T. DeKok [Tue, 7 Sep 2021 15:09:47 +0000 (11:09 -0400)] 
sign promote the input only if the underlying data type is signed

3 years agorearrange code in preparation for encoding other attributes
Alan T. DeKok [Tue, 7 Sep 2021 12:51:10 +0000 (08:51 -0400)] 
rearrange code in preparation for encoding other attributes

and also fix some bugs with encoding, where the argument count
was tracked incorrectly

3 years agostart of trying to decode as named attributes
Alan T. DeKok [Mon, 6 Sep 2021 20:03:55 +0000 (16:03 -0400)] 
start of trying to decode as named attributes

and fix the test which somehow had an extraneous empty string
for Argument-List

3 years agoprint out decoded packet, too
Alan T. DeKok [Mon, 6 Sep 2021 19:59:33 +0000 (15:59 -0400)] 
print out decoded packet, too

3 years agonormalize name
Alan T. DeKok [Mon, 6 Sep 2021 19:41:13 +0000 (15:41 -0400)] 
normalize name

3 years agofix typo
Alan T. DeKok [Mon, 6 Sep 2021 19:14:13 +0000 (15:14 -0400)] 
fix typo

3 years agoadd support for foo.bar[baz] = x
Alan T. DeKok [Mon, 6 Sep 2021 15:26:08 +0000 (11:26 -0400)] 
add support for foo.bar[baz] = x

tho it doesn't _quite_ work yet, because the tokenizer will
stop at the '[', and will not pass the full name to the add_pair()
function.

3 years agoregenerate
Alan T. DeKok [Fri, 3 Sep 2021 18:40:56 +0000 (14:40 -0400)] 
regenerate

3 years agofix links
Alan T. DeKok [Fri, 3 Sep 2021 18:38:40 +0000 (14:38 -0400)] 
fix links

3 years agouse dots now, not :
Alan T. DeKok [Fri, 3 Sep 2021 18:14:53 +0000 (14:14 -0400)] 
use dots now, not :

3 years agoAdd toggle for requiring client certificates
Arran Cudbard-Bell [Tue, 7 Sep 2021 14:59:41 +0000 (09:59 -0500)] 
Add toggle for requiring client certificates

3 years agoAdd TEST_CHECK_SLEN
Arran Cudbard-Bell [Tue, 7 Sep 2021 14:07:53 +0000 (09:07 -0500)] 
Add TEST_CHECK_SLEN

3 years agoCorrect casts in TEST_CHECK_LEN() (#4221)
James Jones [Tue, 7 Sep 2021 14:05:16 +0000 (09:05 -0500)] 
Correct casts in TEST_CHECK_LEN() (#4221)

3 years agoDisplay build result to try and figure out why coverity isn't working
Arran Cudbard-Bell [Mon, 6 Sep 2021 22:32:10 +0000 (17:32 -0500)] 
Display build result to try and figure out why coverity isn't working