]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
4 years agoDeal with error paths in callers of dict_attr_alloc_null
Arran Cudbard-Bell [Tue, 26 Jan 2021 21:52:32 +0000 (21:52 +0000)] 
Deal with error paths in callers of dict_attr_alloc_null

4 years agoUpdate license
D. Domig [Tue, 26 Jan 2021 16:47:10 +0000 (17:47 +0100)] 
Update license

4 years agoCI: Fix fuzzer asset naming
Terry Burton [Tue, 26 Jan 2021 14:25:55 +0000 (14:25 +0000)] 
CI: Fix fuzzer asset naming

4 years agoScheduled fuzzing improvements
Terry Burton [Tue, 26 Jan 2021 12:23:39 +0000 (12:23 +0000)] 
Scheduled fuzzing improvements

Change scheduled fuzzing to a matrix workflow so that we fuzz protocols in separate
jobs: More CPUs; less context switching.

If HEAD doesn't build then walk up the tree until we find something that does,
then fuzz that.

Set the runtime based on the calculated time remaining in the job since we
don't know ahead of time how much time we will spend walking the tree to find a
working build.

Name assests after "<commit>:<protocol>"

Copy the job output text into the asset that is uploaded when there are fuzzing
failures.

4 years agoRename parameters of fr_dbuff_in_bytes() and FR_DBUFF_IN_BYTES_RETURN()
James Jones [Mon, 25 Jan 2021 19:29:59 +0000 (13:29 -0600)] 
Rename parameters of fr_dbuff_in_bytes() and FR_DBUFF_IN_BYTES_RETURN()

Though they could be either dbufs or markers, the parameter names
suggested that only dbuffs would do. They now follow the convention
of "_dbuff_or_marker" to indicate their possible use. There was
already an fr_dbuff_in() call in dbuff_tests using a marker, but
none for fr_dbuff_in_bytes(), dbuff or marker; the latter is now
present, and both include tests to explicitly test cases in which
fr_dbuff_used(dbuff) and fr_dbuff_used(marker) differ.

4 years agoRename dpair_legacy.c to pair_legacy.c
Nick Porter [Mon, 25 Jan 2021 16:54:10 +0000 (16:54 +0000)] 
Rename dpair_legacy.c to pair_legacy.c

4 years agoRename dpair.c to pair.c
Nick Porter [Mon, 25 Jan 2021 16:52:52 +0000 (16:52 +0000)] 
Rename dpair.c to pair.c

4 years agotry to shut up the linter.
Alan T. DeKok [Tue, 26 Jan 2021 12:23:43 +0000 (07:23 -0500)] 
try to shut up the linter.

4 years agodocs, and provisions for lldb
Alan T. DeKok [Tue, 26 Jan 2021 12:20:58 +0000 (07:20 -0500)] 
docs, and provisions for lldb

4 years agowrapper script so we don't need to remember anything
Alan T. DeKok [Tue, 26 Jan 2021 12:11:44 +0000 (07:11 -0500)] 
wrapper script so we don't need to remember anything

4 years agoclean up tags on fail, too
Alan T. DeKok [Tue, 26 Jan 2021 11:45:27 +0000 (06:45 -0500)] 
clean up tags on fail, too

4 years agoGCC doesn't deal with multiple pragmas in the same line correctly
Arran Cudbard-Bell [Mon, 25 Jan 2021 23:36:15 +0000 (23:36 +0000)] 
GCC doesn't deal with multiple pragmas in the same line correctly

4 years agoMissing inline
Arran Cudbard-Bell [Mon, 25 Jan 2021 22:52:44 +0000 (22:52 +0000)] 
Missing inline

4 years agoFix various build issues
Arran Cudbard-Bell [Mon, 25 Jan 2021 22:47:42 +0000 (22:47 +0000)] 
Fix various build issues

4 years agoCan't warn about unused results when there's no result
Arran Cudbard-Bell [Mon, 25 Jan 2021 22:17:38 +0000 (22:17 +0000)] 
Can't warn about unused results when there's no result

4 years agoFormat build deps correctly
Arran Cudbard-Bell [Mon, 25 Jan 2021 20:51:19 +0000 (20:51 +0000)] 
Format build deps correctly

4 years agoMark up return values of pair allocation functions as needing to be assigned
Arran Cudbard-Bell [Mon, 25 Jan 2021 19:48:15 +0000 (19:48 +0000)] 
Mark up return values of pair allocation functions as needing to be assigned

4 years agoNote used
Arran Cudbard-Bell [Mon, 25 Jan 2021 19:47:42 +0000 (19:47 +0000)] 
Note used

4 years agoRework DIAG_ON and DIAG_OFF macros to behave consistently.
Arran Cudbard-Bell [Mon, 25 Jan 2021 17:16:16 +0000 (17:16 +0000)] 
Rework DIAG_ON and DIAG_OFF macros to behave consistently.

Add DIAG_OFF_OPTIONAL and DIAG_ON_OPTIONAL which ignore unknown pragmas

4 years agoCI: Activate tmate on failure when pushing to the ci-debug branch
Terry Burton [Mon, 25 Jan 2021 01:52:52 +0000 (01:52 +0000)] 
CI: Activate tmate on failure when pushing to the ci-debug branch

4 years agoUse new function for clearing error stack
Arran Cudbard-Bell [Mon, 25 Jan 2021 16:17:30 +0000 (16:17 +0000)] 
Use new function for clearing error stack

4 years agoCI: Rework package installation for on-push CI and scheduled fuzzing
Terry Burton [Sun, 24 Jan 2021 20:56:38 +0000 (20:56 +0000)] 
CI: Rework package installation for on-push CI and scheduled fuzzing

Install packages from debian/control file.

Install extra CI-specific packages from new scripts/ci/extra
packages.control file

Defer fixture package installation until after build.

Disable rebuild of initramfs to optimise runtime.

4 years agoRemove util/pair.c and util/pair_legacy.c
Nick Porter [Mon, 25 Jan 2021 11:46:26 +0000 (11:46 +0000)] 
Remove util/pair.c and util/pair_legacy.c

4 years agoRemove USE_DOUBLE_LIST from build options
Nick Porter [Mon, 25 Jan 2021 11:33:13 +0000 (11:33 +0000)] 
Remove USE_DOUBLE_LIST from build options

4 years agoSet correct function type for eval function in protocol test points.
Nick Porter [Mon, 25 Jan 2021 11:30:10 +0000 (11:30 +0000)] 
Set correct function type for eval function in protocol test points.

4 years agoReplace references to cursor.h with dcursor.h
Nick Porter [Mon, 25 Jan 2021 11:29:07 +0000 (11:29 +0000)] 
Replace references to cursor.h with dcursor.h

and remove un-used references to cursor.h

4 years agoReplace util/pair_legacy.h with util/dpair_legacy.h
Nick Porter [Mon, 25 Jan 2021 10:30:47 +0000 (10:30 +0000)] 
Replace util/pair_legacy.h with util/dpair_legacy.h

4 years agoReplace util/pair.h with util/dpair.h
Nick Porter [Mon, 25 Jan 2021 10:21:50 +0000 (10:21 +0000)] 
Replace util/pair.h with util/dpair.h

4 years agoAdd build dependency for deb packages on Perl
Arran Cudbard-Bell [Mon, 25 Jan 2021 16:11:50 +0000 (16:11 +0000)] 
Add build dependency for deb packages on Perl

4 years agoRun fuzzer.c through the formatter
Arran Cudbard-Bell [Mon, 25 Jan 2021 16:01:51 +0000 (16:01 +0000)] 
Run fuzzer.c through the formatter

4 years agows
Arran Cudbard-Bell [Mon, 25 Jan 2021 15:59:17 +0000 (15:59 +0000)] 
ws

4 years agoAdd function for explicitly clearing outstanding messages
Arran Cudbard-Bell [Mon, 25 Jan 2021 14:33:50 +0000 (14:33 +0000)] 
Add function for explicitly clearing outstanding messages

4 years agotypo
Alan T. DeKok [Sun, 24 Jan 2021 19:09:23 +0000 (14:09 -0500)] 
typo

4 years agowe have one byte of option length, too
Alan T. DeKok [Sun, 24 Jan 2021 13:09:13 +0000 (08:09 -0500)] 
we have one byte of option length, too

4 years agouse p / end, and data / data_len
Alan T. DeKok [Sun, 24 Jan 2021 13:06:51 +0000 (08:06 -0500)] 
use p / end, and data / data_len

mixing and matching is a bad idea

4 years agoensure variables are initialized
Alan T. DeKok [Sun, 24 Jan 2021 12:51:19 +0000 (07:51 -0500)] 
ensure variables are initialized

4 years agoclear errors after every run.
Alan T. DeKok [Sun, 24 Jan 2021 12:45:37 +0000 (07:45 -0500)] 
clear errors after every run.

4 years agoFiz various issues with fuzzer.c
Arran Cudbard-Bell [Sat, 23 Jan 2021 15:36:31 +0000 (15:36 +0000)] 
Fiz various issues with fuzzer.c

- Initialise the atexit handlers
- Initialise error pools before starting to fuzz
- Use fr_perror() so errors get printed correctly
- Use macros when calling failure functions

4 years agoRevert "just call printf, not push"
Arran Cudbard-Bell [Sat, 23 Jan 2021 14:37:51 +0000 (14:37 +0000)] 
Revert "just call printf, not push"

This reverts commit 02209ba71c112c9f72dc0e6b9304dd2bdfb222e9.

4 years agojust call printf, not push
Alan T. DeKok [Sat, 23 Jan 2021 14:26:20 +0000 (09:26 -0500)] 
just call printf, not push

4 years agoinclude stdbool
Arran Cudbard-Bell [Sat, 23 Jan 2021 13:04:51 +0000 (13:04 +0000)] 
include stdbool

4 years ago...and the mk file
Arran Cudbard-Bell [Sat, 23 Jan 2021 12:58:57 +0000 (12:58 +0000)] 
...and the mk file

4 years agoNightly, continuous fuzzing using LLVM snapshot
Terry Burton [Fri, 22 Jan 2021 01:09:56 +0000 (01:09 +0000)] 
Nightly, continuous fuzzing using LLVM snapshot

Parallel fuzzing of all protocols restarting every 5 minutes or on failure.

4 years agoFuzzer: Honour -D dictdir when using jobs=N option
Terry Burton [Fri, 22 Jan 2021 14:21:49 +0000 (14:21 +0000)] 
Fuzzer: Honour -D dictdir when using jobs=N option

4 years agoFuzzer: Correctly remove -D dictdir argument
Terry Burton [Fri, 22 Jan 2021 14:22:33 +0000 (14:22 +0000)] 
Fuzzer: Correctly remove -D dictdir argument

4 years agoTypo
Terry Burton [Fri, 22 Jan 2021 01:15:55 +0000 (01:15 +0000)] 
Typo

4 years agoMove type functions into a separate source file
Arran Cudbard-Bell [Sat, 23 Jan 2021 12:12:10 +0000 (12:12 +0000)] 
Move type functions into a separate source file

4 years agoFix type ordering, add missing types to FR_TYPE_FIXED_SIZE
Arran Cudbard-Bell [Sat, 23 Jan 2021 11:59:45 +0000 (11:59 +0000)] 
Fix type ordering, add missing types to FR_TYPE_FIXED_SIZE

4 years agoCorrectly remove pairs from "from" list in raidus_pairmove()
Nick Porter [Fri, 22 Jan 2021 18:25:44 +0000 (18:25 +0000)] 
Correctly remove pairs from "from" list in raidus_pairmove()

and remove a stray debugging printf

4 years agomove "sort $INCLUDE dir/" code to using heap
Alan T. DeKok [Fri, 22 Jan 2021 19:31:12 +0000 (14:31 -0500)] 
move "sort $INCLUDE dir/" code to using heap

in preparation for moving rbtree nodes in-line in functions

4 years agotypo
Alan T. DeKok [Fri, 22 Jan 2021 19:30:37 +0000 (14:30 -0500)] 
typo

4 years agorename function
Alan T. DeKok [Fri, 22 Jan 2021 19:20:27 +0000 (14:20 -0500)] 
rename function

if we're comparing inodes, call it inode_cmp

4 years agoremove empty array at the end of a structure
Alan T. DeKok [Fri, 22 Jan 2021 16:26:46 +0000 (11:26 -0500)] 
remove empty array at the end of a structure

it's a GCC extension, and very useful.  But clang complains.

4 years agoadd libfreeradius-PROTOCOL.la as dependency of test.unit.PROTOCOL
Alan T. DeKok [Fri, 22 Jan 2021 16:25:38 +0000 (11:25 -0500)] 
add libfreeradius-PROTOCOL.la as dependency of test.unit.PROTOCOL

because GNU make is too stupid to figure it out

4 years agoallocate child_struct for all key fields
Alan T. DeKok [Fri, 22 Jan 2021 16:14:19 +0000 (11:14 -0500)] 
allocate child_struct for all key fields

even if it doesn't actually use child structs

4 years agoCall trigger_args_afrom_server() with a fr_pair_list to populate
Nick Porter [Fri, 22 Jan 2021 12:14:41 +0000 (12:14 +0000)] 
Call trigger_args_afrom_server() with a fr_pair_list to populate

rather than allocating a new list in the function

4 years agoCorrect order of parameters in eap_packet_to_vp()
Nick Porter [Fri, 22 Jan 2021 11:18:06 +0000 (11:18 +0000)] 
Correct order of parameters in eap_packet_to_vp()

4 years agofr_pair_list_clear() is not needed to clear and initialise a list.
Nick Porter [Fri, 22 Jan 2021 11:09:03 +0000 (11:09 +0000)] 
fr_pair_list_clear() is not needed to clear and initialise a list.

fr_pair_list_free() leaves the header in the correct state

4 years agoCall map_list_mod_to_vps() with a fr_pair_list_t to populate
Nick Porter [Fri, 22 Jan 2021 11:04:04 +0000 (11:04 +0000)] 
Call map_list_mod_to_vps() with a fr_pair_list_t to populate

rather than allocating a new list in the function.

4 years agoMove cursor tests to correct framework
Nick Porter [Wed, 20 Jan 2021 12:49:24 +0000 (12:49 +0000)] 
Move cursor tests to correct framework

4 years agoRemove un-used cursor
Nick Porter [Wed, 20 Jan 2021 10:38:14 +0000 (10:38 +0000)] 
Remove un-used cursor

4 years agoReplace cursor functions with pair_list functions in rlm_couchbase.c
Nick Porter [Wed, 20 Jan 2021 10:37:01 +0000 (10:37 +0000)] 
Replace cursor functions with pair_list functions in rlm_couchbase.c

4 years agoCorrect docuemntation
Nick Porter [Wed, 20 Jan 2021 10:36:31 +0000 (10:36 +0000)] 
Correct docuemntation

4 years agoCorrect method to add pairs to existing list in rlm_mruby.c
Nick Porter [Tue, 19 Jan 2021 17:24:20 +0000 (17:24 +0000)] 
Correct method to add pairs to existing list in rlm_mruby.c

4 years agoPass pointer to request_pairs to lua_pushlightuserdata()
Nick Porter [Mon, 18 Jan 2021 13:39:46 +0000 (13:39 +0000)] 
Pass pointer to request_pairs to lua_pushlightuserdata()

4 years agos/fr_cursor/fr_dcursor/ in rlm_lua/lua.c
Nick Porter [Mon, 18 Jan 2021 12:37:55 +0000 (12:37 +0000)] 
s/fr_cursor/fr_dcursor/ in rlm_lua/lua.c

4 years agoRemove final packet->vps references
Nick Porter [Wed, 13 Jan 2021 08:12:34 +0000 (08:12 +0000)] 
Remove final packet->vps references

4 years agoUse TALLOC_FREE() to free and reset single fr_pair_t
Nick Porter [Tue, 12 Jan 2021 10:03:49 +0000 (10:03 +0000)] 
Use TALLOC_FREE() to free and reset single fr_pair_t

4 years agoReworked version of raidus_pairmove()
Nick Porter [Mon, 11 Jan 2021 09:41:56 +0000 (09:41 +0000)] 
Reworked version of raidus_pairmove()

Rather than break the "to" and "from" lists into arrays, this
implementation keeps the fr_pair_list_t structures but uses arrays to
mark which "to" entries are edited / to be deleted.

New pair_list functions are used for list manipulation.

The original int counters are retained for debug messages.

4 years agoAmend rls_files.c to handle map_to_vp appending to pair_list
Nick Porter [Mon, 11 Jan 2021 09:27:45 +0000 (09:27 +0000)] 
Amend rls_files.c to handle map_to_vp appending to pair_list

4 years agos/fr_cursor/fr_dcursor/ in rlm_eap_ttls/ttls.c
Nick Porter [Mon, 11 Jan 2021 09:22:57 +0000 (09:22 +0000)] 
s/fr_cursor/fr_dcursor/ in rlm_eap_ttls/ttls.c

4 years agoCorrect function for returning a locally generated pair_list
Nick Porter [Mon, 11 Jan 2021 09:08:05 +0000 (09:08 +0000)] 
Correct function for returning a locally generated pair_list

4 years agoAmend attr_filter_common() to handle map_to_vp() appending to a pair_list
Nick Porter [Mon, 11 Jan 2021 09:07:38 +0000 (09:07 +0000)] 
Amend attr_filter_common() to handle map_to_vp() appending to a pair_list

4 years agoTidy map_to_request()
Nick Porter [Mon, 11 Jan 2021 09:05:17 +0000 (09:05 +0000)] 
Tidy map_to_request()

Replace one cursor with pair_list functions
Use the previous cursor's name as the pair_list name for clarity
Use correct function to clear a list for re-use

4 years agoAmend map_exec_to_vp() to append pairs to a fr_pair_list_t
Nick Porter [Mon, 11 Jan 2021 08:59:51 +0000 (08:59 +0000)] 
Amend map_exec_to_vp() to append pairs to a fr_pair_list_t

Needs to work the same as map_to_vp()

4 years agoCorrect method to return a locally created list
Nick Porter [Mon, 11 Jan 2021 08:58:27 +0000 (08:58 +0000)] 
Correct method to return a locally created list

4 years agoAlter _json_map_proc_get_value() to append to fr_pair_list_t
Nick Porter [Mon, 11 Jan 2021 08:52:50 +0000 (08:52 +0000)] 
Alter _json_map_proc_get_value() to append to fr_pair_list_t

Needs to behave the same as map_to_vp()

4 years agoAmend fr_ldap_map_getvalue() to handle map_to_vp() adding to lists
Nick Porter [Mon, 11 Jan 2021 08:47:51 +0000 (08:47 +0000)] 
Amend fr_ldap_map_getvalue() to handle map_to_vp() adding to lists

4 years agoAmend map_to_vp to add pairs to a fr_pair_list_t
Nick Porter [Mon, 11 Jan 2021 08:43:15 +0000 (08:43 +0000)] 
Amend map_to_vp to add pairs to a fr_pair_list_t

Usually it will only find one pair, but the case of list to list means a
whole list is returned.

4 years agoUse correct function for appending a pair_list to another in rlm_json.c
Nick Porter [Mon, 11 Jan 2021 08:36:50 +0000 (08:36 +0000)] 
Use correct function for appending a pair_list to another in rlm_json.c

4 years agoAdd fr_pair_list_len to return length of a fr_pair_list_t list
Nick Porter [Sat, 9 Jan 2021 16:14:41 +0000 (16:14 +0000)] 
Add fr_pair_list_len to return length of a fr_pair_list_t list

4 years agos/fr_cursor/fr_dcursor/ in vmps/vmps.c
Nick Porter [Sat, 9 Jan 2021 16:13:55 +0000 (16:13 +0000)] 
s/fr_cursor/fr_dcursor/ in vmps/vmps.c

4 years agos/fr_cursor/fr_dcursor/ in tacacs/encode.c
Nick Porter [Sat, 9 Jan 2021 16:12:51 +0000 (16:12 +0000)] 
s/fr_cursor/fr_dcursor/ in tacacs/encode.c

4 years agos/fr_cursor/fr_dcursor/ in tacacs/decode.c
Nick Porter [Sat, 9 Jan 2021 15:59:02 +0000 (15:59 +0000)] 
s/fr_cursor/fr_dcursor/ in tacacs/decode.c

4 years agos/fr_cursor/fr_dcursor/ in internal/encode.c
Nick Porter [Sat, 9 Jan 2021 15:56:54 +0000 (15:56 +0000)] 
s/fr_cursor/fr_dcursor/ in internal/encode.c

4 years agos/fr_cursor/fr_dcursor/ in internal/decode.c
Nick Porter [Sat, 9 Jan 2021 15:56:07 +0000 (15:56 +0000)] 
s/fr_cursor/fr_dcursor/ in internal/decode.c

4 years agoHandle child options being in a fr_pair_list_t in dhcpv6/encode.c
Nick Porter [Sat, 9 Jan 2021 15:52:50 +0000 (15:52 +0000)] 
Handle child options being in a fr_pair_list_t in dhcpv6/encode.c

4 years agos/fr_cursor/fr_dcursor/ in dhcpv6/encode.c
Nick Porter [Sat, 9 Jan 2021 15:48:35 +0000 (15:48 +0000)] 
s/fr_cursor/fr_dcursor/ in dhcpv6/encode.c

4 years agoCorrect assignment of temporary list to vp->group for fr_pair_list_t
Nick Porter [Sat, 9 Jan 2021 15:45:37 +0000 (15:45 +0000)] 
Correct assignment of temporary list to vp->group for fr_pair_list_t

4 years agos/fr_cursor/fr_dcursor/ in dhcpv6/decode.c
Nick Porter [Sat, 9 Jan 2021 15:44:38 +0000 (15:44 +0000)] 
s/fr_cursor/fr_dcursor/ in dhcpv6/decode.c

4 years agos/fr_cursor/fr_dcursor/ in dhcpv6/base.c
Nick Porter [Sat, 9 Jan 2021 15:41:07 +0000 (15:41 +0000)] 
s/fr_cursor/fr_dcursor/ in dhcpv6/base.c

4 years agoAmend fr_dhcpv6_next_encocable to work with dcursors
Nick Porter [Sat, 9 Jan 2021 15:39:46 +0000 (15:39 +0000)] 
Amend fr_dhcpv6_next_encocable to work with dcursors

4 years agos/fr_cursor/fr_dcursor/ in dhcpv4/packet.c
Nick Porter [Sat, 9 Jan 2021 15:00:17 +0000 (15:00 +0000)] 
s/fr_cursor/fr_dcursor/ in dhcpv4/packet.c

4 years agos/fr_cursor/fr_dcursor/ in dhcpv4/decode.c
Nick Porter [Sat, 9 Jan 2021 14:59:31 +0000 (14:59 +0000)] 
s/fr_cursor/fr_dcursor/ in dhcpv4/decode.c

4 years agos/fr_cursor/fr_dcursor/ in dhcpv4/encode.c
Nick Porter [Sat, 9 Jan 2021 14:58:06 +0000 (14:58 +0000)] 
s/fr_cursor/fr_dcursor/ in dhcpv4/encode.c

4 years agos/fr_cursor/fr_dcursor/ in dhcpv4/base.c
Nick Porter [Sat, 9 Jan 2021 14:55:56 +0000 (14:55 +0000)] 
s/fr_cursor/fr_dcursor/ in dhcpv4/base.c

4 years agos/fr_cursor/fr_dcursor/ in arp/base.c
Nick Porter [Sat, 9 Jan 2021 14:55:16 +0000 (14:55 +0000)] 
s/fr_cursor/fr_dcursor/ in arp/base.c

4 years agoHandle adding of individual vps in mod_vptuple()
Nick Porter [Sat, 9 Jan 2021 14:32:18 +0000 (14:32 +0000)] 
Handle adding of individual vps in mod_vptuple()

VPs are added to a temporary list and then the whole list
radius_pairmove() added to the destination.

4 years agoUse correct type for local temporary lists in rlm_sql.c
Nick Porter [Sat, 9 Jan 2021 14:20:34 +0000 (14:20 +0000)] 
Use correct type for local temporary lists in rlm_sql.c

And correct function to clear lists for re-use.

4 years agoUse fr_pair_list_t rather than cursor in sql_pair_list_afrom_str()
Nick Porter [Sat, 9 Jan 2021 14:16:54 +0000 (14:16 +0000)] 
Use fr_pair_list_t rather than cursor in sql_pair_list_afrom_str()