Joel Rosdahl [Thu, 19 Mar 2015 21:02:20 +0000 (22:02 +0100)]
Merge branch '3.2-maint'
* 3.2-maint:
Introduce logging wrappers for stat/lstat/fstat functions
Harden logging, perror() replaced with fatal(), unlink() failure recorded
Always check the result of stat() system calls
Log failure of opening file to hash
Jiang Jiang [Tue, 2 Dec 2014 16:23:16 +0000 (17:23 +0100)]
Support syntax CCACHE_COMPILERCHECK=string:<value>
This can be faster than running a command directly, because the
command to run might just produce the same result for every ccache
invocation. By reading it from config file or environment variable
we can just run that command once and store the result in the string
following "string:" and reusing it.
For example when we want to use clang revision for clang built from
SVN trunk, we can just call clang --version once and store the
revision number like:
Joel Rosdahl [Sat, 7 Mar 2015 16:39:54 +0000 (17:39 +0100)]
Avoid unnecessary copy of object file on cache miss
As noted by Chiaki Ishikawa, ccache performs an unnecessary copy of the
object file from the cache on a cache miss. This was an refactoring
oversight in 18a645451194becb832bd1ff4fee1c1e9f3d0dc5.
Joel Rosdahl [Fri, 20 Feb 2015 19:32:33 +0000 (20:32 +0100)]
Fix comment scanning bug in hash_source_code_string
hash_source_code_string tries to ignore __DATE__/__TIME strings in
comments, but fails to parse code that contains character literal of a
double quote. This could result in false cache hits when the source code
happens to contain '"' followed by " /*" or " //" (with variations).
The fix is to do like it's already done in ccache 3.2: Don't try to be
overly clever about __DATE__/__TIME__, just check for those strings
anywhere in the source code string.
ryb [Sat, 7 Feb 2015 14:30:16 +0000 (15:30 +0100)]
Don't clean up the clang diagnostics file in failure cases
It isn't necessary to remove the file as it will be overwritten when re-running
the compiler in failed(). tmp_unlink() is the wrong function to use in any case,
as the file is not temporary and could be on an NFS volume (see the comment for
tmp_unlink()).
ryb [Sat, 7 Feb 2015 14:01:34 +0000 (15:01 +0100)]
Don't delete the clang diagnostics file after compiler failures
move_file() returns an error when called with the same source and destination,
causing the diagnostics file to be removed.
As of 18a645451 ("Create destination file and then copy into cache instead of
the opposite") it is no longer necessary to move the diagnostics file at all
after a compiler failure.
ryb [Sat, 7 Feb 2015 13:28:48 +0000 (14:28 +0100)]
Remove incorrect preconditions for outputting captured stderr
errno is set in an unrelated system call. In my tests involving compiler
failures, it is last set to ENOENT in from_cache() when calling stat() for the
cached object, accidentally making "errno == ENOENT" true.
The condition was no longer necessary as of 18a645451 ("Create destination file
and then copy into cache instead of the opposite"), as the temp output file no
longer needed to be moved.
Joel Rosdahl [Wed, 28 Jan 2015 22:15:01 +0000 (23:15 +0100)]
Various fixes in WIN32-specific code
* Avoid potential buffer overflow in add_exe_ext_if_no_to_fullpath.
* Avoid using zero-padding strncpy function.
* Removed superfluous newline characters from log messages.
* For consistency, moved variable declarations to the top of the scope
to please older compilers.
* For consistency, used C89-style comments to please older compilers.
* Fixed source code formatting.
Joel Rosdahl [Fri, 26 Dec 2014 09:07:25 +0000 (10:07 +0100)]
Include info on CCACHE_CPP2 in hash
Made hash of cached result created with and without CCACHE_CPP2 different.
This makes it possible to rebuild with CCACHE_CPP2 set without having to
clear the cache to get new results.
It turned out to be a bad idea to use mkstemp for temporary files that are
renamed into files to save in the cache since mkstemp creates the file with
permissions 0600.
Joel Rosdahl [Wed, 19 Nov 2014 20:23:20 +0000 (21:23 +0100)]
Pass -fdiagnostics-color=auto to the compiler even if stderr is redirected
This fixes a problem when e.g. a configure test probes if the compiler
(wrapped via ccache) supports -fdiagnostics-color=auto. If ccache discards
the option since configure redirects stderr, then configure will
erroneously think that the compiler supports the option and the build will
fail later on (if stderr refers to a TTY).
Joel Rosdahl [Sat, 15 Nov 2014 12:50:49 +0000 (13:50 +0100)]
Improve execute() to take FDs instead of filenames
This means that execute() no longer needs to recreate the temporary
stdout/stderr files needlessly.
Note: ccache will no longer build on win32 after this change, but I don't
know what needs to be done to win32execute(). I leave that to those who
know.
Joel Rosdahl [Sat, 8 Nov 2014 15:53:34 +0000 (16:53 +0100)]
Do not rely on pids being unique
Based on a patch by Mike Frysinger <vapier@gentoo.org>:
"Linux supports creating pid namespaces cheaply and running processes
inside of them. When you try to share a single cache among multiple such
runs, the fact that the code relies on pid numbers as globally unique
values quickly fails. Instead, switch to standard mkstemp to generate temp
files for us."
Joel Rosdahl [Sat, 16 Aug 2014 12:22:04 +0000 (14:22 +0200)]
Require CCACHE_SLOPPINESS=pch_defines when creating precompiled header
708d9110a103bd49437be7bff1e82697fff68d0b introduced the requirement of
sloppy pch_defines for using a PCH, but it's the act of creating (and
storing in the cache) a PCH that needs to be opt-in.
Luboš Luňák [Fri, 29 Nov 2013 11:14:03 +0000 (12:14 +0100)]
support compiler color diagnostics if possible
Clang and GCC (starting with 4.9) support color output if possible,
but since ccache redirects stderr to a file, they detect the output
is not a terminal and do not enable colors. Try to detect if colors
would be used and force colors explicitly.
Caveats:
- Compiles with and without colors are considered different from each
other (so they are "duplicated").
- GCC decided to roll its own name for the option, so it's necessary
to guess which compiler is actually used.
Joel Rosdahl [Sun, 8 Jun 2014 15:29:44 +0000 (17:29 +0200)]
Create destination file and then copy into cache instead of the opposite
This simplifies the code so that there is no special case kicking in when
using --serialize-diagnostics (which requires the "-o" option to refer to
the destination instead of a temporary file in the cache).
Joel Rosdahl [Wed, 14 May 2014 20:03:53 +0000 (22:03 +0200)]
Merge branch 'maint'
* maint:
Fix clang build warning "shift count >= width of type"
Clean up stale files in internal tempdir once an hour
Add signal handler to clean up temporary files at unexpected program exit
Don't needlessly allocate empty counter_updates data in stats_flush()
Joel Rosdahl [Tue, 15 Apr 2014 20:31:21 +0000 (22:31 +0200)]
Merge branch 'maint'
* maint:
manifest file_info fix
Clean up dead code flagged by cppcheck and clang-analyzer
Mark fatal() with __attribute__((noreturn)) to please clang-analyzer
Fix bug in common_dir_prefix_length