docs: update v2.21-ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update AUTHORS file

Signed-off-by: Karel Zak <kzak@redhat.com>

po: merge changes

Signed-off-by: Karel Zak <kzak@redhat.com>

po: update uk.po (from translationproject.org)

po: update pl.po (from translationproject.org)

po: update nl.po (from translationproject.org)

po: update fr.po (from translationproject.org)

po: update cs.po (from translationproject.org)

umount: respect fs search path

This brings search path support to umount to match existing behavior
in fsck and mount.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

fdisk: update information about GNU Parted in fdisk.8

The support for resizing partitions and filesystems has been
removed from parted since version 3.0.

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

mount: distinguish between MS_COMMENT flags (netdev, nofail, ...)

Since util-linux 2.12h (year 2004) there is only one flag for all
dummy options like _netdev or nofail. Unfortunately it means that when
mount(8) composes the final mount options string for mtab (or for
mount.<type> helpers) the string is generated incorrectly.

Reported-by: Dave Reisner <d@falconindy.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

mount: clear flags before options parsing

for example "mount -a" calls the mount options parser more than once

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add wall to build-sys tests

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: clean up context docs

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: add note about mount(8) options to TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/strutils: move array bounds check in string_to_idarray() to appropriate place.

string_to_idarray() will incorrectly exit with an error when the last element
of the passed in array gets filled. However it should only exit with an error
if there is more input. To fix this move the array bounds check.

Signed-off-by: Chandan B Rajenda <chandan@linux.vnet.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

libblkid: add BLKID_PARTS_MAGIC to blkid_do_wipe() docs

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update copyright years

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: cleanup docs

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: update docs

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: remove teaser proto for mnt_table_get_name

This function was never implemented, but the proto has existed since the
inception of the library. As the libmnt_table struct doesn't include a
member necessary to carry the name of the table, simply discard this
prototype. If ever a need to break ABI comes up, perhaps this could be
revisited.

Signed-off-by: Dave Reisner <dreisner@archlinux.org>

docs: trivial documentation fixes and improvements

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

cytune.8: fix formatting

W: manual-page-warning /usr/share/man/man8/cytune.8.gz 178: warning:
macro `chars',' not defined (possibly missing space after `ch')

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

build-sys: fix building of wall

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

mkfs.bfs: add setlocale

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

docs: add note about losetup to TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: add note about fdisk to TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: make minix tests more robust

Signed-off-by: Karel Zak <kzak@redhat.com>

unshare: add note about MS_SHARED to unshare.1

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add tools/ to EXTRA_DIST

Reported-by: Petr Uzel <petr.uzel@suse.cz>
Signed-off-by: Karel Zak <kzak@redhat.com>

lib/fsprobe: mar this internal API as deprecated

The fsprobe has been added many years ago to provide unified API for

- built-in libblkid
- e2fsprogs libblkid
- udev libvolume_id

these all is unnecessary as we strictly depends on built-in libblkid.

Signed-off-by: Karel Zak <kzak@redhat.com>

login: add LOGIN_RETRIES, cleanup retries check code

Signed-off-by: Karel Zak <kzak@redhat.com>

setsid: add "+" to getopt_long()

otherwise setsid wants to interpret <program> arguments

$ setsid sh -i
setsid: invalid option -- 'i'

Usage:
 setsid [options] <program> [arguments ...]

Signed-off-by: Harald Hoyer <harald@redhat.com>

tunelp: free allocation, use xalloc

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

switch_root: close open file after usage [cppcheck]

[sys-utils/switch_root.c:159]: (error) Resource leak: cfd

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

chcpu: use appropriate variable type [cppcheck]

[sys-utils/chcpu.c:251]: (style) Checking if unsigned variable 'maxcpus' is less than zero.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

taskset: use appropriate variable type [cppcheck]

[schedutils/taskset.c:182]: (style) Checking if unsigned variable 'ncpus' is less than zero.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

libblkid: verify arroy bound before reference [cppcheck]

[libblkid/src/read.c:428]: (style) Array index end is used before limits check

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

libblkid: allow return value to indicate error [cppcheck]

[libblkid/src/probe.c:1207]: (style) Checking if unsigned variable 'len' is less than zero.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

libblkid: clarify operation order [cppcheck]

[libblkid/src/cache.c:265]: (style) Suspicious condition (assignment+comparison), it can be clarified with parentheses

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

sfdisk: free variable which got the allocation [cppcheck]

[fdisk/sfdisk.c:358]: (error) Memory leak: ss

[kzak@redhat.com: - free after error]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: remove redundant declaration [cppcheck]

fdisk.h:116:12: warning: redundant redeclaration of 'valid_part_table_flag' [-Wredundant-decls]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

raw: remove unnecessary return [cppcheck]

[disk-utils/raw.c:171]: (style) Consecutive return, break, continue, goto or throw statements are unnecessary.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

mkfs.cramfs: check blocksize user input [cppcheck]

Enhance user input checking and error messaging, while fixing
cppcheck warning.

[disk-utils/mkfs.cramfs.c:729]: (style) Checking if unsigned variable 'blksize' is less than zero.

[kzak@redhat.com: fix coding style]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

mkfs.cramfs: close open file after usage [cppcheck]

[disk-utils/mkfs.cramfs.c:913]: (error) Resource leak: fd

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

libblkid: improve reiserfs and btrfs min. size limits

Reported-by: Rogier Goossens <goossens.rogier@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

flock: add missing word »be« to flock.1

flock: fix flock.1 grammar by removing »s«

tools: use gpg-aggent in ko-release-gen

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: release++ (v2.21-rc2)

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update v2.21-ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: remove >> 9 from GPT code

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update AUTHORS file

Signed-off-by: Karel Zak <kzak@redhat.com>

po: merge changes

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add --memcheck to

Signed-off-by: Karel Zak <kzak@redhat.com>

agetty: check localtime() result

Signed-off-by: Karel Zak <kzak@redhat.com>

login: fix leak, improve strtok usage

Signed-off-by: Karel Zak <kzak@redhat.com>

vipw: use xalloc.h

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: use #ifdef fr selinux specific variables

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: remove uneecessary code

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: check stat() return code

Signed-off-by: Karel Zak <kzak@redhat.com>

login: allocate buffer with shell name

Signed-off-by: Karel Zak <kzak@redhat.com>

hexdump: make code more robust

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/loopdev: remove dead assigment and null deference

Signed-off-by: Karel Zak <kzak@redhat.com>

sfdisk: remove dead assigment

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: don't ignore chmod/own errors

Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: remove dead assigment

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/loopdev: fix part scan detection code

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: remove dead assigment

Signed-off-by: Karel Zak <kzak@redhat.com>

hwclock: remove never read value

Signed-off-by: Karel Zak <kzak@redhat.com>

hwclock: clean usage, remove redundat code

Signed-off-by: Karel Zak <kzak@redhat.com>

login: (and chsh) make pw_shell usage more robust

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: initialize rc variable

blockdev: make the code more readable for static analysers

Signed-off-by: Karel Zak <kzak@redhat.com>

sfdisk: cleanup fd usage

sfdisk: fix typo in cdrom detection

Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: fix fd leak

Signed-off-by: Karel Zak <kzak@redhat.com>

sfdisk: fix fd leak

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: make --poll more robust

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/sysfs: fix handle leak

Signed-off-by: Karel Zak <kzak@redhat.com>

kill: fix fd leak

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: fix cdrom detection

Signed-off-by: Karel Zak <kzak@redhat.com>

newgrp: fix possible FILE leak on error

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/loopdev: fix possible dir leak on error

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/sysfs: fix possible fd leak on error

Signed-off-by: Karel Zak <kzak@redhat.com>

vipw: don't modify environment, check strtok() return value

Signed-off-by: Karel Zak <kzak@redhat.com>

chcpu: check get_max_number_of_cpus() result properly

Signed-off-by: Karel Zak <kzak@redhat.com>

cfdisk: wctomb() returns -1 on error

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: don't swap unsigned char

Signed-off-by: Karel Zak <kzak@redhat.com>

partx: fix small leak

Signed-off-by: Karel Zak <kzak@redhat.com>

fsck.cramfs: mark usage() as noreturn

Signed-off-by: Karel Zak <kzak@redhat.com>

chrt: add comment to keep static analysers happy

blkid: add comment to keep static analysers happy

sfdisk: add comment to keep static analysers happy

fdisk: add missing break

Signed-off-by: Karel Zak <kzak@redhat.com>

more: add comment

Signed-off-by: Karel Zak <kzak@redhat.com>

swapon: add break to keep static analysers happy

umount: add missing break

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix suspicious implicit sign extension [coverity scan]

... thanks to "value preserving rules".

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: more robust idx usage [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>