]>
git.ipfire.org Git - thirdparty/knot-resolver.git/log
Vladimír Čunát [Tue, 3 Nov 2020 11:34:04 +0000 (12:34 +0100)]
daemon/worker: allow dropping even on non-XDP
During testing it was sending me SERVFAIL, which was weird.
There's no use case so far, but if it was decided to drop the answer,
it should really happen regardless of the transport.
Vladimír Čunát [Fri, 30 Oct 2020 15:29:44 +0000 (16:29 +0100)]
modules: fix issues with dropped answers
Vladimír Čunát [Fri, 30 Oct 2020 06:37:31 +0000 (07:37 +0100)]
lua net.listen(): default freebind = false
It's unclear why it defaulted to true in TLS cases.
Vladimír Čunát [Mon, 26 Oct 2020 19:41:13 +0000 (20:41 +0100)]
XDP: add documentation
Vladimír Čunát [Fri, 23 Oct 2020 09:11:38 +0000 (11:11 +0200)]
modules/policy TC(): better detection of non-UDP requests
This amends commit
99e014ac635 .
Vladimír Čunát [Wed, 21 Oct 2020 16:07:43 +0000 (18:07 +0200)]
XDP: add lua interfaces
Vladimír Čunát [Wed, 14 Oct 2020 16:28:26 +0000 (18:28 +0200)]
daemon/bindings net_listen_addrs(): pack parameters
They're starting to be too many. Also improve comments.
Vladimír Čunát [Wed, 21 Oct 2020 15:25:18 +0000 (17:25 +0200)]
XDP: add backend parts
Logging strings: I originally wanted to have four chars inside [],
but it doesn't really matter in these cases where logs don't happen
within a request, so "[xdp]" won due to uniformity and simplicity.
Petr Špaček [Mon, 9 Nov 2020 09:17:10 +0000 (10:17 +0100)]
Merge branch 'base64urlencode-query' into 'master'
scripts: utility to get base64 url encoded query for DoH GET
See merge request knot/knot-resolver!1089
Tomas Krizek [Thu, 5 Nov 2020 09:42:21 +0000 (10:42 +0100)]
scripts: utility to get base64 url encoded query for DoH GET
Tomas Krizek [Mon, 2 Nov 2020 17:29:07 +0000 (18:29 +0100)]
Merge branch 'distrotest-update' into 'master'
distro/tests: update distributions
See merge request knot/knot-resolver!1088
Tomas Krizek [Mon, 2 Nov 2020 10:17:59 +0000 (11:17 +0100)]
distro/tests: update DNSSEC bogus test
dnssec-failed.org domain uses RSA/SHA1 algorithm, which is considered
insecure by Fedora 33+ policy.
Tomas Krizek [Fri, 30 Oct 2020 15:30:38 +0000 (16:30 +0100)]
distro/tests: update distributions
- update fedora to 33
- update ubuntu rolling to groovy
Tomas Krizek [Mon, 2 Nov 2020 11:38:13 +0000 (12:38 +0100)]
Merge branch 'pretty-print' into 'master'
new pretty printer
See merge request knot/knot-resolver!1027
Petr Špaček [Mon, 2 Nov 2020 09:26:35 +0000 (10:26 +0100)]
krprint: nitpick from review
Petr Špaček [Tue, 27 Oct 2020 10:25:28 +0000 (11:25 +0100)]
tests: cover table_print
Petr Špaček [Tue, 27 Oct 2020 10:24:19 +0000 (11:24 +0100)]
krprint: escape non-printable strings in error messages
All strings should be properly escaped but some non-escaped versions
were leaking into error messages.
Petr Špaček [Mon, 26 Oct 2020 18:06:40 +0000 (19:06 +0100)]
krprint: allow tab and newline in pretty printer
Functions like trust_anchors.summary() return strings including tabs and
newlines, so we do not escape those for human-readable output.
Petr Špaček [Mon, 26 Oct 2020 17:38:29 +0000 (18:38 +0100)]
tty: do not print extra newline after empty messages
In case nothing (not even nil) is returned then do not print newline
after the zero-length message. This avoids unambiguous empty line in
output (is it an empty string which got printed?).
Petr Špaček [Mon, 20 Jul 2020 09:08:00 +0000 (11:08 +0200)]
table_print: print multiple values
This change allows sandbox to pretty-print return values from functions
which return multiple values, e.g. future net.bufsize() from MR !1026.
Petr Špaček [Mon, 20 Jul 2020 07:46:10 +0000 (09:46 +0200)]
replace sandbox table_print with new pretty printer
This slightly changes table_print() output format.
table_print() output is not intended for machine consumption,
use krprint.serialize_lua() or JSON for that purpose.
Output from table_print is now a valid Lua expression
if the input contains only serializable data types
(number, string, bool, nil, table), which is nice for copy&pasting.
Functions etc. are also pretty-printed but cannot be deserialized.
Numbers are pretty-printed as well so their precision is reduced (as
compared to krprint.serialize_lua).
Petr Špaček [Fri, 17 Jul 2020 15:18:26 +0000 (17:18 +0200)]
krprint: feature parity between old table_print and new pretty printer
Petr Špaček [Fri, 17 Jul 2020 08:33:49 +0000 (10:33 +0200)]
krprint: support pretty-printing functions
Petr Špaček [Fri, 17 Jul 2020 08:08:25 +0000 (10:08 +0200)]
krprint: order keys while pretty-printing tables
Code was copied from Lua sandbox, the old copy is to be removed once new
pretty-printer is finished.
Petr Špaček [Fri, 17 Jul 2020 07:58:54 +0000 (09:58 +0200)]
krprint: reuse serialization infrastructure for pretty-printer
At the moment it does not handle functions and other non-serializable
types.
Petr Špaček [Fri, 10 Jul 2020 20:09:46 +0000 (22:09 +0200)]
table_print: sort numbers by their value instead of lexicographic representation
Side-effect is that keys are grouped by their type, so numbers come
first and strings later..
Petr Špaček [Fri, 10 Jul 2020 19:59:51 +0000 (21:59 +0200)]
table_print: fix printing tables with key = false
Tomas Krizek [Thu, 29 Oct 2020 09:51:13 +0000 (10:51 +0100)]
Merge branch 'doc-polish' into 'master'
5.2.0 doc polish
See merge request knot/knot-resolver!1087
Petr Špaček [Tue, 27 Oct 2020 16:15:28 +0000 (17:15 +0100)]
doc: document planned --forks removal
Petr Špaček [Tue, 27 Oct 2020 14:47:48 +0000 (15:47 +0100)]
doc: net.bufsize clarification
Petr Špaček [Tue, 27 Oct 2020 14:40:27 +0000 (15:40 +0100)]
doc: DNS Flag Day 2020 is now effective
Petr Špaček [Tue, 27 Oct 2020 11:37:00 +0000 (12:37 +0100)]
doh: clarify warning about legacy DoH in docs
Petr Špaček [Tue, 27 Oct 2020 11:30:19 +0000 (12:30 +0100)]
doh2: replace references to obsolete DoH in docs, tests and example configs
Petr Špaček [Tue, 27 Oct 2020 10:45:01 +0000 (11:45 +0100)]
Merge branch '554-lua-command-map-does-not-work' into 'master'
Reimplement map()
Closes #620 and #554
See merge request knot/knot-resolver!1000
Petr Špaček [Mon, 26 Oct 2020 08:28:47 +0000 (09:28 +0100)]
tests: control socket test improvements
Petr Špaček [Mon, 26 Oct 2020 08:10:37 +0000 (09:10 +0100)]
tests: fixes for control socket tests
Error handling inside the test was incorrent and a detected error would
blow up the test routine.
Related: !1011,
3f5a826d4cb859522d073503dcc40e5c59353511
Tomas Krizek [Mon, 26 Oct 2020 14:18:06 +0000 (15:18 +0100)]
NEWS: cleanup incompatible changes
Petr Špaček [Fri, 23 Oct 2020 16:07:59 +0000 (18:07 +0200)]
graphite: adapt to to changes in map()
We don't have leader instance anymore, so each instance independently
provides Graphite statistics.
This commit also changes default Graphite prefix to solve problem
with conflicting instance names.
Petr Špaček [Fri, 23 Oct 2020 15:48:41 +0000 (17:48 +0200)]
worker: migrate worker.id to string
It now contains either content of SYSTEMD_INSTANCE environment variable
or stringified version of getpid() value.
Main motivation is that the old worker.id was broken on systemd,
i.e. the default installation.
Related: #631
Petr Špaček [Fri, 23 Oct 2020 15:34:31 +0000 (17:34 +0200)]
doc: document new command buffering scheme
Fixup for
c0b5faf222dfa6e8db94838c18331e7147a37128 .
Petr Špaček [Fri, 23 Oct 2020 13:31:28 +0000 (15:31 +0200)]
http: adapt Prometheus to changes in map()
We don't have leader instance anymore, so any instance can provide
Prometheus statistics.
For performance reasons an instance does not store past statistics
when no client is connected to HTTP socket. As a consequence chart in
web interface is empty when client loads the page and then gradually
chart fills up.
Petr Špaček [Fri, 23 Oct 2020 12:33:33 +0000 (14:33 +0200)]
prometheus: run on all instances
Petr Špaček [Thu, 22 Oct 2020 11:15:50 +0000 (13:15 +0200)]
map: document internal use
Petr Špaček [Thu, 22 Oct 2020 10:31:30 +0000 (12:31 +0200)]
systemd: control socket cleanup on exit
Obviously this is is racy and cannot be relied upon.
Caller still has to handle connection errors.
Vladimír Čunát [Thu, 22 Oct 2020 09:17:49 +0000 (11:17 +0200)]
kluautil.list_dir: make it portable to non-Linux
Petr Špaček [Thu, 22 Oct 2020 07:10:28 +0000 (09:10 +0200)]
gitignore: add missing files created by kresd when executed in worktree
New map() creates control/ sockets in current working directory so it
pollutes worktree when developers run it in worktree.
I've also added files with ephemeral certificates and pytests test report
which were missing as well.
Petr Špaček [Fri, 16 Oct 2020 11:50:11 +0000 (13:50 +0200)]
map: tests
Three instances send commands and DNS queries to each other.
Petr Špaček [Tue, 20 Oct 2020 12:30:40 +0000 (14:30 +0200)]
map: disallow commands with \n
Control protocol uses \n as command delimiter so we cannot allow \n
inside commands. Users should be able to Lua-escape \n with \010.
Petr Špaček [Tue, 20 Oct 2020 11:51:54 +0000 (13:51 +0200)]
map: prevent crash on unrepresentable responses
Typical example of unrepresentable message is a Lua error.
E.g. error() called from kresc would lead to NULL message.
Petr Špaček [Tue, 20 Oct 2020 11:04:23 +0000 (13:04 +0200)]
map: thorough error checking on control socket operations
Petr Špaček [Fri, 16 Oct 2020 08:19:14 +0000 (10:19 +0200)]
tests: detect missing environment variable TEST_FILE
Petr Špaček [Fri, 16 Oct 2020 08:15:32 +0000 (10:15 +0200)]
kluautil: remove hard depedency on lua-cqueues
For now we still attempt to support systems without lua-cqueues,
e.g. Ubuntu 16.04.
lua-http depends on lua-cqueues so the test for availability of lua-http
at the beginning of kr_https_fetch() should cover lua-cqueues as well.
Petr Špaček [Wed, 14 Oct 2020 16:05:23 +0000 (18:05 +0200)]
tests: limit number of iterations for krprint.serialize_lua to please CI
We were exceeding CI time limit while running config tests under
Valgrind so let's see if smaller number of tests will get us through CI.
Petr Špaček [Wed, 14 Oct 2020 15:22:51 +0000 (17:22 +0200)]
daf: adapt to changes in map result handling
Petr Špaček [Wed, 14 Oct 2020 15:18:03 +0000 (17:18 +0200)]
map: logging for weird responses
Petr Špaček [Wed, 14 Oct 2020 09:08:43 +0000 (11:08 +0200)]
map: rework result handling
map() command on leader instance now:
- detects call errors on followers
- detects unsupported number of return values
- detects unsupported data types which cannot be serialized
- keeps nil return values (signaled by table counter "n")
Fixes: #662
Petr Špaček [Wed, 14 Oct 2020 07:24:23 +0000 (09:24 +0200)]
map: input command validation
Let's detect syntax errors before sending the command to all instances.
Petr Špaček [Tue, 13 Oct 2020 15:53:37 +0000 (17:53 +0200)]
kluautil: table pack and unpack
Helper functions for handling variable length arrays with nil values.
Petr Špaček [Tue, 13 Oct 2020 15:05:59 +0000 (17:05 +0200)]
map: stricter argument checking
Petr Špaček [Tue, 13 Oct 2020 10:54:16 +0000 (12:54 +0200)]
tests: adapt config tests to new map()
map() now depends on presence of control sockets, and by default config
tests are executed with KRESD_NO_LISTEN=1 env var which prevents control
sockets from being created. Tests for features which depend on map() now
explicitly create their own control socket.
Petr Špaček [Tue, 13 Oct 2020 10:53:07 +0000 (12:53 +0200)]
tests: improve process cleanup after config tests
Previously exit trap executed command "kill -9" even if there were no
leftover processes and this lead to clutter in logs because kill
complained about missing arguments.
As a bonus the cleanup routine now prints information about leftover
processes.
Petr Špaček [Tue, 21 Jul 2020 12:11:53 +0000 (14:11 +0200)]
daemon: always listen on control socket, even in interactive mode
Reasons:
- It allows to run several kresd instances and use map() without
worrying about instance parameters.
- It removes special case from map().
Proper functionality depends on changes in MR !1011.
Petr Špaček [Mon, 20 Jul 2020 09:17:23 +0000 (11:17 +0200)]
krprint.serialize_lua: rename function parameter to on_unpresentable
Petr Špaček [Fri, 10 Jul 2020 12:32:25 +0000 (14:32 +0200)]
new serialization method krprint.serialize_lua
Serializes: boolean, nil, number, string, table.
Skips all other types (functions, cdata, thread ...) and repeated
references to tables.
Resulting string should Lua-evaluate to identical objects.
Lukáš Ježek [Mon, 27 Apr 2020 12:00:17 +0000 (14:00 +0200)]
map: use control sockets instead of pipe from parent process
This change allows map() to work with systemd integration.
As a bonus the new client implementation is based on Lua cqueues
allows caller to wrap map() in worker.corroutine() and get
asynchronous execution/avoid blocking main loop.
Currently socket communication does not employ timeouts so a hang
instance will lead to hang map() call. This does not affect query
processing _if_ map() is being run in worker.corroutine.
Fixes: #554
Fixes: #620
Tomas Krizek [Fri, 23 Oct 2020 08:59:48 +0000 (10:59 +0200)]
Merge branch '538-lower-default-edns-buffer-size-to-1232' into 'master'
daemon: lower EDNS buffer size to 1232
Closes #300 and #538
See merge request knot/knot-resolver!920
Vladimír Čunát [Fri, 11 Sep 2020 15:39:37 +0000 (17:39 +0200)]
ci/respdiff: keep bufsize towards respdiff at 4K
Note: this commits affects just the small respdiffs, not the big ones.
Petr Špaček [Mon, 3 Feb 2020 14:11:15 +0000 (15:11 +0100)]
docs: EDNS bufsize = 1232
Lukáš Ježek [Fri, 10 Jan 2020 06:17:06 +0000 (07:17 +0100)]
daemon: lower EDNS buffer size to 1232
Petr Špaček [Wed, 21 Oct 2020 20:31:16 +0000 (22:31 +0200)]
Merge branch 'forward-cname-sibling' into 'master'
fix SERVFAIL in *FORWARD modes with certain CNAME setup
Closes #614
See merge request knot/knot-resolver!1070
Vladimír Čunát [Mon, 5 Oct 2020 08:35:16 +0000 (10:35 +0200)]
fix SERVFAIL in *FORWARD modes with CNAME to sibling zone
It failed on a CNAME to a sibling name that's a zone cut.
Fixed by a minimalistic approach - tweaking the conditions
to always ask each CNAME step separately when forwarding.
Vladimír Čunát [Wed, 21 Oct 2020 11:20:49 +0000 (13:20 +0200)]
Merge !985: change API for reply packet buffers
Vladimír Čunát [Fri, 25 Sep 2020 15:59:57 +0000 (17:59 +0200)]
lib/resolve kr_request_ensure_answer(): allow it to fail
For now I was too afraid to use "multi-flag" kr_request::state,
so I kept it at _FAIL; anyone can recognize it by NULL answer anyway.
Lua wrapper: using exception was considered but didn't seem good.
I utilized the fact that modules can return nil meaning no state change.
Vladimír Čunát [Fri, 13 Sep 2019 17:18:55 +0000 (19:18 +0200)]
lib/resolve answer_finalize: fix AD flag handling
Resolves a FIXME, and this way of doing AD should be better/safer.
(Lower likelihood of accidentally leaving it on in some situation.)
GC test: the record is inserted manually with _SECURE rank but without
signatures. I think it's better to return AD flag in that edge case.
Vladimír Čunát [Fri, 13 Sep 2019 16:26:19 +0000 (18:26 +0200)]
WIP delay allocation of kr_request::answer
FIXME: see FIXMEs in diff, document the API change, re-review.
Vladimír Čunát [Fri, 13 Sep 2019 16:14:54 +0000 (18:14 +0200)]
iterate nitpick: drop unused function parameter
Vladimír Čunát [Wed, 11 Sep 2019 15:57:41 +0000 (17:57 +0200)]
lib/resolve creation of first query: fix a rare possible bug
qname here wasn't lower-cased, so the match might not be correct.
Still, practically all deployments use either root TA or none,
and these can't be affected.
Vladimír Čunát [Wed, 11 Sep 2019 15:22:59 +0000 (17:22 +0200)]
compatible changes around kr_request::answer
Tomas Krizek [Tue, 20 Oct 2020 13:58:35 +0000 (15:58 +0200)]
Merge branch 'meson-0.49' into 'master'
meson: update to version 0.49
See merge request knot/knot-resolver!1082
Tomas Krizek [Fri, 16 Oct 2020 08:49:39 +0000 (10:49 +0200)]
meson: update to version 0.49
Tomas Krizek [Tue, 20 Oct 2020 09:11:51 +0000 (11:11 +0200)]
Merge branch 'unify-ENABLE-defines' into 'master'
treewide: unify ENABLE_* defines
See merge request knot/knot-resolver!1084
Vladimír Čunát [Mon, 19 Oct 2020 14:24:09 +0000 (16:24 +0200)]
treewide: unify ENABLE_* defines
Two styles were used: (un)defined and 0/1. We switch to 0/1.
Advantage: it can be used also like `if (ENABLE_FOO)`
(outside preprocessor).
Except for ./meson.build it's sed \
-e 's/#ifdef ENABLE_CAP_NG/#if ENABLE_CAP_NG/g' \
-e 's/#ifdef ENABLE_DOH2/#if ENABLE_DOH2/g' \
-e 's/defined(ENABLE_COOKIES)/ENABLE_COOKIES/g' \
-e 's/#ifdef ENABLE_COOKIES/#if ENABLE_COOKIES/g' \
-i $(git grep -l ENABLE_)
Tomas Krizek [Tue, 20 Oct 2020 09:02:46 +0000 (11:02 +0200)]
Merge branch 'ci-knot-xdp' into 'master'
ci: use docker image with XDP support
See merge request knot/knot-resolver!1085
Vladimír Čunát [Tue, 20 Oct 2020 08:55:06 +0000 (10:55 +0200)]
ci: use docker image with XDP support
Vladimír Čunát [Fri, 16 Oct 2020 08:04:46 +0000 (10:04 +0200)]
Merge !1079: doc: generate Info manual
Tomas Krizek [Thu, 15 Oct 2020 08:48:09 +0000 (10:48 +0200)]
doc/info: package figures
Simon South [Thu, 15 Oct 2020 11:13:20 +0000 (07:13 -0400)]
doc/info: create and install figures
Tomas Krizek [Wed, 14 Oct 2020 10:22:53 +0000 (12:22 +0200)]
doc/meson: fix installation with missing info page
Tomas Krizek [Tue, 13 Oct 2020 09:29:31 +0000 (11:29 +0200)]
distro/*: package info files
Simon South [Tue, 13 Oct 2020 00:14:43 +0000 (20:14 -0400)]
doc: use non-format-specific references to documentation
The "build-html-doc" ref-ID is preserved so as to not risk breaking
Web links and similar.
Simon South [Tue, 13 Oct 2020 00:14:42 +0000 (20:14 -0400)]
doc: generate Info manual
Check for makeinfo during configuration and if found, generate and
install documentation in Info format.
Tomas Krizek [Thu, 15 Oct 2020 11:17:08 +0000 (13:17 +0200)]
Merge branch '251-warn-if-static-unmanaged-key-is-used' into 'master'
Resolve "warn if static (unmanaged) key is used"
Closes #251
See merge request knot/knot-resolver!1051
Lukáš Ježek [Tue, 13 Oct 2020 09:13:00 +0000 (11:13 +0200)]
modules/ta_update: improve warning message
Vladimír Čunát [Thu, 13 Aug 2020 11:42:40 +0000 (13:42 +0200)]
modules/ta_update nitpick: don't call os.time() again
Vladimír Čunát [Mon, 5 Oct 2020 17:44:16 +0000 (19:44 +0200)]
tests: replace the deprecated -f parameter
Lukáš Ježek [Tue, 25 Aug 2020 10:03:10 +0000 (12:03 +0200)]
modules/ta_update: warn if there are differences between statically configured keys and upstream
Lukáš Ježek [Fri, 14 Aug 2020 09:50:05 +0000 (11:50 +0200)]
ta_update: rfc5011 test: fix knotd startup
Lukáš Ježek [Fri, 14 Aug 2020 09:28:40 +0000 (11:28 +0200)]
ta_update: rfc5011 test: removing the missing -r parameter for dnssec-tools
Lukas Jezek [Tue, 13 Oct 2020 12:23:06 +0000 (14:23 +0200)]
Merge branch 'doh-module-c' into 'master'
doh2: C implementation of DoH using nghttp2
Closes #600
See merge request knot/knot-resolver!997
Tomas Krizek [Wed, 7 Oct 2020 13:14:09 +0000 (15:14 +0200)]
daemon/http: fix double-free on some pkt send failures
When http_write() returns non-zero, worker_submit() performs the task
cleanup and calling on_write() callback only causes double free.