Vladimír Čunát [Tue, 5 Jan 2021 15:59:48 +0000 (16:59 +0100)]
tests/dnstap: fix, refactor and integrate into meson and CI
They need one go package which I can't find even in Debian,
so it probably can't work without network access.
The new dnstap in extra_tests runs if dnstap is built and go is found.
It also tries to keep the source tree clean.
Now both query and reply messages are tested.
In CI (after caching go deps in image) this tests only takes slightly
more time than the longest config.* tests, so that seems OK.
Even so, it's not added into the valgrind variant, as compilation
of the test still isn't split away from the run itself.
Vladimír Čunát [Mon, 4 Jan 2021 09:50:18 +0000 (10:50 +0100)]
treewide: avoid memset where it's trivial
More idiomatic code seems better:
- for variable initialization we have = { 0 }
- (mm_)calloc for heap allocations
sizeof: use variable instead of type (where suitable; not sure why)
Vladimír Čunát [Tue, 22 Dec 2020 11:44:39 +0000 (12:44 +0100)]
copy mempattern files from Knot DNS as they are
It seems just easier than having the copies in the current way.
I don't think the `static inline` were helping us anyway,
except for avoiding KR_EXPORT in some cases.
Still, differences when copying:
- we use plain memset() in the implementation
(no motivation here to use the complex memzero() approach)
- we expose mm_malloc(), as we've been referring to it
- we KR_EXPORT some of the functions (for lua and modules)
Vladimír Čunát [Mon, 4 Jan 2021 15:28:52 +0000 (16:28 +0100)]
dnstap: represent DoT and DoH
(instead of marking them as TCP)
This includes latest dnstap.proto, except for keeping our local changes
of the licensing comment.
https://github.com/dnstap/dnstap.pb/blob/master/dnstap.proto
Pavel Dolezal [Tue, 15 Dec 2020 12:27:50 +0000 (13:27 +0100)]
dnstap: multiple changes
- log queries and responses as separate dnstap messages
- use "query" instead of "request" to mirror dnstap specification
- don't export "query_zone" field in "CLIENT_*" messages
Jakub Ružička [Fri, 8 Jan 2021 16:23:17 +0000 (17:23 +0100)]
distro: introduce upstream cznic release prefix
using cznic.1 release string for upstream packages ensures they are
prefered over downstream ones and that their versions don't collide
which was causing issues for users with both downstream and upstream
packaging repos enabled.
Following statements are true according to `dpkg --compare-versions`:
1.2.3-1 < 1.2.3-cznic.1
1.2.3-999 < 1.2.3-cznic.1
So upstream packages should always take precedence over downstream
packages of the same version.
Tomas Krizek [Tue, 5 Jan 2021 12:08:35 +0000 (13:08 +0100)]
daemon/http: fix memleak
The http_data structure is allocated in http_write_pkt() and the last
callback that uses it is on_pkt_write(), so it should be responsible for
freeing the memory.
This used to leak a small amount of memory on every DoH response.
Štěpán Balážik [Wed, 6 Jan 2021 12:06:25 +0000 (13:06 +0100)]
daemon/worker.c: fix warning from compilation without asserts
I kept the changes (especially the one in qr_task_on_send) as local as
possible while hopefully preserving the invariants other functions in
worker rely upon.
Vladimír Čunát [Tue, 22 Dec 2020 10:29:39 +0000 (11:29 +0100)]
lib/selection: minor refactorings and comments
Small things I've noticed while reading it all.
- line breaks: I believe <90 is OK, as usually the attempts to reduce
lengths impair readability
- avoid unnecessary casts; usually the type was visible
on the same line anyway
- avoid `|` on booleans
- one block gets de-indented (often badly shown in diffs)
- no need for UNRECOVERABLE_ERRORS in a header (and a weird one, too)
- recoverability from failed assertions (in case they're turned off)
Vladimír Čunát [Tue, 29 Dec 2020 14:51:50 +0000 (15:51 +0100)]
lib/selection: tweak computation of RTT estimates
- fix switched \alpha and \beta from the RFC (no big deal, I think)
- use the same order as in the RFC (perhaps that caused the switch?)
- avoid floating-point arithmetics (it's simple with these formulas)
- simplify the the backoff formula (MINs instead of branches)
Vladimír Čunát [Tue, 29 Dec 2020 08:28:16 +0000 (09:28 +0100)]
lib/selection: be more careful around rtt_state.dead_since
It's all because the timestamp that we're using isn't (guaranteed to be)
meaningful across reboots or different machines, whereas our cache even
persists by default.
Vladimír Čunát [Mon, 28 Dec 2020 09:09:18 +0000 (10:09 +0100)]
lib/selection: tweak how cache is used
- standardize cache key choice and ensure impossibility of collisions
- comment on interaction with GC; it would be better to give RTT
priority over most of other records
- be more robust wrt. value in cache
Vladimír Čunát [Mon, 16 Nov 2020 13:28:49 +0000 (14:28 +0100)]
iterate: accept parent-side records for nameservers
When resolving just NS names and addresses which won't go to answers,
our cache can satisfy them with just parent-side records.
Now we also make iterator consistent with that, and it will cut short
if a delegation satisfies what the kr_query wants.
There's a general risk that we will never get the child-side records,
and in practice the parent-side ones are sometimes "less accurate".
This change may increase this risk (to NS addresses in particular),
but we'd better consider addressing the risk later and systematically.
A suggestion is to refresh the records asynchronously:
https://tools.ietf.org/html/draft-ietf-dnsop-ns-revalidation
---
State before this commit lead to a weird behaviour where some IPv4-only
tests in Deckard (namely `iter_pcdiff.rpl`) were failing with IPv6
turned off.
This was due to the resolvers' internal preference towards AAAA records
for NS names. With IPv6 networking on, NS name resolution was first
done for AAAA record and the glue (containing A record for the NS name
in question) from parent zone was put into cache. As the AAAA
resolution failed (there is no AAAA for this NS name), A was queried
next and was satisfied from cache.
With IPv6 off, there is no query for the AAAA record, so no A record
from glue gets put in to the cache. A record is resolved first, and
resolution ignores the glue in parent zone and continue to the child
zone which might be broken (intentionally in the case of that
`iter_pcdiff.rpl` test).
Vladimír Čunát [Mon, 14 Dec 2020 10:54:55 +0000 (11:54 +0100)]
view.addr(): throw error on bad subnet
It's more consistent with what we do. Now it will look like:
[system] error while loading config: .../lib/knot-resolver/kres_modules/view.lua:28: failed to parse subnet [::1]/128 (workdir '/foo/bar')
Tomas Krizek [Fri, 11 Dec 2020 14:42:22 +0000 (15:42 +0100)]
doc: use :any: to refer to non-function policies
:func: directive automatically always adds brackets. This results in
links such as "policy.PASS()", which can be confusing, since the actual
policy is supposed to be "policy.PASS".
Using :any: results in links without the added brackets, which makes
non-function policies less confusing.
Vladimír Čunát [Mon, 30 Nov 2020 06:39:24 +0000 (07:39 +0100)]
contrib/cleanup: loosen type-checking in auto_free
- advantage: `auto_free anyType *foo;` works (for anyType != char)
- disadvantage: `auto_free anyType bar;` is also accepted,
though I expect such problems will be relatively easy to debug.
Vladimír Čunát [Thu, 12 Nov 2020 13:13:49 +0000 (14:13 +0100)]
xdp: warn when using XDP emulation
For simplicity we bump Knot version that's required for using XDP.
Syntax: I found no better way to split the line;
alternative: backslash in meson >= 0.50.
projects / thirdparty / knot-resolver.git / log
