Nikola Forró [Tue, 8 Dec 2015 16:09:08 +0000 (17:09 +0100)]
api.c: change cgroup of every thread of a process
When changing cgroup of multi-threaded process, only the main threads
cgroup actually changed. Now all threads of a process are enumerated
and cgroup is changed for each of them.
Nikola Forró [Tue, 8 Dec 2015 15:53:41 +0000 (16:53 +0100)]
api.c: fix infinite loop
If getgrnam or getpwuid functions failed, the program entered
an infinite loop, because the rule pointer was never advanced.
This is now fixed by updating the pointer before continuing
to the next iteration.
Thus, setting of more network interfaces can not be done from configuration file. Or
devices.allow="a *:* w
c 8:* r";
thus setting list of allow devices can not be set as well. The only way is to set it from userspace, e.g.:
# echo "lo 7" > /sys/fs/cgroup/net_prio/testGroup/net_prio.ifpriomap
# echo "eth 0" > /sys/fs/cgroup/net_prio/testGroup/net_prio.ifpriomap
# echo "eth 1" > /sys/fs/cgroup/net_prio/testGroup/net_prio.ifpriomap
# echo "eth 2" > /sys/fs/cgroup/net_prio/testGroup/net_prio.ifpriomap
# echo "eth 3" > /sys/fs/cgroup/net_prio/testGroup/net_prio.ifpriomap
This patch allows setting of multiline variables.
How this support works:
Multiline value is broken in lines and each line is set by write (man 2 write) syscall (without bufferring).
This implies change of fopen with open, fclose with close.
There is no control on multiline value, thus "eth0\n \t\n" can be set. However, setting
of " \t" will fail as write command returns -1. Thus administrator has to set correct
multiline values.
Tested on virtual machine with fedora and rhel with network interface lo, eth0-eth3. Configuration file:
net_prio has to be created before:
# modprobe netprio_cgroup
# mkdir /sys/fs/cgroup/net_prio
# mount -t cgroup -onet_prio none /sys/fs/cgroup/net_prio
Changelog:
test of success of strdup call
free str_val before return (str_val is changing in while cycle,
thus str_start_val points to the start of str_val before while)
Signed-off-by: Jan Chaloupka <jchaloup@redhat.com>
Jan Chaloupka [Mon, 8 Sep 2014 11:28:18 +0000 (13:28 +0200)]
parse.y: extending cgroup names with "default"
default is used as a keyword for defining default group permissions. Having "default" as a group name (with double quotes "), parsing is successfull. Howerver, using default without double quotes, parsing fails. This patch modifies parsing rule and lex for default group name without double quotes.
cgroup_add_all_controllers function attach all mounted controllers to a given cgroup. This function just modifies internal libcgroup structure, not the kernel control group.
input parameter: cgroup
output parameter: zero or error number
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Reviewed-by: Jan Chaloupka <jchaloup@redhat.com>
Jan Chaloupka [Thu, 31 Jul 2014 09:23:08 +0000 (11:23 +0200)]
cgrules.d: new man page
This patch contains new man page for cgrules.d directory and corresponding
update of existing man pages. It describes the way additional configuration
files should be created and potential conflicts resulting from an arbitrary
order or reading files in the directory.
Changelog:
* line wrapping (max to 80 characters)
* hiearchy typo corrected
* diffrent typo corrected
* succesfully typo corrected
* /etc/cgconfig.conf added into FILES section
* formulation of advice for creating rules updated. Is it enough or
still confusing? If so, can you be more specific?
* reformulation of the first and the second paragraph
Signed-off-by: Jan Chaloupka <jchaloup@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Jan Chaloupka [Thu, 31 Jul 2014 09:21:19 +0000 (11:21 +0200)]
api.c: Adding support for loading configuration files from cgrules.d directory
Implementation of loading rules from /etc/cgrules.d/. Explanation is in the
cover letter. New function cgroup_parse_rules_file created,
calling cgroup_parse_rules. cgroup_parse_rules is invoked only in
cgroup_change_cgroup_flags, cgroup_init_rules_cache and
cgroup_reload_cached_rules functions. For them the change in cgroup_parse_rules
implementation is transpart.
Tested with two configuration files in /etc/cgrules.d/ and all rules
in /etc/cgrules.conf commented out:
$ cat /etc/cgrules.conf
#*:ls cpu strom/%u
#*:sleep memory les/%g
$ cat /etc/cgrules.d/cgrules1.conf
*:ls cpu strom/%u
Tested to cache reload as well by sending SIGUSR2 signal to running
cgrulesengd process. After first reload I commented out all rules => no
rules match after invoking ls command. After second reload I uncommented
out ls rule => rule match after invoking ls command. After third reload
I uncommented out ls and sleep rule => debug output of cgrulesengd shows
both rules loaded in the cache
Changelog:
* CGROUP_PARSE_STATE_UNLOCK removed
* reformulation of comment to "Cannot read directory. However,
CGRULES_CONF_FILE is succesfully parsed. Thus return as a success for
back compatibility."
* errno = 0 removed, once it is not zero, function returns, so need to set
it to 0 in every iteration
* fprintf replaced by cgroup_err
* added missing unlocks + new label unlock_list for all returns
This
- * finds a rule matching the given UID or GID. It will store this rule in rl,
+ * finds a rule matching the given UID or GID. It will store this rule in trl,
is valid correction. "It will store this rule in rl" talks about cache being
disabled. In this case, it is stored into trl.
Signed-off-by: Jan Chaloupka <jchaloup@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
When multi subsystems mounted on one place like this:
$ lssubsys -m
cpu,cpuacct /cgroup/cpu
$ lscgroup
cpu,cpuacct:/
cpu,cpuacct:/test
if we delete the cgroup with the cgdelete -g, and specifying multi
controllers like this:
$ cgdelete -g cpu,cpuacct:test
or
$ cgdelete -g cpu:test -g cpuacct:test
it will report error:
cgdelete: cannot remove group 'test': No such file or directory
this patch fix the problem.
v1 -> v2
- make cgdelete -g cpu:/test -g cpu:test failed.
v2 -> v3
- make cgdelete -g cpu:test -g cpu:test1 ok.
v3 -> v4
- make cgdelete -g cpuacct:test -g cpu:test -g cpuacct:test failed.
- add some comments
- fix the uninitialized warning
v4 -> v5 (created by Ivana Hutarova Varekova, acked by Weng Meiling)
- make cgdelete -g cpuacct:test -g cpu:test -g cpu:test failed
- join extended cgroup list variables to one record, do the list dynamic (static version can exceed the given limit and the safe static limit is quite high)
Signed-off-by: Weng Meiling <wengmeiling.weng@huawei.com> Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Weng Meiling <wengmeiling.weng@huawei.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Jan Chaloupka [Thu, 19 Jun 2014 09:42:14 +0000 (11:42 +0200)]
manpages: update of manpages for loading configuration
Manual pages for new functionality. Because loading files from directory is already implemented in cgconfig tool, there is nothing new. cgrulesengd reads only templates from given files. Rules for writing templates are already specified.
Signed-off-by: Jan Chaloupka <jchaloup@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Jan Chaloupka [Thu, 19 Jun 2014 09:39:37 +0000 (11:39 +0200)]
Makefile: update for cgruleseng.d Makefiles
Modification of makefiles. cgrulesengd.c uses new functions for loading files from /etc/cgconfig.d/. Thus there is a dependency on tools-common.[c|h] files. Unfortunatelly they are in ../tools directory, adding dependency on files in a diffrent directory but on the same level. Makefile.in is regenerated from Makefile.am using autoreconf -ivf.
Tested on my local machine, all files are loaded properly, cgrulesengd properly creates groups based on templates from files from /etc/cgconfig.d/.
Signed-off-by: Jan Chaloupka <jchaloup@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Jan Chaloupka [Thu, 19 Jun 2014 09:04:26 +0000 (11:04 +0200)]
cgrulesengd.c: loading of multiples files during init/reload
This patch use new implementation. In cgrulesengd.c, static variable template_files is used to save all config files, i.e. /etc/cgconfig.conf and /etc/cgconfig.d/*. This list of files is then passed to cgroup_templates_cache_set_source_files, which saves files to template_files in config.c module. This list is accessed through invocation of cgroup_init_templates_cache_from_files and cgroup_reload_templates_cache_from_files, which can access variables only from config.c, thus presenting cgroup_templates_cache_set_source_files function. At the end, this list is set free.
Signed-off-by: Jan Chaloupka <jchaloup@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Jan Chaloupka [Thu, 19 Jun 2014 08:34:32 +0000 (10:34 +0200)]
config.c: loading templates from multiple files into one template table
This patch implements loading files from /etc/cgconfig.d/. It uses already implemented functions. To hold list of files to be read for template reloading, new static variable for this list (list of template files) has been added to config.c. It is the same list as file list read with cgconfigparser (cgconfig.c file), i.e. the same functions are called. Because parser reads only one file, it is called for each file in template file list. Thus initialization, resp. template duplication has to be called before, resp. after each file parsing. Thus new functions has been presented, thus modifying config.[h|c] api and libcgroup.map. Again parsing more files for templates is analogy to parsing files for groups in cgconfig.c.
cgroup_load_cached_templates_from_file is a modification of cgroup_reload_cached_templates and cgroup_init_templates_cache. Only for loop and auxiliary variables added.
Changelog:
Description of config.h updated. [init|reload] replaced by load
TEMPLATE_ACTION_[INIT|RELOAD] removed
Instead of returning error on uninitialized list of template files, CGCONFIG_CONF_FILE with old cgroup_[init|reload]_templates_cache functions is called.
cgroup_config_create_template_group reports which template file caused unsuccesfull loading of template files
Signed-off-by: Jan Chaloupka <jchaloup@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
There is a situation when moving a task from child cgroup
to parent cgroup, the task exited. This will lead to service
cgconfig start failed. So ignore the error ESRCH.
Signed-off-by: Weng Meiling <wengmeiling.weng@huawei.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Jan Chaloupka [Mon, 10 Mar 2014 17:50:57 +0000 (18:50 +0100)]
lex: add \ character into regexp for ID token
Having virtual machine up, group name contains \ character after
cgsnapshot output. lex.l does not consider this case. For example:
group machine.slice/machine-qemu\x2drhel6.4.scope {...}
Adding \ character into regexp for ID token resolves this problem.
Signed-off-by: Jan Chaloupka <jchaloup@redhat.com> Acked-by: Dhaval Giani <dhaval.giani@gmail.com>
List of all patches:
Ivana Hutarova Varekova (37):
fix permissions of logger.sh
cgroup_get_cgroup: remove bogus comment
fix template function to copy template groups properly
documentation: fix cgroup_copy cgroup description
config.c: better detect whether template group already is created
parse: fix template parsing
lex: suppress useless warning message during compilation
create_cgroup_from_name_value_pairs can't deal n/v pairs from the same controller
cgsnapshot: don't display mountpoints which are not wanted
cgclassify: polish usage function
cgclassify: unify help output
cgclear: polish usage function
cgconfig: polish usage function
cgclear: unify help output
cgconfig: unify the help output
cgcreate: polish usage function
cgdelete: polish usage function
cgdelete: unification of usage function output
cgexec: polish usage function
cgexec: unify the help output
cgget: polish usage function
cgset: polish usage function
cgsnapshot: polish usage function
cgsnapshot: unify help output
lscgroup: polish usage function
lscgroup: unify help output
lssubsys: polish usage function
lssubsys: unify help output
cgroup_init: stop mntopt parsing if there is a bug in named hierarchy
cgroup_copy_with_slash: two typos
cgroup_get_current_controller_path: test whether strtok_r returns NULL
cgroup_config_create_template_group: fix strncpy limits
cgroup_config_create_template_group: test the right variable
cgroup_{reload|init}_cached_templates:memory leaks
cgroup_create_cgroup: write error on fail
cgconfig.conf: enable sign "@" in cgroup name
bindings: remove -nostdinc compiler option
Libo Chen (8):
log.h: add head file <stdarg.h>
cgcreate: add err check
cgconfig: add err check
cgconfig: fix the excursive processing
cgconfig: add parameter check
cgconfig: correct freeing default_cgroup
cgconfig: add check and nonzero
cgconfig: change function usage behavior
Peter Schiffer (8):
Use cache when reading /etc/passwd file
Cgred service won't start if /etc/cgrules.conf is missing
Typo in debug message in cgexec.c file
Incorrect cast
Invalid reallocation of config_table in config_insert_cgroup()
Templates letter case is switched
Use cache when calling cgroup_change_cgroup_flags()
Variable procname leaks
Weng Meiling (6):
cgsnapshot: fix the print message when use cgsnapshot with -f
when we use cgsnapshot with the given controller, the result always displays the last mounted controller which is not specified, so fix it.
It's more readable and friendly to use the enum value instead of number.
cgclassify: use the error message instead of error number
cgred:cgred should start when cgroup is mounted
cgcreate: fix the wrong uid/gid set.
stdarg.h header file is now (libstdc++-devel-4.6.3) in libctdc++ package, thus compilation of bindings failed:
../../include/libcgroup/log.h:12:20: fatal error: stdarg.h: No such file or directory
Thus -nostdinc compiler option have to be removed.
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Jan Safranek <jsafrane@redhat.com>
This patch enables to have "@" sign in cgroup name in cgconfig.conf as
well.
It is because of systemd, which uses sign "@" to separate the template name
from the instance identifier in its cgroup names.
For example: systemd-fsck@.service.
Without this patch, it's not possible to use these names in cgconfig.conf file.
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Peter Schiffer <pschiffe@redhat.com>
In the current version cgroup_create_cgroup returns warning if it fails and
can't set some variable. Thus on default configuration there is no
information about the problem. This situation happens if the cgconfigparser
reads cgconfig.conf. The error message where is the problem is very useful
in this case. The patch do the message visible in standard configuration.
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Peter Schiffer <pschiffe@redhat.com>
Peter Schiffer [Mon, 14 Oct 2013 06:49:34 +0000 (08:49 +0200)]
Use cache when calling cgroup_change_cgroup_flags()
When system contains cgrules.conf file with few thousand rules,
cgroup_change_cgroup_flags() function without CGFLAG_USECACHE flag is very
slow.
As Ivana pointed out, cgexec and cgclassify tools might have problems with
cache
reloading, so I've removed them from the patch for now.
Currently, the patch affects only cgrulesengd daemon. Testing was done with
approximately 4000 users, rules in cgrules.conf file and same amount of
entries
in cgconfig.conf. Without the CGFLAG_USECACHE the cgrulesengd is starting
for
about 15 - 20 minutes (this is because of cgroup_change_all_cgroups()
function,
which scans all running processes on cgrulesengd start).
Signed-off-by: Peter Schiffer <pschiffe@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Peter Schiffer [Mon, 14 Oct 2013 06:43:24 +0000 (08:43 +0200)]
Templates letter case is switched
Man page cgrules.conf(5) says:
%u username, uid if name resolving fails
%U uid
%g group name, gid if name resolving fails
%G gid
%p process name, pid if name not available
%P pid
However, in cgroup_change_cgroup_flags() function, the letter case is switched.
This patch fixes the problem.
Signed-off-by: Peter Schiffer <pschiffe@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Fix a typo when the '/' character is tested on the last but one position instead of the last.
There have to be more allocated more memory in the same function.
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Peter Schiffer <pschiffe@redhat.com> Acked-by: Dhaval Giani <dhaval.giani@gmail.com>
lscgroup: unify help output
* use tabulators instead of spaces
* at first describe the functionality and then describe options
* use printf instead fprintf(stdout,..)
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Dhaval Giani <dhaval.giani@gmail.com> Acked-by: Jan Safranek <jsafrane@redhat.com>
This change is suggested by Dhaval Giani <dhaval.giani@gmail.com>.
Polish "usage" function of cgset tool. Remove a level of indentation.
Use tabulators instead of spaces.
Based on Jan's comment change typo display->set in -g description
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Dhaval Giani <dhaval.giani@gmail.com> Acked-by: Jan Safranek <jsafrane@redhat.com>
This change is suggested by Dhaval Giani <dhaval.giani@gmail.com>.
Polish "usage" function of cgget tool. Remove a level of indentation.
Use printf instead of fprintf(stdout,...)
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Dhaval Giani <dhaval.giani@gmail.com> Acked-by: Jan Safranek <jsafrane@redhat.com>
This change is suggested by Dhaval Giani <dhaval.giani@gmail.com>.
Polish "usage" function of cgcreate tool. Remove a level of indentation.
use printf instead of fprintf(stderr,...)
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Dhaval Giani <dhaval.giani@gmail.com> Acked-by: Jan Safranek <jsafrane@redhat.com>
Remove cgconfig input free row and change the output program name to standardize
the output with the other libcgroup tools.
sort options based on alphabetical order
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Dhaval Giani <dhaval.giani@gmail.com> Acked-by: Jan Safranek <jsafrane@redhat.com>
remove exit from function usage and add a structure like usage function
in the other tools.
This is suggested by Ivana Hutarova Varekova <varekova@redhat.com>
now usage willn't exit, so we should help it in err case.
v4:
- fix some code style reported by checkpatch.pl
Signed-off-by: Libo Chen <clbchenlibo.chen@huawei.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
cgroup still can be created even if giving invalid -d,-f,-s parameter.
e.g.
cgconfigparser -d 888 -l /etc/cgconfig.conf
"888" is invalid, but cgroup will be created.
So we should exit when -d,-f or -s is invalid.
v3:
- add nonzero return value
- use error instead of ret
Signed-off-by: Libo Chen <clbchenlibo.chen@huawei.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
cgsnapshot: don't display mountpoints which are not wanted
the first version of this patch was created by Libo Chen <clbchenlibo.chen@...>
see http://sourceforge.net/p/libcg/mailman/libcg-devel/thread/51FB6459.9000307%40huawei.com/#msg31243958
before patch:
#lscgroup
cpu:/
cpuset:/
#cgsnapshot -s cpu
mount {
cpuset = /cgroup/cpuacct;
cpu = /cgroup/cpu;
}
We just wanted to save cpu controller, so cpuset was unexpected
Changelog:
* parse controller list only if the list is set, if there is no restriction display all hierarchies
* parse named list as well, thus they are not output if they are not wanted
* remove TODO comment
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Reported-by: Libo Chen <clbchenlibo.chen@...> Acked-by: Jan Safranek <jsafrane@redhat.com>
create_cgroup_from_name_value_pairs can't deal n/v pairs from the same controller
create_cgroup_from_name_value_pairs can't deal name/value pairs from the
same controller
E.G.
cgset -r cpu.cfs_quota_us=400000 -r cpu.cfs_period_us=400000 cgroup
This patch fix the problem.
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Jan Safranek <jsafrane@redhat.com>
fix cgroup_copy_cgroup description. There should be obvious this function only copy the controller stuff. It does not copy permissions, name and ownership.
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Jan Safranek <jsafrane@redhat.com>
fix template function to copy template groups properly
This patch fixes cgroup_init_templates_cache and cgroup_reload_cached_templates functions. Their have to copy not only
controllers and their structures but all variables (controller name, permissions and ownership) for templates.
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-by: Jan Safranek <jsafrane@redhat.com>
Peter Schiffer [Tue, 25 Jun 2013 04:47:47 +0000 (06:47 +0200)]
Cgred service won't start if /etc/cgrules.conf is missing
By default, the /etc/cgrules.conf file contains only comments. If this is the case, the cgred service starts without problem. But if /etc/cgrules.conf file is empty or missing, the cgred service won't start, even this case is equivalent with the first one.
This patch allows the cgred service start even when the /etc/cgrules.conf files is empty, or missing.
Signed-off-by: Peter Schiffer <pschiffe@redhat.com> Acked-by: Jan Safranek <jsafrane@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Peter Schiffer [Tue, 25 Jun 2013 04:37:41 +0000 (06:37 +0200)]
Use cache when reading /etc/passwd file
Currently, libcgroup code reads /etc/passwd file once for every line in the cgrules.conf file, what can have performance impact on the login times if system contains thousands of users and cgrules.conf contains thousands of lines.
This patch adds CGFLAG_USECACHE flag to the cgroup_change_cgroup_uid_gid() function call which enables cache usage, and thus speeds up login times on those systems.
Signed-off-by: Peter Schiffer <pschiffe@redhat.com> Acked-by: Jan Safranek <jsafrane@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
The major changes are template stuff and new logging.
List of all patches:
Ivana Hutarova Varekova (12):
cgrules.conf: no documentation inside config file
cgroup_change_cgroup_flags: create template control group on the fly
cgconfigparser: add template tag to cgconfigparser
cgconfig.conf: parse template tag and fill relevant structures
config.h: create function for init/reload cgconfig template cache
api: add function for creating template control groups
cgrulesengd: cache templates
cgroup_change_cgroup_flags: use templates if they are in rules
update documentation to reflect the changes regarding templates
api.c: cgroup_create_template_group templates crashing
templates have to be coppied in proper way to template_table structure
remove useless include from log.h
John Fastabend (1):
libcg: scan running tasks at start time to classify existing pids
Peter Schiffer (15):
Removed cgroup_dbg from cgrulesengd
Reworked libcgroup logging
Enabled default logging
Reworked logging configuration
Added parsing of CGROUP_LOGLEVEL
Recognize DEBUG level of CGROUP_LOGLEVEL variable in daemon
Fixed cgrulesengd to log libcgroup log messages to syslog
Changed log level of various messages
Added new errors/warnings
Enabled logging in cgconfigparser
Added new logging to the tools
Added a test for the new logging
Added CGROUP_LOGLEVEL to man pages + fixed the style of 'FILES' section where appropriate.
Update default logging for cgrulesengd
Make cg_mkdir_p() function compatible with read-only fs
Robert Milasan (1):
fix defaultcgroup detection (better description)
Roberto Polli (1):
support indented comments in cgconfigparser
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com>
Peter Schiffer [Thu, 16 May 2013 15:10:32 +0000 (17:10 +0200)]
Make cg_mkdir_p() function compatible with read-only fs
mkdir(2) function returns EROFS error even when the path already exists on
the read only file system, so it is impossible to determine whether the path
already exists on this kind of fs only be return code from the mkdir(2). To make
cg_mkdir_p() compatible with the ro fs, the function checks whether the
path exists with stat(2) before trying to create it.
Signed-off-by: Peter Schiffer <pschiffe@redhat.com> Acked-By: Jan Safranek <jsafrane@redhat.com>
templates have to be coppied in proper way to template_table structure
cgroup_reload_cached_templates and cgroup_init_templates_cache functions fill structure template_table in old version the data are coppied
(memcpy function) from config_template_table.
This causes problem if both template_table and config_template_table are reloaded or if config_template_table is updated. Patch fix this problem and copy data properly (cgroup_copy_cgroup function)
The reproducer of this bug is described in http://sourceforge.net/mailarchive/forum.php?thread_name=khtfkj%24c8l%241%40ger.gmane.org&forum_name=libcg-devel
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-By: Jan Safranek <jsafrane@redhat.com>
cgroup_create_template_group procedure writes to the first place of string of characters even if the varible points to NULL. As the result templates crashes.
See http://sourceforge.net/mailarchive/forum.php?thread_name=khtfkj%24c8l%241%40ger.gmane.org&forum_name=libcg-devel
Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com> Acked-By: Jan Safranek <jsafrane@redhat.com>
Peter Schiffer [Tue, 2 Apr 2013 08:57:07 +0000 (10:57 +0200)]
Update default logging for cgrulesengd
Cgrulesengd is using different default logging level than the library.
Currently
it's set to WARNING, which is not consistend with the rest of the library.
This
patch sets the default logging level to ERROR.
This patch also unifies logging levels with default logging system used in
libcg, be removing LOG_NOTICE and replacing it with LOG_INFO.
Signed-off-by: Peter Schiffer <pschiffe@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Peter Schiffer [Tue, 2 Apr 2013 08:56:51 +0000 (10:56 +0200)]
Enabled logging in cgconfigparser
cgconfigparser calls cgroup_init too late, it's necessary to initialize
libcgroup logging earlier in the process, so various messages get visible
to user.
Signed-off-by: Peter Schiffer <pschiffe@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Peter Schiffer [Tue, 2 Apr 2013 08:56:45 +0000 (10:56 +0200)]
Added new errors/warnings
I've put few errors and warnings where I find them appropriate - usually
when a function returns error and the user might be interested exactly what
file/directory is bad.
Signed-off-by: Peter Schiffer <pschiffe@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Peter Schiffer [Tue, 2 Apr 2013 08:55:40 +0000 (10:55 +0200)]
Changed log level of various messages
I went through cgroup_dbg messages and increased they log level where I
found it appropriate. I am pretty sure I missed other important ones, this
is just a first attempt. Feel free to suggest additional messages.
Changelog:
- fixed capital letters in few log messages
Signed-off-by: Peter Schiffer <pschiffe@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
Peter Schiffer [Tue, 2 Apr 2013 08:52:59 +0000 (10:52 +0200)]
Reworked libcgroup logging
Whole new logging with following goals is here:
- more log levels.
- allow applications to log somewhere else than stdout using their custom
callback.
- provide simple stdout logger for 'lazy' applications.
The logging is off by default, i.e. no message appears on stdout unless
application initializes the logging explicitly. But see following patches!
Internally, nothing changes, cgroup_dbg is still working. In addition,
cgroup_err, cgroup_warn and cgroup_info appeared. Description what message
should use which log level is in doxygen info, together with new public API
incl. simple example, I won't copy it here
Also the cgroup_log function is made public. I am not sure if it is the
right thing to do, but that's currently the simplest way how to use the
logging from our tools (which link only the public libcgroup API).
Changelog:
- fixed typo in cgroup_log doxygen comment
Signed-off-by: Peter Schiffer <pschiffe@redhat.com> Acked-by: Ivana Hutarova Varekova <varekova@redhat.com>
projects / thirdparty / libcgroup.git / log
