[#2454] Compilation fix

[#2454] Renamed ctrl socket template to appease doxygen

[#2454] More Doxygen warnings fixed

[#2454] doxygen tags added

[#2454] Doxygen fixes

[#1781] spelling

[#1781] Additional review comments

src/hooks/dhcp/high_availability/query_filter.h
    Added commentary

src/hooks/dhcp/high_availability/tests/query_filter_unittest.cc
    Added commentary

[#1781] spelling

[#1781] Addressed initial review comments

doc/sphinx/arm/hooks.rst
    Added paragraph about hook library ordering

src/hooks/dhcp/high_availability/query_filter.cc
    Added comment

src/hooks/dhcp/high_availability/tests/query_filter_unittest.cc
    Test beyond enum EOF.

[#1781] spelling

[#1781] Removed whitespace

[#1781] HA now load balances only specific message types

Added a ChangeLog

src/hooks/dhcp/high_availability/query_filter.*
    QueryFilter::isHaType(const dhcp::Pkt4Ptr& query4)
    QueryFilter::isHaType(const dhcp::Pkt6Ptr& query6)
    - new functions

    QueryFilter::inScope() - uses new functions to balance
    and scope messages of specific types

src/hooks/dhcp/high_availability/tests/query_filter_unittest.cc
    TEST_F(QueryFilterTest, loadBalancingHaTypes4)
    TEST_F(QueryFilterTest, loadBalancingHaTypes4MultiThreading)
    TEST_F(QueryFilterTest, loadBalancingHaTypes6)
    TEST_F(QueryFilterTest, loadBalancingHaTypes6MultiThreading)
    - new tests

src/lib/dhcp/dhcp6.h
    Uncommented v6 message types.

[#2491] Add hammer support for alpine 3.16

[#2437] ARM style change: render literals in black and underline xrefs

Apply 1 suggestion(s) to 1 file(s)

Update doc/sphinx/arm/hooks-lease-cmds.rst

[#2487] Toned down message ID and text

Removed the word FAILED/failed and toned down log messages added in #2352
so they will not be mistaken for error conditions.

src/lib/dhcpsrv/cfg_subnets4.cc
src/lib/dhcpsrv/cfg_subnets6.cc

src/lib/dhcpsrv/dhcpsrv_messages.cc b/src/lib/dhcpsrv/dhcpsrv_messages.cc
src/lib/dhcpsrv/dhcpsrv_messages.h b/src/lib/dhcpsrv/dhcpsrv_messages.h
src/lib/dhcpsrv/dhcpsrv_messages.h b/src/lib/dhcpsrv/dhcpsrv_messages.me

[#2469] moved upload to cloudsmith step later in the process, addressed review comments

[#2469] updates to release checklist

[#2481] Added ChangeLog entry

[#2481] Addressed review comments

Apply 17 suggestion(s) to 3 file(s)

[#2481] unrelated - respect naming convention for structs

[#2481] document lease limits in the ARM

[#2083] addressed comments

[#2083] addressed comments

[#2083] addressed comments

[#2083] fixed documentation

[#2083] fixed ha rst documntation by adding quotation marcs and fixing indentation

[#2419] Make suggested changes from Code Review

[#2419] Add changelog entry for reservation conflicts stat

[#2419] Add changelog entry for reservation conflicts stat

[#2419] Begin adding stats to track HR assignment conflicts

Resolved merge conflict

[#2419] Modify existing unit tests that cause reservation conflicts to ensure stats are working

[#2419] Add documentation for v4-reservation-conflicts

[#2419] Fix statistics (add v4-reservation-conflicts) unit tests for dhcp4

[#2419] Begin adding stats to track HR assignment conflicts

[#2432] Added a note about no longer needing autogeneration

[#2432] solve warning: std::binary_function is deprecated

[#2432] solve warning: std::unary_function is deprecated

[#2432] solve warning: unused variable ‘err’

[#2448] add NEXT_STEP_DROP test cases to dhcpX_srv_configured unit test

[#2448] make NEXT_STEP_DROP in dhcpX_srv_configured lead to DHCPX_CONFIG_LOAD_FAIL

[#2448] add virtual in LeaseMgr methods

[#2448] solve unused parameter warning

[#2448] add "limits" to header regex in .clang-format

[#2448] add ClientClasses::toElement()

[#2448] add C++ template adapters to LeaseXPtr

[#2448] make class counter methods virtual in LeaseMgr

[#2448] add MultiThreadingLock

[#2448] add Element::create(uint32_t)

[#2473] added ChangeLog

[#2473] add continuation for ScopedCalloutHandleState

[#2470] fix formatting tools on premium or other repos

[#2461] remove SHA2-256 from hash generated by openssl command to keep backwards compatibility

[#2379] add ChangeLog entry

[#2379] add tools/check-for-missing-api-commands.sh

[#2447] added ChangeLog

[#2447] fixed documentation

[#2445] add the proper data types to function arguments in dhcpdb_drop.pgsql

[#2445] change lease_type to smallint in PostgreSQL trigger functions

[#2445] trim double quotes from classes in PostgreSQL update triggers

[#2445] add getClassLeaseCount() for MySQL and PostgreSQL

[#2445] add ChangeLog entry

[#2445] use PgSqlExchange::getColumnValue() to fetch limits

[#2445] fix PgSqlLeaseMgr::isJsonSupported() from always returning true

[#2445] PostgreSQL lease manager tests

[#2445] implement PostgreSQL lease manager methods for limit checking

[#2445] tests for PostgreSQL lease counting

[#2445] PostgreSQL schema changes in support of lease limiting

[#2436] Added virtual to getCLassLeaseCount

modified:   memfile_lease_mgr.h

[#2436] Added ChangeLog entry

[#2436] Addressed review comments

src/lib/dhcpsrv/memfile_lease_limits.cc
    ClassLeaseCounter::getLeaseClientClasses()
    - improved error handling

src/lib/dhcpsrv/memfile_lease_limits.h
    ClassLeaseCounter::getLeaseClientClasses()
    - changed from const to static

src/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::checkLimits4() fixed count type
    Memfile_LeaseMgr::checkLimits6() fixed exception

dhcpsrv/memfile_lease_mgr.h
    fixed typos

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
    GenericLeaseMgrTest::testLeaseLimits4()
    GenericLeaseMgrTest::testLeaseLimits6()
    - removed unecesary CfgMgr logic

src/lib/dhcpsrv/tests/memfile_lease_limits_unittest.cc
    TEST_F(ClassLeaseCounterTest, adjustClassCountsTest4)
    TEST_F(ClassLeaseCounterTest, adjustClassCountsTest6)
    TEST_F(ClassLeaseCounterTest, getLeaseClientClassesTest)
    - new tests

src/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::getClassLeaseCount() - added mutex

src/lib/dhcpsrv/memfile_lease_mgr.h
    Added thread-safe comments

[#2426] Addressed review comments

src/lib/dhcpsrv/memfile_lease_limits.cc
    ClassLeaseCounter::getLeaseClientClasses()
    - improved error handling

src/lib/dhcpsrv/memfile_lease_limits.h
    ClassLeaseCounter::getLeaseClientClasses()
    - changed from const to static

src/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::checkLimits4() fixed count type
    Memfile_LeaseMgr::checkLimits6() fixed exception

dhcpsrv/memfile_lease_mgr.h
    fixed typos

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
    GenericLeaseMgrTest::testLeaseLimits4()
    GenericLeaseMgrTest::testLeaseLimits6()
    - removed unecesary CfgMgr logic

src/lib/dhcpsrv/tests/memfile_lease_limits_unittest.cc
    TEST_F(ClassLeaseCounterTest, adjustClassCountsTest4)
    TEST_F(ClassLeaseCounterTest, adjustClassCountsTest6)
    TEST_F(ClassLeaseCounterTest, getLeaseClientClassesTest)
    - new tests

[#2436] Implemement Memfile_LeaseMgr:checkLimitsX functions

src/lib/dhcpsrv/lease_mgr.h
    Make LeaseMgr::getClassLeaseCount() const

src/lib/dhcpsrv/memfile_lease_limits.*
    Add ClassLeaseCounter()::getConstCountMap()
    make  size() const

src/lib/dhcpsrv/memfile_lease_mgr.*
    make Memfile_LeaseMgr::getClassLeaseCount() const
    Memfile_LeaseMgr::checkLimits4()
    Memfile_LeaseMgr::checkLimits6()
    Memfile_LeaseMgr::getSubnetStat()
    Memfile_LeaseMgr::getLeaseLimit() - new functions

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
    GenericLeaseMgrTest::testLeaseLimits4()
    GenericLeaseMgrTest::testLeaseLimits6()
    - use CfgMgr to update subent stats

src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
    Enable checkLimits tests

[#2436]  More review comments

Use "client-classes" not "classes" in user-context

src/lib/dhcpsrv/memfile_lease_limits.cc
src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
src/lib/dhcpsrv/tests/memfile_lease_limits_unittest.cc

[#2436] Fixed broken generic lease mgr test

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
    GenericLeaseMgrTest::testLeaseLimits6() - fixed error created
    one I originally split testLeaseLimits()

src/lib/dhcpsrv/tests/mysql_lease_mgr_unittest.cc
   split TEST_F(MySqlLeaseMgrTest, checkLimits) into v4 and v6 tests

[#2436] Rebased and added generic tests

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.*
    Split GenericLeaseMgrTest::testLeaseLimits() into:
        GenericLeaseMgrTest::testLeaseLimits4()
        GenericLeaseMgrTest::testLeaseLimits6()

src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
    TEST_F(MemfileLeaseMgrTest, isJsonSupported4)
    TEST_F(MemfileLeaseMgrTest, isJsonSupported6)
    TEST_F(MemfileLeaseMgrTest, DISABLED_checkLimitsNull4)
    TEST_F(MemfileLeaseMgrTest, DISABLED_checkLimitsNull6)
    TEST_F(MemfileLeaseMgrTest, DISABLED_checkLimits4)
    TEST_F(MemfileLeaseMgrTest, DISABLED_checkLimits6) - new tests

src/lib/dhcpsrv/tests/mysql_lease_mgr_unittest.cc
    TEST_F(MySqlLeaseMgrTest, DISABLED_classLeaseCount4)
    TEST_F(MySqlLeaseMgrTest, DISABLED_classLeaseCount6_NA)
    TEST_F(MySqlLeaseMgrTest, DISABLED_classLeaseCount6_PD) - new tests

[#2436] More review comments pre-rebase

src/lib/dhcpsrv/memfile_lease_limits.h
    Commentary fixes

rc/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::updateLease4Internal()
    Memfile_LeaseMgr::updateLease6Internal() - adjust counts
    after replacing the lease in store

    Memfile_LeaseMgr::recountClassLeases4()
    Memfile_LeaseMgr::recountClassLeases6() - remove use of index

src/lib/dhcpsrv/tests/memfile_lease_limits_unittest.cc
    Fix wrong lease states.

[#2436] Addressed most review comments prior to rebase

src/lib/dhcpsrv/memfile_lease_limits.cc
    ClassLeaseCounter::getLeaseClientClasses() - looks for classes in "ISC"

src/lib/dhcpsrv/memfile_lease_limits.h
    ClassCountMap& getCountMap() - reordered return logic

src/lib/dhcpsrv/memfile_lease_mgr.h
    override and virtual use correction

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.*
    GenericLeaseMgrTest::makeContextWithClasses() - embed in "ISC" element

src/lib/dhcpsrv/tests/memfile_lease_limits_unittest.cc
    makeContextWithClasses() - embed in "ISC" element

src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
    add using namespace data

Apply 3 suggestion(s) to 2 file(s)

Apply 1 suggestion(s) to 1 file(s)

[#2436] Removed unecessary added include

modified:   memfile_lease_mgr_unittest.cc

[#2436] Make class lease count tests generic

Moved tests from memfile_lease_mgr_unittests.* to
generic_lease_mgr_unitest.*

[#2436] Remove class lease recount definitions from LeaseMgr

[#2436] Memfile_LeaseMgr now counts class leases

src/lib/dhcpsrv/lease_mgr.*
    LeaseMgr - added virtual methods:
    ::recountClassLeases4()
    ::recountClassLeases6()
    ::getClassLeaseCount()

src/lib/dhcpsrv/memfile_lease_mgr.*
    Memfile_LeaseMgr
    ::addLeaseInternal()
    ::updateLeaseXInternal()
    ::deleteLeaseInternal(const Lease4Ptr& lease) {
    - added calls to add/remove leases from count map

    ::recountClassLeases4()
    ::recountClassLeases6()
    ::getClassLeaseCount()

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
    Added boolean flag to makeLease4 and makeLease6

src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
    New tests:
    TEST_F(MemfileLeaseMgrTest, classLeaseCount4)
    TEST_F(MemfileLeaseMgrTest, classLeaseCount6_NA)
    TEST_F(MemfileLeaseMgrTest, classLeaseCount6_PD)
    TEST_F(MemfileLeaseMgrTest, classLeaseRecount4)
    TEST_F(MemfileLeaseMgrTest, classLeaseRecount6)

[#2436] Added ClassLeaseCounter container

Implemented dhcp::ClassLeaseCounter, a container for
managing lease counts per class

src/lib/dhcpsrv/memfile_lease_limits.h
src/lib/dhcpsrv/memfile_lease_limits.cc
    New files that support class lease counting

src/lib/dhcpsrv/Makefile.am
    added memfile_lease_limits.cc, memfile_lease_limits.h

src/lib/dhcpsrv/lease.h
    added Lease::getType() because I am sick of it not existing

src/lib/dhcpsrv/memfile_lease_limits_unittest.cc
    New file

src/lib/dhcpsrv/tests/Makefile.am
    added memfile_lease_limits_unittest.cc

Update configure.ac

Update platforms.rst

Update platforms.rst

Update platforms.rst

spell check, sphnx config change for RHEL9

Spell check

[#2463] release changes

[#2457] fill vector with zeros in SecBuf without referencing potentially unallocated first element

[#2458] added missing package for pdf documentation in ubuntu 22

[#2455] bump lib versions for 2.1.7

[#2266] updated doxygen

[#2266] fixed indentation

[#2266] addressed comments