Add a test utility function, copy_reference_file simply coping
a sample file to the current directory of a running test.
A uudecode filter test will use it for its new test.
TODO: make a symbolic link file insted of copying a sample file.
Historically, libarchive cannot handle uuencoded files when
libarchive's test suit was made. Now libarchive can handle it
directly by uudecode filter, I think, we can reduce copying
sample files to the directory test program expects they are
on an isolated directory for their test.
Romain Fliedel [Fri, 20 Jun 2014 13:45:09 +0000 (15:45 +0200)]
Silently ignore lchmod failure in when not supported
lchmod might be defined but not supported by the platform,
(this is the case with musl implementation of fchmodat) in
this case we can safely ignore the error.
Check for legal HTTP but illegal unix filenames in WARCs archives.
This changeset will refuse to extract WARCs that contain filenames
a la http://example.com/implicit/content/
There is a todo note in archive_read_support_format_warc.c discussing
possible archive options to extract filenames like those either by
explicit user input or by some sort of heuristic as used in wget
for example.
This changeset adheres to the previously imported read test.
The archive format is hard-set to ARCHIVE_FORMAT_WARC, while the
format name is the stringified WARC/x.y version designator, which
for performance reasons will be cached between calls to the header
reader _warc_rdhdr().
Hygiene, set unconsumed slot exactly once for each branch
in _warc_read(). Also kick __archive_read_consume() because the writer
will consume the bytes for us. So for the EOF case, set unconsumed to 0,
for the non-EOF case set unconsumed to the minimum of the number of bytes
read and the content length.
Hygiene, trust __archive_read_ahead() and kick superfluous check.
Heeding Tim's advice, a non-NULL from __archive_read_ahead() is
guaranteed to be of at least the minimum size, therefore no need to
check for this condition again.
fix, never write more bytes in _warc_data() than ...
previously announce in _warc_header().
The test suite (as is) is one offender. It populates a 9-byte string, mimicking an IFREG file
but by the time the header makes it into the archive, the size changes from 0 to 9.
Paul Barker [Sun, 6 Apr 2014 21:54:48 +0000 (22:54 +0100)]
Fix intermittent segfault when reading zip files
When looking up the compression name for a zip file the index variable was being
incremented too soon. Thus element zero ("uncompressed") was never checked and
reads could be made past the end of the array. This was causing intermittent
segfaults in the call to sprintf in zip_read_local_file_header.
Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
Paul Barker [Thu, 6 Feb 2014 21:20:06 +0000 (21:20 +0000)]
Prevent unnecessary linking against deflate code
In _archive_write_disk_free, the call to deflateEnd was compiled if HAVE_ZLIB_H
was defined. However, all other calls to deflate functions were only compiled
if __APPLE__, UF_COMPRESSED and HAVE_SYS_XATTR_H were also defined. So if one of
these macros was not defined but HAVE_ZLIB_H was defined, the call the
deflateEnd would be unnecessary as deflateInit could never have been called.
In statically linked applications which don't use deflate functions elsewhere
this was causing unnecessary linking of the deflate code from zlib, adding at
least 20k of object code to the final executable size.
This patch fixes the above issue by surrounding the call to deflateEnd with the
same conditional compilation checks as surround the call to deflateInit.
Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
Paul Barker [Sun, 6 Apr 2014 14:48:24 +0000 (15:48 +0100)]
Split archive_read_extract2 from archive_read_extract
The function archive_read_extract requires a call to
archive_write_disk_set_standard_lookup but the functions archive_read_extract2
and archive_read_extract_set_progress_callback do not. Therefore, the latter
pair of functions, the internal function __archive_read_get_extract and the
static function copy_data are moved out of archive_read_extract.c into the new
file archive_read_extract2.c.
This ensures that when statically linking, the standard user and group lookup
functions will not be linked into a program unless they are really needed.
Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
Paul Barker [Sun, 6 Apr 2014 13:37:03 +0000 (14:37 +0100)]
Refactor archive_read_extract
The initialisation of the archive_write_disk object and the call to
archive_write_disk_set_standard_lookup are only needed in the
archive_read_extract function, not in archive_read_extract2 or other related
functions. Therefore this initialisation is merged into archive_read_extract.
The static function get_extract is renamed to __archive_read_get_extract so that
is can be made non-static. The struct extract is renamed to archive_read_extract
so that it can be placed in a header file without risk of namespace clashes.
Both these declarations are then moved to the archive_read_private.h header.
This preparation is necessary so that the contents of archive_read_extract.c can
be split between two source files.
Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
Mike Kazantsev [Sat, 5 Apr 2014 22:40:40 +0000 (04:40 +0600)]
Change bsdcat behavior to process as many files as possible.
Change is to match "cat" behavior of printing any errors (e.g. "unable to
open file") and continue to the next file instead of exiting on first error
encountered.
projects / thirdparty / libarchive.git / log
