]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
3 years agoT_HASH is the end of equality operators
Alan T. DeKok [Tue, 16 Nov 2021 00:40:23 +0000 (19:40 -0500)] 
T_HASH is the end of equality operators

this change means we can add new operators without changing this
definition

3 years agoadd function to insert list after another one
Alan T. DeKok [Sun, 14 Nov 2021 19:58:23 +0000 (14:58 -0500)] 
add function to insert list after another one

3 years agobetter error messages for inline attribute editing
Alan T. DeKok [Sun, 14 Nov 2021 13:58:40 +0000 (08:58 -0500)] 
better error messages for inline attribute editing

3 years agoadd fr_edit_list_free_children()
Alan T. DeKok [Sun, 14 Nov 2021 03:07:15 +0000 (22:07 -0500)] 
add fr_edit_list_free_children()

which will clear the children of a structural type

3 years ago"edit value then delete" gets moved to the tail of the edit list
Alan T. DeKok [Sat, 13 Nov 2021 18:38:19 +0000 (13:38 -0500)] 
"edit value then delete" gets moved to the tail of the edit list

3 years agoadd insert/delete tests
Alan T. DeKok [Sat, 13 Nov 2021 18:31:26 +0000 (13:31 -0500)] 
add insert/delete tests

3 years agoadd "edit value then delete" tests
Alan T. DeKok [Sat, 13 Nov 2021 18:19:28 +0000 (13:19 -0500)] 
add "edit value then delete" tests

3 years agore-init the deleted pairs list on abort
Alan T. DeKok [Sat, 13 Nov 2021 18:30:14 +0000 (13:30 -0500)] 
re-init the deleted pairs list on abort

because the pairs will be moved to their correct place by
edit_undo()

3 years agodon't re-insert edit structure on "value then delete"
Alan T. DeKok [Sat, 13 Nov 2021 18:13:02 +0000 (13:13 -0500)] 
don't re-insert edit structure on "value then delete"

3 years agoadd replace_value() and tweak API
Alan T. DeKok [Sat, 13 Nov 2021 17:53:53 +0000 (12:53 -0500)] 
add replace_value() and tweak API

3 years agoadd hint for edit list size
Alan T. DeKok [Sat, 13 Nov 2021 13:50:34 +0000 (08:50 -0500)] 
add hint for edit list size

so that all of the edits can (generally) live in a contiguous
region of memory, and then be freed all at once.

3 years agoif we free on abort, we might as well make commit into free
Alan T. DeKok [Sat, 13 Nov 2021 13:44:57 +0000 (08:44 -0500)] 
if we free on abort, we might as well make commit into free

3 years agono need to call talloc_free() after aborting the edits
Alan T. DeKok [Fri, 12 Nov 2021 21:50:32 +0000 (16:50 -0500)] 
no need to call talloc_free() after aborting the edits

3 years agoScheduled fuzzing: Merge and push pack the corpus (#4313)
Terry Burton [Fri, 12 Nov 2021 23:19:34 +0000 (23:19 +0000)] 
Scheduled fuzzing: Merge and push pack the corpus (#4313)

3 years agoremove dead store
Alan T. DeKok [Fri, 12 Nov 2021 21:43:47 +0000 (16:43 -0500)] 
remove dead store

3 years agowe can't edit values of structural pairs
Alan T. DeKok [Fri, 12 Nov 2021 21:32:06 +0000 (16:32 -0500)] 
we can't edit values of structural pairs

3 years agoinsert_after tests
Alan T. DeKok [Fri, 12 Nov 2021 21:21:56 +0000 (16:21 -0500)] 
insert_after tests

3 years agominor notes
Alan T. DeKok [Fri, 12 Nov 2021 21:21:45 +0000 (16:21 -0500)] 
minor notes

3 years agodon't free VP, pair_delete() does that
Alan T. DeKok [Fri, 12 Nov 2021 21:19:28 +0000 (16:19 -0500)] 
don't free VP, pair_delete() does that

3 years agorearrange / rename API, and add fr_edit_list_replace()
Alan T. DeKok [Fri, 12 Nov 2021 20:56:40 +0000 (15:56 -0500)] 
rearrange / rename API, and add fr_edit_list_replace()

3 years agoremove INSERT_BEFORE, and update API
Alan T. DeKok [Fri, 12 Nov 2021 16:34:23 +0000 (11:34 -0500)] 
remove INSERT_BEFORE, and update API

3 years agowe only need INSERT as insert after
Alan T. DeKok [Fri, 12 Nov 2021 16:26:58 +0000 (11:26 -0500)] 
we only need INSERT as insert after

3 years agotry to shut up clang scan
Alan T. DeKok [Fri, 12 Nov 2021 16:25:50 +0000 (11:25 -0500)] 
try to shut up clang scan

3 years agoadd edit lists and tests
Alan T. DeKok [Thu, 11 Nov 2021 22:13:05 +0000 (17:13 -0500)] 
add edit lists and tests

so that we can edit lists "in place", and then undo the edits
if anything goes wrong.

3 years agofunctions return fr_pair_t*, not void*
Alan T. DeKok [Thu, 11 Nov 2021 21:57:26 +0000 (16:57 -0500)] 
functions return fr_pair_t*, not void*

3 years agocheck correct variable, and allow "pos" to be NULL
Alan T. DeKok [Thu, 11 Nov 2021 21:52:25 +0000 (16:52 -0500)] 
check correct variable, and allow "pos" to be NULL

which lets us insert things at the start of the list.

3 years agoTidy up ephemeral module_ctx_t struct creation
Arran Cudbard-Bell [Fri, 12 Nov 2021 02:06:02 +0000 (20:06 -0600)] 
Tidy up ephemeral module_ctx_t struct creation

3 years agoCorrect fix for rlm_sql_cassandra
Arran Cudbard-Bell [Thu, 11 Nov 2021 22:23:09 +0000 (16:23 -0600)] 
Correct fix for rlm_sql_cassandra

3 years agoUnbound needs the inst name for xlats
Arran Cudbard-Bell [Thu, 11 Nov 2021 22:13:44 +0000 (16:13 -0600)] 
Unbound needs the inst name for xlats

3 years agoSync up module and instance data name
Arran Cudbard-Bell [Thu, 11 Nov 2021 22:12:02 +0000 (16:12 -0600)] 
Sync up module and instance data name

3 years agoFix arguments to cassandra
Arran Cudbard-Bell [Thu, 11 Nov 2021 22:10:26 +0000 (16:10 -0600)] 
Fix arguments to cassandra

3 years agoUse correct mctx fields in rlm_rest
Arran Cudbard-Bell [Thu, 11 Nov 2021 22:01:08 +0000 (16:01 -0600)] 
Use correct mctx fields in rlm_rest

3 years agoMark command_encode_dns_labels as nonnull
Arran Cudbard-Bell [Thu, 11 Nov 2021 21:05:18 +0000 (15:05 -0600)] 
Mark command_encode_dns_labels as nonnull

3 years agoUse structures to pass arguments to instantiation and detach functions
Arran Cudbard-Bell [Thu, 11 Nov 2021 21:00:46 +0000 (15:00 -0600)] 
Use structures to pass arguments to instantiation and detach functions

3 years agoKeep a pointer to the module instance in the thread instance
Arran Cudbard-Bell [Wed, 10 Nov 2021 21:36:06 +0000 (15:36 -0600)] 
Keep a pointer to the module instance in the thread instance

3 years agoRemove mctx->instance
Arran Cudbard-Bell [Wed, 10 Nov 2021 21:17:25 +0000 (15:17 -0600)] 
Remove mctx->instance

It's annoying having the same data twice.  There's also tons of places this data is cached

3 years agouse appropriate error functions
Alan T. DeKok [Wed, 10 Nov 2021 18:50:23 +0000 (13:50 -0500)] 
use appropriate error functions

which mean we don't need LOG_PREFIX here

3 years agoPass the private version of dl_inst down in the mctx
Arran Cudbard-Bell [Wed, 10 Nov 2021 17:41:26 +0000 (11:41 -0600)] 
Pass the private version of dl_inst down in the mctx

3 years agoMake TEST_CHECK_*() macros display stringified _got (#4310)
James Jones [Wed, 10 Nov 2021 01:44:18 +0000 (19:44 -0600)] 
Make TEST_CHECK_*() macros display stringified _got (#4310)

3 years agoConditionalize the definition of ALLOC_REQ() (#4309)
James Jones [Wed, 10 Nov 2021 00:12:01 +0000 (18:12 -0600)] 
Conditionalize the definition of ALLOC_REQ() (#4309)

3 years agoshut up compiler
Alan T. DeKok [Tue, 9 Nov 2021 23:46:28 +0000 (18:46 -0500)] 
shut up compiler

3 years agobe a bit more forgiving around registering xlats
Alan T. DeKok [Tue, 9 Nov 2021 20:35:55 +0000 (15:35 -0500)] 
be a bit more forgiving around registering xlats

for module instances like "foo { ... }" versus "foo bar { ... }".
if the xlat is already registered, don't do anything.  If it isn't
registered, then register it

3 years agono need to cache CONF_SECTION
Alan T. DeKok [Tue, 9 Nov 2021 20:18:00 +0000 (15:18 -0500)] 
no need to cache CONF_SECTION

3 years agono need to print the name
Alan T. DeKok [Tue, 9 Nov 2021 20:14:59 +0000 (15:14 -0500)] 
no need to print the name

the module isn't going away until after it's data has been freed.

3 years agoadd 'const' here, too
Alan T. DeKok [Tue, 9 Nov 2021 19:11:58 +0000 (14:11 -0500)] 
add 'const' here, too

3 years agoadd 'const'
Alan T. DeKok [Tue, 9 Nov 2021 19:11:00 +0000 (14:11 -0500)] 
add 'const'

3 years agoremove rlm_ldap_t from fr_ldap_thread_t
Alan T. DeKok [Tue, 9 Nov 2021 18:02:30 +0000 (13:02 -0500)] 
remove rlm_ldap_t from fr_ldap_thread_t

the only use of thread->inst uses thread->inst->config, which is
already cached in thread->config

3 years agoremove unnecessary pointer indirection, and make config 'const'
Alan T. DeKok [Tue, 9 Nov 2021 17:52:49 +0000 (12:52 -0500)] 
remove unnecessary pointer indirection, and make config 'const'

3 years agono need to call it mod_instantiate()
Alan T. DeKok [Tue, 9 Nov 2021 14:49:24 +0000 (09:49 -0500)] 
no need to call it mod_instantiate()

everything else uses instantiate()

3 years agoremove unused prototype
Alan T. DeKok [Tue, 9 Nov 2021 14:45:50 +0000 (09:45 -0500)] 
remove unused prototype

3 years agoRemove redundant comparisons (#4307)
James Jones [Tue, 9 Nov 2021 17:25:55 +0000 (11:25 -0600)] 
Remove redundant comparisons (#4307)

3 years agomake sure we catch 0 iterations in the $PBKDF2$... format, too
Matthew Newton [Tue, 9 Nov 2021 17:06:51 +0000 (17:06 +0000)] 
make sure we catch 0 iterations in the $PBKDF2$... format, too

3 years agoWorking trunk tests (#4306)
James Jones [Tue, 9 Nov 2021 14:32:50 +0000 (08:32 -0600)] 
Working trunk tests (#4306)

* Enable working trunk tests

All time function usage is updated to use the new API.

* Change to make test_connection_start_on_enqueue() work

The code added causes the event to handle the backlogged request
to run, the absence of which throws off all the following checks.

3 years agodon't bother using "rlm_" prefixes everywhere. They're not needed
Alan T. DeKok [Mon, 8 Nov 2021 19:56:30 +0000 (14:56 -0500)] 
don't bother using "rlm_" prefixes everywhere.  They're not needed

use "foo - bar" for names, as that's being used elsewhere, too

and the output looks cleaner.

3 years agouse inst->name where possible
Alan T. DeKok [Mon, 8 Nov 2021 19:51:36 +0000 (14:51 -0500)] 
use inst->name where possible

3 years agothese are just EAP things, and are common across all EAP modules
Alan T. DeKok [Mon, 8 Nov 2021 19:51:14 +0000 (14:51 -0500)] 
these are just EAP things, and are common across all EAP modules

3 years agoremove LOG_PREFIX_ARGS, and just use LOG_PREFIX everywhere
Alan T. DeKok [Mon, 8 Nov 2021 19:36:08 +0000 (14:36 -0500)] 
remove LOG_PREFIX_ARGS, and just use LOG_PREFIX everywhere

which simplifies things, in preparation for adding log IDs
everywhere, too.

3 years agouse inst->name instead of dl_module_instance_name_by_data()
Alan T. DeKok [Mon, 8 Nov 2021 16:58:40 +0000 (11:58 -0500)] 
use inst->name instead of dl_module_instance_name_by_data()

3 years agouse static name with log_prefix and ID
Alan T. DeKok [Mon, 8 Nov 2021 16:53:36 +0000 (11:53 -0500)] 
use static name with log_prefix and ID

instead of re-converting them every time

3 years agounify to inst->name, instead of inst->xlat_name
Alan T. DeKok [Mon, 8 Nov 2021 16:47:11 +0000 (11:47 -0500)] 
unify to inst->name, instead of inst->xlat_name

3 years agoshut up compiler
Alan T. DeKok [Sat, 6 Nov 2021 15:13:44 +0000 (11:13 -0400)] 
shut up compiler

3 years agoreturn on error
Alan T. DeKok [Sat, 6 Nov 2021 15:07:32 +0000 (11:07 -0400)] 
return on error

3 years agoRevert "Remove hot branch in rbtree find_node"
Arran Cudbard-Bell [Sat, 6 Nov 2021 15:04:03 +0000 (11:04 -0400)] 
Revert "Remove hot branch in rbtree find_node"

This reverts commit b19a7ac6737e7a0f0aefb20cd94d9441d0e0eb3c.

3 years agoRemove hot branch in rbtree find_node
Arran Cudbard-Bell [Sat, 6 Nov 2021 14:46:43 +0000 (10:46 -0400)] 
Remove hot branch in rbtree find_node

3 years agoSuppress lgtm weak crypto warning
Arran Cudbard-Bell [Sat, 6 Nov 2021 14:46:10 +0000 (10:46 -0400)] 
Suppress lgtm weak crypto warning

3 years agoInclude dhcpv6 state machine options to control status-code contents
Arran Cudbard-Bell [Fri, 5 Nov 2021 23:37:23 +0000 (19:37 -0400)] 
Include dhcpv6 state machine options to control status-code contents

3 years agoAdd idx versions of pair_find functions
Arran Cudbard-Bell [Fri, 5 Nov 2021 17:20:56 +0000 (13:20 -0400)] 
Add idx versions of pair_find functions

3 years agoUpdate test now we don't send status by default
Arran Cudbard-Bell [Fri, 5 Nov 2021 16:11:26 +0000 (12:11 -0400)] 
Update test now we don't send status by default

3 years agoInformation requests are not directed
Arran Cudbard-Bell [Fri, 5 Nov 2021 15:58:01 +0000 (11:58 -0400)] 
Information requests are not directed

3 years agoDon't add status on success
Arran Cudbard-Bell [Fri, 5 Nov 2021 15:29:14 +0000 (11:29 -0400)] 
Don't add status on success

3 years agocache align TCP packets, too
Alan T. DeKok [Fri, 5 Nov 2021 15:00:45 +0000 (11:00 -0400)] 
cache align TCP packets, too

3 years agoremove unused functions
Alan T. DeKok [Fri, 5 Nov 2021 14:11:59 +0000 (10:11 -0400)] 
remove unused functions

3 years agocache align UDP messages
Alan T. DeKok [Fri, 5 Nov 2021 13:56:47 +0000 (09:56 -0400)] 
cache align UDP messages

not TCP message for now, as that requires memmove() on the
"leftover" bytes, which requires more expensive logic

3 years agoCPU cache line sizes are generally 64 bytes
Alan T. DeKok [Thu, 4 Nov 2021 21:37:14 +0000 (17:37 -0400)] 
CPU cache line sizes are generally 64 bytes

3 years agoRevert "Pass dict root not dicts..."
Arran Cudbard-Bell [Fri, 5 Nov 2021 14:02:11 +0000 (10:02 -0400)] 
Revert "Pass dict root not dicts..."

This reverts commit 1503b48d7dfd64c303f7db9b9872f16f54bb7fdb.

3 years agoPass dict root not dicts...
Arran Cudbard-Bell [Fri, 5 Nov 2021 13:49:37 +0000 (09:49 -0400)] 
Pass dict root not dicts...

3 years agoPass in protocol specific dictionaries to the packet debug functions
Arran Cudbard-Bell [Fri, 5 Nov 2021 02:08:32 +0000 (22:08 -0400)] 
Pass in protocol specific dictionaries to the packet debug functions

3 years agoInvert args
Arran Cudbard-Bell [Thu, 4 Nov 2021 20:18:50 +0000 (16:18 -0400)] 
Invert args

3 years agospecial free function
Arran Cudbard-Bell [Thu, 4 Nov 2021 20:09:41 +0000 (16:09 -0400)] 
special free function

3 years agoWe apparently don't cache this anymore
Arran Cudbard-Bell [Thu, 4 Nov 2021 20:01:31 +0000 (16:01 -0400)] 
We apparently don't cache this anymore

3 years agosingular not plaural
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:27:17 +0000 (15:27 -0400)] 
singular not plaural

3 years agoInclude our talloc header here
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:16:02 +0000 (15:16 -0400)] 
Include our talloc header here

3 years agoTypo
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:14:10 +0000 (15:14 -0400)] 
Typo

3 years agoAruba dict updates closes #4297
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:13:22 +0000 (15:13 -0400)] 
Aruba dict updates closes #4297

3 years ago...one more
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:09:51 +0000 (15:09 -0400)] 
...one more

3 years ago...and another
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:09:30 +0000 (15:09 -0400)] 
...and another

3 years agoShould be signed
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:08:14 +0000 (15:08 -0400)] 
Should be signed

3 years agoMove talloc header
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:07:14 +0000 (15:07 -0400)] 
Move talloc header

3 years agoCopy interface id back if it was included
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:06:24 +0000 (15:06 -0400)] 
Copy interface id back if it was included

3 years agoFix various dumb issues
Arran Cudbard-Bell [Thu, 4 Nov 2021 18:59:53 +0000 (14:59 -0400)] 
Fix various dumb issues

3 years agoFix typos
Arran Cudbard-Bell [Thu, 4 Nov 2021 18:55:28 +0000 (14:55 -0400)] 
Fix typos

3 years agowe don't need a second name here
Alan T. DeKok [Thu, 4 Nov 2021 18:49:40 +0000 (14:49 -0400)] 
we don't need a second name here

3 years agoallow running individual module tests
Alan T. DeKok [Thu, 4 Nov 2021 18:47:14 +0000 (14:47 -0400)] 
allow running individual module tests

3 years agoNeed talloc
Arran Cudbard-Bell [Thu, 4 Nov 2021 18:50:38 +0000 (14:50 -0400)] 
Need talloc

3 years agoDump capabilities to INFO() at various phases in the process lifecycle
Arran Cudbard-Bell [Thu, 4 Nov 2021 18:31:21 +0000 (14:31 -0400)] 
Dump capabilities to INFO() at various phases in the process lifecycle

3 years agoadd const
Alan T. DeKok [Thu, 4 Nov 2021 17:46:41 +0000 (13:46 -0400)] 
add const

3 years agomove mschap specific rules to top-level, and make top-level more generic
Alan T. DeKok [Thu, 4 Nov 2021 15:05:00 +0000 (11:05 -0400)] 
move mschap specific rules to top-level, and make top-level more generic

and don't bother re-running 'configure'.  It doesn't work
half of the time.

3 years agolet's put files into ${localstatedir}, and not /tmp
Alan T. DeKok [Wed, 3 Nov 2021 22:32:58 +0000 (18:32 -0400)] 
let's put files into ${localstatedir}, and not /tmp

3 years agomove db_dir, as nothing uses it
Alan T. DeKok [Thu, 4 Nov 2021 12:07:25 +0000 (08:07 -0400)] 
move db_dir, as nothing uses it

3 years agofix xlats for virtual modules
Alan T. DeKok [Wed, 3 Nov 2021 21:32:51 +0000 (17:32 -0400)] 
fix xlats for virtual modules

don't even bother for "group".

Register the xlats in the "bootstrap" stage, by walking over the
virtual modules.

switch xlat_redundant() etc. to use the new XLAT API.