Balbir Singh [Fri, 22 Aug 2008 16:44:17 +0000 (16:44 +0000)]
This patch adds cgroup_create_cgroup_from_parent() API. I've tested it
with a modified version of libcg_ba (basic acceptance tests), that I'll send
out later. I've also fixed a couple of bugs, I'll list them in order and
if desired, I'll split out the patches so that the enhancements can be
separate from the bug fixes
1. Fix cg_create_control_group() to succeed if the directory already exists
2. We can't always append a control_file, we need to open it "r+"
3. It's OK for writing values to a control_file to fail, since some of
them are read-only and some may not exist in hierarchies below the root
4. Skip over directories while trying to read control file's name value pairs
5. In cg_rd_ctlr_file we don't allocate any memory to value, directly fscanf
into it, that's been fixed
6. There might be more fixes that might already be present in trunk, since
I hope I've not redone a lot of the fixes, I had branched of trunk very
recently
Changelog v2
------------
1. Refactor cgroup_free_controllers() and use it in
cgroup_create_cgroup_from_parent()
2. Check for strdup failure
3. Check if dst == src
TODO:
1. Use cg_add_controller() API
2. Use cg_add_value_string() API
I'll send out patches for the TODOs later.
I've also updated the basic acceptance test (libcg_ba.cpp)
Dhaval Giani [Thu, 14 Aug 2008 15:05:48 +0000 (15:05 +0000)]
Fix configuration assert when multiple controllers are enabled
Since we support multiple controllers, asserting is no longer a good
idea.
TODO: Support other controllers, memory, cpu and cpuacct (possibly
cpusets as well). Well, this code is obsolete and will be replaced
by the newer cgroup API.
Dhaval Giani [Thu, 14 Aug 2008 11:10:23 +0000 (11:10 +0000)]
libcgroup: Fix the delete API
The delete call was returning a wrong value even on success.
The reason was because in the fallback path, we try to delete
all the groups again. Now it is possible that a group might
have already been deleted and we return a wrong value.
Change the API to check if the group exists before trying to rmdir
it in the error path.
Dhaval Giani [Wed, 13 Aug 2008 20:04:51 +0000 (20:04 +0000)]
cgclassify: A command line tool to classify/re-classify already running task
From: Vivek Goyal <vgoyal@redhat.com>
o cgclassify, a command line tool to put a list of pids to the right cgroup
based on rules in /etc/cgrules.conf. It can be mainly used for
reclassification of tasks which are already running. Can think of two
use cases.
- During initial bootup, after cgroups are mounted, one needs to
move tasks (started beofore cgroups were mounted) into right
cgroup.
- Once can choose to reclassify the tasks if admin has changed the
rules and thinks a group of tasks should reclassified based on
new rules.
Dhaval Giani [Wed, 13 Aug 2008 20:01:16 +0000 (20:01 +0000)]
cgexec: A command line tool to execute a task in a cgroup
From: Vivek Goyal <vgoyal@redhat.com>
o cgexec, a command line tool for placing the task in right cgroup
in advance so that no help is needed from rules daemon and user can
avoid delay in execution of rules.
Dhaval Giani [Wed, 13 Aug 2008 19:58:05 +0000 (19:58 +0000)]
libcgroup: New API interfaces for task placement
From: Vivek Goyal <vgoyal@redhat.com>
Enhancement to libcg to do following.
- Parse the /etc/cgrules.conf file and place the task in the right cgroup.
- Exported two APIs which can place the task based on /etc/cgrules.conf
or based on cgroup explicitly specified by the caller.
- There can be multiple users.
- PAM module (pam_cgroup)
- cgexec tool
- cgclassify tool
- APIs can be directly used by other cgroup aware user progarams.
- Classification daemon
Dhaval Giani [Wed, 13 Aug 2008 13:33:59 +0000 (13:33 +0000)]
libcgroup: check for return code of fprintf()
From: Vivek Goyal <vgoyal@redhat.com>
o Adding a task to a particular cgroup currently does fprintf() and never
check the return code. Modify it to check for the return code in case
fprintf() and fflush() did not succeed.
o I ran into the issues when i can't add migration thread to
/container/admingroup/tasks and it will fail silently.
Dhaval Giani [Tue, 12 Aug 2008 08:21:08 +0000 (08:21 +0000)]
libcgroup: Extend cgroup_get_cgroup for uids as well.
Now that a new API is available which allows a cgroup structure to
be generated with just a name, extend cgroup_get_cgroup to get the
uids and gids from the fs itself.
Dhaval Giani [Tue, 12 Aug 2008 08:19:24 +0000 (08:19 +0000)]
libcgroup: Add cgroup_?et_value_* APIs
Adding in APIs which allow you to set and get values from a cgroup
controller. Use cgroup_get_controller to get a controller, and then
use cgroup_?et_value_* API for your requirement.
Dhaval Giani [Sat, 9 Aug 2008 09:27:30 +0000 (09:27 +0000)]
libcgroup: Fix the wrapper warnings
Fixes the following warnings
wrapper.c: In function ‘cgroup_add_value_int64’:
wrapper.c:152: warning: format ‘%lld’ expects type ‘long long int’, but argument 4 has type ‘int64_t’
wrapper.c:152: warning: format ‘%lld’ expects type ‘long long int’, but argument 4 has type ‘int64_t’
wrapper.c: In function ‘cgroup_add_value_uint64’:
wrapper.c:186: warning: format ‘%llu’ expects type ‘long long unsigned int’, but argument 4 has type ‘u_int64_t’
wrapper.c:186: warning: format ‘%llu’ expects type ‘long long unsigned int’, but argument 4 has type ‘u_int64_t’
Dhaval Giani [Sat, 9 Aug 2008 09:25:22 +0000 (09:25 +0000)]
libcgroup: Fix index values in cgroup_add_value_*
There is a horrible bug in wrapper.c. The loop was causing a segmentation
fault. This is because we were checking for index value as opposed to
i.
This bug was not hit before, because in all our testing, we were
trying out only with CONFIG_FAIR_GROUP_SCHED and we were setting only one
value inside the memory subsystem.
Dhaval Giani [Sat, 9 Aug 2008 09:23:56 +0000 (09:23 +0000)]
libcgroup: Fix segmentation fault in cgroup_init() -take2
An artifact from the time when libcgroup could not handle multiple
cgroup filesystems mounted at multiple points. It is very much possible
a subsystem is not mounted at that point. (FWIW, it is wrong even on a
single mount point, but I am quite surprised that no one hit it yet.)
Dhaval Giani [Wed, 6 Aug 2008 17:47:41 +0000 (17:47 +0000)]
libcgroup: Add new API to get cgroup data structure from filesystem
New API to get the cgroup datastructure from the mounted filesystem.
It accepts the cgroup datastructure with the name of the cgroup
which has to populated across various mountpoints.
TODO:
More testing.
Signed-off-by: Dhaval Giani <dhaval@linux.vnet.ibm.com> Cc: Dan Smith <danms@us.ibm.com> Cc: Paul Menage <menage@google.com>
git-svn-id: https://libcg.svn.sourceforge.net/svnroot/libcg/trunk@117 4f4bb910-9a46-0410-90c8-c897d4f1cd53
libcgroup: Fix test cases to use CPU controller if available
The test cases used the memory controller. This is not a good idea
since most distro kernels don't enable it by default. For the moment
I'm setting it to use CPU if memory is not found, but in the longer
term I am planning to set it to use CPU first and then memory.
libcgroup: adds sanity check in libcgroup testcases binary
This patch adds a sanity check on cgroup file system info in testcases.
If cgroup filesystem is not mounted and script sends the info as mounted,
then the binar would have failed. This patch handles that.
This patch adds testcases for libcgroup API cgroup_modify_cgroup() testing. The API
is called with filesystem mounted (FS_MOUNTED=1) and return values are checked.
The API is first called with the same cgroup(the one which is existing in the
file system, and with all the same parameters). The second time it is called
with a null cgroup. Third time it is called with a new cgroup having different
controller.
The filesystem is checked if the values have been modified.
This patch puts the common code for creating cgroup structure into
a function struct cgroup *new_cgroup(). The function uses few global
variables which are changed before the function call and takes few
variables as arguments.
libcgroup: testcases for wrapper api and cgroup_modify_cgroup()
This patch creates a valid cgroup structure to be passed as the parameter
for cgroup_modify_cgroup() function and calls this function. The return
values are checked and on that basis the test is declared as pass or fail.
The patch adds the code that check if the parameter changed reflect in
the filesystem.
libcgroup: further testcases for create_cgroup() and delete_cgroup()
This patch adds testcases for libcgroup API cgroup_create_cgroup() and
cgroup_delete_cgroup() testing. The APIs are called under the same but two
conditions(FS_MOUNTED=0/1) and return values are checked. The test checks if
these APIs can handle a null cgroup and hence passes a nulll cgroup as
parameter.
libcgroup: libcgroup testcases for cgroup_attach_task()
This patch adds testcases for libcgroup API cgroup_create_cgroup() and
cgroup_delete_cgroup() testing. The APIs are called under the same but two
conditions(FS_MOUNTED=0/1) and return values are checked. The cgroup is
created and freed using the wrapper APIs.
libcgroup: libcgroup testcases for cgroup_attach_task()
This patch adds 3 testcases for libcgroup API cgroup_attach_task() testing. The API
is called under the same but two conditions(FS_MOUNTED=0/1) and return
values are checked. For FS_MOUNTED=1 the API is first called without
intializing ie without calling cgroup_init(), and then after cg_init(). Each time
the null cgroup is passed. The task is checked if it exists under the root
group's tasks file.
The 4th testcase calls cgroup_attach_task_pid() with an invalid pid.
This patch adds total 3 testcases for libcgroup API cgroup_init() testing.The
API is called under the same three conditions(FS_MOUNTED=0/1/2) and return
values are checked. Testcases for FS_MOUNTED=2 have to be updated and added.
This Patch creates the basic infrastructure for libcgroup testcases. This
patch adds a script which runs the binary(C) file. The script does all the
environment setup to run the tests and passes this info to the C file through
command line arguments. The binary runs the test cases calling the API's
in different environment conditions. The Makefile compiles the test. The top
level Makefile.in is edited to support
make test
make testclean
The script runs this binary total 3 times, each time with diff varaible.
FS_MOUNTED=0 # cgroup fs not mounted
FS_MOUNTED=1 # cgroup fs mounted
FS_MOUNTED=2 # cgroup fs mounted at multiple points
This Patch creates the basic infrastructure for libcgroup testcases. This
patch adds a script which runs the binary(C) file. The script does all the
environment setup to run the tests and passes this info to the C file through
command line arguments. The binary runs the test cases calling the API's
in different environment conditions. The Makefile compiles the test. The top
level Makefile.in is edited to support
make test
make testclean
The script runs this binary total 3 times, each time with diff varaible.
FS_MOUNTED=0 # cgroup fs not mounted
FS_MOUNTED=1 # cgroup fs mounted
FS_MOUNTED=2 # cgroup fs mounted at multiple points
Dhaval Giani [Wed, 11 Jun 2008 08:20:54 +0000 (08:20 +0000)]
libcgroup: Fix segmentation fault in APIs.
Dan Smith reported some segmentation faults. It turns out that we did
not NULL terminate all the structures when we had moved to the wrapper
based approach. With this in mind, the loop checks the index instead
of a NULL structure.
Balbir Singh [Sat, 17 May 2008 16:06:20 +0000 (16:06 +0000)]
Multiple mount point support. Patches built on top of Dhaval'a patches.
Works for me on my testing. NOTE: The testing is insufficient as we
only test cg_control_create_cgroup() and not delete_cgroup() or
attach_task(). Sudhir's new test cases should really help
Several coding style fixes and changes, enhancements to make the code
work.
NOTE: Since this is development release -DDEBUG is back in the makefile.
Once this is committed, I'll bump up the version to 0.05 if no one objects.
Test report
-----------
debug log from the library
matched cpuacct:cpuacct
Found cgroup option rw,relatime,cpuacct, count 0
matched cpu:cpu
Found cgroup option rw,relatime,cpu, count 1
tuid 0, tgid 0, cuid 1000, cgid 1000
path is /tmp/container_cpu/database/
path is /tmp/container_cpuacct/database/
NOTE: The database directory was created as expected on both mount points
/tmp/container_cpu and /tmp/container_cpuacct
projects / thirdparty / libcgroup.git / log
