jake%acutex.net [Fri, 5 Oct 2001 22:18:12 +0000 (22:18 +0000)]
Fix for bug 83474 - The tables were not being unlocked properly when rebuilding the keyword cache if there were no keywords to rebuild.
Patch by Lukasz Engel <Lukasz.Engel@softax.pl>
r= matty@chariot.net.au
Fix for bug 82809: comments in bugs no longer have 
 where the linefeeds should be.
Patch by Dave Miller <justdave@syndicomm.com>
r= timeless@mac.com (no 2nd review needed)
Fix for bug 98744: No more software error when the user clicks "remove cc" without specifying users to remove.
Fix by Jake <jake@acutex.net>.
r=myk@mozilla.org, no second review needed.
Fix for bug 73959: Make buglist.cgi display the "Show Votes" link at the bottom of the screen.
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org, no second review needed.
Fix for bug #53612: The milestone URL appears correctly when deleting a product or a component.
Patch by Jake <jake@acutex.net>.
r=gerv@mozilla.org,myk@mozilla.org
Partil fix for bug 102032: Fix tinderbox test errors and warnings. This patch adds some -w and use strict; work to clean up
most of the '002goodperl.t' errors.
r=Dave Miller <justdave@syndicomm.com> no 2nd review required.
Fix for bug 101659: emailsuffix was missing from the component owner mailto tag on sites that use emailsuffix.
Patch by Steve Naldrett <snaldrett@transparentnetworks.com>
r= justdave@syndicomm.com x2
Fix for bug 97588: localconfig should mention access.conf as well as
httpd.conf (for old apache). Simple 2line comment addition to localconfig
to inform the user they may need to look at access.conf in addition to
httpd.conf if they are using an older version of apache.
Patch by Gavin Shelley <gavins@iplbath.com> r=Zach Lipton
<zach@zachlipton.com> no 2nd review needed for this patch.
Fix for bug 97971 - Sanity check should check statuses, resolutions, everconfirmed & number of votes.
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net
Fix for bug 90333: Bugzilla now displays an appropriate error message if a user hits process_bug.cgi without specifying any bugs to change.
Patch by Myk Melez <myk@mozilla.org>
r=jake@acutex.net
Fix to make the tests generate the list of files to test instead of having to update the list manually whenever a file is added
or removed. The main logic is in t/Support/Files.pm, changes to the test files are needed to allow it to function properly.
NOT_PART_OF_BUILD. No review needed for tests at this time.
Fix for bug 97657 - in defparams.pl, the sillyness sub should be called defparams_pl_sillyness
Patch by David D. Kilzer <ddkilzer@theracingworld.com>
r= jake@acutex.net
Fix for bug 71664 - Don't complain about a bad keyword cache for a bug that doesn't exist.
Patch by Matthew Tuck <matty@chariot.net.au>
r= afranke@ags.uni-sb.de, jake@acutex.net
Fix for bug 98468: sample email regexp for username-only address changed from ^[^@]*$ to ^[^@]+$ and the default emailregexp changed from ^[^@]*@[^@]*\\.[^@]*$ to ^[^@]+@[^@]+\\.[^@]+$
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net x2
refix for bug 91808: previous patch for this bug used an INNER JOIN construct in the SQL, which is not supported by the
minimum version of MySQL that we require.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x2
Fix for bug 30597 - Hyperlinking the number of votes was causing some confusion because it was such a small link, yet the most useful. Instead, we now have a link labeled "Show votes for this bug".
Patch by Matthew Tuck <matty@chariot.net.au>
r= louie@ximian.com, jake@acutex.net
Fix for bug 42337: Adding the usual red box for errors uploading attachments.
Patch by Matthew Tuck <matty@chariot.net.au>
r= louie@ximian.com, justdave@syndicomm.com
Fix for bug 69616: If you have tweakparams privs, the "Sanity check" link was listed with a group of items that said "Edit" so
it appeared as if you were going to edit the sanity checks if you clicked on it, when in fact you were going to run them.
This patch rewords the links so Sanity check is in a group by itself in the block of links on the right.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x2
Addition of Files.pm which will be used shortly by 1.t (soon to be 1compile.t) which contains the list of files to test. This is important so that we can bring it into other tests which check files for content, etc...
No review required for tests as of now as per Dave.
Fix for bug 91808: Additional sanitycheck tests for the duplicates table.
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net, caillon@returnzero.com
Added a --verbose option to runtests.sh that the tinderbox scripts can use to get all the warnings and errors and whatnot into the build log. Also corrected several syntax and logic errors in the 1.t test file.
Fix for bug 42810 - Bugzilla would choke if your product name contained a ' mark.
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com, caillon@returnzero.com
Fix for bug 96603: Grammatical error in bug_status.html. Simple one word fix.
Patch by Christopher Aillon (caillon@returnzero.com). r1=Christian Reis (kiko@async.com.br),
r2=Zach Lipton (zach@zachlipton.com) though not really needed for this patch.
Fix for bug 97764: Fixes errant sending of mail on attachment changes to users who do not want to receive mail about their own changes.
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org; no second review needed.
Fix for bug 97721: Bugzilla now requires Perl 5.005 (previous requirement was Perl 5.004). This is due to the use of Template Toolkit for templatizing the pages for easier local customization. The new attachment tracker that was checked in earlier tonight uses the templates. Also included on this patch is a check for AppConfig, which is a prerequisite for Template Toolkit, because the Makefile.PL for Template Toolkit won't run without it, and it doesn't tell CPAN that it has prereqs, which causes confusion if you're installing from CPAN.
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org
Fix for bug 75840: syncshadowdb -syncall now properly shuts down Bugzilla during the sync process so mysql doesn't get overloaded while the tables are locked. This patch also adds some funtionality to the script to allow you to specify an alternate temp directory on the command line, in case you have a large database and need it made to a different filesystem for space reasons.
Patch by Dawn Endico <endico@mozilla.org> and Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
myk%mozilla.org [Fri, 31 Aug 2001 11:19:32 +0000 (11:19 +0000)]
Fix for bug 84338: initial implementation of attachment tracker, which lets users flag attachments with statuses.
Patch by Myk Melez <myk@mozilla.org>
r=justdave@syndicomm.com
myk%mozilla.org [Fri, 31 Aug 2001 10:54:25 +0000 (10:54 +0000)]
Fix for bug 84338: initial implementation of attachment tracker, which lets users flag attachments with statuses.
Patch by Myk Melez <myk@mozilla.org>
r=justdave@syndicomm.com
Fix for bug 96534: The version, component, and milestone select lists on the query page were slow to reflow when you changed the product in the first select list. This patch is a complete rewrite from scratch of the javascript used on query.cgi, which results in an approximately 700% speed increase in the reflow time when changing the selected product.
Patch by Chris Lahey <clahey@ximian.com> and Christian Reis <kiko@async.com.br>
Javascript changes r= caillon@returnzero.com, louie@ximian.com
Perl changes r= jake@acutex.net, justdave@syndicomm.com
jake%acutex.net [Thu, 30 Aug 2001 10:14:24 +0000 (10:14 +0000)]
Fix for bug 28736 - Bugmail will now show the summary for the bug that changed in the "This bug depends on bug X, which changed state" messages.
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net
Buncha' release updates. Moved all images to
./images so we don't have multiple copies of the
same image, fixed these doc bugs (in no particular order):
94949
97070
97071
97114
96498
95970
96677
94953
96501
96679
97068
97191
97192
Re-fix for bug 87769: the original patch checked in for this prevented any votes from being changed at all. This corrects that so votes can be changed again while still trapping the error the original patch was designed to catch.
Patch by Christoper Aillon <caillon@returnzero.com>
r= justdave@syndicomm.com
Fix for bug 92266: Prevent dataloss in the bugs_activity table by wrapping
entries into additional entries if they're too long to fit.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
Fix for bug 95235: variables with untrusted content were being echoed back to the user in error messages. Those variables are now run through html_quote() first.
Patch by Gavin Shelley <gavins@iplbath.com>
r= justdave@syndicomm.com
myk%mozilla.org [Tue, 21 Aug 2001 03:36:10 +0000 (03:36 +0000)]
Fix for bug 96085: don't allow unauthorized users to access restricted bugs that do not have a QA contact.
Patch by Myk Melez <myk@mozilla.org>
r=Jake <jake@acutex.net>
myk%mozilla.org [Mon, 20 Aug 2001 01:26:21 +0000 (01:26 +0000)]
Fix for bug 95890: Correctly convert/record keyword changes in the bugs_activity table for keywords containing a plus sign or other
regular expression meta-characters. Myk's first ever Bugzilla checkin!
Patch by Dave Miller <justdave@syndicomm.com> and Myk Melez <myk@mozilla.org>.
r=myk@mozilla.org,justdave@syndicomm.com
jake%acutex.net [Sat, 18 Aug 2001 10:35:36 +0000 (10:35 +0000)]
Refixing bug 95875 - The code that breakes the typed in CC list into individual lists is now slightly more robust and allows perl to handle the splitting more efficiently (by using a space as the delimiter).
r= myk@mozilla.org
Fix for bug 95857: process_bugs.cgi sees blank address in cc: line (would show up as __UNKNOWN__)
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
jake%acutex.net [Sat, 18 Aug 2001 03:18:33 +0000 (03:18 +0000)]
Fix for bug 95747 - CC List validation (for additions) wasn't happening until after the bug's changes were in the process of being commited. This caused problems if a typo was made in the e-mail address.
r= myk@mozilla.org
jake%acutex.net [Fri, 17 Aug 2001 19:42:34 +0000 (19:42 +0000)]
Fix for bug 95731: "INSERT INTO shadowlog" failed because "Table 'shadowlog' not locked", fixed typo in lock tables command.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
Fix for bug 95743: the role-accessible checkboxes were getting cleared if a user with group access had to log in to make changes to a public bug.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
Fix for bug 95731: "INSERT INTO shadowlog" failed because "Table 'shadowlog' not locked", fixed typo in lock tables command.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
Fix for bug 95535: the token generator for password resets is allowing the & character to be used for tokens, but wasn't escaping them for the URL it emailed to users to use to get in to reset their password.
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org
Fix for bug 87779: thanks to the new password reset code, there was no clear way to create a new Bugzilla account from the login screen. There is now a link to createaccount.cgi from the login screen, and the text around the password reset button has been edited so it doesn't sound like you can get a new account by using it (because you can't)
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org
Fix for bug 92593: Changing a bugs product will no longer remove the votes from that bug unless the number of votes for a given user is beyond what is allowed per-bug on the new product. Only the per-bug vote count is checked. If the user is beyond the per-product vote limit for the new product, it is left alone, on the theory that it's better to preserve the votes on the bug. The user will be forced to reduce their votes to fit the product limit the next time they try to vote on something.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
Re-fix for bug 95082: allow syncshadowdb to continue to make queries while Bugzilla is shut down.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com