]>
git.ipfire.org Git - thirdparty/freeradius-server.git/log
Arran Cudbard-Bell [Wed, 5 Apr 2023 01:20:53 +0000 (19:20 -0600)]
exec: Create two distinct interfaces for the exec code
- Low level interface is used for spawning global processes used in pool.
- High level interface is for oneshot requests use for backticks and rlm_exec.
Arran Cudbard-Bell [Wed, 5 Apr 2023 01:16:36 +0000 (19:16 -0600)]
event-waitid: When waitid returns 0, info isn't initialised so we can't check it
Arran Cudbard-Bell [Wed, 5 Apr 2023 00:12:42 +0000 (18:12 -0600)]
Ignore doxygen src
Alan T. DeKok [Tue, 4 Apr 2023 19:15:49 +0000 (15:15 -0400)]
The RADIUS module can only use RADIUS attributes for status-server
Alan T. DeKok [Tue, 4 Apr 2023 19:08:30 +0000 (15:08 -0400)]
update for WITH_SASL build
Nick Porter [Tue, 4 Apr 2023 17:20:00 +0000 (18:20 +0100)]
Remove unused connection pool
Nick Porter [Tue, 4 Apr 2023 16:16:02 +0000 (17:16 +0100)]
Use correct debug level
Alan T. DeKok [Mon, 3 Apr 2023 20:53:07 +0000 (16:53 -0400)]
rename to "PROTO.encode"
as most everything else is hiearchical based on protocol name
Nick Porter [Fri, 31 Mar 2023 17:17:46 +0000 (18:17 +0100)]
No need for non-async LDAP modify now
Nick Porter [Fri, 31 Mar 2023 12:13:10 +0000 (13:13 +0100)]
Rework LDAP user_modify to use async queries
Nick Porter [Tue, 28 Mar 2023 13:51:27 +0000 (14:51 +0100)]
Rework mod_authorize_resume to use state, group and profile async lookups
Nick Porter [Thu, 30 Mar 2023 18:41:19 +0000 (19:41 +0100)]
Rework LDAP profile lookup to use async queries
Nick Porter [Tue, 28 Mar 2023 13:40:56 +0000 (14:40 +0100)]
Rework rlm_ldap_cacheable_groupobj() to use async queries
Nick Porter [Tue, 28 Mar 2023 13:33:56 +0000 (14:33 +0100)]
Rework rlm_ldap_cacheable_userobj() to use async lookups
Nick Porter [Tue, 28 Mar 2023 13:16:38 +0000 (14:16 +0100)]
Create async functions to convert group DNs to names
The sync version is still needed for LDAP-Group pair cmp magic at
present.
Nick Porter [Tue, 28 Mar 2023 13:06:15 +0000 (14:06 +0100)]
Re-work group name to DN lookup to be async
Nick Porter [Tue, 28 Mar 2023 13:06:43 +0000 (14:06 +0100)]
Add context for resolving group membership from user object
Nick Porter [Tue, 28 Mar 2023 11:31:59 +0000 (12:31 +0100)]
Set a valid LOG_PREFIX
Nick Porter [Wed, 22 Mar 2023 19:41:01 +0000 (19:41 +0000)]
Remove tmpl expansions now done by module environment
Nick Porter [Tue, 28 Mar 2023 13:52:17 +0000 (14:52 +0100)]
Use module environment in rlm_ldap_map_profile
Nick Porter [Wed, 22 Mar 2023 19:39:55 +0000 (19:39 +0000)]
Make SASL binds work again for user auth
Nick Porter [Wed, 22 Mar 2023 19:37:03 +0000 (19:37 +0000)]
Add fr_ldap_sasl_bind_auth_async and supporting functions
Nick Porter [Wed, 22 Mar 2023 14:52:19 +0000 (14:52 +0000)]
Allow for SASL bind ctx in LDAP auth bind ctx
Nick Porter [Tue, 28 Mar 2023 11:19:04 +0000 (12:19 +0100)]
Add state to LDAP authorization ctx
To track progress through multiple async LDAP queries
Nick Porter [Wed, 21 Sep 2022 09:36:00 +0000 (10:36 +0100)]
Use async lookup of user DN in rlm_ldap mod_authorize
Nick Porter [Tue, 20 Sep 2022 16:47:20 +0000 (17:47 +0100)]
Use async user DN lookup in LDAP authentication
Nick Porter [Wed, 22 Mar 2023 18:54:25 +0000 (18:54 +0000)]
Module environment for rlm_ldap
Nick Porter [Wed, 15 Mar 2023 14:54:15 +0000 (14:54 +0000)]
Add macro for module env subsections
Nick Porter [Tue, 20 Sep 2022 16:38:23 +0000 (17:38 +0100)]
Move include - function.h will be needed by most LDAP source
Nick Porter [Tue, 20 Sep 2022 16:37:21 +0000 (17:37 +0100)]
Add rlm_ldap_find_user_async() and supporting functions
Nick Porter [Tue, 20 Sep 2022 16:35:43 +0000 (17:35 +0100)]
Add rlm_find_user_dn_cached()
Nick Porter [Wed, 29 Mar 2023 18:19:33 +0000 (19:19 +0100)]
Correct return of fr_ldap_trunk_search and fr_ldap_trunk_modify
It is the child function which yields (until everything becomes async at
which point this will get simplified)
Arran Cudbard-Bell [Tue, 4 Apr 2023 00:34:36 +0000 (18:34 -0600)]
slab: Style guide says alloc functions should return the newly allocated structure unless they have complex failure conditions which slabs don't
https://wiki.freeradius.org/contributing/coding-standards#return-types_pointer
Arran Cudbard-Bell [Mon, 3 Apr 2023 23:31:35 +0000 (17:31 -0600)]
jlibtool: Fix minor warnings
Arran Cudbard-Bell [Mon, 3 Apr 2023 23:09:00 +0000 (17:09 -0600)]
clangd: Ignore osmocom code in submodules
Arran Cudbard-Bell [Mon, 3 Apr 2023 22:40:09 +0000 (16:40 -0600)]
slab: Remove implicit fr_ prefix
Yes, the framework for creating slabs is in the util library, but the functions and types it produces may not be so should not have an implicit fr_ prefix.
Arran Cudbard-Bell [Mon, 3 Apr 2023 22:19:55 +0000 (16:19 -0600)]
cf_util: Add cf_log_perr_by_child
Arran Cudbard-Bell [Mon, 3 Apr 2023 22:19:23 +0000 (16:19 -0600)]
cf_util: Pass in copy of va_list not original va_list
Arran Cudbard-Bell [Mon, 3 Apr 2023 02:18:08 +0000 (20:18 -0600)]
rlm_exec: Various cleanups
Arran Cudbard-Bell [Mon, 3 Apr 2023 02:11:43 +0000 (20:11 -0600)]
Add CONF_PARSER snippet for slabs
Arran Cudbard-Bell [Mon, 3 Apr 2023 00:07:50 +0000 (18:07 -0600)]
Simplify and document conf parser macros
Alan T. DeKok [Mon, 3 Apr 2023 17:00:53 +0000 (13:00 -0400)]
update code and add tests to allow a group on the RHS of edits
Arran Cudbard-Bell [Sun, 2 Apr 2023 19:49:55 +0000 (13:49 -0600)]
exec: Fixup another config file
Arran Cudbard-Bell [Sun, 2 Apr 2023 19:10:23 +0000 (13:10 -0600)]
modules: Bubble up errors so the server will refuse to start if there's a module error
Decorate all the functions with "warn_unused_result" so this doesn't happen again.
Arran Cudbard-Bell [Sun, 2 Apr 2023 18:19:33 +0000 (12:19 -0600)]
exec: Use conf parser to deal with input and output tmpl parsing
James Jones [Fri, 31 Mar 2023 22:03:53 +0000 (17:03 -0500)]
Annotate intentional writes of const-qualified data (CID #
1508484 , #
1517674 ) (#4872)
Certain members of fr_value_box_t and hence of fr_pair_t have
const-qualified type, so pair_init_from_da() and fr_value_box_init(),
which modify some of those members, coverity points them out.
(UNCONST() placates the compiler, but not coverity.)
The coverity primitives that one might think would apply here,
__coverity_write_buffer_{bytes, elements}__(), are said to relate
mostly to checkers unrelated to writes to const-qualified fields,
so we annotate.
Arran Cudbard-Bell [Fri, 31 Mar 2023 22:02:35 +0000 (16:02 -0600)]
LGTM no longer used
Max Khon [Fri, 31 Mar 2023 21:03:27 +0000 (04:03 +0700)]
fr_sbuff_out_bstrncpy_until(): call fr_sbuff_extend_lowat() with proper sbuff (#4873)
Arran Cudbard-Bell [Thu, 30 Mar 2023 21:21:05 +0000 (15:21 -0600)]
Use correct attribute type
Arran Cudbard-Bell [Thu, 30 Mar 2023 20:43:31 +0000 (14:43 -0600)]
xlat: Always check registration rcode to keep coverity quiet
James Jones [Thu, 30 Mar 2023 15:52:16 +0000 (10:52 -0500)]
Remove what we believe to be unnecessary alloc_strlen annotations (#4949)
1. Either coverity has changed or pen_buffer_as_file() has,
because an essentially identical use of it isn't annotated
and doesn't register a defect, so the annotaion can go.
2. The curl_escape() call now just passes 0 and lets the
function itself call strlen(), so that annotation should
be unneccessary.
James Jones [Thu, 30 Mar 2023 14:53:05 +0000 (09:53 -0500)]
Add IGNORE() macro to let us avoid some identical branch annotations (#4948)
If the unused-return warning is set, gcc will complain even in the
presence of an explicit cast to void. This lets us avoid that warning
in an error handling case that would otherwise be written
if (cleanup() < 0) goto error;
goto error;
about which Coverity complains.
Alan T. DeKok [Tue, 28 Mar 2023 07:36:46 +0000 (16:36 +0900)]
clean up error messages for consistency
Arran Cudbard-Bell [Thu, 30 Mar 2023 03:31:06 +0000 (21:31 -0600)]
xlat: Move function setting overrides into xlat_func.c
Arran Cudbard-Bell [Thu, 30 Mar 2023 03:14:58 +0000 (21:14 -0600)]
xlat: Add an internal flag for marking xlats as internal
Arran Cudbard-Bell [Thu, 30 Mar 2023 00:31:45 +0000 (18:31 -0600)]
Fix setting xlat flags in redundant
Arran Cudbard-Bell [Thu, 30 Mar 2023 00:26:40 +0000 (18:26 -0600)]
Add sigmask to xlat/module/func signal handler registration
Arran Cudbard-Bell [Wed, 29 Mar 2023 23:20:28 +0000 (17:20 -0600)]
xlat: Rename xlat_register to xlat_func and give all functions a common prefix
Arran Cudbard-Bell [Wed, 29 Mar 2023 22:56:01 +0000 (16:56 -0600)]
redundant xlat: Move to a separate source file
Arran Cudbard-Bell [Wed, 29 Mar 2023 22:54:51 +0000 (16:54 -0600)]
vscode: Always insert a final newline
Arran Cudbard-Bell [Wed, 29 Mar 2023 22:44:10 +0000 (16:44 -0600)]
xlat: Move function registration code into its own source file
Arran Cudbard-Bell [Wed, 29 Mar 2023 22:43:02 +0000 (16:43 -0600)]
vscode: Always trim trailing whitespace
Arran Cudbard-Bell [Wed, 29 Mar 2023 18:25:58 +0000 (12:25 -0600)]
subrequests/synchronous interpreter: Use the detached done callback to free requests
Use unlang_interpret_signal to manage cleaning up detached requests instead of having custom code inside the subrequest code
Arran Cudbard-Bell [Wed, 29 Mar 2023 18:24:40 +0000 (12:24 -0600)]
request: When a request is detached it's no longer detachable...
Arran Cudbard-Bell [Wed, 29 Mar 2023 02:55:08 +0000 (20:55 -0600)]
subrequest: More verbose log messages on subrequest completion
Arran Cudbard-Bell [Wed, 29 Mar 2023 02:50:18 +0000 (20:50 -0600)]
subrequest: Detached subrequest sections should not return calculate the result of the section
What was happening previously was the current section rcode was being evaluated with the priorities of the subrequest section, and causing spurious failures.
Arran Cudbard-Bell [Tue, 28 Mar 2023 23:58:36 +0000 (17:58 -0600)]
xlat: Set func flags using a separate function as the majority of registrations don't have flags set
Jorge Pereira [Tue, 28 Mar 2023 22:42:45 +0000 (19:42 -0300)]
Don't leak memory on error conditions (#4947)
Arran Cudbard-Bell [Tue, 28 Mar 2023 20:46:49 +0000 (14:46 -0600)]
interpreter: Be more eplicit about which action gets used for what
Arran Cudbard-Bell [Tue, 28 Mar 2023 20:36:39 +0000 (14:36 -0600)]
Revert "tacacs: Move packet code check to before the main encoder?"
This reverts commit
93885589666b73e660d42d94bd5a330483f58914 .
Nick Porter [Tue, 28 Mar 2023 12:50:42 +0000 (13:50 +0100)]
docs: Document missing argument
Nick Porter [Tue, 28 Mar 2023 12:46:52 +0000 (13:46 +0100)]
Escape & for doxygen
Alan T. DeKok [Tue, 28 Mar 2023 07:36:46 +0000 (16:36 +0900)]
move disallow_qualifiers boolean to list_presence enum
Alan T. DeKok [Tue, 28 Mar 2023 05:01:42 +0000 (14:01 +0900)]
add enum to allow / forbid / require list references
because it makes no sense to do:
&reply += {
&request.User-Name = "foo"
}
Alan T. DeKok [Tue, 28 Mar 2023 00:49:21 +0000 (09:49 +0900)]
typos
Alan T. DeKok [Tue, 28 Mar 2023 00:48:12 +0000 (09:48 +0900)]
add BFD to PROTOCOLS list so that the fuzzer can run
Arran Cudbard-Bell [Tue, 28 Mar 2023 00:10:16 +0000 (18:10 -0600)]
Detach cancelled children from their parents
Arran Cudbard-Bell [Tue, 28 Mar 2023 00:06:55 +0000 (18:06 -0600)]
Fix various warnings
Arran Cudbard-Bell [Mon, 27 Mar 2023 23:16:45 +0000 (17:16 -0600)]
Fix counts
Arran Cudbard-Bell [Sat, 18 Mar 2023 04:46:41 +0000 (00:46 -0400)]
fuzzer: Ignore extracted corpus files for BFD
Arran Cudbard-Bell [Sat, 18 Mar 2023 04:45:25 +0000 (00:45 -0400)]
tacacs: Move regression tests into their own file
Arran Cudbard-Bell [Sat, 18 Mar 2023 04:40:17 +0000 (00:40 -0400)]
tacacs: Move packet code check to before the main encoder?
Arran Cudbard-Bell [Sat, 18 Mar 2023 04:37:56 +0000 (00:37 -0400)]
cancel: Add more complete tests
Arran Cudbard-Bell [Sat, 18 Mar 2023 04:37:28 +0000 (00:37 -0400)]
Formatting
Arran Cudbard-Bell [Sat, 18 Mar 2023 04:37:20 +0000 (00:37 -0400)]
subrequest: Resume the parent if the child is cancelled
Arran Cudbard-Bell [Sat, 18 Mar 2023 04:36:56 +0000 (00:36 -0400)]
cancel: Insert dummy resume function to keep interpreter happy
Arran Cudbard-Bell [Sat, 18 Mar 2023 04:35:58 +0000 (00:35 -0400)]
synchronous interpreter: Decrement yielded count on stopped requests
James Jones [Mon, 27 Mar 2023 22:16:32 +0000 (17:16 -0500)]
First attempt at a state transition diagram for trunk requests (#4940)
Some of the functions cause two state transitions. Those are shown
with dashed-style edges, with a distinct color.
Matthew Newton [Thu, 23 Mar 2023 16:20:31 +0000 (16:20 +0000)]
CI: mirror more Docker images locally
Alan T. DeKok [Thu, 23 Mar 2023 20:35:43 +0000 (16:35 -0400)]
more magic
Alan T. DeKok [Thu, 23 Mar 2023 17:20:09 +0000 (13:20 -0400)]
$(Q) -> ${Q}
$(...) can be function calls in GNU Make.
${...} are always variable references
Matthew Newton [Thu, 23 Mar 2023 16:25:38 +0000 (16:25 +0000)]
CI: use local copies of Docker images
Matthew Newton [Thu, 23 Mar 2023 15:31:02 +0000 (15:31 +0000)]
CI: remove post-ci cleanup job
Alan T. DeKok [Thu, 23 Mar 2023 13:43:48 +0000 (09:43 -0400)]
check for "too small" earlier
so that we don't allocate VPs, try to decode them, and then discover
that it never would have worked.
Alan T. DeKok [Thu, 23 Mar 2023 13:43:25 +0000 (09:43 -0400)]
check for overflow when we add the length field
Alan T. DeKok [Wed, 22 Mar 2023 21:40:01 +0000 (17:40 -0400)]
0 return is "cannot decode", so we stop
Matthew Newton [Wed, 22 Mar 2023 19:25:28 +0000 (19:25 +0000)]
CI: gcc-11 has issues with the fuzzer
Alan T. DeKok [Wed, 22 Mar 2023 15:11:19 +0000 (11:11 -0400)]
add BFD fuzzer
Alan T. DeKok [Tue, 21 Mar 2023 20:36:11 +0000 (16:36 -0400)]
further simplifications
Matthew Newton [Tue, 21 Mar 2023 22:47:35 +0000 (22:47 +0000)]
CI: use local docker image for self-hosted runs