]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
3 years agodon't bother using "rlm_" prefixes everywhere. They're not needed
Alan T. DeKok [Mon, 8 Nov 2021 19:56:30 +0000 (14:56 -0500)] 
don't bother using "rlm_" prefixes everywhere.  They're not needed

use "foo - bar" for names, as that's being used elsewhere, too

and the output looks cleaner.

3 years agouse inst->name where possible
Alan T. DeKok [Mon, 8 Nov 2021 19:51:36 +0000 (14:51 -0500)] 
use inst->name where possible

3 years agothese are just EAP things, and are common across all EAP modules
Alan T. DeKok [Mon, 8 Nov 2021 19:51:14 +0000 (14:51 -0500)] 
these are just EAP things, and are common across all EAP modules

3 years agoremove LOG_PREFIX_ARGS, and just use LOG_PREFIX everywhere
Alan T. DeKok [Mon, 8 Nov 2021 19:36:08 +0000 (14:36 -0500)] 
remove LOG_PREFIX_ARGS, and just use LOG_PREFIX everywhere

which simplifies things, in preparation for adding log IDs
everywhere, too.

3 years agouse inst->name instead of dl_module_instance_name_by_data()
Alan T. DeKok [Mon, 8 Nov 2021 16:58:40 +0000 (11:58 -0500)] 
use inst->name instead of dl_module_instance_name_by_data()

3 years agouse static name with log_prefix and ID
Alan T. DeKok [Mon, 8 Nov 2021 16:53:36 +0000 (11:53 -0500)] 
use static name with log_prefix and ID

instead of re-converting them every time

3 years agounify to inst->name, instead of inst->xlat_name
Alan T. DeKok [Mon, 8 Nov 2021 16:47:11 +0000 (11:47 -0500)] 
unify to inst->name, instead of inst->xlat_name

3 years agoshut up compiler
Alan T. DeKok [Sat, 6 Nov 2021 15:13:44 +0000 (11:13 -0400)] 
shut up compiler

3 years agoreturn on error
Alan T. DeKok [Sat, 6 Nov 2021 15:07:32 +0000 (11:07 -0400)] 
return on error

3 years agoRevert "Remove hot branch in rbtree find_node"
Arran Cudbard-Bell [Sat, 6 Nov 2021 15:04:03 +0000 (11:04 -0400)] 
Revert "Remove hot branch in rbtree find_node"

This reverts commit b19a7ac6737e7a0f0aefb20cd94d9441d0e0eb3c.

3 years agoRemove hot branch in rbtree find_node
Arran Cudbard-Bell [Sat, 6 Nov 2021 14:46:43 +0000 (10:46 -0400)] 
Remove hot branch in rbtree find_node

3 years agoSuppress lgtm weak crypto warning
Arran Cudbard-Bell [Sat, 6 Nov 2021 14:46:10 +0000 (10:46 -0400)] 
Suppress lgtm weak crypto warning

3 years agoInclude dhcpv6 state machine options to control status-code contents
Arran Cudbard-Bell [Fri, 5 Nov 2021 23:37:23 +0000 (19:37 -0400)] 
Include dhcpv6 state machine options to control status-code contents

3 years agoAdd idx versions of pair_find functions
Arran Cudbard-Bell [Fri, 5 Nov 2021 17:20:56 +0000 (13:20 -0400)] 
Add idx versions of pair_find functions

3 years agoUpdate test now we don't send status by default
Arran Cudbard-Bell [Fri, 5 Nov 2021 16:11:26 +0000 (12:11 -0400)] 
Update test now we don't send status by default

3 years agoInformation requests are not directed
Arran Cudbard-Bell [Fri, 5 Nov 2021 15:58:01 +0000 (11:58 -0400)] 
Information requests are not directed

3 years agoDon't add status on success
Arran Cudbard-Bell [Fri, 5 Nov 2021 15:29:14 +0000 (11:29 -0400)] 
Don't add status on success

3 years agocache align TCP packets, too
Alan T. DeKok [Fri, 5 Nov 2021 15:00:45 +0000 (11:00 -0400)] 
cache align TCP packets, too

3 years agoremove unused functions
Alan T. DeKok [Fri, 5 Nov 2021 14:11:59 +0000 (10:11 -0400)] 
remove unused functions

3 years agocache align UDP messages
Alan T. DeKok [Fri, 5 Nov 2021 13:56:47 +0000 (09:56 -0400)] 
cache align UDP messages

not TCP message for now, as that requires memmove() on the
"leftover" bytes, which requires more expensive logic

3 years agoCPU cache line sizes are generally 64 bytes
Alan T. DeKok [Thu, 4 Nov 2021 21:37:14 +0000 (17:37 -0400)] 
CPU cache line sizes are generally 64 bytes

3 years agoRevert "Pass dict root not dicts..."
Arran Cudbard-Bell [Fri, 5 Nov 2021 14:02:11 +0000 (10:02 -0400)] 
Revert "Pass dict root not dicts..."

This reverts commit 1503b48d7dfd64c303f7db9b9872f16f54bb7fdb.

3 years agoPass dict root not dicts...
Arran Cudbard-Bell [Fri, 5 Nov 2021 13:49:37 +0000 (09:49 -0400)] 
Pass dict root not dicts...

3 years agoPass in protocol specific dictionaries to the packet debug functions
Arran Cudbard-Bell [Fri, 5 Nov 2021 02:08:32 +0000 (22:08 -0400)] 
Pass in protocol specific dictionaries to the packet debug functions

3 years agoInvert args
Arran Cudbard-Bell [Thu, 4 Nov 2021 20:18:50 +0000 (16:18 -0400)] 
Invert args

3 years agospecial free function
Arran Cudbard-Bell [Thu, 4 Nov 2021 20:09:41 +0000 (16:09 -0400)] 
special free function

3 years agoWe apparently don't cache this anymore
Arran Cudbard-Bell [Thu, 4 Nov 2021 20:01:31 +0000 (16:01 -0400)] 
We apparently don't cache this anymore

3 years agosingular not plaural
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:27:17 +0000 (15:27 -0400)] 
singular not plaural

3 years agoInclude our talloc header here
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:16:02 +0000 (15:16 -0400)] 
Include our talloc header here

3 years agoTypo
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:14:10 +0000 (15:14 -0400)] 
Typo

3 years agoAruba dict updates closes #4297
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:13:22 +0000 (15:13 -0400)] 
Aruba dict updates closes #4297

3 years ago...one more
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:09:51 +0000 (15:09 -0400)] 
...one more

3 years ago...and another
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:09:30 +0000 (15:09 -0400)] 
...and another

3 years agoShould be signed
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:08:14 +0000 (15:08 -0400)] 
Should be signed

3 years agoMove talloc header
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:07:14 +0000 (15:07 -0400)] 
Move talloc header

3 years agoCopy interface id back if it was included
Arran Cudbard-Bell [Thu, 4 Nov 2021 19:06:24 +0000 (15:06 -0400)] 
Copy interface id back if it was included

3 years agoFix various dumb issues
Arran Cudbard-Bell [Thu, 4 Nov 2021 18:59:53 +0000 (14:59 -0400)] 
Fix various dumb issues

3 years agoFix typos
Arran Cudbard-Bell [Thu, 4 Nov 2021 18:55:28 +0000 (14:55 -0400)] 
Fix typos

3 years agowe don't need a second name here
Alan T. DeKok [Thu, 4 Nov 2021 18:49:40 +0000 (14:49 -0400)] 
we don't need a second name here

3 years agoallow running individual module tests
Alan T. DeKok [Thu, 4 Nov 2021 18:47:14 +0000 (14:47 -0400)] 
allow running individual module tests

3 years agoNeed talloc
Arran Cudbard-Bell [Thu, 4 Nov 2021 18:50:38 +0000 (14:50 -0400)] 
Need talloc

3 years agoDump capabilities to INFO() at various phases in the process lifecycle
Arran Cudbard-Bell [Thu, 4 Nov 2021 18:31:21 +0000 (14:31 -0400)] 
Dump capabilities to INFO() at various phases in the process lifecycle

3 years agoadd const
Alan T. DeKok [Thu, 4 Nov 2021 17:46:41 +0000 (13:46 -0400)] 
add const

3 years agomove mschap specific rules to top-level, and make top-level more generic
Alan T. DeKok [Thu, 4 Nov 2021 15:05:00 +0000 (11:05 -0400)] 
move mschap specific rules to top-level, and make top-level more generic

and don't bother re-running 'configure'.  It doesn't work
half of the time.

3 years agolet's put files into ${localstatedir}, and not /tmp
Alan T. DeKok [Wed, 3 Nov 2021 22:32:58 +0000 (18:32 -0400)] 
let's put files into ${localstatedir}, and not /tmp

3 years agomove db_dir, as nothing uses it
Alan T. DeKok [Thu, 4 Nov 2021 12:07:25 +0000 (08:07 -0400)] 
move db_dir, as nothing uses it

3 years agofix xlats for virtual modules
Alan T. DeKok [Wed, 3 Nov 2021 21:32:51 +0000 (17:32 -0400)] 
fix xlats for virtual modules

don't even bother for "group".

Register the xlats in the "bootstrap" stage, by walking over the
virtual modules.

switch xlat_redundant() etc. to use the new XLAT API.

3 years agouse another module for redundant tests
Alan T. DeKok [Wed, 3 Nov 2021 16:39:02 +0000 (12:39 -0400)] 
use another module for redundant tests

3 years agomove virtual module to "modules" section
Alan T. DeKok [Wed, 3 Nov 2021 16:35:33 +0000 (12:35 -0400)] 
move virtual module to "modules" section

3 years agoremove all references to "instantiate"
Alan T. DeKok [Wed, 3 Nov 2021 16:31:37 +0000 (12:31 -0400)] 
remove all references to "instantiate"

3 years agoremove special cases for "instantiate", it no longer exists
Alan T. DeKok [Wed, 3 Nov 2021 16:30:24 +0000 (12:30 -0400)] 
remove special cases for "instantiate", it no longer exists

3 years agolook up virtual modules using new API
Alan T. DeKok [Wed, 3 Nov 2021 16:27:19 +0000 (12:27 -0400)] 
look up virtual modules using new API

instead of relying on the old "instantiate" section

3 years agomove virtual_modules back to bootstrap, and track them
Alan T. DeKok [Wed, 3 Nov 2021 16:25:40 +0000 (12:25 -0400)] 
move virtual_modules back to bootstrap, and track them

expose an API to discover the CONF_SECTION for a virtual module

3 years agoRevert "Revert "remove the 'instantiate' section, as it's no longer necessary""
Alan T. DeKok [Wed, 3 Nov 2021 16:22:30 +0000 (12:22 -0400)] 
Revert "Revert "remove the 'instantiate' section, as it's no longer necessary""

This reverts commit 09416b43dfcb6b232bd184fd3a56156a5dd4426a.

3 years agoallow for multiple instances
Alan T. DeKok [Wed, 3 Nov 2021 13:31:32 +0000 (09:31 -0400)] 
allow for multiple instances

3 years agoadd LOG_ID_LIB to files
Alan T. DeKok [Tue, 2 Nov 2021 20:28:20 +0000 (16:28 -0400)] 
add LOG_ID_LIB to files

3 years agocleanups, and allow assigning of IDs to files
Alan T. DeKok [Tue, 2 Nov 2021 19:31:55 +0000 (15:31 -0400)] 
cleanups, and allow assigning of IDs to files

3 years agodefine LOG_ID_SECTION for the drivers
Alan T. DeKok [Tue, 2 Nov 2021 18:13:11 +0000 (14:13 -0400)] 
define LOG_ID_SECTION for the drivers

3 years agocleanups
Alan T. DeKok [Tue, 2 Nov 2021 18:12:35 +0000 (14:12 -0400)] 
cleanups

3 years agoallow for LIB/SECTION IDs to be in different directories
Alan T. DeKok [Tue, 2 Nov 2021 01:24:28 +0000 (21:24 -0400)] 
allow for LIB/SECTION IDs to be in different directories

as with rlm_sql and rlm_eap

3 years agomore notes
Alan T. DeKok [Tue, 2 Nov 2021 01:24:12 +0000 (21:24 -0400)] 
more notes

3 years agoAdd #include <sys/types.h> to the ssize_t test program (#4303)
James Jones [Thu, 4 Nov 2021 14:16:35 +0000 (09:16 -0500)] 
Add #include <sys/types.h> to the ssize_t test program (#4303)

That's (at least one place) where ssize_t gets defined, so the
test program can work as intended. (The header's there for Mac
OS X as well.)

3 years agoDon't print the module prefix
Arran Cudbard-Bell [Thu, 4 Nov 2021 04:09:04 +0000 (00:09 -0400)] 
Don't print the module prefix

3 years agoHelps to init the lists
Arran Cudbard-Bell [Thu, 4 Nov 2021 03:30:00 +0000 (23:30 -0400)] 
Helps to init the lists

3 years agoCopy all of the server_id and client_id attributes
Arran Cudbard-Bell [Thu, 4 Nov 2021 03:20:35 +0000 (23:20 -0400)] 
Copy all of the server_id and client_id attributes

3 years agoFix assert
Arran Cudbard-Bell [Wed, 3 Nov 2021 23:33:20 +0000 (19:33 -0400)] 
Fix assert

3 years agoFinal temporary fix for replacing nested pairs
Arran Cudbard-Bell [Wed, 3 Nov 2021 23:20:31 +0000 (19:20 -0400)] 
Final temporary fix for replacing nested pairs

3 years agoAdd more validation calls
Arran Cudbard-Bell [Wed, 3 Nov 2021 22:06:52 +0000 (18:06 -0400)] 
Add more validation calls

3 years ago:= should just replace the existing vp instead of building out extents
Arran Cudbard-Bell [Wed, 3 Nov 2021 21:40:52 +0000 (17:40 -0400)] 
:= should just replace the existing vp instead of building out extents

3 years agoStill replacing in the extent's list
Arran Cudbard-Bell [Wed, 3 Nov 2021 21:13:51 +0000 (17:13 -0400)] 
Still replacing in the extent's list

3 years agoFix case in tmpl_extents_find for where the leaf attribute exists
Arran Cudbard-Bell [Wed, 3 Nov 2021 21:00:05 +0000 (17:00 -0400)] 
Fix case in tmpl_extents_find for where the leaf attribute exists

We still want to return its direct parent as a leaf

3 years agoCatch logic errors sooner in tmpl_extents_find
Arran Cudbard-Bell [Wed, 3 Nov 2021 20:20:11 +0000 (16:20 -0400)] 
Catch logic errors sooner in tmpl_extents_find

3 years agoThey're fixed length attributes...
Arran Cudbard-Bell [Wed, 3 Nov 2021 19:53:22 +0000 (15:53 -0400)] 
They're fixed length attributes...

3 years agov4: Convert SQL xlat to new API (#4302)
Nick Porter [Wed, 3 Nov 2021 19:52:10 +0000 (19:52 +0000)] 
v4: Convert SQL xlat to new API (#4302)

* Define sql_xlat_escape()

* Define mox_xlat_instantiate() for rlm_sql

* Amend SQL xlat to use new API

* Register new sql xlat

* Remove old sql xlat escape function

3 years ago...and another couple
Arran Cudbard-Bell [Wed, 3 Nov 2021 19:40:17 +0000 (15:40 -0400)] 
...and another couple

3 years agoIncorrect ctx for timer
Arran Cudbard-Bell [Wed, 3 Nov 2021 19:32:42 +0000 (15:32 -0400)] 
Incorrect ctx for timer

3 years agoFormatting
Arran Cudbard-Bell [Wed, 3 Nov 2021 19:32:29 +0000 (15:32 -0400)] 
Formatting

3 years agotypo
Arran Cudbard-Bell [Wed, 3 Nov 2021 19:18:35 +0000 (15:18 -0400)] 
typo

3 years agoRemove coverity badge. The coverity scan tool is broken.
Arran Cudbard-Bell [Wed, 3 Nov 2021 19:17:13 +0000 (15:17 -0400)] 
Remove coverity badge.  The coverity scan tool is broken.

3 years agoWe need the link address attribute not its ancestor
Arran Cudbard-Bell [Wed, 3 Nov 2021 19:15:30 +0000 (15:15 -0400)] 
We need the link address attribute not its ancestor

3 years agoDon't process the next state if we can't find the required fields
Arran Cudbard-Bell [Wed, 3 Nov 2021 19:11:15 +0000 (15:11 -0400)] 
Don't process the next state if we can't find the required fields

3 years agoOff by one
Arran Cudbard-Bell [Wed, 3 Nov 2021 18:59:13 +0000 (14:59 -0400)] 
Off by one

3 years agoFix crash on exit
Arran Cudbard-Bell [Wed, 3 Nov 2021 18:55:26 +0000 (14:55 -0400)] 
Fix crash on exit

3 years agoDon't loop infinitely when cancelling requests
Arran Cudbard-Bell [Wed, 3 Nov 2021 18:47:12 +0000 (14:47 -0400)] 
Don't loop infinitely when cancelling requests

3 years agoMore quotes
Arran Cudbard-Bell [Wed, 3 Nov 2021 18:46:56 +0000 (14:46 -0400)] 
More quotes

3 years agoDon't leave freed thread trunks in the tree of ldap connections
Arran Cudbard-Bell [Wed, 3 Nov 2021 18:08:04 +0000 (14:08 -0400)] 
Don't leave freed thread trunks in the tree of ldap connections

3 years agoFix dns encoder call to dump_fuzzer_data
Arran Cudbard-Bell [Wed, 3 Nov 2021 17:42:23 +0000 (13:42 -0400)] 
Fix dns encoder call to dump_fuzzer_data

3 years agoMove rctx into mctx, fixing dhcpv6_process in the process
Arran Cudbard-Bell [Wed, 3 Nov 2021 17:36:03 +0000 (13:36 -0400)] 
Move rctx into mctx, fixing dhcpv6_process in the process

3 years agoRevert "remove the 'instantiate' section, as it's no longer necessary"
Arran Cudbard-Bell [Wed, 3 Nov 2021 13:17:32 +0000 (09:17 -0400)] 
Revert "remove the 'instantiate' section, as it's no longer necessary"

This reverts commit 842b82fae919c1457b0264ca448395c9c7678790.

3 years agoslightly clear
Arran Cudbard-Bell [Wed, 3 Nov 2021 03:31:20 +0000 (23:31 -0400)] 
slightly clear

3 years agoBetter string parsing errors
Arran Cudbard-Bell [Wed, 3 Nov 2021 03:25:22 +0000 (23:25 -0400)] 
Better string parsing errors

3 years agoFix protocol attributes in xlats in policies
Arran Cudbard-Bell [Wed, 3 Nov 2021 01:56:33 +0000 (21:56 -0400)] 
Fix protocol attributes in xlats in policies

3 years agoIgnore profiler files
Arran Cudbard-Bell [Wed, 3 Nov 2021 01:54:14 +0000 (21:54 -0400)] 
Ignore profiler files

3 years agoCreate tag attributes from the root _not_ under TLVs or other structural elements.
Arran Cudbard-Bell [Tue, 2 Nov 2021 17:47:22 +0000 (13:47 -0400)] 
Create tag attributes from the root _not_ under TLVs or other structural elements.

3 years agoAllow setting the debug level for fuzzer targets
Arran Cudbard-Bell [Tue, 2 Nov 2021 17:46:19 +0000 (13:46 -0400)] 
Allow setting the debug level for fuzzer targets

It can be very useful for tracing protocol execution

3 years agoHave the fuzzer print out talloc errors
Arran Cudbard-Bell [Tue, 2 Nov 2021 14:49:50 +0000 (10:49 -0400)] 
Have the fuzzer print out talloc errors

3 years agofuzzer-no-link needs to be passed to the compiler and linker step
Arran Cudbard-Bell [Tue, 2 Nov 2021 14:00:32 +0000 (10:00 -0400)] 
fuzzer-no-link needs to be passed to the compiler and linker step

3 years agoDo a complete build before running the unit tests
Arran Cudbard-Bell [Tue, 2 Nov 2021 13:52:39 +0000 (09:52 -0400)] 
Do a complete build before running the unit tests

3 years agoQuiet the compiler
Arran Cudbard-Bell [Tue, 2 Nov 2021 13:40:17 +0000 (09:40 -0400)] 
Quiet the compiler

The result of course, is identical.

3 years agoAdd coverage option
Arran Cudbard-Bell [Tue, 2 Nov 2021 13:36:26 +0000 (09:36 -0400)] 
Add coverage option