Willem Toorop [Tue, 12 Mar 2013 13:34:18 +0000 (13:34 +0000)]
- Uninitialized variable in securetrace.c
- New install-sh (apperantly :)
- Get rid of "dereferencing type-punned pointer will break strict-aliasing rules" warnings in sha2.c with gcc >= 4.7
Willem Toorop [Wed, 21 Nov 2012 22:12:52 +0000 (22:12 +0000)]
Fix ldns_dnssec_zone_new_frm_fp_l to allow the last parsed line of a zone to be an NSEC3 (or its RRSIG) covering an empty non terminal.
Thanks Peter van Dijk
Willem Toorop [Sat, 17 Nov 2012 23:22:53 +0000 (23:22 +0000)]
Support for RFC6742 Resource Records for the Identifier-Locator Network Protocol (ILNP): NID, L32, L64 and LP.
There was a need to add a new rdf type representing 64bits represented as 4 hexidecimal shorts seperated by colons.
Proper testing still pending.
Willem Toorop [Fri, 19 Oct 2012 12:03:05 +0000 (12:03 +0000)]
Findings from release candidate
- With drill:
- Read default key only when DNSSEC tracing or chasing
- With ldns-dane:
- When performing as stub resolver with DNSSEC enabled,
interpret SERVFAIL as BOGUS.
- Just discard bogus address records (instead of quiting all together)
- Don't release on the stack rdf data in ldns_pkt_verify_time
Willem Toorop [Sun, 7 Oct 2012 09:42:10 +0000 (09:42 +0000)]
bugfix 473.
- Fix unnecessary opening and closing of file in read_hex_buffer in drill/work.c.
- Close input_file in read_key_file
- Signed return type of possibly -1 returning read_line
Willem Toorop [Tue, 25 Sep 2012 11:58:14 +0000 (11:58 +0000)]
Final code review thingies:
Bufferoverflow in data_buffer2wire in ldns-testpkts.c
Print unknown rcodes in ldns_axfr_next in resolver.c
Handle errors in main in ldns-keyfetcher.c
Continue in correct loop in ldns_resolver_new_frm_fp_l in resolver.c
Skip set delimeters (to del) when tokenread i.s.o. delim in ldns_bget_token and ldns_fget_token in parse.c
Test reply when verifying tsig in ldns_send_buffer in net.c
Assert that verify_next_hashed_name is only called with nsecs in the zone with ldns-verify-zone.c
Set inception and expiration on keys after they are read from the engine in main in ldns-signzone.c
Gracefully return from ldns_dnssec_zone_add_empty_nonterminals in a broken rbtree.
Check if tree->rr is null before use in ldns_dnssec_trust_tree_contains_keys in dnssec_verify.c
Check data for null before use in ldns_dnssec_create_nsec_bitmap in dnssec.c
Dead code in ldns_str2rdf_wks, ldns_resolver_query, examples/ldns_testpkts/data_buffer2wire, drill/work/packetbuffromfile & ldns_dnssec_verify_denial_nsec3_match.
Willem Toorop [Mon, 24 Sep 2012 20:38:11 +0000 (20:38 +0000)]
Code review changes:
free wire when returning from dump_hex in drill/work.c
return properly from do_secure_trace in drill/securetrace.c on ldns_resolver_push_nameserver_rr_list error
free keys after use in print_ds_of_keys in drill/drill_util.c
free util variables when returning from ldns_verify_denial in drill/dnssec.c
Free ldns_pkt p when returning from get_rr in drill/dnssec.c
Resource leak in get_dnssec_rr in drill/dnssec.c
Resource leak in drill_pkt_print_footer in drill/dnssec.c
free new_nss after printing in drill_pkt_print in drill/dnssec.c
Resource leak in drill_pkt_print in drill/dnssec.c
Free res and p when returning from do_trace in drill/chasetrace.c
Multiple resource leaks in ldns_dnssec_zone_new_frm_fp_l in dnssec_zone.c
free chopped_dname before return in ldns_dnssec_verify_denial in dnssec_verify.c
Proper cleanup of tmp_rrset in ldns_dnssec_derive_trust_tree_normal_rrset_time in dnssec_verify.c
free signatures in ldns_dnssec_build_data_chain in dnssec_verify.c
free b64sig when RSA_sign fails in ldns_sign_public_rsasha1 in dnssec_sign.c
free currentsig and signatures when premature returning from ldns_sign_public in dnssec_sign.c
shallow free nsec3_list when returning from ldns_dnssec_zone_create_nsec3s_mkmap in dnssec_sign.c
multiple resource leaks in ldns_pkt_verify_time in dnssec.c
Free hashed_owner when prematurily returning from ldns_create_nsec3 in dnssec.c
and
Fix root label detection in dname.c (before last non-root labels ending in 0-character were not possible -- and they are really)
Lessen memory-management in ldns_dname_reverse to 1 malloc
Willem Toorop [Wed, 19 Sep 2012 21:00:03 +0000 (21:00 +0000)]
Asked Jakob. A CA certificate is a certificate with the CA basicConstraint set to true (provided by X509_check_ca in OpenSSL).
So no need to check for it in the validation store.
Willem Toorop [Tue, 4 Sep 2012 07:34:21 +0000 (07:34 +0000)]
Support for Python's rich comparison methods into ldns_dname, ldns_rdf,
ldns_rr and ldns_rr_list classes. These are necessary for the proper
function of binary comparison operators (<, ==, ...) in Python 3,
because the __cmp__() special method isn't supported in Python 3.