Patch for bug 53452: Mid-air collision: allow copy-paste of the comment from a textarea; patch by Brodie Thiesfield <brofield@jellycan.com>; r=kiko, a=justdave.
Fix for bug 216008: Time Tracking: default values cause change bug
errors. Check if the time values haven't actually changed by using integer comparison (instead of string comparison). r=jouni, a=justdave.
Missing bits of fix for bug 236678: Clean up access to COOKIE global.
Murder the last remaining places in the tree where COOKIE is used;
includes a rather thorough cleanup of Bugzilla::Bug->user and a minor
doc update. r=joel, a=justdave.
Fix for bug 252789: Empty timetrackinggroup causes error "hours worked
needs to be positive" when changing bug. Sanitizing the AddComment bits
in process_bug.cgi to only touch work_time if user is in
timetrackinggroup. Fixes regression introduced in bug 252159.
r=jouni,joel; a=justdave.
Fix for bug 252839: Remove &action=view from links in attachment table;
this was done to improve link target consistency and avoid shell-pasting
bustage from the & character. r=myk, a=justdave.
Fix for bug 236678: Clean up access to COOKIE global. Murder the last
remaining places in the tree where COOKIE is used; includes a rather
thorough cleanup of Bugzilla::Bug->user and a minor doc update. r=joel, a=justdave.
Fix for bug 252943: broken title in interdiff. Adds reasonable title while
doing an interdiff, and fixes some broken and confusing double-linking
in the text. r=joel, a=justdave.
Fix for bug 251911: Silly ThrowUserError bits in attachment.cgi. Fixing
variables missing in some errors raised, and doing bits of $::FORM
cleanup while we're at it. r=joel, a=justdave.
Fix for bug 252370: Provide edit link for attachment in comment. Adds an
[edit] link next to attachments in comment text, and removes the
&action=view suffix which breaks things when pasting into a shell.
r=bugreport, myk; a=myk.
Fix for bug 252159: centralize time validation. Adds a ValidateTime
function to Bugzilla::Bug and uses it in relevant callsites. Patch by
Alexandre Michetti Manduca <michetti@grad.icmc.usp.br>. r=kiko, a=justdave.
Fix for bug 251727: Create a /images directory. Moved 1x1.gif into it; left
ant.jpg out to avoid complaints about "this very important testing
resource" <wink>. Fixed single callsite (and someone please explain to
me what it's useful for!) a=justdave, myk.
Fix for bug 251841: body id from urlbase with tilde (~) fails
validation. Swap [sequences of] tilde, hypens and some other common
symbols into hyphens. r=burnus, a=myk.
Fix for bug 123030: Move query.cgi javascript to separate file. Create
productform.js that contains functions to handle the various select
boxes in the advanced search page, and update the callsites to use
it. r,a=myk.
Fix for bug 251898: Add function information to PatchReader output.
Added support for the function strings included in unified and
contextual diffs, which is included in PatchReader-0.9.5. r=jkeiser,
a=justdave.
Additional fix for bug 244324: bugzilla-submit crashes when incorrect
base url provided. Check other situations in which we may have trouble
with bad base urls and report error conditions. contrib checkin.
More manpage fixage: make screen sections indent and format properly. For
some reason, they need indentation to look good in the generated nroff
format.
Bustage fix for bug 251469. Solve filtering issues with javascript_url,
which includes fixing style_url as well and removing it from
filterexceptions. r,a=justdave
Fix for bug 251469: Add an interface argument in header template to
import <script src files. Patch by Tiago R. Mello <tiago@async.com.br>.
r=timeless, a=justdave.
Bug 238797: minor adjustment to javascript filters to prevent tags inserted in product, component, and flag names from causing problems.
r=gerv, a=justdave
Fix for bug 250754: Require Chart::Base 1.0. Push up the requirement a
single notch to avoid GIF-requirements in GD and 0.99 `confusioning'. r,a=justdave
Patch for bug 250265: fix taint issues with vote fields when editing products; patch by GavinS <bugzilla@chimpychompy.org> slightly updated by me; r=joel; a=justdave.
Patch for bug 249863: Move hidden initial state INPUT field at the beginning of the table (previously it was inserted between table rows, causing invalid HTML); patch by GavinS <bugzilla@chimpychompy.org>; r=vladd, a=justdave.
Fix for bug 248988: On Windows, attachments may fail due to "CGI open of tmpfile"; patch by byron jones (glob) <bugzilla@glob.com.au>; r=jouni; a=justdave.
Bug 245077: The "Find a specific bug" tab is now the default query when you go to query.cgi. To keep the developers happy, a cookie is now set to remember which query page you last visited, and going to query.cgi without specifying which tab will get you the last one you visited.
Patch by Byron Jones <bugzilla@glob.com.au>
r=justdave, a=justdave
Bug 239343: Contribution of sendbugmail.pl script, drop-in replacement for the no-longer-existing processmail for use by external scripts that used to use processmail's functionality.
Contributed by Nick Barnes of Ravenbrook Ltd.
a=justdave
Bug 245101: Fixes non-fatal warnings about the "attachstatusdefs" table not existing during an upgrade from 2.14.x or older without going through 2.16.x in between.
r=joel, a=justdave
Patch for bug 248001: Conversion of boolean conditions in SQL statements for better DB independence; patch by David Lawrence <dkl@redhat.com>; r=joel, vladd; a=justdave.