According to comments in main/pbx.c, it is essential that if we are going to lock
the conlock as well as the hints lock, it must be locked in that respective order.
In order to prevent a potential deadlock, we need to lock the conlock prior to
locking the hints lock in ast_hint_state_changed (see the call stack example on
issue #11323 for how this can happen).
(closes issue #11323, reported by eelcob, suggestion for patch by eelcob, patch by me)
Luigi Rizzo [Tue, 20 Nov 2007 16:12:10 +0000 (16:12 +0000)]
Fix building of modules under cygwin.
After this commit we can actually load modules under windows,
and we can start debugging more interesting problems related
to the load order and functionality of modules.
Joshua Colp [Tue, 20 Nov 2007 15:00:41 +0000 (15:00 +0000)]
Minor documentation tweak and if an incorrect parameter is given to core show translation return the usage information.
(closes issue #11316)
Reported by: eliel
Patches:
translate.c.patch uploaded by eliel (license 64)
Mark Michelson [Mon, 19 Nov 2007 23:24:35 +0000 (23:24 +0000)]
Changed the "busy-level" option in sip.conf to "busylevel" to be more parallel
with the SIPPEER() argument of the same name. The deprecation procedure is not
being used here since this is a trunk-only option.
(closes issue #11307, reported by pj, patched by me)
Steve Murphy [Mon, 19 Nov 2007 22:55:38 +0000 (22:55 +0000)]
These changes were made in response to niklas@tese.se's letter of 11-17-2007, where he had 20 and 201 in two different contexts, included in the same context. In that particular case, we were behaving the same as 1.4, but after experimenting, I quickly found that if 20 and 201 were in the same extension, 1.4 would return 201, and this code returns 20. These changes now enable the current code to replicate the behavior of 1.4 in respect to MATCHMORE in cases like this.
Tilghman Lesher [Mon, 19 Nov 2007 20:13:40 +0000 (20:13 +0000)]
Change delimiter of SIPPEER to be comma (instead of pipe) and further deprecate the old ':' delimiter
Reported by: pj
Patch by: tilghman
Closes issue #11305
Luigi Rizzo [Mon, 19 Nov 2007 19:36:32 +0000 (19:36 +0000)]
move the declaration of struct ast_channel ast_frame and ast_module
to compat.h so it is always available - hopefully this will let
us reduce the number of inclusions of channel.h and frame.h
Print out the correct filename (features.conf) in the log message when parkpos options are incorrect.
(closes issue #11295)
Reported by: Laureano
Patches:
res_features.c.patch uploaded by Laureano (license 265)
Clarify documentation a bit, include that a frame has to pass through the core in order for the Local channel optimization to happen.
(closes issue #11246)
Reported by: jon
Olle Johansson [Mon, 19 Nov 2007 08:34:26 +0000 (08:34 +0000)]
Make some notes about a problem I found with the OPTIONs handler while working with
the bug tracker. Since we don't authenticate devices (peers/users) on OPTIONS we don't
have the proper context set for the user/peer.
However, we might not want to process an authentication for every OPTIONS, so we could
have a config option for this, "optionsforceok" to always answer 200 OK on the request
and not check device or destination, nor add a SDP. If Asterisk sends the OPTIONs request,
it doesn't care about the reply. Some devices use OPTIONs to discover capabilities,
since we should answer like an INVITE from the device and we need to support that properly
too, which we don't today.
Joshua Colp [Sun, 18 Nov 2007 17:01:41 +0000 (17:01 +0000)]
Change how we handle alloca to conform with how it is suggested in the autoconf manual for AC_FUNC_ALLOCA. FreeBSD 6 now builds again and no other platforms should be broken by this.
Joshua Colp [Sat, 17 Nov 2007 23:03:16 +0000 (23:03 +0000)]
Use autoconf logic to determine the presence of PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP and PTHREAD_MUTEX_RECURSIVE_NP. Enclose error message from network.h in "
Steve Murphy [Sat, 17 Nov 2007 17:46:36 +0000 (17:46 +0000)]
a quick fix to pbx_dundi.c to make it so it will compile. Hope I did the right thing. And some additions to removal of extens to take care of hashtab pointers in all cases.
Luigi Rizzo [Sat, 17 Nov 2007 17:27:26 +0000 (17:27 +0000)]
as discussed some time ago on the -dev list, create embedde object
with a .eo suffix even if they are coming from .cc sources.
This simplifies the handling in the build scripts.
Luigi Rizzo [Sat, 17 Nov 2007 09:54:54 +0000 (09:54 +0000)]
add a return NULL to a function that is expected to return a value
so compilers that don't understand that this code is NOTREACHED
will not complain (the fault is not much on the compiler but on the
declaration of pthread_exit on certain platforms)
s/certain platform/cygwin/ if you are really curious
Luigi Rizzo [Sat, 17 Nov 2007 09:51:45 +0000 (09:51 +0000)]
define RTLD_LOCAL for platforms that don't have it.
This is only to complete the build, clearly the linker
behaviour will be completely different and likely to
cause trouble in those cases.
Luigi Rizzo [Sat, 17 Nov 2007 09:48:45 +0000 (09:48 +0000)]
filter out modules that do not compile under windows
(this should be handled with the dependencies generated by
configure and menuselect, but will be fixed later)
Russell Bryant [Sat, 17 Nov 2007 06:33:07 +0000 (06:33 +0000)]
Update the configure script check for sys/poll.h to also provide the result in
include/asterisk/autoconfig.h. Also, move the conditional include of sys/poll.h
or asterisk/poll-compat.h into asterisk/config.h instead of the two headers it
existed in before.
Russell Bryant [Sat, 17 Nov 2007 06:07:57 +0000 (06:07 +0000)]
Use the fix suggested by Tilghman on the -dev to make cutting up the BUILDSUM
friendly to non-bash shells. I think this should work for BSD/mingw as well,
but did not yet remove the switch statement.
Luigi Rizzo [Sat, 17 Nov 2007 01:49:26 +0000 (01:49 +0000)]
acinclude.m4: add a function to help checking sdl-config, gtk-config
and the like (this could be used for gtk and gtk2 as well)
Other files: add tests for sdl, sdl_image and avcodec and regenerate
configure and autoconfig.h.in
Steve Murphy [Fri, 16 Nov 2007 23:33:32 +0000 (23:33 +0000)]
My goodness, haven't handled an extension deletion. Add code to ast_context_remove_extension2() to remove an extension from the trie. Done by marking it deleted. The scoreboard won't update for it any more. Also, a couple of calls to insert hashtab had a spurious ->exten, which was removed.
Luigi Rizzo [Fri, 16 Nov 2007 22:37:17 +0000 (22:37 +0000)]
whitespace only change - adjust indentation and add some
comments on the content of these two files.
utils.h (which is included in over 150 files) contains a lot of
unrelated functions which require the inclusion of a large number
of other headers. At some point we should partition its content
in a better way.
Russell Bryant [Fri, 16 Nov 2007 22:33:24 +0000 (22:33 +0000)]
Blocked revisions 89339 via svnmerge
........
r89339 | russell | 2007-11-16 16:26:44 -0600 (Fri, 16 Nov 2007) | 5 lines
Temporarily revert revision 89325, which added md5 magic for keeping track of
what build options were used. We agreed that we should remove this before
making a 1.4 release, and then we can put it back in. Then, we can take a
month or so to play around with it to get it how we want it.