]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
4 years ago...and the ctx structure too
Arran Cudbard-Bell [Tue, 6 Apr 2021 11:49:15 +0000 (12:49 +0100)] 
...and the ctx structure too

4 years agoRename tmpl_cursor_init and tmpl_cursor_clear to tmpl_pair_cursor_init and tmpl_curso...
Arran Cudbard-Bell [Tue, 6 Apr 2021 11:48:08 +0000 (12:48 +0100)] 
Rename tmpl_cursor_init and tmpl_cursor_clear to tmpl_pair_cursor_init and tmpl_cursor_pair_clear

4 years agoDeal with channels being closed on server exit
Arran Cudbard-Bell [Tue, 6 Apr 2021 11:27:15 +0000 (12:27 +0100)] 
Deal with channels being closed on server exit

4 years agocombo-ip and combo-ip-prefix have a special format in RADIUS
Alan T. DeKok [Tue, 6 Apr 2021 11:16:02 +0000 (07:16 -0400)] 
combo-ip and combo-ip-prefix have a special format in RADIUS

4 years agomark up MSK as being 32 octets in length
Alan T. DeKok [Tue, 6 Apr 2021 11:07:58 +0000 (07:07 -0400)] 
mark up MSK as being 32 octets in length

4 years agocombo IPv6 is 16 octets, not 17
Alan T. DeKok [Tue, 6 Apr 2021 10:54:01 +0000 (06:54 -0400)] 
combo IPv6 is 16 octets, not 17

combo-ip is only used for WiMAX, and it doesn't have a scope byte.

4 years agoadd rule for: make test.unit.condition
Alan T. DeKok [Mon, 5 Apr 2021 16:08:42 +0000 (12:08 -0400)] 
add rule for: make test.unit.condition

4 years agoShouldn't have been comitted
Arran Cudbard-Bell [Tue, 6 Apr 2021 10:48:18 +0000 (11:48 +0100)] 
Shouldn't have been comitted

4 years agoMore efficient way of cleaning up frames
Arran Cudbard-Bell [Tue, 6 Apr 2021 10:46:03 +0000 (11:46 +0100)] 
More efficient way of cleaning up frames

4 years agoEnsure stack frame state is freed in a deterministic way
Arran Cudbard-Bell [Tue, 6 Apr 2021 10:26:52 +0000 (11:26 +0100)] 
Ensure stack frame state is freed in a deterministic way

4 years agoFix asserts
Arran Cudbard-Bell [Tue, 6 Apr 2021 10:07:07 +0000 (11:07 +0100)] 
Fix asserts

4 years agoReset indent to 0 on stopped requests
Arran Cudbard-Bell [Tue, 6 Apr 2021 00:54:02 +0000 (01:54 +0100)] 
Reset indent to 0 on stopped requests

4 years agoInterpret signal marks the request as done
Arran Cudbard-Bell [Tue, 6 Apr 2021 00:38:29 +0000 (01:38 +0100)] 
Interpret signal marks the request as done

4 years agoExited child should still definitely be in the parent state
Arran Cudbard-Bell [Tue, 6 Apr 2021 00:26:21 +0000 (01:26 +0100)] 
Exited child should still definitely be in the parent state

4 years agoBetter assert
Arran Cudbard-Bell [Tue, 6 Apr 2021 00:08:02 +0000 (01:08 +0100)] 
Better assert

4 years agoCorrectly categorise messages
Arran Cudbard-Bell [Mon, 5 Apr 2021 23:33:23 +0000 (00:33 +0100)] 
Correctly categorise messages

4 years agoMuch too chatty
Arran Cudbard-Bell [Mon, 5 Apr 2021 23:31:07 +0000 (00:31 +0100)] 
Much too chatty

4 years agoUse the correct return code
Arran Cudbard-Bell [Mon, 5 Apr 2021 23:07:31 +0000 (00:07 +0100)] 
Use the correct return code

4 years agoNot all requests have clients
Arran Cudbard-Bell [Mon, 5 Apr 2021 23:01:51 +0000 (00:01 +0100)] 
Not all requests have clients

4 years agoReally can't free detached requests here...
Arran Cudbard-Bell [Mon, 5 Apr 2021 23:01:38 +0000 (00:01 +0100)] 
Really can't free detached requests here...

4 years agoEnsure we don't trash request->packet->code
Arran Cudbard-Bell [Mon, 5 Apr 2021 22:10:31 +0000 (23:10 +0100)] 
Ensure we don't trash request->packet->code

4 years agoActually need a worker pointer...
Arran Cudbard-Bell [Mon, 5 Apr 2021 21:51:48 +0000 (22:51 +0100)] 
Actually need a worker pointer...

4 years agoRemove detached requests from the time_order_heap
Arran Cudbard-Bell [Mon, 5 Apr 2021 21:48:48 +0000 (22:48 +0100)] 
Remove detached requests from the time_order_heap

4 years agoUnpick some cross dependencies with detach functions
Arran Cudbard-Bell [Mon, 5 Apr 2021 21:37:12 +0000 (22:37 +0100)] 
Unpick some cross dependencies with detach functions

4 years agoRemove assert... these requests really do need to be internal
Arran Cudbard-Bell [Mon, 5 Apr 2021 21:08:52 +0000 (22:08 +0100)] 
Remove assert... these requests really do need to be internal

4 years agoTypo
Arran Cudbard-Bell [Mon, 5 Apr 2021 20:54:35 +0000 (21:54 +0100)] 
Typo

4 years agoAdd explicit request types (external, internal, detached)
Arran Cudbard-Bell [Mon, 5 Apr 2021 20:49:52 +0000 (21:49 +0100)] 
Add explicit request types (external, internal, detached)

Add stop and detach interpreter callbacks to fix state issues

4 years agoNothing uses request_state anymore
Arran Cudbard-Bell [Mon, 5 Apr 2021 16:05:07 +0000 (17:05 +0100)] 
Nothing uses request_state anymore

4 years agoDoes DHCPv6 now too
Arran Cudbard-Bell [Mon, 5 Apr 2021 14:11:33 +0000 (15:11 +0100)] 
Does DHCPv6 now too

4 years agoQuiet clang scan
Arran Cudbard-Bell [Mon, 5 Apr 2021 13:31:45 +0000 (14:31 +0100)] 
Quiet clang scan

4 years agoTreat combo IP address attributes as normal types
Arran Cudbard-Bell [Mon, 5 Apr 2021 11:15:01 +0000 (12:15 +0100)] 
Treat combo IP address attributes as normal types

4 years agoAdd type check macros
Arran Cudbard-Bell [Sun, 4 Apr 2021 21:48:10 +0000 (22:48 +0100)] 
Add type check macros

4 years agoRework xlat code to produce FR_TYPE_NULL boxes
Arran Cudbard-Bell [Sun, 4 Apr 2021 19:20:24 +0000 (20:20 +0100)] 
Rework xlat code to produce FR_TYPE_NULL boxes

4 years agoclean up public APIs
Alan T. DeKok [Sat, 3 Apr 2021 12:17:01 +0000 (08:17 -0400)] 
clean up public APIs

move "node" functions internal to rbtree.c.

The public APIs are now:

rbtree_insert
rbtree_find
rbtree_delete

which fixes ~20 years of a bad API

4 years agojust call delete_by_data
Alan T. DeKok [Sat, 3 Apr 2021 12:14:49 +0000 (08:14 -0400)] 
just call delete_by_data

4 years agojust call "delete by data" instead of two separate calls
Alan T. DeKok [Sat, 3 Apr 2021 12:11:35 +0000 (08:11 -0400)] 
just call "delete by data" instead of two separate calls

4 years agono need to call insert_node, just insert is fine
Alan T. DeKok [Sat, 3 Apr 2021 12:08:18 +0000 (08:08 -0400)] 
no need to call insert_node, just insert is fine

4 years agoall external requests MUST have a listener
Alan T. DeKok [Fri, 2 Apr 2021 10:21:41 +0000 (06:21 -0400)] 
all external requests MUST have a listener

the listener is only cleaned up when the worker side informs
the network side that all outstanding requests are finished.

4 years agoFix typo (#4047)
Jorge Pereira [Fri, 2 Apr 2021 22:45:21 +0000 (19:45 -0300)] 
Fix typo (#4047)

4 years agoReturn error when we fail to parse a template
Arran Cudbard-Bell [Fri, 2 Apr 2021 17:49:02 +0000 (18:49 +0100)] 
Return error when we fail to parse a template

4 years agoTypo
Arran Cudbard-Bell [Fri, 2 Apr 2021 17:48:35 +0000 (18:48 +0100)] 
Typo

4 years agoCall the repeat func first if we have no initial func
Arran Cudbard-Bell [Fri, 2 Apr 2021 17:36:34 +0000 (18:36 +0100)] 
Call the repeat func first if we have no initial func

4 years agoMissing header
Arran Cudbard-Bell [Fri, 2 Apr 2021 17:22:51 +0000 (18:22 +0100)] 
Missing header

4 years agoThread interpreter may be NULL
Arran Cudbard-Bell [Fri, 2 Apr 2021 17:18:55 +0000 (18:18 +0100)] 
Thread interpreter may be NULL

4 years agoRun triggers synchronously in certain situations
Arran Cudbard-Bell [Fri, 2 Apr 2021 17:07:25 +0000 (18:07 +0100)] 
Run triggers synchronously in certain situations

4 years agoDon't SEGV if we don't have a parent and experience an error
Arran Cudbard-Bell [Fri, 2 Apr 2021 15:35:41 +0000 (16:35 +0100)] 
Don't SEGV if we don't have a parent and experience an error

4 years agoDon't detach if already detached
Arran Cudbard-Bell [Fri, 2 Apr 2021 14:55:53 +0000 (15:55 +0100)] 
Don't detach if already detached

4 years agoAllow worker to set a default interpreter for a thread
Arran Cudbard-Bell [Fri, 2 Apr 2021 12:41:16 +0000 (13:41 +0100)] 
Allow worker to set a default interpreter for a thread

4 years agoCopy the interpreter from the parent
Arran Cudbard-Bell [Fri, 2 Apr 2021 12:20:24 +0000 (13:20 +0100)] 
Copy the interpreter from the parent

4 years agoFixup trigger code
Arran Cudbard-Bell [Fri, 2 Apr 2021 12:06:27 +0000 (13:06 +0100)] 
Fixup trigger code

4 years agoset LIBRARY_EXT if it's not already set
Alan T. DeKok [Fri, 2 Apr 2021 09:52:01 +0000 (05:52 -0400)] 
set LIBRARY_EXT if it's not already set

4 years agoreturn PUSHED_CHILD, not YIELD
Alan T. DeKok [Wed, 31 Mar 2021 15:40:06 +0000 (11:40 -0400)] 
return PUSHED_CHILD, not YIELD

which saves another bounce through the event loop

4 years agosuppress leaks on OSX
Alan T. DeKok [Wed, 31 Mar 2021 15:39:41 +0000 (11:39 -0400)] 
suppress leaks on OSX

4 years agoMove MAC validation into eap-sim/aka/aka' module
Arran Cudbard-Bell [Thu, 1 Apr 2021 22:10:10 +0000 (23:10 +0100)] 
Move MAC validation into eap-sim/aka/aka' module

4 years agoSet IDs correctly
Arran Cudbard-Bell [Thu, 1 Apr 2021 21:40:43 +0000 (22:40 +0100)] 
Set IDs correctly

4 years agoMore debugging
Arran Cudbard-Bell [Thu, 1 Apr 2021 21:40:29 +0000 (22:40 +0100)] 
More debugging

4 years agoMove checkcode calculations from state machine to module
Arran Cudbard-Bell [Thu, 1 Apr 2021 16:32:15 +0000 (17:32 +0100)] 
Move checkcode calculations from state machine to module

4 years agoUse correct expected MK length
Arran Cudbard-Bell [Thu, 1 Apr 2021 16:31:10 +0000 (17:31 +0100)] 
Use correct expected MK length

4 years agoand another one...
Arran Cudbard-Bell [Wed, 31 Mar 2021 21:58:11 +0000 (22:58 +0100)] 
and another one...

4 years agoRemove debugging statements
Arran Cudbard-Bell [Wed, 31 Mar 2021 21:55:46 +0000 (22:55 +0100)] 
Remove debugging statements

4 years agoUse cmp macro in more places to fix ordering issues
Arran Cudbard-Bell [Wed, 31 Mar 2021 21:53:51 +0000 (22:53 +0100)] 
Use cmp macro in more places to fix ordering issues

4 years agoDon't update MK, we still need the original for storing new fast reauth IDs
Arran Cudbard-Bell [Wed, 31 Mar 2021 21:52:10 +0000 (22:52 +0100)] 
Don't update MK, we still need the original for storing new fast reauth IDs

4 years agoAdd debugging functions for the next time we have issues with dictionary ref counts
Arran Cudbard-Bell [Wed, 31 Mar 2021 20:43:02 +0000 (21:43 +0100)] 
Add debugging functions for the next time we have issues with dictionary ref counts

4 years agoIncrement instance count when initialising unlang
Arran Cudbard-Bell [Wed, 31 Mar 2021 20:39:31 +0000 (21:39 +0100)] 
Increment instance count when initialising unlang

4 years agoAdditional EAP-SIM regression test
Arran Cudbard-Bell [Wed, 31 Mar 2021 20:38:59 +0000 (21:38 +0100)] 
Additional EAP-SIM regression test

4 years agoRework EAP-AKA' to provide a truncated MK for session resumption
Arran Cudbard-Bell [Wed, 31 Mar 2021 16:58:34 +0000 (17:58 +0100)] 
Rework EAP-AKA' to provide a truncated MK for session resumption

This now makes EAP-AKA' capable of session resumption

4 years agoLet not used
Arran Cudbard-Bell [Wed, 31 Mar 2021 15:25:33 +0000 (16:25 +0100)] 
Let not used

4 years agoInitialise OpenSSL in unit_test_attribute prior to loading other libraries that might...
Arran Cudbard-Bell [Wed, 31 Mar 2021 14:16:22 +0000 (15:16 +0100)] 
Initialise OpenSSL in unit_test_attribute prior to loading other libraries that might also initialise OpenSSL

4 years agoRename thread_local to atexit
Arran Cudbard-Bell [Wed, 31 Mar 2021 12:51:25 +0000 (13:51 +0100)] 
Rename thread_local to atexit

4 years agoAdd function to explicitly trigger all thread local destructors
Arran Cudbard-Bell [Wed, 31 Mar 2021 12:42:06 +0000 (13:42 +0100)] 
Add function to explicitly trigger all thread local destructors

4 years agoAdd debug output for thread local code
Arran Cudbard-Bell [Wed, 31 Mar 2021 08:50:36 +0000 (09:50 +0100)] 
Add debug output for thread local code

4 years agoshut up static analyzer
Alan T. DeKok [Wed, 31 Mar 2021 12:21:52 +0000 (08:21 -0400)] 
shut up static analyzer

4 years agostart of cond_eval_async()
Alan T. DeKok [Tue, 30 Mar 2021 17:15:20 +0000 (13:15 -0400)] 
start of cond_eval_async()

4 years agoRemove request->backlog
Arran Cudbard-Bell [Tue, 30 Mar 2021 10:22:22 +0000 (11:22 +0100)] 
Remove request->backlog

4 years agoUse the $(MAKE) expansion, not `make` else we'll likely end up running the system...
Arran Cudbard-Bell [Tue, 30 Mar 2021 10:21:23 +0000 (11:21 +0100)] 
Use the $(MAKE) expansion, not `make` else we'll likely end up running the system version of make

Which in macos is still 3.81

4 years agodon't load make libraries for "clean".
Alan T. DeKok [Mon, 29 Mar 2021 20:58:55 +0000 (16:58 -0400)] 
don't load make libraries for "clean".

and strip the -fsanitize=... options from the libfreeradius-make
libraries, as GNU Make isn't built with the address/leak sanitizer

4 years agono need to call cond_eval_map()
Alan T. DeKok [Mon, 29 Mar 2021 19:06:25 +0000 (15:06 -0400)] 
no need to call cond_eval_map()

4 years agocache if this condition requires async expansion
Alan T. DeKok [Mon, 29 Mar 2021 16:13:21 +0000 (12:13 -0400)] 
cache if this condition requires async expansion

4 years agoremove depth and condition count after doing validation tests
Alan T. DeKok [Mon, 29 Mar 2021 15:14:35 +0000 (11:14 -0400)] 
remove depth and condition count after doing validation tests

4 years agoFix unused variable
Arran Cudbard-Bell [Mon, 29 Mar 2021 18:52:50 +0000 (19:52 +0100)] 
Fix unused variable

4 years agoRemove more references to "backlog"
Arran Cudbard-Bell [Mon, 29 Mar 2021 16:16:52 +0000 (17:16 +0100)] 
Remove more references to "backlog"

4 years agodon't run unlang_subrequest_child_run multiple times if the child isn't freed immediately
Arran Cudbard-Bell [Mon, 29 Mar 2021 16:16:40 +0000 (17:16 +0100)] 
don't run unlang_subrequest_child_run multiple times if the child isn't freed immediately

4 years agoMove the majority of the SIM/AKA/AKA' logic into process modules
Arran Cudbard-Bell [Mon, 29 Mar 2021 16:16:10 +0000 (17:16 +0100)] 
Move the majority of the SIM/AKA/AKA' logic into process modules

4 years agostandardise encode_ctx vs encoder_ctx and decode_ctx vs decoder_ctx
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:46:34 +0000 (15:46 +0100)] 
standardise encode_ctx vs encoder_ctx and decode_ctx vs decoder_ctx

4 years agoAvoid allocating a new EVP_CIPHER_CTX for every operation
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:43:42 +0000 (15:43 +0100)] 
Avoid allocating a new EVP_CIPHER_CTX for every operation

4 years agoBetter way to free detached requests
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:41:07 +0000 (15:41 +0100)] 
Better way to free detached requests

4 years agoUse a single code path when stopping requests
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:40:48 +0000 (15:40 +0100)] 
Use a single code path when stopping requests

Instead of a bunch of them, and miss critical cleanup phases

4 years agoDon't crash if we can't find the right public module symbol
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:39:12 +0000 (15:39 +0100)] 
Don't crash if we can't find the right public module symbol

4 years agoTypo in pair.h (pairs were being prepended not appended)
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:38:53 +0000 (15:38 +0100)] 
Typo in pair.h (pairs were being prepended not appended)

4 years agoFix issue in request.c with -M flag
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:38:32 +0000 (15:38 +0100)] 
Fix issue in request.c with -M flag

4 years agoMark up lengths as unsigned
Arran Cudbard-Bell [Mon, 29 Mar 2021 10:23:30 +0000 (11:23 +0100)] 
Mark up lengths as unsigned

4 years agoFree detached requests when they're done
Arran Cudbard-Bell [Mon, 29 Mar 2021 10:22:11 +0000 (11:22 +0100)] 
Free detached requests when they're done

4 years agoBetter error message
Arran Cudbard-Bell [Mon, 29 Mar 2021 10:21:47 +0000 (11:21 +0100)] 
Better error message

4 years agoAdd functions for removing and freeing an item in a dlist
Arran Cudbard-Bell [Mon, 29 Mar 2021 10:21:13 +0000 (11:21 +0100)] 
Add functions for removing and freeing an item in a dlist

4 years agoAdd missing line prefix for L_DBG_INFO
Arran Cudbard-Bell [Mon, 29 Mar 2021 10:19:36 +0000 (11:19 +0100)] 
Add missing line prefix for L_DBG_INFO

4 years agore-enable make dl libraries
Alan T. DeKok [Mon, 29 Mar 2021 13:59:13 +0000 (09:59 -0400)] 
re-enable make dl libraries

4 years agodon't hoist things too far
Alan T. DeKok [Mon, 29 Mar 2021 13:22:21 +0000 (09:22 -0400)] 
don't hoist things too far

do less hoisting during normalization.  Do one last set of
hoisting just before we return.

4 years agocomment out dlopen stuff
Alan T. DeKok [Mon, 29 Mar 2021 12:58:13 +0000 (08:58 -0400)] 
comment out dlopen stuff

until we figure out why builds are failing

4 years agocalculate total depth, and number of conditions
Alan T. DeKok [Mon, 29 Mar 2021 12:36:40 +0000 (08:36 -0400)] 
calculate total depth, and number of conditions

needed to evaluate the conditional tree

4 years agoconditionally load plugins
Alan T. DeKok [Mon, 29 Mar 2021 11:28:45 +0000 (07:28 -0400)] 
conditionally load plugins

until such time as we find out why CI fails with an error about
autoconf.h