Move name from interface to tunnel

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Fix paren typo

"I am very anti-paren." --Eric

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Nuke trailing spaces

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

providerConfiguration is now a WgQuickConfig

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Do not require NetworkExtension to know its own name

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

All migration stuff moved to one gross file

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Simplify versioning of stored data

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Get rid of superflous isActivateOnDemandEnabled key

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Updated NETunnelProvider save format

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

NE: simplify logic

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

NE: Simplify DNS resolution

Signed-off-by: Roopesh Chander <roop@roopc.net>

Localize all the things

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel detail: iPad: Handle deletion of tunnel correctly

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: Update listen port only when first interface changes

When handling network path changes, change the listen port
only when the first interface has changed.

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: Change handling of bad domain names and Activate On Demand

The solution implemented in commit b8c331c causes the tunnel to
remain in 'Activating' state, without the ability to cancel that.

So, in this commit, instead of retrying DNS silently on
Activated-On-Demand tunnels, we fail the startTunnel() silently.

To summarize, if activate-on-demand is on:
- If started from the WireGuard app, show error using lastErrorFile
mechanism, suggesting a way to turn off Activate On Demand
- If not started from WireGuard app, don't call displayMessage()
(don't show error to user) and silently fail starting the tunnel

Signed-off-by: Roopesh Chander <roop@roopc.net>

Added missing param in MockTunnels

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

wireguard-go-bridge: SDK_DIR is not defined for simulator

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Enabled more swiftlint rules

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Added a String->[String] helper

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

TunnelErrors: Remove unused error

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel edit: init() need not take a tunnelConfiguration argument

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: Log whether tunnel was activated from the app or not

Signed-off-by: Roopesh Chander <roop@roopc.net>

Remove non-helpful comments

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel edit: Fix comment

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: If only Activate On Demand has changed, don't restart tunnel

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: Handle bad domain names and Activate On Demand

This combination causes iOS to keep trying to bring up the tunnel,
leading to a lot of displayMessage() alerts.

In this fix, if we get a DNS resolution error in an Activate On Demand
enabled tunnel, we silently retry 9 times (with a 4-second delay before
each retry) and then show the displayMessage() alert.

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: No need for two startTunnel() methods

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Handle waiting on a stale tunnel

If we have a stale tunnel on which we don't get status updates we rely
on a timer to update the status (see commit 34a7e5b).  Previously, if
the user tries to activate another tunnel, that resulted in both tunnels
waiting indefinitely. This commit fixes that.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Remove buttons and text from LaunchScreen.storyboard

With state restoration, we're not guaranteed that the
list view will get shown immediately after the launch screen.
So, generalize the launch screen as much as possible.

Signed-off-by: Roopesh Chander <roop@roopc.net>

s/Observervation/Observation/g;

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel detail: Update restorationIdentifier when tunnel name changes

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Add periods to end the system error messages

Because they can be part of a multi-sentence message when displayed
in the alert.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error handling: Add info on the underlying system error to error alerts

Signed-off-by: Roopesh Chander <roop@roopc.net>

Version bump

This is our first release to the real app store.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Got TunnelsManager back under the max file length by splitting out NEVPNStatus+CustomStringConvertible

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Potential fix for insertRowAtIndexPath crash

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

More proper way to get sdk root directory

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Further generalize makefile

This should allow us to eventually build on macOS

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Bump the go runtime

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Improve mock tunnels generation

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Provide mock tunnels for the Simulator

To help in generation of screenshots for the App Store

Signed-off-by: Roopesh Chander <roop@roopc.net>

Nuke duplicate file

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Bump the go runtime

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Version bump

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Fixed editable KeyValueCells being copyable
Fixed DNS servers not saving

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Fix confusing indentation

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

KeyValueCells now share code

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Reorganized project structure

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Most similar views now shared between ViewControllers

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Prettier log time format

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Simplify logging tags

This was roop's initial idea, and it turns out to be the better one, now
that we can pass cstrings more easily.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Fix tunnel remaining in 'Activating' state

It uses to remain in 'Activating' state when we don't get a status
update notification, for example, when turning on the tunnel repeatedly
without Internet connectivity.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Fix status switch weird state after an error occurs

Signed-off-by: Roopesh Chander <roop@roopc.net>

Deduplicate functions

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Simplify filemanager extension

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Can't -> cannot

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

NE: Communicate last error to app through a shared file

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: startActivation() need not take a tunnelConfiguration

Signed-off-by: Roopesh Chander <roop@roopc.net>

Localize swiftlint

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Reorganized ViewControllers (split out UIViews and UITableViewCells into their own classes)
All swiftlint warnings except one fixed up

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Avoid escaping heap allocation

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Tidy up str to gostr conversion

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

TunnelsManager: Remove mentions of 'internal error'

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Ask to check Internet connectivity in error alert

Signed-off-by: Roopesh Chander <roop@roopc.net>

Remove unused code: InternetReachability

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Remove unused variable

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Remove assert

Signed-off-by: Roopesh Chander <roop@roopc.net>

Simplify C strings

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

TunnelsManager: Fix race between multiple startActivation() calls

After startActivate() is called on a waiting tunnel, user might turn
on a different tunnel before the waiting tunnel's status gets updated.
This fix prevents that from happening.

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Reintroduce waiting for another tunnel to deactivate

Signed-off-by: Roopesh Chander <roop@roopc.net>

Rewrite Logger

This reverts all of Roop's changes to the C code, and then rewrites the
logger logic to be cleaner.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

More reliable logo sizing

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

TunnelsManager: Report activation errors through the activationDelegate

Don't report activation errors through completion handlers

Signed-off-by: Roopesh Chander <roop@roopc.net>

Logging: Write versions from both app and extension

Signed-off-by: Roopesh Chander <roop@roopc.net>

Logging: file_log doesn't need the message type

Signed-off-by: Roopesh Chander <roop@roopc.net>

Logging: Tag the entries in the merged log

So we know which entry is from the app and which is from the network
extension.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Logging: Use ringlogger for logging from the app

Signed-off-by: Roopesh Chander <roop@roopc.net>

Logging: ringlogger.c: Trim trailing newlines

Signed-off-by: Roopesh Chander <roop@roopc.net>

Logging: Use ringlogger for logging from the extension

Signed-off-by: Roopesh Chander <roop@roopc.net>

Avoid using 'VPN' in code where possible

Signed-off-by: Roopesh Chander <roop@roopc.net>

mv WireGuard/WireGuard/VPN/ WireGuard/WireGuard/Tunnel/

Signed-off-by: Roopesh Chander <roop@roopc.net>

Commit untested ringlogger code

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Remove useless whitespace

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Settings: better padding calculation

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Fixed hacky logo display for settings

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

More formatting nits and cyclomatic complexity fixes

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

More linter warnings fixed, enabled more swiftlint rules, project cleanup

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Tons more swiftlint warnings fixed. Still a few remaining.

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Added swiftlint and fixed all errors (and a bunch, but not all, warnings)

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Zip importing: importFromFile should take a completionHandler

Deletion of the being-imported file should be done in the
completionHandler.

Signed-off-by: Roopesh Chander <roop@roopc.net>

ErrorPresenter: Support onPresented for showErrorAlert(title:,message:)

Signed-off-by: Roopesh Chander <roop@roopc.net>

Zip importing: Handle spaces in filenames correctly

Previously, if a filename of a .conf file inside the zip file
contained spaces, it was not imported.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Supply missing pieces of path change

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Fixed a potential race condition, better naming on PacketTunnelSettingsGenerator methods

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Added an (unfinished) NWPathMonitor implementation for reconnecting on network changes

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Revert pure-go network monitoring and add wgSetConfig

This reverts commit 99f0e457c34480f25582d7b4ed509404712c648c and adds a
function too.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

State restoration: Don't create duplicate mainVC and tunnelsListVC

This creates a duplicate tunnels manager, leading to problems tracking
tunnel statuses.

To reproduce the bug that this commit fixes, you can do the following:
1. Remove all tunnels
2. Run in Xcode
3. Import zip with ~10 tunnels
4. Stop app in Xcode
5. Run in Xcode
6. Turn on 1st tunnel, after it's on, turn off
Turn on 2nd tunnel, after it's on, turn off
...
After 6-8 tunnels, the spinner doesn't show up, indicating that the
status is not being tracked.

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Error out only on no-internet scenario

The other scenario happens even during reloading of a tunnel for activation.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Remove the feature of waiting for another tunnel to deactivate

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Deactivate only when the status becomes 'connected'

Signed-off-by: Roopesh Chander <roop@roopc.net>