Stefan Knoblich [Mon, 21 Jan 2013 22:18:16 +0000 (23:18 +0100)]
mod_fsv: Check audio/video frame size for possible buffer overflow and abort playback
Audio frame sizes were already being checked for overflow,
but video frame sizes were taken as-is, which would
lead to heap corruption.
In case an overflow has been detected, playback is aborted immediately as
there is no way we can ever recover from such a situation due to the lack
of a (well-known) frame header signature that could be used to skip over
the corrupted part of the streams.
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
William King [Tue, 15 Jan 2013 21:22:28 +0000 (13:22 -0800)]
FS-3882, FS-3546, FS-3712, FS-3970: --resolve Fixes the segfault in mod_rtmp where the channel was destroyed, but the endpoint still tried to send or receive data from the session.
Stefan Knoblich [Mon, 14 Jan 2013 14:01:39 +0000 (15:01 +0100)]
mod_sofia: Follow-up fix for FS-5009 to avoid NULL-ptr dereference
Commit f913670e changed switch_core_session_sprintf() args
from sip->sip_to to sip->sip_from, but didn't update the enclosing if()
clause protecting the code from dereferencing NULL pointers.
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
Stefan Knoblich [Wed, 9 Jan 2013 23:29:08 +0000 (00:29 +0100)]
mod_event_zmq: Use sed to patch configure.in to use AC_CONFIG_HEADERS
AM_CONFIG_HEADER is deprecated in automake 1.13.1 (and temporarily not available in 1.13),
the replacement is available in autoconf-2.59 (and maybe before).
NOTE: Remove sed hackery when upstream has released a fixed version
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
Stefan Knoblich [Wed, 9 Jan 2013 23:12:08 +0000 (00:12 +0100)]
mod_soundtouch: Use sed to patch configure.ac to use AC_CONFIG_HEADERS
AM_CONFIG_HEADER is deprecated in automake 1.13.1 (and temporarily not available in 1.13),
the replacement is available in autoconf-2.59 (and maybe before).
NOTE: Remove sed hackery when upstream has released a fixed version (> 1.7.0)
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
Stefan Knoblich [Mon, 7 Jan 2013 17:04:00 +0000 (18:04 +0100)]
ftmod_misdn: Fix brown paperbag logic bug in handle_b_channel_event()
Yeah, right, discard the incoming audio data when the b-channel is active...
Reverse the check, so ftdm_read() on an active mISDN b-channel will
be able to read audio data from the RX socketpair and not kill
the call from repeatedly timing out in poll().
Fixes:
[WARNING] mod_freetdm.c:775 Too many timeouts while waiting I/O in channel FreeTDM/1:1/XX device 1:1!
[ERR] mod_freetdm.c:820 clearing IO in channel FreeTDM/1:1/XX device 1:1!
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
Stefan Knoblich [Mon, 7 Jan 2013 12:24:01 +0000 (13:24 +0100)]
ftmod_misdn: Retry recvfrom() in case of EAGAIN
epoll_wait() on the B-channel socket may indicate pending messages, but
recvfrom() returns EAGAIN. Retry a few more times (up to 5 retries)
to get the pending message.
Signed-off-by: Stefan Knoblich <stkn@openisdn.net>
Stefan Knoblich [Sun, 6 Jan 2013 12:47:06 +0000 (13:47 +0100)]
ftmod_misdn: Fix %lx vs.__u64 format string error
Fixes:
src/ftmod/ftmod_misdn/ftmod_misdn.c:924:3: error: format '%lx' expects
argument of type 'long unsigned int', but argument 13 has type '__u64'
[-Werror=format]
Signed-off-by: Stefan Knoblich <stkn@openisdn.net> Reported-by: hyper_ch #freetdm @ irc.freenode.net
Travis Cross [Thu, 3 Jan 2013 17:38:28 +0000 (17:38 +0000)]
Fix mod_mongo build when no CFLAGS/CXXFLAGS are set in environment
os.environ['CFLAGS'] raises a KeyError if no CFLAGS variable is set in
the environment. So instead we use os.environ.get('CFLAGS','') which
will return the empty string in the event no CFLAGS variable is set.
The previous problematic pattern originated from the suggested code
here for importing the build environment in SCons: