Florian Forster [Wed, 8 Feb 2012 09:25:59 +0000 (10:25 +0100)]
write_graphite plugin: Decrese buffer size.
The larger the buffer, the longer you need to wait for the data to be written
to Carbon. The new buffer size assumes an MTU of 1500 bytes (Ethernet payload)
and keeps margins for IPv6 and TCP (with timestamps). This should decrease the
number of packets needed (because data is now cleanly aligned to the packet
size) and decrease the overall time spent buffered.
Florian Forster [Tue, 7 Feb 2012 17:19:20 +0000 (18:19 +0100)]
write_graphite plugin: Implement the "AlwaysAppendDS" option.
Don't append DS name by default, except when there is more than one DS.
The "AlwaysAppendDS" option can be used to force the plugin to always
append the DS.
Florian Forster [Fri, 3 Feb 2012 09:54:58 +0000 (10:54 +0100)]
write_graphite plugin: Fix locking.
wg_send_buffer() is called from wg_flush_nolock(). When calling
wg_flush_nolock(), the thread has to hold cb->send_lock. Locking it again
will fail, but this condition is not checked for. Then the lock is
released twice which may result in concurrency issues.
Florian Forster [Fri, 3 Feb 2012 09:34:51 +0000 (10:34 +0100)]
write_graphite plugin: Escape *all* the things!
Dots and spaces can appear anywhere, e.g. spaces in hostnames and dots in type
instances. Escape them all to avoid unintended special treatment by Carbon /
Graphite.
Bostjan Skufca [Fri, 3 Feb 2012 02:10:08 +0000 (03:10 +0100)]
Changes in irq plugin:
- fixes errors described here: http://mailman.verplant.org/pipermail/collectd/2011-July/004638.html
- refactored parsing code in order to make it a bit more intuitive
- added a few additional comments
Florian Forster [Thu, 2 Feb 2012 16:39:21 +0000 (17:39 +0100)]
write_graphite plugin: Improve Hostname / Port handling.
Use getaddrinfo(3) for hostname lookup -- this also adds IPv6 compatibility.
Switch the internal names to node / service, to follow the terminology used by
getaddrinfo(3). Use cf_util_get_string() rather than implementing our own.
Allow service names in addition to port numbers.
Chris Lundquist [Fri, 13 Jan 2012 22:33:29 +0000 (14:33 -0800)]
compiles cleanly. libmongoc doesn't have an install target, will try to commit one there instead of having to hack the directory stucture to please ./configure.
Jonathan Nieder [Mon, 9 Jan 2012 18:01:50 +0000 (19:01 +0100)]
common: check_create_dir(): Support symlinks as well.
Previously, the following situation would cause an endless look (as reported
by Michael Prokop in Debian bug #619123): the (CSV or RRD) datadir is a
symlink pointing to a non-existent target.
With this patch applied, check_create_dir() fails with "<file> exists but is
not a directory".
Sebastian Harl [Mon, 9 Jan 2012 10:16:19 +0000 (11:16 +0100)]
build system, ipvs plugin: Check for linux/ip_vs.h as well.
Also, try to find ip_vs.h without using KERNEL_CFLAGS at first. The Linux
kernel headers should not be used directly -- in current kernel versions this
generates warnings leading to build failures because of -Werror.
Toni Ylenius [Fri, 6 Jan 2012 16:13:56 +0000 (18:13 +0200)]
df: Set negative free space values to zero.
Some file systems (eg. UFS) may report negative free spave values.
Previously this caused underflow, but now it is prevented by setting
negative values to zero.
The former is a simple key/value lookup, while the latter
triggers a method call and yields the result.
Operations have signatures, they can be fed an array of
parameters. For now, calls are triggered assuming
there are no parameters. Later a separate keyword
`Operation` can be introduced, taking a list of
`Parameter` directives specifying type and values
to feed to the MBean operation.
Aaron Brady [Sun, 15 Jan 2012 13:16:37 +0000 (13:16 +0000)]
Migration: Ensure destination directories exist when moving RRDs
If you have not run collectd 5 before, then when type instances
are migrated to plugin instances the destination directories
may not already exist. For example:
Florian Forster [Fri, 25 Nov 2011 09:48:22 +0000 (10:48 +0100)]
Merge "Fix file:// not working as return code is 0 and not 200, as fixed beforehand in curl_json. Remove mention of http in documention as file also works now (and ftp most likely too)" into collectd-4.10
Fabien Wernli [Fri, 4 Nov 2011 10:25:59 +0000 (11:25 +0100)]
Fix file:// not working as return code is 0 and not 200, as fixed
beforehand in curl_json.
Remove mention of http in documention as file also works now (and ftp most likely too)
Scott Sanders [Fri, 18 Nov 2011 16:11:35 +0000 (11:11 -0500)]
Add patch from jimmyattime (issue #8)
This is certainly no worse than the previous usage of
pthread_mutex_lock, and will prevent the plugin from blocking. I'd like
to add better handling of failed locks in future commits.
Scott Sanders [Sun, 9 Oct 2011 23:08:27 +0000 (19:08 -0400)]
Prefix is no longer a required directive
While useful, the user should not be required to provide a prefix.
Having the hosts as the top level containers may make sense in some
environments. The current format is "${prefix}${hostname}${postfix}" so
be careful to add dots where needed.
Scott Sanders [Sun, 9 Oct 2011 23:02:06 +0000 (19:02 -0400)]
Allow the user to append a string to the hostname
The user should be able to append a string to the hostname to provide
better organization if they wish. The directive used to set this option
is Postfix.