]> git.ipfire.org Git - thirdparty/kea.git/log
thirdparty/kea.git
17 months ago[#3025] fix ProcessSpawn on BSD
Andrei Pavel [Fri, 23 Feb 2024 18:01:00 +0000 (20:01 +0200)] 
[#3025] fix ProcessSpawn on BSD

- Always break after collecting exit status. Previously it broke the
  loop always on failure of waitpid which does happen after calling it
  subsequently, but there is no reason to wait until then.
- When waitpid returns -1 in sync mode, throw exception, except for
  EINTR which happens on signals (usually one time) prior to
  the child process exiting if sigaction is called without SA_RESTART
  which is the default on some systems.
- Only initialize the global IO signal set on the IO service in async
  mode. It makes no sense to do it in sync mode because there is no IO service.
- Swap pid and wpid names to conform to names in `man wait` on BSD.
- Add FAIL() on timer expiration.
- Don't call runOne() the third time in unit tests because it waits for
  the timer to expire.

17 months ago[#3141] addressed review comments
Piotrek Zadroga [Fri, 23 Feb 2024 15:59:15 +0000 (16:59 +0100)] 
[#3141] addressed review comments

- Mostly further corrections in ARM docs and in comments.

17 months ago[#3141] addressed review comments
Piotrek Zadroga [Fri, 23 Feb 2024 14:23:51 +0000 (15:23 +0100)] 
[#3141] addressed review comments

- refactored code of SvcParam config parser
- added new 2 UTs
- added some more comments in code

17 months ago[#3141] addressed review comments
Piotrek Zadroga [Fri, 23 Feb 2024 09:41:57 +0000 (10:41 +0100)] 
[#3141] addressed review comments

- Rephrased some text in ARM docs.
- Added new text to ARM docs.

17 months ago[#3141] fix compilation error
Piotrek Zadroga [Thu, 22 Feb 2024 14:16:20 +0000 (15:16 +0100)] 
[#3141] fix compilation error

17 months ago[#3141] ChangeLog entry
Piotrek Zadroga [Tue, 20 Feb 2024 13:49:55 +0000 (14:49 +0100)] 
[#3141] ChangeLog entry

17 months ago[#3141] ARM docs updated
Piotrek Zadroga [Tue, 20 Feb 2024 13:42:58 +0000 (14:42 +0100)] 
[#3141] ARM docs updated

17 months ago[#3141] delete excessive dnr.json examples
Piotrek Zadroga [Tue, 20 Feb 2024 11:09:26 +0000 (12:09 +0100)] 
[#3141] delete excessive dnr.json examples

17 months ago[#3141] json examples update
Piotrek Zadroga [Tue, 20 Feb 2024 11:08:35 +0000 (12:08 +0100)] 
[#3141] json examples update

17 months ago[#3141] restore delimiter escaping
Piotrek Zadroga [Tue, 20 Feb 2024 09:29:09 +0000 (10:29 +0100)] 
[#3141] restore delimiter escaping

17 months ago[#3141] provide RFC in comments
Piotrek Zadroga [Mon, 19 Feb 2024 21:33:15 +0000 (22:33 +0100)] 
[#3141] provide RFC in comments

17 months ago[#3141] DNRv4 UTs edited
Piotrek Zadroga [Mon, 19 Feb 2024 20:15:48 +0000 (21:15 +0100)] 
[#3141] DNRv4 UTs edited

17 months ago[#3141] option definition UTs fix
Piotrek Zadroga [Mon, 19 Feb 2024 10:44:02 +0000 (11:44 +0100)] 
[#3141] option definition UTs fix

17 months ago[#3141] DNRv6 UTs edited
Piotrek Zadroga [Fri, 16 Feb 2024 19:39:14 +0000 (20:39 +0100)] 
[#3141] DNRv6 UTs edited

17 months ago[#3141] unpack SvcParams from hex data
Piotrek Zadroga [Fri, 16 Feb 2024 19:25:21 +0000 (20:25 +0100)] 
[#3141] unpack SvcParams from hex data

17 months ago[#3141] DNRv4 config parser
Piotrek Zadroga [Thu, 15 Feb 2024 19:19:17 +0000 (20:19 +0100)] 
[#3141] DNRv4 config parser

17 months ago[#3141] pack SvcParams to buffer
Piotrek Zadroga [Thu, 15 Feb 2024 11:34:37 +0000 (12:34 +0100)] 
[#3141] pack SvcParams to buffer

17 months ago[#3141] unpack dohpath SvcParam
Piotrek Zadroga [Wed, 14 Feb 2024 21:57:13 +0000 (22:57 +0100)] 
[#3141] unpack dohpath SvcParam

17 months ago[#3141] unpack port SvcParam
Piotrek Zadroga [Wed, 14 Feb 2024 12:44:09 +0000 (13:44 +0100)] 
[#3141] unpack port SvcParam

17 months ago[#3141] unpack alpn SvcParam
Piotrek Zadroga [Wed, 14 Feb 2024 11:14:25 +0000 (12:14 +0100)] 
[#3141] unpack alpn SvcParam

17 months ago[#3141] config parser wip
Piotrek Zadroga [Tue, 13 Feb 2024 18:02:17 +0000 (19:02 +0100)] 
[#3141] config parser wip

17 months ago[#3141] added ALPN-IDs
Piotrek Zadroga [Mon, 12 Feb 2024 21:19:40 +0000 (22:19 +0100)] 
[#3141] added ALPN-IDs

17 months ago[#3141] config parsers boilerplate
Piotrek Zadroga [Mon, 12 Feb 2024 21:04:39 +0000 (22:04 +0100)] 
[#3141] config parsers boilerplate

17 months ago[#3141] make dnr options type internal
Piotrek Zadroga [Mon, 12 Feb 2024 13:14:44 +0000 (14:14 +0100)] 
[#3141] make dnr options type internal

17 months ago[#3141] List of Service Parametes (DNR) added
Tomek Mrugalski [Mon, 29 Jan 2024 13:26:43 +0000 (14:26 +0100)] 
[#3141] List of Service Parametes (DNR) added

17 months ago[#3141] Doc updated for v6 DNR option
Tomek Mrugalski [Mon, 29 Jan 2024 12:42:17 +0000 (13:42 +0100)] 
[#3141] Doc updated for v6 DNR option

17 months ago[#3141] ARM updated
Tomek Mrugalski [Thu, 25 Jan 2024 13:26:05 +0000 (14:26 +0100)] 
[#3141] ARM updated

 - Added DNR description
 - added to list of supported RFCs
 - Also removed one server limitation that's no longer valid
   (because we have ping-check). Not related, but small enough.

17 months ago[#3245] Minor UT change
Thomas Markwalder [Thu, 22 Feb 2024 21:57:42 +0000 (16:57 -0500)] 
[#3245] Minor UT change

modified:   src/hooks/dhcp/perfmon/tests/monitored_duration_unittests.cc

17 months ago[#3245] Wordiing fix
Thomas Markwalder [Thu, 22 Feb 2024 20:30:01 +0000 (15:30 -0500)] 
[#3245] Wordiing fix

modified:   pkt_filter_lpf.cc

17 months ago[#3245] addressed review
Razvan Becheriu [Thu, 22 Feb 2024 19:23:58 +0000 (21:23 +0200)] 
[#3245] addressed review

17 months ago[#3245] Remove wrong doxygen use in UT
Thomas Markwalder [Wed, 21 Feb 2024 16:46:35 +0000 (11:46 -0500)] 
[#3245] Remove wrong doxygen use in UT

modified:   alarm_unittests.cc
modified:   monitored_duration_unittests.cc

17 months ago[#3245] Moved Alarm into own files
Thomas Markwalder [Wed, 21 Feb 2024 12:43:18 +0000 (07:43 -0500)] 
[#3245] Moved Alarm into own files

new file:   src/hooks/dhcp/perfmon/alarm.cc
new file:   src/hooks/dhcp/perfmon/alarm.h
new file:   src/hooks/dhcp/perfmon/tests/alarm_unittests.cc

modified:   src/hooks/dhcp/perfmon/Makefile.am
modified:   src/hooks/dhcp/perfmon/monitored_duration.cc
modified:   src/hooks/dhcp/perfmon/monitored_duration.h
modified:   src/hooks/dhcp/perfmon/tests/Makefile.am
modified:   src/hooks/dhcp/perfmon/tests/monitored_duration_unittests.cc

17 months ago[#3245] Fixed unused variable warning
Thomas Markwalder [Tue, 20 Feb 2024 20:47:33 +0000 (15:47 -0500)] 
[#3245] Fixed unused variable warning

src/lib/dhcp/pkt_filter_inet6.cc
    PktFilterInet6::openSocket() - added errmsg to exception text as originally intended

17 months ago[#3245] Adds fundamental classes to perfmon
Thomas Markwalder [Fri, 16 Feb 2024 21:18:44 +0000 (16:18 -0500)] 
[#3245] Adds fundamental classes to perfmon

src/hooks/dhcp/perfmon/monitored_duration.cc
src/hooks/dhcp/perfmon/monitored_duration.h
    New files that add DurationDataInterval, DurationKey, Alarm, and MonitoredDuration classes

src/hooks/dhcp/perfmon/monitored_duration.h
New file of unit tests for new classes

modified:   Makefile.am
modified:   tests/Makefile.am

17 months ago[#2022] Added a comment about yhe unparking race
Francis Dupont [Thu, 22 Feb 2024 15:17:55 +0000 (16:17 +0100)] 
[#2022] Added a comment about yhe unparking race

17 months ago[#2022] Added parking points
Francis Dupont [Wed, 21 Feb 2024 21:48:41 +0000 (22:48 +0100)] 
[#2022] Added parking points

17 months ago[#2022] Checkpoint: added methods
Francis Dupont [Wed, 21 Feb 2024 16:13:55 +0000 (17:13 +0100)] 
[#2022] Checkpoint: added methods

17 months ago[#3025] fix missing include
Andrei Pavel [Thu, 22 Feb 2024 11:18:06 +0000 (13:18 +0200)] 
[#3025] fix missing include

17 months ago[#3025] add ChangeLog entry
Andrei Pavel [Fri, 16 Feb 2024 11:34:21 +0000 (13:34 +0200)] 
[#3025] add ChangeLog entry

17 months ago[#3025] fix distcheck
Andrei Pavel [Wed, 21 Feb 2024 13:08:54 +0000 (15:08 +0200)] 
[#3025] fix distcheck

17 months ago[#3025] use admin-utils.sh based on location in upgrade scripts
Andrei Pavel [Tue, 20 Feb 2024 22:56:10 +0000 (00:56 +0200)] 
[#3025] use admin-utils.sh based on location in upgrade scripts

17 months ago[#3025] address review comments
Andrei Pavel [Tue, 20 Feb 2024 22:25:22 +0000 (00:25 +0200)] 
[#3025] address review comments

17 months ago[#3025] appease shellcheck
Andrei Pavel [Tue, 20 Feb 2024 18:49:37 +0000 (20:49 +0200)] 
[#3025] appease shellcheck

 . "${admin_utils}"
  ^--------------^ SC1090: Can't follow non-constant source. Use a directive to specify location.

    version=$(checked_mysql_version)
              ^-------------------^ SC2119: Use checked_mysql_version "$@" if function's $1 should mean script's $1.

... and others that spiraled afterwards

17 months ago[#3025] simplify logic in ensureSchemaVersion
Andrei Pavel [Tue, 20 Feb 2024 15:39:49 +0000 (17:39 +0200)] 
[#3025] simplify logic in ensureSchemaVersion

... and allow kea-admin path to be overridden in tests.

17 months ago[#3025] re-enable ProcessSpawnTest.isRunningSync
Andrei Pavel [Tue, 20 Feb 2024 15:38:42 +0000 (17:38 +0200)] 
[#3025] re-enable ProcessSpawnTest.isRunningSync

17 months ago[#3025] fix location detection in kea-admin
Andrei Pavel [Tue, 20 Feb 2024 15:37:09 +0000 (17:37 +0200)] 
[#3025] fix location detection in kea-admin

17 months ago[#3025] add isFile
Andrei Pavel [Tue, 20 Feb 2024 15:36:10 +0000 (17:36 +0200)] 
[#3025] add isFile

17 months ago[#3025] document automatic db init
Andrei Pavel [Fri, 16 Feb 2024 11:34:05 +0000 (13:34 +0200)] 
[#3025] document automatic db init

17 months ago[#3025] add unit tests
Andrei Pavel [Fri, 16 Feb 2024 10:06:45 +0000 (12:06 +0200)] 
[#3025] add unit tests

17 months ago[#3025] sync kea-admin in db connection and fix interaction with retry
Andrei Pavel [Fri, 16 Feb 2024 07:45:54 +0000 (09:45 +0200)] 
[#3025] sync kea-admin in db connection and fix interaction with retry

17 months ago[#3025] add ability to wait sync in ProcessSpawn
Andrei Pavel [Fri, 16 Feb 2024 06:33:02 +0000 (08:33 +0200)] 
[#3025] add ability to wait sync in ProcessSpawn

17 months ago[#3025] add db init on startup to other managers
Andrei Pavel [Tue, 13 Feb 2024 17:17:57 +0000 (19:17 +0200)] 
[#3025] add db init on startup to other managers

17 months ago[#3025] switch io service to DatabaseConnection's
Andrei Pavel [Tue, 13 Feb 2024 13:17:06 +0000 (15:17 +0200)] 
[#3025] switch io service to DatabaseConnection's

17 months ago[#3025] minor changes to kea-admin
Andrei Pavel [Tue, 13 Feb 2024 13:17:42 +0000 (15:17 +0200)] 
[#3025] minor changes to kea-admin

- Reword 'Database version' to 'Schema version'.
- Remove a newline that was present only when running mysql operations
  and not for postgresql operations. It was more visible since now it
  appeared in the kea logs.
- Remove some extraneous exits. They weren't in the way of anything, but
  weren't doing anything either.

17 months ago[#3025] add ability to inherit env in ProcessSpawn
Andrei Pavel [Tue, 13 Feb 2024 10:59:44 +0000 (12:59 +0200)] 
[#3025] add ability to inherit env in ProcessSpawn

17 months ago[#3025] automatic init of postgresql schema
Andrei Pavel [Tue, 13 Feb 2024 08:15:34 +0000 (10:15 +0200)] 
[#3025] automatic init of postgresql schema

17 months ago[#3025] convert db access params to kea-admin
Andrei Pavel [Mon, 20 Nov 2023 22:06:56 +0000 (00:06 +0200)] 
[#3025] convert db access params to kea-admin

17 months ago[#3025] automatic init of mysql schema
Andrei Pavel [Mon, 20 Nov 2023 10:21:45 +0000 (12:21 +0200)] 
[#3025] automatic init of mysql schema

17 months ago[#3130] trim trailing slash
Piotrek Zadroga [Tue, 20 Feb 2024 14:52:53 +0000 (15:52 +0100)] 
[#3130] trim trailing slash

17 months ago[#3185] fixed access invalid iterator
Razvan Becheriu [Tue, 20 Feb 2024 08:56:43 +0000 (10:56 +0200)] 
[#3185] fixed access invalid iterator

17 months ago[#2022] Fixed comment
Francis Dupont [Wed, 21 Feb 2024 09:02:08 +0000 (10:02 +0100)] 
[#2022] Fixed comment

17 months ago[#2022] Checkpoint: began reorg
Francis Dupont [Mon, 19 Feb 2024 15:59:06 +0000 (16:59 +0100)] 
[#2022] Checkpoint: began reorg

17 months ago[#3231] Fixed some additional comments.
Thomas Markwalder [Tue, 20 Feb 2024 18:15:45 +0000 (13:15 -0500)] 
[#3231] Fixed some additional comments.

Minor nits in:

src/bin/dhcp4/tests/dhcp4_test_utils.h
src/bin/dhcp6/tests/dhcp6_test_utils.h

17 months ago[#3231] Refine conditional log in pkt_filter_bpf.cc
Thomas Markwalder [Tue, 20 Feb 2024 16:31:46 +0000 (11:31 -0500)] 
[#3231] Refine conditional log in pkt_filter_bpf.cc

modified:   pkt_filter_bpf.cc

17 months ago[#3231] Fixed build issue under MacOS Sonoma
Thomas Markwalder [Tue, 20 Feb 2024 14:28:00 +0000 (09:28 -0500)] 
[#3231] Fixed build issue under MacOS Sonoma

Added conditional compilation to address MacOS adding
the macro BPF_TIMEVAL to define the structure used
in the bpf header as either "struct timeval" or
"struct timeval32" (64 bit vs 32 bit).  CMSG uses
timeval, BPF uses timeval32.

src/lib/dhcp/pkt_filter_bpf.cc
    PktFilterBPF::receive()

17 months ago[#3231] Addressed review comments
Thomas Markwalder [Tue, 20 Feb 2024 14:27:08 +0000 (09:27 -0500)] 
[#3231] Addressed review comments

Minor cleanups, added a ChangeLog entry

17 months ago[#3231] Log SOCKET RECEIVED TIME support
Thomas Markwalder [Fri, 16 Feb 2024 20:17:20 +0000 (15:17 -0500)] 
[#3231] Log SOCKET RECEIVED TIME support

src/hooks/dhcp/perfmon/perfmon_callouts.cc
    dhcp4_srv_configured()
    dhcp6_srv_configured()
    - added to log socket received time support

src/hooks/dhcp/perfmon/perfmon_messages.mes
    PERFMON_DHCP4_SOCKET_RECEIVED_TIME_SUPPORT
    PERFMON_DHCP6_SOCKET_RECEIVED_TIME_SUPPORT
    - new messages

17 months ago[#3231] Add log of event stack to Perfmon callouts
Thomas Markwalder [Fri, 16 Feb 2024 19:38:00 +0000 (14:38 -0500)] 
[#3231] Add log of event stack to Perfmon callouts

src/hooks/dhcp/perfmon/perfmon_callouts.cc
    pkt4_send()
    pkt6_send()
        Added dump off packet event stack as a DEBUG log message

src/hooks/dhcp/perfmon/perfmon_messages.mes
    New messages:
    PERFMON_DHCP4_PKT_EVENTS
    PERFMON_DHCP6_PKT_EVENTS

17 months ago[#3231] Core task 3 for perfmon
Thomas Markwalder [Fri, 16 Feb 2024 19:13:29 +0000 (14:13 -0500)] 
[#3231] Core task 3 for perfmon

Add packet events and subnet callout argumments
to kea-dhcp4 and kea-dhcp6

src/bin/dhcp4/dhcp4_srv.*
    Dhcpv4Srv::runOne() - add mt_queued packet event to query in MT mode
    Dhcpv4Srv::processPacket() - add "process_started" event to query upon entry
    Dhcpv4Srv::processDhcp4Query() - pass selected subnet (if one) into processPacketPktSend()
    Dhcpv4Srv::sendResponseNoThrow() - add subnet parameter, pass it into processPacketPktSend9()
    Dhcpv4Srv::processPacketPktSend() - add subnet parameter, add "process_completed" event
    to query, add subnet to callout arguments

src/bin/dhcp4/tests/dhcp4_test_utils.cc
src/bin/dhcp4/tests/dhcp4_test_utils.h
src/bin/dhcp4/tests/hooks_unittest.cc
    Updates to verify packet events content add subnet4 callout argument

src/bin/dhcp6/dhcp6_srv.cc
    Dhcpv6Srv::runOne() - add mt_queued packet event to query in MT mode
    Dhcpv6Srv::processPacket() - add "process_started" event to query upon entry
    Dhcpv6Srv::processDhcp6Query() - pass selected subnet (if one) into processPacketPktSend()
    Dhcpv6Srv::sendResponseNoThrow() - add subnet parameter, pass it into processPacketPktSend9()
    Dhcpv6Srv::processPacketPktSend() - add subnet parameter, add "process_completed" event
    to query, add subnet to callout arguments

src/bin/dhcp6/tests/dhcp6_test_utils.cc
src/bin/dhcp6/tests/dhcp6_test_utils.h
src/bin/dhcp6/tests/hooks_unittest.cc
    Updates to verify packet events content add subnet4 callout argument

src/bin/dhcp4/dhcp4_hooks.dox
    Updated pkt4_send arguments

src/bin/dhcp6/dhcp6_hooks.dox
    Updated pkt6_send arguments

17 months ago[#3207] Format the code
Slawek Figiel [Tue, 20 Feb 2024 08:24:29 +0000 (09:24 +0100)] 
[#3207] Format the code

17 months ago[#3207] Change the member names
Slawek Figiel [Tue, 20 Feb 2024 08:04:35 +0000 (09:04 +0100)] 
[#3207] Change the member names

17 months ago[#3207] Add some comments
Slawek Figiel [Tue, 20 Feb 2024 07:59:48 +0000 (08:59 +0100)] 
[#3207] Add some comments

17 months ago[#3207] Remove a blank line from Changelog
Slawek Figiel [Tue, 20 Feb 2024 07:52:05 +0000 (08:52 +0100)] 
[#3207] Remove a blank line from Changelog

17 months ago[#3207] Change the letter case
Slawek Figiel [Tue, 20 Feb 2024 07:51:09 +0000 (08:51 +0100)] 
[#3207] Change the letter case

17 months ago[#3207] Trim whitespace
Slawek Figiel [Fri, 9 Feb 2024 12:05:23 +0000 (13:05 +0100)] 
[#3207] Trim whitespace

17 months ago[#3207] Update Changelog
Slawek Figiel [Fri, 9 Feb 2024 12:03:16 +0000 (13:03 +0100)] 
[#3207] Update Changelog

17 months ago[#3207] Replace boost radom with std
Slawek Figiel [Fri, 9 Feb 2024 12:02:12 +0000 (13:02 +0100)] 
[#3207] Replace boost radom with std

17 months ago[#3207] Remove old implementation
Slawek Figiel [Fri, 9 Feb 2024 11:49:40 +0000 (12:49 +0100)] 
[#3207] Remove old implementation

17 months ago[#3207] Add a wrapper for boost rand generator
Slawek Figiel [Fri, 9 Feb 2024 11:41:35 +0000 (12:41 +0100)] 
[#3207] Add a wrapper for boost rand generator

17 months ago[#3207] Remove helper class
Slawek Figiel [Fri, 9 Feb 2024 10:46:23 +0000 (11:46 +0100)] 
[#3207] Remove helper class

17 months ago[#3207] Remove helper classes
Slawek Figiel [Fri, 9 Feb 2024 10:39:54 +0000 (11:39 +0100)] 
[#3207] Remove helper classes

17 months ago[#3207] Remove weighted random generator
Slawek Figiel [Fri, 9 Feb 2024 10:31:12 +0000 (11:31 +0100)] 
[#3207] Remove weighted random generator

17 months ago[#2022] fix User-Password example in ARM
Andrei Pavel [Mon, 19 Feb 2024 15:48:42 +0000 (17:48 +0200)] 
[#2022] fix User-Password example in ARM

17 months ago[#2022] fix non-matching quotes and indentation
Andrei Pavel [Mon, 19 Feb 2024 08:52:16 +0000 (10:52 +0200)] 
[#2022] fix non-matching quotes and indentation

17 months ago[#2022] Added max-pending-requests doc
Francis Dupont [Tue, 13 Feb 2024 15:11:07 +0000 (16:11 +0100)] 
[#2022] Added max-pending-requests doc

17 months ago[#2022] Checkpoint: last version of parking code
Francis Dupont [Thu, 8 Feb 2024 20:27:57 +0000 (21:27 +0100)] 
[#2022] Checkpoint: last version of parking code

17 months ago[#3242] Fixed copyright date
Thomas Markwalder [Fri, 16 Feb 2024 16:02:28 +0000 (11:02 -0500)] 
[#3242] Fixed copyright date

17 months ago[#3242] Addressed comments, added ChangeLog entry
Thomas Markwalder [Fri, 16 Feb 2024 15:59:31 +0000 (10:59 -0500)] 
[#3242] Addressed comments, added ChangeLog entry

Minor cosmetic fixes.

17 months ago[#3209] Fixed .gitattributes file
Thomas Markwalder [Tue, 6 Feb 2024 19:27:30 +0000 (14:27 -0500)] 
[#3209] Fixed .gitattributes file

modified:   src/hooks/dhcp/perfmon/.gitattributes

17 months ago[#3242] Added bare-bones perfmon hook library
Thomas Markwalder [Tue, 6 Feb 2024 15:40:27 +0000 (10:40 -0500)] 
[#3242] Added bare-bones perfmon hook library

New files:
    arm/hooks-perfmon.rst
src/hooks/dhcp/perfmon/.gitattributes
src/hooks/dhcp/perfmon/.gitignore
src/hooks/dhcp/perfmon/Makefile.am
src/hooks/dhcp/perfmon/libloadtests/.gitignore
src/hooks/dhcp/perfmon/libloadtests/Makefile.am
src/hooks/dhcp/perfmon/libloadtests/load_unload_unittests.cc
src/hooks/dhcp/perfmon/libloadtests/run_unittests.cc
src/hooks/dhcp/perfmon/perfmon.dox
src/hooks/dhcp/perfmon/perfmon_callouts.cc
src/hooks/dhcp/perfmon/perfmon_log.cc
src/hooks/dhcp/perfmon/perfmon_log.h
src/hooks/dhcp/perfmon/perfmon_messages.cc
src/hooks/dhcp/perfmon/perfmon_messages.h
src/hooks/dhcp/perfmon/perfmon_messages.mes
src/hooks/dhcp/perfmon/tests/.gitignore
src/hooks/dhcp/perfmon/tests/Makefile.am
src/hooks/dhcp/perfmon/tests/run_unittests.cc
src/hooks/dhcp/perfmon/version.cc

Modified:
configure.ac
arm/hooks-perfmon.rst
arm/hooks.rst
arm/logging.rst
arm/rst_arm_sources.mk
conf.py
src/hooks/dhcp/Makefile.am

17 months ago[#3230] addressed review
Razvan Becheriu [Fri, 16 Feb 2024 16:30:14 +0000 (18:30 +0200)] 
[#3230] addressed review

17 months ago[#3230] Added UT to BPF filter
Thomas Markwalder [Fri, 16 Feb 2024 15:01:31 +0000 (10:01 -0500)] 
[#3230] Added UT to BPF filter

modified:   tests/pkt_filter_bpf_unittest.cc

17 months ago[#3230] Added UTs for isSocketReceiveTimeSupported
Thomas Markwalder [Fri, 16 Feb 2024 14:51:43 +0000 (09:51 -0500)] 
[#3230] Added UTs for isSocketReceiveTimeSupported

src/lib/dhcp/tests/pkt_filter_inet6_unittest.cc
src/lib/dhcp/tests/pkt_filter_inet_unittest.cc
src/lib/dhcp/tests/pkt_filter_lpf_unittest.cc
    Added test for isSocketReceivedTimeSupported)

17 months ago[#3230] Move isSocketReceivedSuppported()
Thomas Markwalder [Fri, 16 Feb 2024 14:29:25 +0000 (09:29 -0500)] 
[#3230] Move isSocketReceivedSuppported()

Move isSocketReceivedSuppported() impls out of headers and into
cc files so we're sure SO_TIMESTAMP is known.

17 months ago[#3230] Addressed review comments
Thomas Markwalder [Fri, 16 Feb 2024 13:10:38 +0000 (08:10 -0500)] 
[#3230] Addressed review comments

src/lib/dhcp/iface_mgr.*
    IfaceMgr::isSocketReceviedTimeSupported() - new function

src/lib/dhcp/pkt_filter.*
    PktFilter::isSocketReceviedTimeSupported() - new  pure virtual function

src/lib/dhcp/pkt_filter6.cc
src/lib/dhcp/pkt_filter_bpf.h
src/lib/dhcp/pkt_filter_inet.h
src/lib/dhcp/pkt_filter_inet6.h
src/lib/dhcp/pkt_filter_lpf.h
    Added implementation of isSocketReceivedTimeSupported()

src/lib/dhcp/pkt_filter_lpf.cc
    Removed WITH_CMSG and refactored receive() to be a single function
    with conditional codde based on SO_TIMESTAMP

Updated UTs accordingly

17 months ago[#3230] addressed review
Razvan Becheriu [Thu, 15 Feb 2024 17:57:19 +0000 (19:57 +0200)] 
[#3230] addressed review

17 months ago[#3230] Initial commit
Thomas Markwalder [Thu, 1 Feb 2024 20:27:14 +0000 (15:27 -0500)] 
[#3230] Initial commit

Adds dhcp::PktEvent, modifies packet filters and tests

src/lib/dhcp/pkt.*
    Add PktEvent class, add stack and methods to Pkt

src/lib/dhcp/pkt_filter_bpf.cc
    PktFilterBPF::receive() - fetch timestamp from bpfhdr,
    add SOCKET_RECEIVED and BUFFER_READ events

    PktFilterBPF::send() - add RESPONSE_SENT event

src/lib/dhcp/pkt_filter_inet.cc
    PktFilterInet::openSocket() - enable SO_TIMESTAMP socket option

    PktFilterInet::receive() - fetch SO_TIMESTAMP via CMSG,
    add SOCKET_RECEIVED and BUFFER_READ events

    PktFilterInet::send() - add RESPONSE_SENT event

src/lib/dhcp/pkt_filter_inet6.cc
    PktFilterInet6::openSocket() - enable SO_TIMESTAMP socket option

    PktFilterInet6::receive() - fetch SO_TIMESTAMP via CMSG,
    add SOCKET_RECEIVED and BUFFER_READ events

    PktFilterInet::send() - add RESPONSE_SENT event

src/lib/dhcp/pkt_filter_lpf.cc

    PktFilterLPF::openSocket() - enable SO_TIMESTAMP socket option
    PktFilterLPF::receive() - added conditonal compilation version based
    on WITH_CMSG macro that fetches SO_TIMESTAMP and add SOCKET_RECEIVED
    and BUFFER_READ events

    PktFilterLPF::send() - add RESPONSE_SENT event

src/lib/dhcp/tests/pkt4_unittest.cc
    TEST_F(Pkt4Test, PktEvents) - new test

src/lib/dhcp/tests/pkt6_unittest.cc
    TEST_F(Pkt6Test, PktEvents) - new test

src/lib/dhcp/tests/pkt_filter6_test_utils.cc
src/lib/dhcp/tests/pkt_filter6_test_utils.h
src/lib/dhcp/tests/pkt_filter_inet6_unittest.cc
src/lib/dhcp/tests/pkt_filter_inet_unittest.cc
src/lib/dhcp/tests/pkt_filter_test_utils.cc
src/lib/dhcp/tests/pkt_filter_test_utils.h
    Updated tests to check PktEvent stack contents

src/lib/dhcp/tests/pkt_filter_bpf_unittest.cc
src/lib/dhcp/tests/pkt_filter_lpf_unittest.cc
    Updated tests to check PktEvent stack contents,
    Changed DISABLED_ tests to use SKIP_IF(notRoot)

18 months ago[#3209] Further review comments
Thomas Markwalder [Tue, 6 Feb 2024 20:38:23 +0000 (15:38 -0500)] 
[#3209] Further review comments

modified:   encode/encode.cc

18 months ago[#3209] Addressed review comments
Thomas Markwalder [Tue, 6 Feb 2024 19:22:14 +0000 (14:22 -0500)] 
[#3209] Addressed review comments

Minor clean up, added commentary

18 months ago[#3209] addressed review
Razvan Becheriu [Tue, 6 Feb 2024 16:56:27 +0000 (18:56 +0200)] 
[#3209] addressed review