]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
14 years agoIf accounting start/interim/stop doesn't do anything, return NOOP
Alan T. DeKok [Tue, 10 May 2011 08:45:54 +0000 (10:45 +0200)] 
If accounting start/interim/stop doesn't do anything, return NOOP

If num_affected_rows == 0, return NOOP

14 years agoFix typo
Alan T. DeKok [Mon, 9 May 2011 17:37:46 +0000 (19:37 +0200)] 
Fix typo

If we're making a directory, make sure it's from the '/',
and not from the whole filename.

14 years agoCall fnmatch only if the packet was read from the detail file.
Alan T. DeKok [Mon, 9 May 2011 11:16:04 +0000 (13:16 +0200)] 
Call fnmatch only if the packet was read from the detail file.

And re-arranged the logic to make sense.

If the packet was read from the detail file AND will be written back
to the same directory (glob match), then do NOOP.

Otherwise, just go make the directory

14 years agofix lower->tolower typo in policy.conf
Alexander Clouter [Mon, 9 May 2011 10:15:16 +0000 (11:15 +0100)] 
fix lower->tolower typo in policy.conf

git commit abc96955 contains a typo that this patch fixes.  As the
module 'lower' does not exist calling this policy always results in a
reject.

Signed-off-by: Alexander Clouter <alex@digriz.org.uk>
14 years agoDefine _GNU_SOURCE before checking for structures
Alan T. DeKok [Fri, 6 May 2011 14:49:32 +0000 (16:49 +0200)] 
Define _GNU_SOURCE before checking for structures

On Linux, useful features that are industry standard are
"protected" by requiring -D_GNU_SOURCE.  Why would you want
your users to *use* the features of libc?

14 years agoAdd EAP tests to automated test suite
Alan T. DeKok [Fri, 6 May 2011 12:32:12 +0000 (14:32 +0200)] 
Add EAP tests to automated test suite

14 years agoMove proxy ID handler to RB trees instead of hashes
Alan T. DeKok [Wed, 4 May 2011 11:50:46 +0000 (13:50 +0200)] 
Move proxy ID handler to RB trees instead of hashes

This is apparently the root cause behind bug #35.  It's not
clear why the hash table has that problem, but making this change
fixes it.

14 years agoChange assert to run-time check
Alan T. DeKok [Wed, 4 May 2011 11:42:25 +0000 (13:42 +0200)] 
Change assert to run-time check

14 years agoDon't decode attributes if there's no secret
Alan T. DeKok [Tue, 3 May 2011 07:23:41 +0000 (09:23 +0200)] 
Don't decode attributes if there's no secret

This is really a bug in the caller, but it's a reasonable
change to make.

14 years agoUse built-in "offsetof"
Alan T. DeKok [Mon, 2 May 2011 12:47:16 +0000 (14:47 +0200)] 
Use built-in "offsetof"

Look for "stddef.h", and if found, include it in the various
configure checks.  Also use it at run time.

14 years agopairmake may return NULL if the dictionaries are broken.
Alan T. DeKok [Thu, 28 Apr 2011 09:09:45 +0000 (11:09 +0200)] 
pairmake may return NULL if the dictionaries are broken.

The code should check for this, and behave gracefully

14 years agoFix typo in attribute name
Alan T. DeKok [Thu, 28 Apr 2011 09:07:07 +0000 (11:07 +0200)] 
Fix typo in attribute name

14 years agoLoad the default virtual server before any others
Alan T. DeKok [Wed, 27 Apr 2011 07:41:08 +0000 (09:41 +0200)] 
Load the default virtual server before any others

This avoids user surprise

14 years agoMark the module as HUP-safe
Alan T. DeKok [Thu, 21 Apr 2011 07:00:09 +0000 (09:00 +0200)] 
Mark the module as HUP-safe

14 years agoMake proxy inner tunnel MS-CHAP work again
Alan T. DeKok [Fri, 15 Apr 2011 13:28:57 +0000 (15:28 +0200)] 
Make proxy inner tunnel MS-CHAP work again

14 years agoFix arguments to pairmove2
Alan T. DeKok [Sun, 10 Apr 2011 14:28:27 +0000 (16:28 +0200)] 
Fix arguments to pairmove2

14 years agoDon't set "EAP Failure" when sending error message back
Alan T. DeKok [Sun, 10 Apr 2011 06:02:05 +0000 (08:02 +0200)] 
Don't set "EAP Failure" when sending error message back

14 years agoThe file may be closed when there are no VPs
Alan T. DeKok [Fri, 8 Apr 2011 11:04:25 +0000 (13:04 +0200)] 
The file may be closed when there are no VPs

14 years agoMake error sending configurable
Alan T. DeKok [Fri, 8 Apr 2011 07:36:49 +0000 (09:36 +0200)] 
Make error sending configurable

14 years agoHandle failures
Alan T. DeKok [Thu, 7 Apr 2011 14:29:20 +0000 (16:29 +0200)] 
Handle failures

14 years agoAdd allow_retry and retry_msg functionality
Alan T. DeKok [Thu, 7 Apr 2011 14:18:27 +0000 (16:18 +0200)] 
Add allow_retry and retry_msg functionality

Based on a patch from John Hayward.

Setting "allow_retry=0" and "retry_msg = hello" seems to help
with EAP-MSCHAPv2 and cached passwords...

14 years agoAllow MS-CHAP-Error in Access-Reject
Alan T. DeKok [Thu, 7 Apr 2011 14:11:58 +0000 (16:11 +0200)] 
Allow MS-CHAP-Error in Access-Reject

14 years agoDon't over-write a fail code with a success code.
Alan T. DeKok [Thu, 7 Apr 2011 07:44:26 +0000 (09:44 +0200)] 
Don't over-write a fail code with a success code.

Closes bug #152

14 years agoAdd -4 and -6 options
Alan T. DeKok [Tue, 5 Apr 2011 14:56:33 +0000 (16:56 +0200)] 
Add -4 and -6 options

These force NAS-IP-Address or NAS-IPv6-Address

14 years agoFix handling of "-l stdout"
Alan T. DeKok [Tue, 29 Mar 2011 13:53:01 +0000 (15:53 +0200)] 
Fix handling of "-l stdout"

14 years agoCorrect debug log for internal proxied requests
Alan T. DeKok [Fri, 25 Mar 2011 12:53:10 +0000 (13:53 +0100)] 
Correct debug log for internal proxied requests

14 years agoFix generation of autoheader, and re-build it
Alan T. DeKok [Fri, 25 Mar 2011 09:21:07 +0000 (10:21 +0100)] 
Fix generation of autoheader, and re-build it

14 years agoFix typo in last commit
Alan T. DeKok [Fri, 25 Mar 2011 09:14:57 +0000 (10:14 +0100)] 
Fix typo in last commit

14 years agoRe-build more on reconfig
Alan T. DeKok [Fri, 25 Mar 2011 09:09:33 +0000 (10:09 +0100)] 
Re-build more on reconfig

14 years agoFix autogen.sh
John Dennis [Thu, 24 Mar 2011 15:59:37 +0000 (11:59 -0400)] 
Fix autogen.sh

The script is invoked with -e which causes the script to exit
immediately if a subshell command enclosed in parentheses
has a non-zero exit status. The command

  grep "^AC_CONFIG_HEADER" configure.in > /dev/null

returns non-zero for many of the subdirs which causes the autogen.sh
script to immediately exit. In fact it exits on the very first
subdirectory (src/modules/rlm_sql) prematurely aborting the entire
operation.

14 years agoMove illegal attributes around
Alan T. DeKok [Wed, 23 Mar 2011 07:59:22 +0000 (08:59 +0100)] 
Move illegal attributes around

And enable the Motorola VSA dictionary

14 years agoRemove trailing whitespace
Alan T. DeKok [Wed, 23 Mar 2011 07:41:38 +0000 (08:41 +0100)] 
Remove trailing whitespace

14 years agoMore Canopy attributes as posted to the list
Alan T. DeKok [Wed, 23 Mar 2011 07:41:21 +0000 (08:41 +0100)] 
More Canopy attributes as posted to the list

14 years agoFix typos
Alan T. DeKok [Wed, 23 Mar 2011 07:40:21 +0000 (08:40 +0100)] 
Fix typos

14 years agoClearer warnings about unsupported operators
Alan T. DeKok [Sun, 20 Mar 2011 07:11:05 +0000 (08:11 +0100)] 
Clearer warnings about unsupported operators

14 years agoExpose API to get token names
Alan T. DeKok [Sun, 20 Mar 2011 07:10:47 +0000 (08:10 +0100)] 
Expose API to get token names

14 years agoHow RADIUS should be done.
Alan T. DeKok [Sat, 19 Mar 2011 15:16:12 +0000 (16:16 +0100)] 
How RADIUS should be done.

14 years agoExpose rad_print_hex, and use it in radsniff
Alan T. DeKok [Wed, 16 Mar 2011 10:26:04 +0000 (11:26 +0100)] 
Expose rad_print_hex, and use it in radsniff

14 years agoFix compilation errors
Alan T. DeKok [Tue, 15 Mar 2011 16:23:22 +0000 (17:23 +0100)] 
Fix compilation errors

14 years agoId is unsigned for printing
Alan T. DeKok [Tue, 15 Mar 2011 14:30:37 +0000 (15:30 +0100)] 
Id is unsigned for printing

14 years agoFix build error
Alan T. DeKok [Tue, 15 Mar 2011 10:27:47 +0000 (11:27 +0100)] 
Fix build error

14 years agoUpdated as per latest spec
Alan T. DeKok [Tue, 15 Mar 2011 09:19:10 +0000 (10:19 +0100)] 
Updated as per latest spec

14 years agoFixed for latest rev
Alan T. DeKok [Tue, 15 Mar 2011 09:11:22 +0000 (10:11 +0100)] 
Fixed for latest rev

14 years agoIf select() returns an error, show it to the user.
Alan T. DeKok [Tue, 15 Mar 2011 08:45:11 +0000 (09:45 +0100)] 
If select() returns an error, show it to the user.

Helps to address bug #149

However, the underlying issue still isn't fixed.  It isn't clear
why select() returns an error.  An alternate solution might be
to simply re-do all of the FD_SET stuff, in the hope that
the cached version was wrong.

14 years agoNote bad configuration
Alan T. DeKok [Tue, 15 Mar 2011 08:34:54 +0000 (09:34 +0100)] 
Note bad configuration

The sqlcounter module does it's own expansion.  This doesn't
seem to work.

14 years agoUpdated command list
Alan T. DeKok [Mon, 14 Mar 2011 13:15:21 +0000 (14:15 +0100)] 
Updated command list

radmin -e "help -r" | perl -ne 's/^(.*) - /\n/;$foo = $1; $foo =~ s/\ /\\ /g;print ".IP ", $foo;print;' > foo

14 years agoNotes changes for 2.1.11
Alan T. DeKok [Mon, 14 Mar 2011 13:06:17 +0000 (14:06 +0100)] 
Notes changes for 2.1.11

14 years agoCheck pre-condictions
Alan T. DeKok [Mon, 14 Mar 2011 13:01:28 +0000 (14:01 +0100)] 
Check pre-condictions

"inject file" requires "inject to" and "inject from"

14 years agoIf the source address is INADDR_ANY, don't use udpfromto
Alan T. DeKok [Mon, 14 Mar 2011 11:04:56 +0000 (12:04 +0100)] 
If the source address is INADDR_ANY, don't use udpfromto

It breaks various systems.  Closes bug #148

14 years agoExpose fr_inaddr_any
Alan T. DeKok [Mon, 14 Mar 2011 11:02:57 +0000 (12:02 +0100)] 
Expose fr_inaddr_any

14 years agoMoved USR/ascend illegal dictionaries back to share/
Alan T. DeKok [Mon, 14 Mar 2011 09:25:45 +0000 (10:25 +0100)] 
Moved USR/ascend illegal dictionaries back to share/

raddb/dictionary is *not* changed on an upgrade, so removing those
dictionaries from share/dictionary means that they might be
surprisingly removed from the local configuration, and break things.
That would be bad.

14 years agoRevert "Fix typos and regenerate for 2.1.11"
Alan T. DeKok [Sun, 13 Mar 2011 17:50:54 +0000 (18:50 +0100)] 
Revert "Fix typos and regenerate for 2.1.11"

This reverts commit 2d0c5fa94938f727b4f37fb7399b777437171eeb.

14 years agoComplain about duplicate virtual servers, too
Alan T. DeKok [Sun, 13 Mar 2011 09:12:11 +0000 (10:12 +0100)] 
Complain about duplicate virtual servers, too

14 years agoLook for duplicate module definitions.
Alan T. DeKok [Sun, 13 Mar 2011 09:02:33 +0000 (10:02 +0100)] 
Look for duplicate module definitions.

Doing an O(N^2) search over the modules{} section.  If the same module
is defined twice, print an error detailing *both* locations where it
occurs, and exit.

This helps prevent broken configurations by disallowing the server
from loading two conflicting module definitions

14 years agoAdded cf_section_find_name2() API
Alan T. DeKok [Sun, 13 Mar 2011 09:02:06 +0000 (10:02 +0100)] 
Added cf_section_find_name2() API

This lets us find the next section by name1 and name2

14 years agoAdded dictionary from Moonshot project
Alan T. DeKok [Fri, 11 Mar 2011 09:49:43 +0000 (10:49 +0100)] 
Added dictionary from Moonshot project

14 years agoHack to let developers catch bad dictionaries
Alan T. DeKok [Sat, 5 Mar 2011 07:07:14 +0000 (08:07 +0100)] 
Hack to let developers catch bad dictionaries

uses fprintf to print warning messages when the attributes are
illegally defined in the IANA standard space

14 years agoMove references to illegal dictionaries to raddb/dictionary
Alan T. DeKok [Sat, 5 Mar 2011 06:55:14 +0000 (07:55 +0100)] 
Move references to illegal dictionaries to raddb/dictionary

The main dictionary files should NOT be edited.  Ever.  So placing
the "illegal" attributes in a file which can be edited is a good idea.

14 years agoAdded license text
Alan T. DeKok [Sat, 5 Mar 2011 06:50:37 +0000 (07:50 +0100)] 
Added license text

14 years agoFix typo
Alan T. DeKok [Sat, 5 Mar 2011 06:48:17 +0000 (07:48 +0100)] 
Fix typo

14 years agoRegen configure scripts
Alan T. DeKok [Sat, 5 Mar 2011 06:31:39 +0000 (07:31 +0100)] 
Regen configure scripts

14 years agoLook for <openssl/hmac.h>
Alan T. DeKok [Sat, 5 Mar 2011 06:20:21 +0000 (07:20 +0100)] 
Look for <openssl/hmac.h>

14 years agoMark pointer NULL when it's free
Alan T. DeKok [Fri, 4 Mar 2011 14:07:56 +0000 (15:07 +0100)] 
Mark pointer NULL when it's free

14 years agoudpfromto doesn't seem to work for DHCP.
Alan T. DeKok [Thu, 3 Mar 2011 14:22:26 +0000 (15:22 +0100)] 
udpfromto doesn't seem to work for DHCP.

It should really be replaced on sending by using an ethernet socket

14 years agoBe more forgiving about policy parsing
Alan T. DeKok [Tue, 1 Mar 2011 15:58:57 +0000 (16:58 +0100)] 
Be more forgiving about policy parsing

14 years agoFix typo
Alan T. DeKok [Tue, 1 Mar 2011 12:28:23 +0000 (13:28 +0100)] 
Fix typo

14 years agoAllow SQLite to do non-NAS select queries
Alan T. DeKok [Tue, 1 Mar 2011 09:04:24 +0000 (10:04 +0100)] 
Allow SQLite to do non-NAS select queries

14 years agoAdded sample of using global / static variables
Alan T. DeKok [Mon, 28 Feb 2011 10:00:14 +0000 (11:00 +0100)] 
Added sample of using global / static variables

14 years agoUse rad_digest_cmp() to avoid timing attacks
Alan T. DeKok [Wed, 23 Feb 2011 10:04:31 +0000 (11:04 +0100)] 
Use rad_digest_cmp() to avoid timing attacks

14 years agoUse rad_digest_cmp() to avoid timing attacks
Alan T. DeKok [Wed, 23 Feb 2011 10:01:17 +0000 (11:01 +0100)] 
Use rad_digest_cmp() to avoid timing attacks

14 years agoUse rad_digest_cmp() to avoid timing attacks
Alan T. DeKok [Wed, 23 Feb 2011 10:01:02 +0000 (11:01 +0100)] 
Use rad_digest_cmp() to avoid timing attacks

14 years agoExpose digest_cmp function
Alan T. DeKok [Wed, 23 Feb 2011 09:59:55 +0000 (10:59 +0100)] 
Expose digest_cmp function

So that it can be used in other places to avoid timing attacks

14 years agoUpdated license to LGPL rather than GPL
Alan T. DeKok [Wed, 23 Feb 2011 08:46:30 +0000 (09:46 +0100)] 
Updated license to LGPL rather than GPL

The "lib" directory and everything it needs have been lgpl for a long time.

14 years agoCorrected license to LGPL rather than GPL
Alan T. DeKok [Wed, 23 Feb 2011 08:26:03 +0000 (09:26 +0100)] 
Corrected license to LGPL rather than GPL

14 years agoPrint error if we can't send a packet in rad_send()
Alan T. DeKok [Sun, 20 Feb 2011 08:39:57 +0000 (09:39 +0100)] 
Print error if we can't send a packet in rad_send()

14 years agoUse new format for %{..:-...}
Alan T. DeKok [Fri, 18 Feb 2011 14:44:20 +0000 (15:44 +0100)] 
Use new format for %{..:-...}

14 years agoAdded radtee
Alan T. DeKok [Fri, 18 Feb 2011 09:37:17 +0000 (10:37 +0100)] 
Added radtee

Shamelessly taken from http://horde.net/~jwm/software/misc/comparison-tee

14 years agoUse newer expansion
Alan T. DeKok [Fri, 18 Feb 2011 09:29:24 +0000 (10:29 +0100)] 
Use newer expansion

14 years agoBasic configure scripts
Alan T. DeKok [Fri, 18 Feb 2011 09:25:07 +0000 (10:25 +0100)] 
Basic configure scripts

14 years agoMake CoA proxying work again.
Alan T. DeKok [Fri, 18 Feb 2011 09:01:11 +0000 (10:01 +0100)] 
Make CoA proxying work again.

Only set the reply code if it isn't meant to be proxied.

14 years agoMake query lengths match rlm_sql
Alan T. DeKok [Fri, 18 Feb 2011 08:26:31 +0000 (09:26 +0100)] 
Make query lengths match rlm_sql

Closes bug #139

14 years agoBetter fixes for bug #141
Alan T. DeKok [Thu, 17 Feb 2011 11:05:54 +0000 (12:05 +0100)] 
Better fixes for bug #141

14 years agoSuppress messages if thread pool is ~full.
Alan T. DeKok [Mon, 14 Feb 2011 14:27:40 +0000 (15:27 +0100)] 
Suppress messages if thread pool is ~full.

If it's full and all threads are buys, we shouldn't try to create spare
threads.

14 years agoFix typos and regenerate for 2.1.11
Alan T. DeKok [Mon, 14 Feb 2011 14:03:48 +0000 (15:03 +0100)] 
Fix typos and regenerate for 2.1.11

14 years agoGenerated for 2.1.11
Alan T. DeKok [Mon, 14 Feb 2011 14:03:00 +0000 (15:03 +0100)] 
Generated for 2.1.11

14 years agognore socket if address families don't match. Closes bug #143
Alan T. DeKok [Fri, 11 Feb 2011 09:59:42 +0000 (10:59 +0100)] 
gnore socket if address families don't match.  Closes bug #143

When allocating an Id for proxying, the code previously did not
pay attention to address families.  So if you have two home servers,
on V4 only and one V6 only, it could use a local V4 proxy socket to
connect to a V6 server,  This doesn't work.

14 years agoNo DB handles is an error, not an informational message.
Alan T. DeKok [Thu, 10 Feb 2011 15:20:39 +0000 (16:20 +0100)] 
No DB handles is an error, not an informational message.

14 years agoFixed typo
Alan T. DeKok [Thu, 10 Feb 2011 15:13:59 +0000 (16:13 +0100)] 
Fixed typo

14 years agoFixed onoff query
Alan T. DeKok [Thu, 10 Feb 2011 13:41:38 +0000 (14:41 +0100)] 
Fixed onoff query

14 years agoEnable udpfromto() for IPv6
Alan T. DeKok [Thu, 10 Feb 2011 12:35:52 +0000 (13:35 +0100)] 
Enable udpfromto() for IPv6

On the theory that it will work, or that some magic will get it to work

14 years agoTry to fix udpfromto for IPv6
Alan T. DeKok [Thu, 10 Feb 2011 12:34:20 +0000 (13:34 +0100)] 
Try to fix udpfromto for IPv6

14 years agoChange the rules for sending DHCP responses
Alan T. DeKok [Thu, 10 Feb 2011 09:49:03 +0000 (10:49 +0100)] 
Change the rules for sending DHCP responses

giaddr -> giaddr
broadcast -> broadcast
nak -> broadcast
!ciaddr -> broadcast
ciaddr -> ciaddr BUT
   if the request was not *from* ciaddr, we need to send a "raw"
   response.

Many DHCP clients can handle a broadcast DHCP OFFER / ACK when first
assigning an address.  Some clients expect a response unicast to
their MAC address.

14 years agoAllow spaces and CRs
Alan T. DeKok [Wed, 9 Feb 2011 10:53:50 +0000 (11:53 +0100)] 
Allow spaces and CRs

Now that the underlying redis escape function handles spaces and
control characters

14 years agoAdded escape function
Alan T. DeKok [Wed, 9 Feb 2011 10:52:39 +0000 (11:52 +0100)] 
Added escape function

The rules for redis escaping aren't overly clear.  So we escape
control characters, spaces, and the backslash.

14 years agofix freeing eap_handler as opaque (and typo)
Ken-ichirou MATSUZAWA [Tue, 8 Feb 2011 12:19:10 +0000 (21:19 +0900)] 
fix freeing eap_handler as opaque (and typo)

 Hello,

I hope this would be hint for fixing segfault and
better solution.

Thanks.

Subject: [PATCH 1/2] freeing EAP opaque with one arg

14 years agoAdded sample for dynamic clients from LDAP
Alan T. DeKok [Wed, 2 Feb 2011 09:14:01 +0000 (10:14 +0100)] 
Added sample for dynamic clients from LDAP

15 years agoFix compile warnings and check for !vp
Alan T. DeKok [Sat, 29 Jan 2011 14:44:25 +0000 (15:44 +0100)] 
Fix compile warnings and check for !vp

15 years agoCheck return value of lseek correctly
Alan T. DeKok [Fri, 28 Jan 2011 11:14:03 +0000 (12:14 +0100)] 
Check return value of lseek correctly

15 years agoAdd %{string:...} for printable data
Alan T. DeKok [Thu, 27 Jan 2011 14:33:32 +0000 (15:33 +0100)] 
Add %{string:...} for printable data

15 years agomake fr_print_string return the string length
Alan T. DeKok [Thu, 27 Jan 2011 14:33:17 +0000 (15:33 +0100)] 
make fr_print_string return the string length