Chris Lalancette [Thu, 31 Jul 2008 12:30:34 +0000 (12:30 +0000)]
From Charles Duffy:
Per subject; if autoport is in use for a host, the current
virDomainGraphicsDefFormat code always emits "port=-1", even if a port
is assigned to the host; this leaves no way for a client to find the VNC
port assigned to the host in question.
This patches fixes it by putting the vncport in place if there is one, and
only putting "-1" if we fail that test.
This used to work with older libvirt, but now fails. This is because we are
actually passing the literal string (null) to the qemu command-line, which qemu
barfs on. This patch fixes it up by making it blank, which allows qemu to
continue on it's merry way.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
Daniel Veillard [Tue, 29 Jul 2008 08:42:56 +0000 (08:42 +0000)]
build OpenVZ and LXC support by default, fix OpenVZ build
* src/openvz_conf.c: fix compilation with new XPath interface
signatures
* configure.in: build OpenVZ and LXC support by default
Daniel
Daniel Veillard [Mon, 28 Jul 2008 14:06:54 +0000 (14:06 +0000)]
OpenVZ xml refactoring
* src/domain_conf.[ch] src/openvz_conf.[ch] src/openvz_driver.c:
patch from Evgeniy Sokolov doing the OpenVZ xml refactoring,
still needs to be ported to the new XML parsing code but
implements the new format.
Daniel
Daniel Veillard [Fri, 25 Jul 2008 12:37:06 +0000 (12:37 +0000)]
Skip python bindings for virDomainBlockPeek and virDomainMemoryPeek
* python/generator.py: skip generation for virDomainBlockPeek and
virDomainMemoryPeek as they break the build
Daniel
Daniel Veillard [Fri, 25 Jul 2008 08:52:19 +0000 (08:52 +0000)]
Remove Xen centric comments, rebuild the docs
* include/libvirt/libvirt.h include/libvirt/libvirt.h.in:
remove Xen centric comments patch from Guido Günther
* docs/apibuild.py: ignore VIR_DEPRECATED
* docs/libvirt-*.xml docs/html/libvirt-*.html: regenerated the
documentation for the API
Daniel
Daniel Veillard [Thu, 24 Jul 2008 07:29:50 +0000 (07:29 +0000)]
Check for already running QEmu domain on create
* src/qemu_driver.c: another patch from Guido Günther checking
for an already running domain on create
Daniel
Jim Meyering [Tue, 22 Jul 2008 16:12:01 +0000 (16:12 +0000)]
better diagnostic when failing to undefine a running domain via ID
* src/virsh.c (cmdUndefine): Tell user to shutdown and then use name or UUID.
* tests/undefine: New test. Exercise virsh's undefine command.
* tests/Makefile.am (test_scripts): Add undefine.
Daniel Veillard [Mon, 21 Jul 2008 08:03:58 +0000 (08:03 +0000)]
xen lib detection patch on 64bits
* configure.in: patch from David Lively to try to detect the xen
libs when using --with-xen-distdir= on 64bit arches.
Daniel
Daniel Veillard [Wed, 16 Jul 2008 15:27:00 +0000 (15:27 +0000)]
lookup by ID function and error report fix for OpenVZ
* src/openvz_driver.c: fix the lookup by ID function and error
reporting in OpenVZ, fix by Evgeniy Sokolov
Daniel
Daniel Veillard [Wed, 16 Jul 2008 14:45:55 +0000 (14:45 +0000)]
cleaning up the exec calls to OpenVZ binaries
* src/openvz_driver.c: another cleanup patch from Evgeniy Sokolov
cleaning up the exec calls to OpenVZ binaries
Daniel
Daniel Veillard [Thu, 10 Jul 2008 12:21:09 +0000 (12:21 +0000)]
cleanup OpenVZ error function
* src/openvz_conf.c src/openvz_conf.h src/openvz_driver.c
Makefile.maint: patch from Evgeniy Sokolov cleaning up the
error function used and format check based on Jim's fedback.
Daniel
Dan Smith [Thu, 26 Jun 2008 16:05:02 +0000 (16:05 +0000)]
[LXC] Detect support for NETNS in lxc driver initialization
Allow check for containers support to be done without CLONE_NEWNET, and then
determine support on the fly by checking for iproute2 support and a
successful clone(CLONE_NEWNET). This lets us set a flag for later, as well
as not completely disable LXC support on a system without NETNS support.
Daniel Veillard [Thu, 19 Jun 2008 14:39:49 +0000 (14:39 +0000)]
fix a couple of List functions for max = 0 issues
* src/xen_internal.c src/xend_internal.c: fix a couple of issues
for List functions where max given is 0
Daniel
Jim Meyering [Thu, 19 Jun 2008 14:30:52 +0000 (14:30 +0000)]
virsh fails to read files larger than BUFSIZ bytes
* src/util.c (fread_file_lim): Use VIR_REALLOC_N, not VIR_ALLOC_N.
Bug introduced in 895d0fdf5bef358fafb91c672609190b3088097b.
* tests/Makefile.am (test_scripts): Add read-bufsiz.
* tests/read-bufsiz: New test for the above.
Chris Lalancette [Thu, 19 Jun 2008 11:58:49 +0000 (11:58 +0000)]
For 0.4.3, danpb's new memory management scheme went into libvirt. This is
fine, except that is subtly alters the semantics of malloc(), calloc(), and
realloc(). In particular, if you say:
foo = malloc(0);
glibc will happily return a non-NULL pointer to you. However, with the new
memory management stuff, if you say:
foo = VIR_ALLOC(0);
you will actually get a NULL pointer back. Personally, I think this is a
dangerous deviation from malloc() semantics that everyone is used to, and is
indeed causing problems with the remote driver. The short of it is that the
remote driver allocates memory on behalf of the remote side using VIR_ALLOC_N,
and this call is returning NULL so that the NULL checks elsewhere in the code
fire and return failure.
The attached patch fixes this situation by removing the 0 checks from the memory
allocation paths, and just lets them fall through to the normal malloc(),
calloc(), or realloc() routines, restoring old semantics.
Signed-off-by: Chris Lalancette <clalance@redhat.com>