]> git.ipfire.org Git - thirdparty/samba.git/log
thirdparty/samba.git
16 years agos3:passdb: add SAMU_BUFFER_V4 with no changes
Stefan Metzmacher [Tue, 16 Dec 2008 10:51:14 +0000 (11:51 +0100)] 
s3:passdb: add SAMU_BUFFER_V4 with no changes

The upgrade is required because of the followin TDBSAM_VERSION
upgrade.

metze
(cherry picked from commit 671469ae7e3013809fe3995ec8f33dda9adda2ed)
(cherry picked from commit 513d7cf7dd8758045ba7666785dbada88a990ce1)

16 years agos3:passdb: make marshalling struct samu from and to a buffer more generic
Stefan Metzmacher [Mon, 15 Dec 2008 17:46:37 +0000 (18:46 +0100)] 
s3:passdb: make marshalling struct samu from and to a buffer more generic

This marshalling isn't specific to tdbsam and it's
ugly to have the related functions in two different files.

metze
(cherry picked from commit 0544734309feea44e8d449737a9934231f63693d)
(cherry picked from commit d54fb8838a418493ebc7a559af4be95def97dfd9)

16 years agoFix a memory leak in cups_pull_comment_location
Volker Lendecke [Tue, 30 Dec 2008 14:47:06 +0000 (15:47 +0100)] 
Fix a memory leak in cups_pull_comment_location

We allocated "request" with ippNew, so we also should ippDelete it.
(cherry picked from commit 6118aaeb2d4b164c5ed213aa2ae25ed13bfe1c22)

16 years agoFix a spinning smbd when printing
Volker Lendecke [Tue, 30 Dec 2008 13:05:26 +0000 (14:05 +0100)] 
Fix a spinning smbd when printing

Without this, we end up adding more than one timed event. In the event handler
print_notify_event_send_messages() only one event will be deleted, all others
will fire indefinitely.
(cherry picked from commit dec9368e7458048b783bb2f967f578d5e094d805)

16 years agoDon't increment twice
Volker Lendecke [Mon, 29 Dec 2008 22:24:43 +0000 (23:24 +0100)] 
Don't increment twice

Thanks metze :-)
(cherry picked from commit fe100673121b73cc2091726d068d9a3e53bf494e)

16 years agoSecond part of the bugfix for #5933
Volker Lendecke [Mon, 29 Dec 2008 21:06:08 +0000 (22:06 +0100)] 
Second part of the bugfix for #5933

Incrementing the next vuid did not correctly overflow

Now we survive BENCH-SESSSETUP with -o 100000. Takes a while though :-)

Thanks a lot to Ofer Tal <otsmb@shmoop.org> for reporting #5933
(cherry picked from commit b99206414f6a90c9b2223a25f3ddf5290861363d)

16 years agoFirst part of bugfix for #5933
Volker Lendecke [Mon, 29 Dec 2008 21:01:57 +0000 (22:01 +0100)] 
First part of bugfix for #5933

Ofer Tal <otsmb@shmoop.org> fully correctly noted that we're incrementing
num_validated_vuids twice per session setup, but decrement it only once.
Looking at sesssetup.c we always call register_initial_vuid() before
register_existing_vuid(), so there's no point in incrementing it in
register_existing_vuid().

Jeremy, please check!
(cherry picked from commit 769989008d97308d2a10675a91ae2dfdde493bab)

16 years agos3:dbwrap: fix dbwrap_store_uint32() to match dbwrap_store_int32()
Stefan Metzmacher [Wed, 17 Dec 2008 16:16:50 +0000 (17:16 +0100)] 
s3:dbwrap: fix dbwrap_store_uint32() to match dbwrap_store_int32()

All callers expect 0 an success and -1 on error.

metze
(cherry picked from commit a255f9ce713b29552722ec73e4038226959e1c8e)
(cherry picked from commit 9aa543fee7ebcc95125d18868bdec7e4bf577d8a)

16 years agoAdd code to test write_data_iov a bit
Volker Lendecke [Mon, 22 Dec 2008 21:42:44 +0000 (22:42 +0100)] 
Add code to test write_data_iov a bit
(cherry picked from commit 8c7552790934397c1bbb7e93eb64716a5fed31fa)

16 years agoAttempt to fix bug 5953: Make cli_send_smb_direct_writeX use writev
Volker Lendecke [Mon, 22 Dec 2008 21:32:12 +0000 (22:32 +0100)] 
Attempt to fix bug 5953: Make cli_send_smb_direct_writeX use writev

It seems there are SMB servers around which can't cope with the write header
being sent in a packet of its own. With writev we keep the advantage of direct
writes, giving the kernel the chance to coalesce the write calls.
(cherry picked from commit 1cbe293e7ba16968bf0e106cb6ee723a1f31d5bb)

16 years agoMake write_data use write_data_iov
Volker Lendecke [Mon, 22 Dec 2008 21:17:59 +0000 (22:17 +0100)] 
Make write_data use write_data_iov
(cherry picked from commit f77527188bdc40a77764451c2fb7bba511a1f5a2)

16 years agoAdd write_data_iov
Volker Lendecke [Mon, 22 Dec 2008 21:17:28 +0000 (22:17 +0100)] 
Add write_data_iov
(cherry picked from commit efd5aa6a75c68c6fa48eaa928e652e3cacf0e18e)

16 years agoAdd sys_writev
Volker Lendecke [Sun, 21 Dec 2008 22:22:30 +0000 (23:22 +0100)] 
Add sys_writev
(cherry picked from commit 886ebe3b6f7b5304ae9c185ee14a444977afac24)

16 years agoFix some nonempty blank lines
Volker Lendecke [Sun, 24 Aug 2008 10:46:26 +0000 (12:46 +0200)] 
Fix some nonempty blank lines
(cherry picked from commit 010c7101e59477f0d5f3bf11c17f474ec6f79cc1)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit c1e0d89d00885dd227b9cec719f2fb3fbc69aea3)

16 years agoFix some C++ warnings
Volker Lendecke [Sun, 24 Aug 2008 10:43:36 +0000 (12:43 +0200)] 
Fix some C++ warnings
(cherry picked from commit dd9e4e6db04acf20f6ef7705955358c7ca442bbd)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit c04b8a612c880513971ea5a03c4d0c120bfa6c4a)

16 years agoFix bug #5990 - strict allocate should be checked before ftruncate
Jeremy Allison [Thu, 25 Dec 2008 20:12:22 +0000 (12:12 -0800)] 
Fix bug #5990 - strict allocate should be checked before ftruncate
reported by and based on a patch by Yasuma Takeda <yasuma@osstech.co.jp>.
Jeremy.
(cherry picked from commit 60707022622068dd5df5c7b5aa82e0d34ed544f5)

16 years agoidmap: Remove passd check from idmap_backends_unixid_to_sid().
Michael Adam [Wed, 1 Oct 2008 06:53:15 +0000 (08:53 +0200)] 
idmap: Remove passd check from idmap_backends_unixid_to_sid().

As noted by Metzy, it makes no sense here to check id->sid.
What is worse, this might even be passed in uninitialized.

This still fixes the bug for me (of course), but we might need
to check, if another special handling of passdb is needed
(possibly changing from constant return code NT_STATUS_OK...)

Michael
(cherry picked from commit 651b5d6deaab4fb3cb726fafd98171c79777631c)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 3d22b77f1ac5e8f83d1063d87c68e60655a3ed6b)

16 years agoFix uid_to_sid mapping when the idmap cache is empty.
Michael Adam [Wed, 1 Oct 2008 06:30:15 +0000 (08:30 +0200)] 
Fix uid_to_sid mapping when the idmap cache is empty.

This failed for backends other than passed, since
idmap_backends_unixid_to_sid() always asked passdb first,
which returned Success no matter whether a mapping was
found or not.

One effect wast that getpwuid failed after "net cache flush".
Only after filling the cache with a getpwnam call it succeeded.

This fix makes the behaviour of idmap_backends_unixid_to_sid()
exactly the same as that of idmap_backends_sid_to_unixid()

Michael
(cherry picked from commit da7eb5e22e56ea718e393375085cf66a90afafc8)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit d4bc1f8d79929dc1a1d06e92eaf85923a1848e6f)

16 years agoFix more asprintf warnings and some error path errors.
Jeremy Allison [Tue, 23 Dec 2008 20:10:47 +0000 (12:10 -0800)] 
Fix more asprintf warnings and some error path errors.
Jeremy.
(cherry picked from commit 44ab658b6d80c66f20d80aede7fc7cd2b9a941b1)

16 years agoMore asprintf warning fixes.
Jeremy Allison [Tue, 23 Dec 2008 19:57:03 +0000 (11:57 -0800)] 
More asprintf warning fixes.
Jeremy.
(cherry picked from commit b37c96a4fcf35ba2208078a53bf9484dcd31bd31)

16 years agoMore asprintf warning fixes.
Jeremy Allison [Tue, 23 Dec 2008 19:45:40 +0000 (11:45 -0800)] 
More asprintf warning fixes.
Jeremy.
(cherry picked from commit badf7dc63fe96930700e7ea04d6d6f66a7a8c1f3)

16 years agoFix more asprintf errors and error code paths.
Jeremy Allison [Tue, 23 Dec 2008 19:29:02 +0000 (11:29 -0800)] 
Fix more asprintf errors and error code paths.
Jeremy.
(cherry picked from commit 0f02a165e23d716dcf3791eeaa6a5afebe7a1f88)

16 years agoFix more ‘asprintf’, declared with attribute warn_unused_result.
Jeremy Allison [Tue, 23 Dec 2008 18:42:38 +0000 (10:42 -0800)] 
Fix more ‘asprintf’, declared with attribute warn_unused_result.
Jeremy.
(cherry picked from commit 9ebaf67d1dce717cafd5761b2f66296712a09957)

16 years agoFix more "warning: ignoring return value of ‘asprintf’, declared with
Jeremy Allison [Tue, 23 Dec 2008 18:27:37 +0000 (10:27 -0800)] 
Fix more "warning: ignoring return value of ‘asprintf’, declared with
attribute warn_unused_result"
Jeremy.
(cherry picked from commit f0c0f2bee3bb874ba841a3b73c8677cd0ba67873)

16 years agoFix another "format not a string literal and no format arguments" warning.
Jeremy Allison [Tue, 23 Dec 2008 17:49:47 +0000 (09:49 -0800)] 
Fix another "format not a string literal and no format arguments" warning.
Jeremy
(cherry picked from commit fc04faf9668bf0176ffd8d5c20e65aa83d63021b)

16 years agos3: Fix stream marshalling to return the correct streaminfo status
Tim Prouty [Tue, 23 Dec 2008 17:20:06 +0000 (09:20 -0800)] 
s3: Fix stream marshalling to return the correct streaminfo status

When there are enough streams on a file to fill up the max_data_count
when responding to a trans2 streaminfo, samba is returning
NT_STATUS_BUFFER_TOO_SMALL.  Windows handles this by returning
NT_STATUS_BUFFER_OVERFLOW while still sending as much of the data that
it can fit into the buffer.  When the windows client sees
BUFFER_OVERFLOW, it retries the streaminfo with a larger buffer (2x).
The windows client starts at 2K and will continue increasing the
buffer size by two until it reaches 64K.  If the streams don't fit in
64K the windows client seems to give up.

This patch fixes marshall_stream_info to overfill the buffer by 1
stream so that send_trans2_replies can properly detect the overflow
and return the correct status.
(cherry picked from commit 3643a1179df42d47c2913c7d5c6a4ec8d8b8eb9d)

16 years agoIn gcc version 4.3.2 we get warnings for functions declared with
Jeremy Allison [Tue, 23 Dec 2008 04:05:45 +0000 (20:05 -0800)] 
In gcc version 4.3.2 we get warnings for functions declared with
attribute warn_unused_result. Start to fix these.
Jeremy.
(cherry picked from commit dfd983881341bfbc811199901ae3d8fe973649c1)

16 years agoFix "allow trusted domain" so it disables trusted domains.
Gerald (Jerry) Carter [Mon, 22 Dec 2008 19:06:29 +0000 (11:06 -0800)] 
Fix "allow trusted domain" so it disables trusted domains.
(cherry picked from commit 2d6946bf3a3b7465c92e707ef136e34996ae90be)

16 years agoWHATSNEW: Add "ldap ssl = start tls" to the release notes.
Karolin Seeger [Sun, 21 Dec 2008 08:15:17 +0000 (09:15 +0100)] 
WHATSNEW: Add "ldap ssl = start tls" to the release notes.

Karolin
(cherry picked from commit 9a94c466210097c852d7e049a57e5777dea6ad84)

16 years agos3:loadparm/docs: Set default for "ldap ssl" to "start tls".
root [Sun, 21 Dec 2008 07:55:30 +0000 (08:55 +0100)] 
s3:loadparm/docs: Set default for "ldap ssl" to "start tls".

This has been discussed on samba-technical before.
3.3 and newer only!

Karolin
(cherry picked from commit a89f7c1f82b03d23a140bdee46b9a60cb8547330)

16 years agos3: loadparm: Clean-up list of parameters.
Karolin Seeger [Sun, 21 Dec 2008 07:23:39 +0000 (08:23 +0100)] 
s3: loadparm: Clean-up list of parameters.

We don't need to list several combinations of lowercase and uppercase here.

Karolin
(cherry picked from commit f2f9956a8ae1f2d6b1807c848961d797549b696b)

16 years agoFix bug #5986 - Editing a stream is broken (rename problems).
Jeremy Allison [Fri, 19 Dec 2008 21:58:22 +0000 (13:58 -0800)] 
Fix bug #5986 - Editing a stream is broken (rename problems).
Jeremy.
(cherry picked from commit d53aa6257d39313b1b493805a2a73774e07faf8a)

16 years agoFix a "ignoring function call result" warning
Volker Lendecke [Fri, 19 Dec 2008 20:05:19 +0000 (12:05 -0800)] 
Fix a "ignoring function call result" warning
(cherry picked from commit bb168470676a610cd77cde196260611a49ddf5d1)

16 years agocorrect the description of the "ldap timeout" parameter
Björn Jacke [Fri, 19 Dec 2008 11:12:59 +0000 (12:12 +0100)] 
correct the description of the "ldap timeout" parameter
(cherry picked from commit 1aff97bc48844afba5de48447fdcdcc02d163a97)
(cherry picked from commit 64656ac02cd9d46224f17f840b4e2c0a9ddf6ba9)

16 years agoComment out the parent inheritance code (this is incorrect) as was
Jeremy Allison [Thu, 18 Dec 2008 23:36:34 +0000 (15:36 -0800)] 
Comment out the parent inheritance code (this is incorrect) as was
done for POSIX ACLs.
Jeremy.
(cherry picked from commit 19b6d80d6bb1d144ac0a303b09e208750b959ee6)

16 years agoFix bug #5980 - Race condition when granting level2 oplocks can cause break notify...
Jeremy Allison [Thu, 18 Dec 2008 21:28:09 +0000 (13:28 -0800)] 
Fix bug #5980 - Race condition when granting level2 oplocks can cause break notify to be missed.
Jeremy.
(cherry picked from commit 61ec751fe3560b47681d414506eca934786e122d)

16 years agoFix bug #5979 - Level 2 oplocks being granted improperly,
Jeremy Allison [Thu, 18 Dec 2008 01:22:34 +0000 (17:22 -0800)] 
Fix bug #5979 - Level 2 oplocks being granted improperly,
Jeremy.
(cherry picked from commit da1852f65188efc559738c2e5da295b702ad4619)

16 years agopackaging(RHEL-CTDB): fix typo in [u]mount.cifs installation
Michael Adam [Wed, 17 Dec 2008 21:27:39 +0000 (22:27 +0100)] 
packaging(RHEL-CTDB): fix typo in [u]mount.cifs installation

Michael
(cherry picked from commit 835108bcf84a5f47f46d237c7a93c572348125a1)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 801e8bbdebe2d5136faf7348294b3cb5a1d43d7e)

16 years agopackaging(RHEL-CTDB): fix build of [u]mount.cifs
Michael Adam [Wed, 17 Dec 2008 17:56:34 +0000 (18:56 +0100)] 
packaging(RHEL-CTDB): fix build of [u]mount.cifs

mount.cifs is now built by make everything.
And it needs extra objects anyways (mtab.o),
which is why the build of mount.cifs failed.

Michael
(cherry picked from commit 96c811cf222be5463a6705feae73d6215685c5f1)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 5b572dea08d804797a3265ca5fe4c09177ed768f)

16 years agopackaging(RHEL-CTDB): Fix accidential linebreak
Michael Adam [Wed, 17 Dec 2008 15:59:24 +0000 (16:59 +0100)] 
packaging(RHEL-CTDB): Fix accidential linebreak

Michael
(cherry picked from commit 5cd8ff8a2aba6b1d6821d4ebb986449b03d40542)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit e67dc7b73bbd4a7fe9973d7cd6dee052a65b09be)

16 years agoFix a valgrind error
Volker Lendecke [Wed, 17 Dec 2008 17:14:09 +0000 (18:14 +0100)] 
Fix a valgrind error

Reported by naga_kishore_kommuri@yahoo.com

Derrel, please check!

Thanks,

Volker
(cherry picked from commit 3356b95f72e26ede4ab16a12c334be90b8b1a639)
(cherry picked from commit 1117be19afb71d595ce4215e4760b18ff2e93869)

16 years agos3/smb.h: Remove unused LDAP_SSL_ON.
Karolin Seeger [Wed, 17 Dec 2008 15:26:43 +0000 (16:26 +0100)] 
s3/smb.h: Remove unused LDAP_SSL_ON.

LDAP_SSL_ON is not defined at all.
Ldaps can be used by specifying an ldaps URL using the "passdb backend"
parameter.

Karolin
(cherry picked from commit 0c6cf1f8793edfde924289aafbd174ce4a4fae0c)

16 years agos3/loadparm.c: Change default value for "ldap ssl".
Karolin Seeger [Wed, 17 Dec 2008 14:53:51 +0000 (15:53 +0100)] 
s3/loadparm.c: Change default value for "ldap ssl".

LDAP_SSL_ON is not defined at all. That's why the actual default value
was "" for a long time. Set a more sensible default value without chnging the
default behaviour.

-----8<------------------snip--------------8<--------------
user@host:/data/git/samba/v3-0-test/source> git grep LDAP_SSL_ON | cat
include/smb.h:enum ldap_ssl_types {LDAP_SSL_ON, LDAP_SSL_OFF,
LDAP_SSL_START_TLS};
param/loadparm.c:       Globals.ldap_ssl = LDAP_SSL_ON;
----->8------------------snap-------------->8--------------

It's the same in 3.2 and 3.3 series.

Karolin
(cherry picked from commit e6d883e003d4560c55259ae1cfdf7319602f76e3)

16 years agodocs: Fix typo in man idmap_hash.
Karolin Seeger [Wed, 17 Dec 2008 15:28:59 +0000 (16:28 +0100)] 
docs: Fix typo in man idmap_hash.

Karolin
(cherry picked from commit 994ef68164c12a3b0494f6491bc9f402c912600f)
(cherry picked from commit 5f7b6f6a3f31b77d133a40b8951ce78b86510135)

16 years agodocs: Update section "ldap ssl" in man smb.conf.
Karolin Seeger [Wed, 17 Dec 2008 15:18:38 +0000 (16:18 +0100)] 
docs: Update section "ldap ssl" in man smb.conf.

Remove non-existent value "on".
Change default value to "no".
Add hint about ldaps.

Karolin
(cherry picked from commit 580461629bb88ce3b61770e7abfe2c942a121877)
(cherry picked from commit d74356627579fe7b9961844a77c4e6daa978d62b)

16 years agodocs: Fix some formatting issues in the "ldap ssl" section of man smb.conf.
Karolin Seeger [Wed, 17 Dec 2008 14:42:12 +0000 (15:42 +0100)] 
docs: Fix some formatting issues in the "ldap ssl" section of man smb.conf.

Karolin
(cherry picked from commit 6ac36698e975649d26e3f2975c2101129c3ffe97)
(cherry picked from commit 655a1c7b05d56326d6cfffbc8e46e1d64565717a)

16 years agoTweak with pam defines of older Linux versions
Lars Müller [Wed, 17 Dec 2008 14:39:35 +0000 (15:39 +0100)] 
Tweak with pam defines of older Linux versions

PAM_AUTHTOK_RECOVERY_ERR is not defined by older Linux versions (SUSE
Linux Enterprise 9 and RedHat Enterprise 4).

Patch suggested by Philipp Thomas <pth at suse dot de>.
(cherry picked from commit b6e1eb476ccd19209ed135ab8c3b7b2b10422b0e)

16 years agodocs: Fix TOC of generated HTML docs.
Karolin Seeger [Wed, 17 Dec 2008 08:17:26 +0000 (09:17 +0100)] 
docs: Fix TOC of generated HTML docs.

This fixes bug #5968.
Thanks to Christian Perrier <bubulle@debian.org> for reporting!

Karolin
(cherry picked from commit 675b363b712e0b91b9b7d1189a819a36853db539)
(cherry picked from commit 3566615292f9cb2d00b03156e515274751e05969)

16 years ago(Fixed) Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentatio...
Kai Blin [Tue, 16 Dec 2008 21:42:12 +0000 (13:42 -0800)] 
(Fixed) Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentation fault (with NAS-BASIC server).
(cherry picked from commit 52654119cbf15acf6c4663b171df04e9a2bc26b7)

16 years agoRevert "Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentatio...
Jeremy Allison [Tue, 16 Dec 2008 21:36:06 +0000 (13:36 -0800)] 
Revert "Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentation fault (with NASBASIC server)."
Error in commit !

This reverts commit e3cb04101453762cda13f16e3e48d704761d5d67.
(cherry picked from commit 4617080b6c4b80bee9c5ebe596636229f778fa62)

16 years agoFinal part of fix for bug #5953 - smbclient crashes: cli_list_new segmentation fault...
Kai Blin [Tue, 16 Dec 2008 21:15:48 +0000 (13:15 -0800)] 
Final part of fix for bug #5953 - smbclient crashes: cli_list_new segmentation fault (with NASBASIC server).
(cherry picked from commit e3cb04101453762cda13f16e3e48d704761d5d67)

16 years agocommit b520befe6f51644d20434add9864d7a2fa30aa2e
SATOH Fumiyasu [Tue, 16 Dec 2008 15:54:30 +0000 (00:54 +0900)] 
commit b520befe6f51644d20434add9864d7a2fa30aa2e
Author: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Date:   Wed Dec 17 00:42:25 2008 +0900

    libsmbclient: Fix SIGBUS on non-x86 CPUs

    We must align the struct smbc_dirent in the struct
    SMBC_internal_data because the struct smbc_dirent
    has numeric values that require alignment.

Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
(cherry picked from commit 2957c03ab59735159aaf108e87a2e571f984fb5d)

16 years agonss_winbind: Solaris 64-bit fix and...
SATOH Fumiyasu [Tue, 16 Dec 2008 15:59:07 +0000 (16:59 +0100)] 
nss_winbind: Solaris 64-bit fix and...

PATCH 1:
Fix gmem->numgids and gmem->maxgids breakage on Solaris 64-bit
because sizeof(int) != sizeof(long int).

PATCH 2:
This patch fixes a compile-time warning
"warning: implicit function declaration: _nss_winbind_initgroups_dyn".
(cherry picked from commit cb036772d09227f870c2fec3ecd8c3f53787dfbc)
(cherry picked from commit 085f4cdb90b12d60804001fd60659a4aa4a174fd)

16 years agodocs: "acl compatibility" is a global parameter.
Karolin Seeger [Tue, 16 Dec 2008 14:10:29 +0000 (15:10 +0100)] 
docs: "acl compatibility" is a global parameter.

This fixes bug #5866.
Thanks to TAKAHASHI Motonobu <monyo@samba.gr.jp> for reporting!

Karolin
(cherry picked from commit 9e64ed018e5aa84d802b01953b481fbb07eb00aa)
(cherry picked from commit 386b0fc4bdc0822ffbc51cfee536bea23df0a755)

16 years agoAdd an entry for the "check" command to the tdbtool manpage.
Holger Hetterich [Thu, 20 Nov 2008 09:32:14 +0000 (10:32 +0100)] 
Add an entry for the "check" command to the tdbtool manpage.
(cherry picked from commit c46c21cde33a9cc1de9d947de64c27052ecce988)

16 years agoAdded a simple tdb integrity check to tdbtool. The command "check" runs traverse...
Holger Hetterich [Sat, 1 Nov 2008 23:12:32 +0000 (00:12 +0100)] 
Added a simple tdb integrity check to tdbtool. The command "check" runs traverse on the currently open tdb, and returns the number of entries if the integrity check is successful.
(cherry picked from commit 12629532985ac9fdc900d8811c33651587d0796d)

16 years agodocs: Raise version number from 3.2 to 3.3.
Karolin Seeger [Tue, 16 Dec 2008 11:03:45 +0000 (12:03 +0100)] 
docs: Raise version number from 3.2 to 3.3.

Karolin
(cherry picked from commit 37543c74d72c1e76df6ff8eeae45883777044bf5)

16 years agodocs: Remove comment about default backend.
Karolin Seeger [Tue, 16 Dec 2008 10:18:45 +0000 (11:18 +0100)] 
docs: Remove comment about default backend.

Karolin
(cherry picked from commit 46f530e42f42b860407696f4e4733ad88e69f1be)
(cherry picked from commit 7cda2d4e26d82ed02719fb098a15760065420658)

16 years agodocs: Fix typo in the idmap_ad manpage.
Karolin Seeger [Tue, 16 Dec 2008 08:04:32 +0000 (09:04 +0100)] 
docs: Fix typo in the idmap_ad manpage.

Karolin
(cherry picked from commit b876e1336bed52e0823e0e88381d223bd6aa95e4)
(cherry picked from commit 611ac35a694930693d2f773d15e59be138261a8e)

16 years agos3:net_status: use dbwrap to open sessionid.tdb
Stefan Metzmacher [Mon, 15 Dec 2008 15:47:38 +0000 (16:47 +0100)] 
s3:net_status: use dbwrap to open sessionid.tdb

metze
(cherry picked from commit 8891b2b0215a3609fcc8c5f9aa3e2fbcf05c6290)
(cherry picked from commit 598bf8fbe38d76adca2e067c90987d9cd31e8a3e)

16 years agoFix bug 5969: Optimize smbclient put command
Volker Lendecke [Mon, 15 Dec 2008 11:46:04 +0000 (12:46 +0100)] 
Fix bug 5969: Optimize smbclient put command

This used to be checkin 3f0406f6 to master
(cherry picked from commit 91ecce438f0fd38ac933ba9bc493e79f8eb5a63a)

16 years agofix build of pam_winbind.so on older Linux systems.
Michael Adam [Mon, 15 Dec 2008 10:38:32 +0000 (11:38 +0100)] 
fix build of pam_winbind.so on older Linux systems.

Older pam implementations on Linux define PAM_AUTHTOK_RECOVER_ERR
instead of PAM_AUTHTOK_RECOVERY_ERR. We have always defined and
are using PAM_AUTHTOK_RECOVER_ERR in all other places.

Michael
(cherry picked from commit d217acb9066b9a6282be3ff737d78e5d9c985ae1)

16 years agoWHATSNEW: Update changes since 3.3.0rc1. samba-3.3.0rc2
Karolin Seeger [Mon, 15 Dec 2008 08:10:11 +0000 (09:10 +0100)] 
WHATSNEW: Update changes since 3.3.0rc1.

Karolin
(cherry picked from commit 34f96b0cdcee3a8ab6612313e70b682f2aa29538)

16 years agoVERSION: Change version to 3.3.0rc2.
Karolin Seeger [Mon, 15 Dec 2008 07:59:11 +0000 (08:59 +0100)] 
VERSION: Change version to 3.3.0rc2.

Karolin

16 years agodon't return 0 on error - bad for scripts
Herb Lewis [Sat, 13 Dec 2008 20:18:15 +0000 (12:18 -0800)] 
don't return 0 on error - bad for scripts
(cherry picked from commit 79d68083411e9119933dbf5c850cb78f47e6f553)

16 years agos3:dsgetdcname: retry with the clients site
Stefan Metzmacher [Fri, 21 Nov 2008 07:28:13 +0000 (08:28 +0100)] 
s3:dsgetdcname: retry with the clients site

metze
(cherry picked from commit 1b7b0e924f3064a9774fd5d46bedc3d342b39ddb)
(cherry picked from commit f7a811f2ae3572791035014b6e20410b07ea011e)

16 years agos3:libnet_join: use DS_FORCE_REDISCOVERY
Stefan Metzmacher [Fri, 21 Nov 2008 07:22:38 +0000 (08:22 +0100)] 
s3:libnet_join: use DS_FORCE_REDISCOVERY

metze
(cherry picked from commit 2bb91392b46e347fe3b6803d10b10d8b40e4a4a6)
(cherry picked from commit 134893ef2b12b4b039c717588a8172613f6d1955)

16 years agos3:libnet_join: call saf_join_store() after a the join.
Stefan Metzmacher [Mon, 27 Oct 2008 18:40:23 +0000 (19:40 +0100)] 
s3:libnet_join: call saf_join_store() after a the join.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(similar to commit feef594d275881466e2c3f59c0ff54609a9cc53b)
(cherry picked from commit 6a993cb333675f4079d439fa334edee2df604933)
(cherry picked from commit 8314ce63ff77f0472d4249adcea87123b3b3f5c2)

16 years agos3:libads/ldap.c: store the dc name in the saf cache as in all other places
Stefan Metzmacher [Mon, 27 Oct 2008 18:39:30 +0000 (19:39 +0100)] 
s3:libads/ldap.c: store the dc name in the saf cache as in all other places

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 543fa85a711337e979c7b631bda5db95d109ef59)
(cherry picked from commit 17efebde11eafd065c2cac39cdbe55b8d40d40be)
(cherry picked from commit 9e78bfdbe107519f2ddfa4d532771945a7691b46)

16 years agos3:libads/ldap.c: if the client belongs to no site at all any dc is the closest
Stefan Metzmacher [Mon, 27 Oct 2008 18:38:15 +0000 (19:38 +0100)] 
s3:libads/ldap.c: if the client belongs to no site at all any dc is the closest

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit f86ef9b53a903485deba94febf90dd4e657cc02b)
(cherry picked from commit a8040d59659e58c5cb92c1107a7ff012eff12729)
(cherry picked from commit 7baceea20252dec6b64e86ec8b5a73b62b373758)

16 years agos3:libads/ldap.c: pass the real workgroup name to get_dc_name()
Stefan Metzmacher [Mon, 27 Oct 2008 18:36:25 +0000 (19:36 +0100)] 
s3:libads/ldap.c: pass the real workgroup name to get_dc_name()

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit c2d4a84abe1b6cbf68d6e9f1bb1f8974d0b628fc)
(cherry picked from commit 2f27ffc4a2ba745341a5961b8f04e62da3fb089a)
(cherry picked from commit 132911954715bfa6df8566c0fb382ef07a7da96e)

16 years agos3:libsmb/namequery.c: add saf_join_store() function
Stefan Metzmacher [Mon, 27 Oct 2008 18:31:30 +0000 (19:31 +0100)] 
s3:libsmb/namequery.c: add saf_join_store() function

saf_join_store() should be called after a successful
domain join, the affinity to the dc used at join time
has a larger ttl, to avoid problems with delayed replication.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 80e74a27c55c01221091e3eec930c2ac4433c22c)
(cherry picked from commit 895c40d03a07182c054a6fd857e7dd6838e698f4)
(cherry picked from commit 7b56268b3c9652e3089bd75e4e51dd626fa742a6)

16 years agos3: libsmb/namequery: fallback to returning all dcs, when none is available in the...
Stefan Metzmacher [Mon, 27 Oct 2008 08:40:25 +0000 (09:40 +0100)] 
s3: libsmb/namequery: fallback to returning all dcs, when none is available in the requested site

It could happen that all dcs in a site are unavailable
(some sites have only one dc) and then we need to fallback
to get all dcs.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit c127367b1dd622eeceb1f47de0a047c297dda222)
(cherry picked from commit 0c43f96330f2935805ba4f0f8f858a027a90bc4c)
(cherry picked from commit caaf59383ceabdc555f7db098dae0455dea65023)

16 years agos3: libads: use get_dc_name() instead of get_sorted_dc_list() in the LDAP case
Stefan Metzmacher [Wed, 22 Oct 2008 09:14:10 +0000 (11:14 +0200)] 
s3: libads: use get_dc_name() instead of get_sorted_dc_list() in the LDAP case

We use get_dc_name() for LDAP because it generates the selfwritten
krb5.conf with the correct kdc addresses and sets KRB5_CONFIG.

For CLDAP we need to use get_sorted_dc_list() to avoid recursion.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit d2f7f81f4d61bae9c4be65cbc1bf962b6c24a31f)
(cherry picked from commit 7f779450cb0b0d9f36665c56c4acd0950daaeab2)
(cherry picked from commit 95c9a0272a72c029d75c3ffd1b5fad360b30f139)

16 years agos3: correctly detect if the current dc is the closest one
Stefan Metzmacher [Wed, 22 Oct 2008 08:36:21 +0000 (10:36 +0200)] 
s3: correctly detect if the current dc is the closest one

ads->config.tried_closest_dc was never set.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit dfe5b00db35e1e7c7bb3ba36729fc3f97eb48db3)
(cherry picked from commit 588f5aae669910fee6da7f807f330163496b4170)
(cherry picked from commit b609f41baa035a15dafb18b2ec569a2b96968b17)

16 years agowinbindd: vars for signals must be volatile sig_atomic_t
SATOH Fumiyasu [Fri, 12 Dec 2008 16:43:51 +0000 (17:43 +0100)] 
winbindd: vars for signals must be volatile sig_atomic_t
(cherry picked from commit 6ffff93aa3d6e2ecf8716ad44db614cb746d1b56)

16 years agoFix error code when smbclient puts a file over an existing directory
Volker Lendecke [Fri, 12 Dec 2008 12:47:41 +0000 (13:47 +0100)] 
Fix error code when smbclient puts a file over an existing directory

Windows returns NT_STATUS_FILE_IS_A_DIRECTORY, as does Samba 3.0. 3.2 and
following returned NT_STATUS_INVALID_PARAMETER which is wrong.

Before I converted reply_open_and_X to create_file() we called
open_file_ntcreate directly. Passing through open&X for a filename that exists
as a directory ends up in open_directory after having tried open_file_ntcreate.
Some check in there returns NT_STATUS_INVALID_PARAMETER. With this additional
FILE_NON_DIRECTORY_FILE flag we get the correct error message back from
create_file_unixpath before trying open_directory().

Survives make test, but as this also touches the other open variants I would
like others to review this.

Volker
(cherry picked from commit fc4366ca11cac97819eb06a744cf8e35b4524bcc)

16 years agoFix the build
Volker Lendecke [Wed, 10 Dec 2008 15:58:40 +0000 (16:58 +0100)] 
Fix the build

Crap, too many trees and no instant, infinitely fast rebuild

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 6459f00d1cad1d5e9e14851610ca7a92406ad54a)

16 years agoAlso search for -lgpfs which is available as GPL in GPFS PTF8 (cherry picked from...
Volker Lendecke [Wed, 10 Dec 2008 17:17:59 +0000 (18:17 +0100)] 
Also search for -lgpfs which is available as GPL in GPFS PTF8 (cherry picked from commit 3c93c96fd0fe362c35fe8127058f94868abc9342)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 011bcdec1960f4e62538046814d381938956644c)

16 years agoMake use of smbd_gpfs_get_realfilename_path in unix_convert (cherry picked from commi...
Volker Lendecke [Wed, 10 Dec 2008 11:32:24 +0000 (12:32 +0100)] 
Make use of smbd_gpfs_get_realfilename_path in unix_convert (cherry picked from commit b37684ffcec4ba0beada55d37bcaf4f5e79bcd58)

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 25e2ff536b2eeffa18b91ab2141d8350d2130824)

16 years agoFix nonempty blank lines in vfs_gpfs.c
Volker Lendecke [Wed, 10 Dec 2008 02:22:04 +0000 (03:22 +0100)] 
Fix nonempty blank lines in vfs_gpfs.c

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit ca5ee1861f0aa170eb862efdb27256a62f20e2b0)

16 years agos3:modules/gpfs: Fix nonempty blank lines
Volker Lendecke [Wed, 1 Oct 2008 10:26:55 +0000 (12:26 +0200)] 
s3:modules/gpfs: Fix nonempty blank lines
(cherry picked from commit efa578bbfe49fdcb14ae6e390a0d54810174dfbc)

16 years agoPass the get_real_filename operation through the VFS
Volker Lendecke [Wed, 10 Dec 2008 02:17:19 +0000 (03:17 +0100)] 
Pass the get_real_filename operation through the VFS

This is done to help file systems that can tell us about the real upper/lower
case combination given a case-insensitive file name. The sample I will soon
push is the gpfs module (recent gpfs has a get_real_filename function), others
might have a similar function to help alleviate the 1million files in a single
directory problem.

Jeremy, please comment!

Thanks,

Volker
(cherry picked from commit bddb6a770f036a21f5485e4f1167628f70d56079)

16 years agoChange get_real_filename() to unix syscall conventions, make it non-static
Volker Lendecke [Wed, 10 Dec 2008 02:03:51 +0000 (03:03 +0100)] 
Change get_real_filename() to unix syscall conventions, make it non-static

It sets errno, so it might as well return 0/-1.
(cherry picked from commit 95050a708c145e99f3c317a5e6834352cbdf5a8c)

16 years agoApply some const
Volker Lendecke [Tue, 9 Dec 2008 12:50:22 +0000 (13:50 +0100)] 
Apply some const
(cherry picked from commit 915b6fbf269a542603da289d8f67b6ca5226e1a0)

16 years agoRename "scan_directory" to "get_real_filename"
Volker Lendecke [Tue, 9 Dec 2008 12:40:41 +0000 (13:40 +0100)] 
Rename "scan_directory" to "get_real_filename"
(cherry picked from commit 9ce0855c11ed437e7e0776dbf725751ea7b84959)

16 years agos3 sesssetup.c: Add missing line break to debug message.
root [Fri, 12 Dec 2008 15:51:34 +0000 (16:51 +0100)] 
s3 sesssetup.c: Add missing line break to debug message.

Karolin
(cherry picked from commit eef7ee5f31dc94639580b01283bc0dbe9a90dbde)

16 years agoWHATSNEW: Prepare WHATSNEW for 3.3.0rc2.
Karolin Seeger [Fri, 12 Dec 2008 15:19:27 +0000 (16:19 +0100)] 
WHATSNEW: Prepare WHATSNEW for 3.3.0rc2.

Karolin
(cherry picked from commit b1875b8e543abfc836309bc6371039e590c6d523)

16 years agodocs: Add hint that "socket address" usually don't need to be set.
Karolin Seeger [Fri, 12 Dec 2008 13:30:01 +0000 (14:30 +0100)] 
docs: Add hint that "socket address" usually don't need to be set.

This fixes bug #5950.
Thanks to the Debian Samba package maintainers for reporting!

Karolin
(cherry picked from commit 19beef0dd9354296ae79d32077c58fbacf570c85)
(cherry picked from commit 0d035d36bd3707ccb9f77f0b2730869dc78719d4)
(cherry picked from commit 6be19f94802d545cc43286aa242b0ca2e5b79721)

16 years agomount.cifs: allow mounts to ipv6 capable servers
Jeff Layton [Fri, 12 Dec 2008 12:06:07 +0000 (07:06 -0500)] 
mount.cifs: allow mounts to ipv6 capable servers

The current name resolution scheme in mount.cifs is IPv4 only. Expand
it to be protocol-independent. Also take advantage of the fact that
getaddrinfo() returns a list of addresses and have mount.cifs try each
in turn until it hits one that's reachable and allows the socket to
connect.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit 4f19e0850bb457b41ea2953ca0d4e9aeaf3bc09a)

16 years agopackaging(RHEL-CTDB): don't show failure messages in check for ccache
Michael Adam [Mon, 1 Dec 2008 22:19:02 +0000 (23:19 +0100)] 
packaging(RHEL-CTDB): don't show failure messages in check for ccache

by fixing the order of "> /dev/null 2>&1"

Michael
(cherry picked from commit 0e9d5638a7c375b3b18f19f83f97924ab45ad382)
(cherry picked from commit 6e51f250c5d38e973948aa1d53222bcccdcca365)

16 years agopackaging(RHEL-CTDB): fix the build when ccache is not found.
Michael Adam [Mon, 1 Dec 2008 22:03:38 +0000 (23:03 +0100)] 
packaging(RHEL-CTDB): fix the build when ccache is not found.

Michael
(cherry picked from commit c98fb34ef933944a96a286d2d276cf2adc99e25e)
(cherry picked from commit 7d929d9fa363a1f1c67926678524f338e84b3535)

16 years agopackaging(RHEL-CTDB): explicitly build the gpfs module
Michael Adam [Mon, 1 Dec 2008 02:05:40 +0000 (03:05 +0100)] 
packaging(RHEL-CTDB): explicitly build the gpfs module

to prevent potetential problems on PTF8 systems where there
is no valid autodetecting configure check yet.

Michael
(cherry picked from commit 37039d345e9a25654bef038f2b8bb4b891cfa6f0)
(cherry picked from commit b486890eb0883508c5ade3e1e4e99ac728b6bf71)

16 years agopackaging(RHEL-CTDB): use ccache if available
Michael Adam [Mon, 1 Dec 2008 02:07:19 +0000 (03:07 +0100)] 
packaging(RHEL-CTDB): use ccache if available

Michael
(cherry picked from commit 36ca917a63f23126536e786bed845dee48fbf61c)
(cherry picked from commit 05b51bc176f87e7dc1b65adf3d866e797159d953)

16 years agopackaging(RHEL-CTDB): adapt configure.rpm to changes to the spec file
Michael Adam [Thu, 18 Sep 2008 03:02:14 +0000 (05:02 +0200)] 
packaging(RHEL-CTDB): adapt configure.rpm to changes to the spec file

Michael
(cherry picked from commit d249a9ca2a1761f20655cbcfe39fbc942547974d)
(cherry picked from commit 402ac73f436e1b1b71199bbef44be775dc67801c)

16 years agopackaging(RHEL-CTDB): move the cifs.upcall manpage to the client package
Michael Adam [Tue, 11 Nov 2008 12:47:37 +0000 (13:47 +0100)] 
packaging(RHEL-CTDB): move the cifs.upcall manpage to the client package

Michael
(cherry picked from commit 16f23eb27467ace9751ef2d1fbb6c4d3a5ae9550)
(cherry picked from commit 9538e3130f33ffde1d68eaea303b2b2dd9ddd71d)

16 years agopackaging(RHEL-CTDB): add the cifs.upcall binary to the client package.
Michael Adam [Tue, 11 Nov 2008 12:45:40 +0000 (13:45 +0100)] 
packaging(RHEL-CTDB): add the cifs.upcall binary to the client package.

Michael
(cherry picked from commit 1875b373a319ac9494fdc907793e59804c577a4d)
(cherry picked from commit e1dca5f1870975b7d9a57869357c971d559afdfe)

16 years agopackaging(RHEL-CTDB): fix typo in makerpms.sh
Michael Adam [Mon, 15 Sep 2008 14:15:42 +0000 (16:15 +0200)] 
packaging(RHEL-CTDB): fix typo in makerpms.sh

Michael
(cherry picked from commit 5fc5e82d4c2c386894fde95f94992171620c7853)
(cherry picked from commit 0e35ff0b46be2f9deab6e539c34970c85c3b58ce)

16 years agopackaging(RHEL-CTDB): refactor creation of spec file from template out
Michael Adam [Fri, 12 Sep 2008 13:50:33 +0000 (15:50 +0200)] 
packaging(RHEL-CTDB): refactor creation of spec file from template out

into new script makespec.sh

Michael
(cherry picked from commit d49a9d1c67e4d98017ce5f7d1351bca1366e1a8d)
(cherry picked from commit 086873f00de96ca48717b05dddb71e776c74ca7d)

16 years agopackaging(RHEL-CTDB): fix installation of pam modules
Michael Adam [Wed, 10 Sep 2008 21:06:28 +0000 (23:06 +0200)] 
packaging(RHEL-CTDB): fix installation of pam modules

use configure parameter to specify the pam modules dir.

Michael
(cherry picked from commit 24282daa5e293ef9362a69f7f70a684587d6763a)