]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
5 years agonetwork: introduce link_deserialize_routes()
Yu Watanabe [Fri, 2 Oct 2020 00:52:07 +0000 (09:52 +0900)] 
network: introduce link_deserialize_routes()

5 years agonetwork: introduce link_drop_routes()
Yu Watanabe [Fri, 2 Oct 2020 00:40:31 +0000 (09:40 +0900)] 
network: introduce link_drop_routes()

5 years agonetwork: introduce link_drop_foreign_routes()
Yu Watanabe [Fri, 2 Oct 2020 00:38:31 +0000 (09:38 +0900)] 
network: introduce link_drop_foreign_routes()

5 years agonetwork: make route_free() return NULL
Yu Watanabe [Fri, 2 Oct 2020 00:31:29 +0000 (09:31 +0900)] 
network: make route_free() return NULL

5 years agonetwork: move manager_rtnl_process_route()
Yu Watanabe [Fri, 2 Oct 2020 00:29:07 +0000 (09:29 +0900)] 
network: move manager_rtnl_process_route()

5 years agonetwork: move link_request_set_routes()
Yu Watanabe [Fri, 2 Oct 2020 00:27:28 +0000 (09:27 +0900)] 
network: move link_request_set_routes()

5 years agonetwork: make network_get_ipv6_dns() always set return value on success
Yu Watanabe [Tue, 29 Sep 2020 21:28:44 +0000 (06:28 +0900)] 
network: make network_get_ipv6_dns() always set return value on success

5 years agonetwork: fix indentation
Yu Watanabe [Tue, 29 Sep 2020 21:17:04 +0000 (06:17 +0900)] 
network: fix indentation

5 years agonetwork: cleanup networkd-radv.h
Yu Watanabe [Tue, 29 Sep 2020 21:10:02 +0000 (06:10 +0900)] 
network: cleanup networkd-radv.h

5 years agonetwork: introduce network_verify_prefix() and network_verify_route_prefix()
Yu Watanabe [Tue, 29 Sep 2020 21:01:09 +0000 (06:01 +0900)] 
network: introduce network_verify_prefix() and network_verify_route_prefix()

5 years agonetwork: also check route prefixes are configured
Yu Watanabe [Tue, 29 Sep 2020 20:56:05 +0000 (05:56 +0900)] 
network: also check route prefixes are configured

5 years agonetwork: drop redundant list of prefixes and route prefixes
Yu Watanabe [Tue, 29 Sep 2020 20:54:19 +0000 (05:54 +0900)] 
network: drop redundant list of prefixes and route prefixes

5 years agonetwork: make prefix_free() and route_prefix_free() return NULL
Yu Watanabe [Tue, 29 Sep 2020 20:40:14 +0000 (05:40 +0900)] 
network: make prefix_free() and route_prefix_free() return NULL

5 years agonetwork: warn if IPv6ProxyNDPAddress= is set and IPv6ProxyNDP= is disabled
Yu Watanabe [Tue, 29 Sep 2020 20:29:42 +0000 (05:29 +0900)] 
network: warn if IPv6ProxyNDPAddress= is set and IPv6ProxyNDP= is disabled

5 years agonetwork: propagate errors in ipv6_proxy_ndp_set()
Yu Watanabe [Tue, 29 Sep 2020 20:24:03 +0000 (05:24 +0900)] 
network: propagate errors in ipv6_proxy_ndp_set()

And ignore IPv6ProxyNDPAddress= settings if proxy_ndp is zero.

5 years agonetwork: drop networkd-ipv6-proxy-ndp.h from networkd-network.h
Yu Watanabe [Tue, 29 Sep 2020 20:16:25 +0000 (05:16 +0900)] 
network: drop networkd-ipv6-proxy-ndp.h from networkd-network.h

5 years agonetwork: rename ipv6_proxy_ndp_addresses_configure() -> link_set_ipv6_proxy_ndp_addre...
Yu Watanabe [Tue, 29 Sep 2020 20:15:32 +0000 (05:15 +0900)] 
network: rename ipv6_proxy_ndp_addresses_configure() -> link_set_ipv6_proxy_ndp_addresses()

5 years agonetwork: drop struct IPv6ProxyNDPAddress
Yu Watanabe [Tue, 29 Sep 2020 20:06:17 +0000 (05:06 +0900)] 
network: drop struct IPv6ProxyNDPAddress

Its only important value is in6_addr. So, let's just use struct in6_addr
and drop IPv6ProxyNDPAddress.

5 years agonetwork: move functions
Yu Watanabe [Tue, 29 Sep 2020 19:37:18 +0000 (04:37 +0900)] 
network: move functions

5 years agonetwork: cleanup networkd-mdb.h
Yu Watanabe [Tue, 29 Sep 2020 17:49:14 +0000 (02:49 +0900)] 
network: cleanup networkd-mdb.h

5 years agonetwork: introduce network_verify_mdb_entries()
Yu Watanabe [Tue, 29 Sep 2020 17:44:57 +0000 (02:44 +0900)] 
network: introduce network_verify_mdb_entries()

5 years agonetwork: drop list of bridge MDB entries
Yu Watanabe [Tue, 29 Sep 2020 17:40:28 +0000 (02:40 +0900)] 
network: drop list of bridge MDB entries

[BridgeMDB] sections are managed by LIST and Hashmap, and they contins
the completely same information. Let's drop the list.

5 years agonetwork: move mdb_entry_free() and friends
Yu Watanabe [Tue, 29 Sep 2020 17:33:14 +0000 (02:33 +0900)] 
network: move mdb_entry_free() and friends

5 years agonetwork: cleanup networkd-fdb.h
Yu Watanabe [Tue, 29 Sep 2020 17:24:02 +0000 (02:24 +0900)] 
network: cleanup networkd-fdb.h

5 years agonetwork: drop unused fdb_ntf_flags_to_string()
Yu Watanabe [Tue, 29 Sep 2020 17:14:19 +0000 (02:14 +0900)] 
network: drop unused fdb_ntf_flags_to_string()

5 years agonetwork: introduce network_verify_fdb_entries()
Yu Watanabe [Tue, 29 Sep 2020 17:09:28 +0000 (02:09 +0900)] 
network: introduce network_verify_fdb_entries()

5 years agonetwork: move link_set_bridge_fdb()
Yu Watanabe [Tue, 29 Sep 2020 17:05:08 +0000 (02:05 +0900)] 
network: move link_set_bridge_fdb()

5 years agonetwork: drop list of bridge FDB entries
Yu Watanabe [Tue, 29 Sep 2020 17:01:46 +0000 (02:01 +0900)] 
network: drop list of bridge FDB entries

[BridgeFDB] sections are managed by both LIST and Hashmap, and they
contains the completely same information. Let's drop the list.

5 years agonetwork: make fdb_entry_free() return NULL
Yu Watanabe [Tue, 29 Sep 2020 16:53:16 +0000 (01:53 +0900)] 
network: make fdb_entry_free() return NULL

5 years agonetwork: cleanup networkd-address-label.h
Yu Watanabe [Tue, 29 Sep 2020 16:40:03 +0000 (01:40 +0900)] 
network: cleanup networkd-address-label.h

5 years agonetwork: introduce link_set_address_labels()
Yu Watanabe [Tue, 29 Sep 2020 16:33:25 +0000 (01:33 +0900)] 
network: introduce link_set_address_labels()

5 years agonetwork: introduce network_verify_address_labels()
Yu Watanabe [Tue, 29 Sep 2020 16:28:35 +0000 (01:28 +0900)] 
network: introduce network_verify_address_labels()

5 years agonetwork: make address_label_free() return NULL
Yu Watanabe [Tue, 29 Sep 2020 16:25:12 +0000 (01:25 +0900)] 
network: make address_label_free() return NULL

5 years agonetwork: drop list of static address labels
Yu Watanabe [Tue, 29 Sep 2020 16:20:43 +0000 (01:20 +0900)] 
network: drop list of static address labels

[IPv6AddressLabel] sections are managed by both LIST and Hashmap.
Let's drop list, as they store the completely same information.

5 years agonetwork: make neighbor_free() return NULL
Yu Watanabe [Tue, 29 Sep 2020 15:45:19 +0000 (00:45 +0900)] 
network: make neighbor_free() return NULL

5 years agonetwork: introduce network_verify_neighbors()
Yu Watanabe [Tue, 29 Sep 2020 15:43:06 +0000 (00:43 +0900)] 
network: introduce network_verify_neighbors()

5 years agonetwork: introduce neighbor_drop_{,foreign_}neighbors()
Yu Watanabe [Tue, 29 Sep 2020 15:37:39 +0000 (00:37 +0900)] 
network: introduce neighbor_drop_{,foreign_}neighbors()

5 years agonetwork: cleanup headers in networkd-neighbor.[ch]
Yu Watanabe [Tue, 29 Sep 2020 15:17:22 +0000 (00:17 +0900)] 
network: cleanup headers in networkd-neighbor.[ch]

5 years agonetwork: drop unused arguments
Yu Watanabe [Tue, 29 Sep 2020 15:09:21 +0000 (00:09 +0900)] 
network: drop unused arguments

5 years agonetwork: make several functions static
Yu Watanabe [Tue, 29 Sep 2020 15:05:18 +0000 (00:05 +0900)] 
network: make several functions static

5 years agonetwork: make neighbor_{add,get}() takes Neighbor object
Yu Watanabe [Tue, 29 Sep 2020 15:00:20 +0000 (00:00 +0900)] 
network: make neighbor_{add,get}() takes Neighbor object

5 years agonetwork: drop list of static neighbors
Yu Watanabe [Tue, 29 Sep 2020 14:31:38 +0000 (23:31 +0900)] 
network: drop list of static neighbors

[Neighbor] sections are managed by both LIST and Hashmap.
Let's drop list, as they store the completely same information.

5 years agonetwork: move manager_rtnl_process_neighbor() to networkd-neighbor.c
Yu Watanabe [Tue, 29 Sep 2020 14:20:14 +0000 (23:20 +0900)] 
network: move manager_rtnl_process_neighbor() to networkd-neighbor.c

5 years agonetwork: move link_request_set_neighbors() to networkd-neighbor.c
Yu Watanabe [Tue, 29 Sep 2020 14:17:43 +0000 (23:17 +0900)] 
network: move link_request_set_neighbors() to networkd-neighbor.c

5 years agonetwork: move functions
Yu Watanabe [Tue, 29 Sep 2020 14:15:41 +0000 (23:15 +0900)] 
network: move functions

5 years agonetwork: introduce network_verify_nexthops()
Yu Watanabe [Tue, 29 Sep 2020 15:58:01 +0000 (00:58 +0900)] 
network: introduce network_verify_nexthops()

5 years agonetwork: use netlink_message_read_in_addr_union()
Yu Watanabe [Tue, 29 Sep 2020 13:35:03 +0000 (22:35 +0900)] 
network: use netlink_message_read_in_addr_union()

5 years agosd-netlink: introduce netlink_message_read_in_addr_union()
Yu Watanabe [Tue, 29 Sep 2020 13:34:37 +0000 (22:34 +0900)] 
sd-netlink: introduce netlink_message_read_in_addr_union()

5 years agonetwork: use log_link_xxx() at more places
Yu Watanabe [Tue, 29 Sep 2020 13:21:52 +0000 (22:21 +0900)] 
network: use log_link_xxx() at more places

5 years agonetwork: drop NextHop::oif and always use link ifindex
Yu Watanabe [Tue, 29 Sep 2020 13:20:23 +0000 (22:20 +0900)] 
network: drop NextHop::oif and always use link ifindex

5 years agonetwork: slightly shorten nexthop_compare_func()
Yu Watanabe [Tue, 29 Sep 2020 12:53:05 +0000 (21:53 +0900)] 
network: slightly shorten nexthop_compare_func()

5 years agonetwork: cleanup headers included in networkd-nexthop.h
Yu Watanabe [Tue, 29 Sep 2020 08:47:28 +0000 (17:47 +0900)] 
network: cleanup headers included in networkd-nexthop.h

5 years agonetwork: drop list of static nexthops
Yu Watanabe [Tue, 29 Sep 2020 08:37:56 +0000 (17:37 +0900)] 
network: drop list of static nexthops

[NextHop] sections are managed by both LIST and Hashmap.
Let's drop list, as they store the completely same information.

5 years agonetwork: drop unused nexthop_remove() and nexthop_equal()
Yu Watanabe [Tue, 29 Sep 2020 08:29:19 +0000 (17:29 +0900)] 
network: drop unused nexthop_remove() and nexthop_equal()

5 years agonetwork: make several functions static
Yu Watanabe [Tue, 29 Sep 2020 08:27:50 +0000 (17:27 +0900)] 
network: make several functions static

5 years agonetwork: move manager_rtnl_process_nexthop() to networkd-nexthop.c
Yu Watanabe [Tue, 29 Sep 2020 08:20:40 +0000 (17:20 +0900)] 
network: move manager_rtnl_process_nexthop() to networkd-nexthop.c

5 years agonetwork: move link_request_set_nexthop() to networkd-nexthop.c
Yu Watanabe [Tue, 29 Sep 2020 08:18:55 +0000 (17:18 +0900)] 
network: move link_request_set_nexthop() to networkd-nexthop.c

5 years agonetwork: introduce helper function to enumerate information using netlink
Yu Watanabe [Tue, 29 Sep 2020 07:44:41 +0000 (16:44 +0900)] 
network: introduce helper function to enumerate information using netlink

5 years agonetwork: specify all known attributes when removing routing policy rules
Yu Watanabe [Mon, 5 Oct 2020 21:20:39 +0000 (06:20 +0900)] 
network: specify all known attributes when removing routing policy rules

Otherwise, routing_policy_rule_remove() may removes unintended rule.

5 years agonetwork: add missing "else"
Yu Watanabe [Mon, 5 Oct 2020 20:05:33 +0000 (22:05 +0200)] 
network: add missing "else"

5 years agonetwork: drop unused element
Yu Watanabe [Sun, 4 Oct 2020 15:55:15 +0000 (00:55 +0900)] 
network: drop unused element

5 years agonetwork: introduce network_verify_routing_policy_rules()
Yu Watanabe [Tue, 29 Sep 2020 15:50:30 +0000 (00:50 +0900)] 
network: introduce network_verify_routing_policy_rules()

5 years agonetwork: make routing_policy_rule_new() static
Yu Watanabe [Tue, 29 Sep 2020 12:43:59 +0000 (21:43 +0900)] 
network: make routing_policy_rule_new() static

5 years agonetwork: move manager_rtnl_process_rule() to networkd-routing-policy-rule.[ch]
Yu Watanabe [Tue, 29 Sep 2020 07:23:57 +0000 (16:23 +0900)] 
network: move manager_rtnl_process_rule() to networkd-routing-policy-rule.[ch]

5 years agonetwork: use typesafe macro netlink_add_match()
Yu Watanabe [Tue, 29 Sep 2020 07:20:00 +0000 (16:20 +0900)] 
network: use typesafe macro netlink_add_match()

5 years agosd-netlink: fix typo and make netlink_add_match() take description
Yu Watanabe [Tue, 29 Sep 2020 07:12:17 +0000 (16:12 +0900)] 
sd-netlink: fix typo and make netlink_add_match() take description

5 years agonetwork: move log_message_warning_errno() to networkd-util.h
Yu Watanabe [Tue, 29 Sep 2020 07:00:21 +0000 (16:00 +0900)] 
network: move log_message_warning_errno() to networkd-util.h

5 years agonetwork: drop list of static routing policy rules
Yu Watanabe [Tue, 29 Sep 2020 06:29:56 +0000 (15:29 +0900)] 
network: drop list of static routing policy rules

[RoutingPolicyRule] sections are managed by both LIST and Hashmap.
Let's drop list.

5 years agonetwork: do not duplicate rule if Family=both
Yu Watanabe [Sun, 4 Oct 2020 14:14:08 +0000 (23:14 +0900)] 
network: do not duplicate rule if Family=both

5 years agonetwork: make routing_policy_rule_free() returns NULL
Yu Watanabe [Tue, 29 Sep 2020 06:36:53 +0000 (15:36 +0900)] 
network: make routing_policy_rule_free() returns NULL

5 years agonetwork: add more logs on loading routing policy rules failure
Yu Watanabe [Tue, 29 Sep 2020 06:04:19 +0000 (15:04 +0900)] 
network: add more logs on loading routing policy rules failure

And reduce scope of variables.

5 years agonetwork: reduce scope of variables
Yu Watanabe [Tue, 29 Sep 2020 05:42:56 +0000 (14:42 +0900)] 
network: reduce scope of variables

5 years agonetwork: drop routing_policy_rule_make_local()
Yu Watanabe [Tue, 29 Sep 2020 05:41:01 +0000 (14:41 +0900)] 
network: drop routing_policy_rule_make_local()

Its error handling was bogus...

5 years agonetwork: make several functions static
Yu Watanabe [Tue, 29 Sep 2020 05:28:21 +0000 (14:28 +0900)] 
network: make several functions static

5 years agonetwork: move link_request_set_routing_policy()
Yu Watanabe [Tue, 29 Sep 2020 05:17:27 +0000 (14:17 +0900)] 
network: move link_request_set_routing_policy()

5 years agoman: fix table alignment
Lennart Poettering [Mon, 5 Oct 2020 15:45:58 +0000 (17:45 +0200)] 
man: fix table alignment

5 years agoNEWS: shorten/reword some things
Zbigniew Jędrzejewski-Szmek [Mon, 5 Oct 2020 11:29:37 +0000 (13:29 +0200)] 
NEWS: shorten/reword some things

5 years agovirt: reference correct file path in log message
Lennart Poettering [Mon, 5 Oct 2020 09:40:33 +0000 (11:40 +0200)] 
virt: reference correct file path in log message

5 years agoman: fix typo systmed → systemd
Lennart Poettering [Mon, 5 Oct 2020 09:40:05 +0000 (11:40 +0200)] 
man: fix typo systmed → systemd

5 years agoupdate TODO
Lennart Poettering [Mon, 5 Oct 2020 09:39:42 +0000 (11:39 +0200)] 
update TODO

5 years agoadd stuff to NEWS for 247
Lennart Poettering [Mon, 5 Oct 2020 09:39:35 +0000 (11:39 +0200)] 
add stuff to NEWS for 247

5 years agoshell-completion: add missing completions to meson.build
Lucas Werkmeister [Sun, 4 Oct 2020 13:39:24 +0000 (15:39 +0200)] 
shell-completion: add missing completions to meson.build

Completions for systemd-id128 and homectl have been available for a
while, but weren’t being installed.

5 years agoMerge pull request #17230 from mrc0mmand/coccinelle_fixes
Zbigniew Jędrzejewski-Szmek [Mon, 5 Oct 2020 06:03:40 +0000 (08:03 +0200)] 
Merge pull request #17230 from mrc0mmand/coccinelle_fixes

coccinelle: fix the incorrect transformation/isomorphisms

5 years agoMerge pull request #17239 from ferivoz/typos
Daan De Meyer [Sun, 4 Oct 2020 17:19:26 +0000 (18:19 +0100)] 
Merge pull request #17239 from ferivoz/typos

Fix typos

5 years agotree-wide: coccinelle fixes 17230/head
Frantisek Sumsal [Sun, 4 Oct 2020 09:29:23 +0000 (11:29 +0200)] 
tree-wide: coccinelle fixes

5 years agococcinelle: skip strjoin transformation in test_strjoin()
Frantisek Sumsal [Sun, 4 Oct 2020 10:29:43 +0000 (12:29 +0200)] 
coccinelle: skip strjoin transformation in test_strjoin()

5 years agococcinelle: limit the # of expressions in in_set/not_in_set
Frantisek Sumsal [Sun, 4 Oct 2020 09:44:48 +0000 (11:44 +0200)] 
coccinelle: limit the # of expressions in in_set/not_in_set

transformations. Otherwise the time and resources to generate all
possible permutations is simply unreasonable for running on local
machines.

5 years agococcinelle: skip the xsprintf transformation on man pages
Frantisek Sumsal [Sun, 4 Oct 2020 09:31:51 +0000 (11:31 +0200)] 
coccinelle: skip the xsprintf transformation on man pages

since we don't expose xsprintf to users.

5 years agococcinelle: disable flags-set where it doesn't make sense
Frantisek Sumsal [Fri, 2 Oct 2020 09:31:47 +0000 (11:31 +0200)] 
coccinelle: disable flags-set where it doesn't make sense

5 years agococcinelle: fix the equals-null transformation
Frantisek Sumsal [Thu, 1 Oct 2020 14:13:30 +0000 (16:13 +0200)] 
coccinelle: fix the equals-null transformation

The original issue with this transformation was that we were replacing
the whole if statement instead of just the expression inside. That
caused the code to be weirdly formatted, as Coccinelle put a new block
around each replaced if statement.

This version replaces just the inner expression if it's in its incorrect
form, otherwise it just accepts it (to avoid recursion).

5 years agococcinelle: drop the custom isomorphisms
Frantisek Sumsal [Thu, 1 Oct 2020 14:11:43 +0000 (16:11 +0200)] 
coccinelle: drop the custom isomorphisms

My former dumb me didn't read the documentation properly, so with the
introduction of custom isomorphisms I caused two issues:

1) Masked all standard isomorphisms defined by Coccinelle
2) Replace the original issue with a completely new one

5 years agoMerge pull request #17233 from poettering/nspawn-reopen-fix
Daan De Meyer [Sat, 3 Oct 2020 12:26:54 +0000 (13:26 +0100)] 
Merge pull request #17233 from poettering/nspawn-reopen-fix

nspawn: reopen stdin/stdout + chmod fixes for stdin/stdout

5 years agoman: fix typos 17239/head
Samanta Navarro [Sat, 3 Oct 2020 11:56:50 +0000 (11:56 +0000)] 
man: fix typos

5 years agoseccomp-util: fix typo in help message
Samanta Navarro [Sat, 3 Oct 2020 11:56:40 +0000 (11:56 +0000)] 
seccomp-util: fix typo in help message

5 years agogithub: ask for arch+kernel in bug report form
Lennart Poettering [Thu, 1 Oct 2020 12:57:06 +0000 (14:57 +0200)] 
github: ask for arch+kernel in bug report form

Quite often we see kernel and arch specific issues, let's ask for the
version right-away when people file the issue.

Other tweaks.

5 years agonspawn: don't chown() stdin/stdout passed in when --console=pipe is used 17233/head
Lennart Poettering [Fri, 2 Oct 2020 09:59:45 +0000 (11:59 +0200)] 
nspawn: don't chown() stdin/stdout passed in when --console=pipe is used

We should chown what we allocate ourselves, i.e. any pty we allocate
ourselves. But for stuff we propagate, let's avoid that: we shouldn't
make more changes than necessary.

Fixes: #17229
5 years agoptyfwd: reopen stdin/sdout before setting O_NONBLOCK
Lennart Poettering [Fri, 2 Oct 2020 09:50:58 +0000 (11:50 +0200)] 
ptyfwd: reopen stdin/sdout before setting O_NONBLOCK

If we set O_NONBLOCK on stdin/stdout directly this means the flag is
left set when we abort abnormally, as we don't get the chance to reset
it again on exit. This might confuse progrms invoking us. Moreover, if
programs invoking us continue to write to the stdout passed to us, they
might be confused by non-blocking mode too.

Hence, let's avoid this if possible: let's reopen stdin/stdout and set
O_NONBLOCK only on the reopend fds, leaving the original fds as they
are.

Prompted-by: https://github.com/systemd/systemd/pull/17070#issuecomment-702304802
5 years agoMerge pull request #17172 from keszybz/read-login-defs
Lennart Poettering [Fri, 2 Oct 2020 09:01:30 +0000 (11:01 +0200)] 
Merge pull request #17172 from keszybz/read-login-defs

Read /etc/login.defs

5 years agoMerge pull request #17219 from poettering/exec-root-dir
Zbigniew Jędrzejewski-Szmek [Thu, 1 Oct 2020 18:01:46 +0000 (20:01 +0200)] 
Merge pull request #17219 from poettering/exec-root-dir

minor tweaks to execute.[ch]

5 years agosysusers: emit warnings about login.defs overrides on first user or group creation 17172/head
Zbigniew Jędrzejewski-Szmek [Thu, 1 Oct 2020 16:18:26 +0000 (18:18 +0200)] 
sysusers: emit warnings about login.defs overrides on first user or group creation

*** Running /home/zbyszek/src/systemd-work/test/test-sysusers/test-14.input (with login.defs symlinked)
login.defs specifies UID allocation range 401–555 that is different than the built-in defaults (201–998)
login.defs specifies GID allocation range 405–666 that is different than the built-in defaults (201–990)