Willem Toorop [Wed, 24 Aug 2011 18:36:34 +0000 (18:36 +0000)]
Fix usage of divides and modulus in the utility time funtions.
i.e. if number of seconds is negative (for example -70) then in C
seconds % 60 = -10
and seconds / 60 = -1
but our algorithm expects
seconds % 60 = 50
and seconds / 60 = -2
Willem Toorop [Tue, 28 Jun 2011 12:15:32 +0000 (12:15 +0000)]
Bugfix 394 of leaking sockets:
when ldns_udp_send_query returned a error when used from ldns_udp_bgsend and ldns_tcp_bgsend, the newly created socket was not closed nor returned.
Now it is closed.
Willem Toorop [Tue, 24 May 2011 11:46:34 +0000 (11:46 +0000)]
Review comment improvements from Matthijs.
Fix for examples to compile on systems with openssl < 1.0 in the 01-compile.tpkg test.
Changed default timeout to 5 seconds.
Willem Toorop [Wed, 18 May 2011 14:15:05 +0000 (14:15 +0000)]
code review #1: Extra info on NSEC records only when verbosity is up
code review #2: Rename serial_arithmitics_gmtime_r to ldns_serial_arithmitics_gmtime_r (and all the other added functions in util.h) and add to ldns_symbols.def.
code review #3: Comment swap of ldns_dnssec_verify_denial_nsec3_match, ldns_verify_rrsig_buffers and ldns_dnssec_verify_denial_nsec3
code review #4: Finishing the sentence in the comment about opt-out handling in function ldns_dnssec_create_nsec3.
code review #5: Just do rd-strlen = strlen(rd) once in rr.c
code review #6: Moved setting of output variables from acx_nlnetlabs.m4 to configure.ac so acx_nlnetlabs.m4 doesn't have to be merged into NSD and Unbound.
Willem Toorop [Wed, 18 May 2011 12:44:09 +0000 (12:44 +0000)]
Get rid of copying of local resolver nameservers to the active resolver in securetrace.
It might be worthwhile to query "." if no root-servers are available, but this is not the place or way to address that.
Willem Toorop [Tue, 17 May 2011 19:47:47 +0000 (19:47 +0000)]
Elimination of the defines in config.h from the header files that are distributed with the library.
Where possible, those are replaced by build configuration defines (that won't conflict with another autoconf environment)
Willem Toorop [Tue, 17 May 2011 14:32:57 +0000 (14:32 +0000)]
Sorry, previous commit (revision 3494, files: dnssec.c, dnssec_sign.c, examples/ldns-verify-zone.c, ldns/dnssec.h, ldns/dnssec_sign.h and ldns_symbols.def) should have included this documentation change and the following text:
Added the ldns_dnssec_mark_and_get_glue function to inventorize the glue from a ldns_dnssec_zone structure.
Also modified the marking to mark all names that are occluded and not just the names that contain only glue.
Modified the signing, adding of nsec and nsec3 functions to handle the ommission of occluded names and obscured rrsets (in stead of only handling the ommision of glue).
Modified the documentation to clarify how ldns_dnssec_mark_glue and ldns_dnssec_name_node_next_nonglue are intended to work togetger.
Willem Toorop [Mon, 16 May 2011 12:18:20 +0000 (12:18 +0000)]
Clarify the operation of the ldns_dnssec_mark_glue() function and the meaning of the is_glue data field in the ldns_dnssec_name structure.
Reveal the existance of the ldns_dnssec_mark_glue() function (that was alleady in the ldns_symbols.def list) in the header file.
Export ldns_dnssec_name_is_glue() with the library.
Willem Toorop [Fri, 13 May 2011 09:24:50 +0000 (09:24 +0000)]
Fix ldns_dnssec_zone_add_empty_nonterminals to also detect the empty nonterminals for labels that are the same as another at a certain position, but for which some of the parent labels differ.
See also: Bug#383.
Thanks to Juergen Geinitz.
Willem Toorop [Thu, 12 May 2011 09:52:34 +0000 (09:52 +0000)]
Alleviate the potential sizeof(bool) discrepancies by:
1. Allocating scructures with (aligned) bool attributes with LDNS_CALLOC (that fills the freshly allocated struct with zero's)
2. signed char as a fall back type for bool, as recommended in the autoconf manual
3. An access function for the is_glueattribute: bool ldns_dnssec_name_is_glue(ldns_dnssec_name *name)
Willem Toorop [Wed, 11 May 2011 12:52:15 +0000 (12:52 +0000)]
Rollback of last changes, because stdbool.h in solaris is only available when using the c99 compile flag.
Otherwise an error is produced.
From /usr/include/stdbool.h:42:2: #error "Use of <stdbool.h> is valid only in a c99 compilation environment.
Willem Toorop [Tue, 15 Mar 2011 13:59:56 +0000 (13:59 +0000)]
Fix to allow glue records with the same name as the delegation + allowing NSEC3 less records when they are NS or glue when the zone is opt-out.
Thanks to Vincent Levigneron (Bug #367)