Peter Stamfest [Wed, 20 Aug 2014 22:43:18 +0000 (00:43 +0200)]
Move custom logic row-rotation logic from write_fh, originally there to
support rrd_restore with its random cur_row placement to
rrd_restore itself. This makes write_fh a truly reuseable function.
Peter Stamfest [Thu, 14 Aug 2014 07:05:04 +0000 (09:05 +0200)]
Keep a pointer to the internal rrd data structure with rrd_file_t objects
to simplify management of opened RRD files - now it is only required
to keep the rrd_file_t object around to be able to manage the underlying
rrd structure and not both objects in some additional data structure.
Peter Stamfest [Wed, 13 Aug 2014 18:14:31 +0000 (20:14 +0200)]
fix init_cdp. The original code implicitly always used the first pdp_prep
structure of the underlying rrd, which lead to wrong cdp initialization in
experimental code. This change will be needed for future work.
Peter Stamfest [Wed, 13 Aug 2014 18:10:43 +0000 (20:10 +0200)]
move write_rrd and write_fh into rrd_create.c.
While this is purely cosmetic, writing an RRD file is actually creating one, so
it makes sense to concentrate the various writing functions into one place.
petgit [Wed, 27 Aug 2014 19:52:53 +0000 (21:52 +0200)]
use of g_free() cause heap damage on windows if memory is allocated by malloc(). Key is allocated by malloc() in sprintf_alloc(), so free() should use.
Peter A. Bigot [Tue, 5 Aug 2014 21:39:58 +0000 (16:39 -0500)]
configure.ac: remove explicit default path for libxml2
OpenEmbedded needs to cross-compile rrdtool, and historically has
applied this patch locally because the implementation of EX_CHECK_ALL
unconditionally added -I/usr/include. Since the correct include path is
automatically provided by a successful pkg-config invocation there is no
need to set it explicitly.
rrd_strtoding now takes error string as an argument
This commit replaces all rrd_strtoding calls with a 4 argument
version of the function and also make sure that its return value
(which shows whether the string has been converted partially,
fully or not converted at all) is checked at all the places.
Tobias Oetiker [Mon, 30 Jun 2014 09:16:40 +0000 (11:16 +0200)]
* msync is NOT necessary before munmap, the data gets synced automatically
* remove WILLNEED madvise, this only slows the code down while the os des not seem todo anything sensible with the info
Peter A. Bigot [Sun, 1 Jun 2014 00:03:55 +0000 (19:03 -0500)]
rrdcached: add options to drop privileges after daemonize
Some init systems have an interface to run daemons as unprivileged
accounts, but they conflict with rrdcached's expectations of creating
pid files and sockets in privileged areas when following Filesystem
Hierarchy Standard namings. Add options that are used to drop to
unprivileged group and accounts after all activities that require
privilege have been completed.
Peter A. Bigot [Sat, 31 May 2014 21:27:16 +0000 (16:27 -0500)]
rrdcached: arrange option flags in order
To make it easier to determine which argument flags are available, the
getopt optstring is sorted into ASCII order. Checking this against the
documentation indicated several supported flags were not present in the
synopsis. Also make all flags bold for consistency.
moli [Fri, 23 May 2014 22:13:59 +0000 (00:13 +0200)]
mods of #477 rrdcached document changes
when group option is specified, socket permission is 760, not 750, i've tested this. the context confirms this behaviour is right, the text was wrong.
-P restricts unix sockets too! tested this also.
Peter A. Bigot [Tue, 20 May 2014 15:59:07 +0000 (10:59 -0500)]
rrdcached: support new option to listen on all addresses at default port
This functionality can be achieved with "-l ''" (specifying an empty
string for host:port) but empty strings may be dropped during option
processing in scripts. A separate option to support this capability is
much more clear.
Peter A. Bigot [Tue, 20 May 2014 15:31:12 +0000 (10:31 -0500)]
misc doc: fix erronous use of section qualifier in intra-package links
rrdxport and rrdcached do belong in section 1 of the Unix manpages, but
they are documented within the RRDTool hierarchy and use of the
qualifier prevents them from being found. Note also the need to
override the substitute text or modify the context so that the generated
HTML content reads correctly.