src/bin/dhcp4/tests/hooks_unittest.cc
TEST_F(HooksDhcpv4SrvTest, ddns4Update) - new test
src/bin/dhcp6/tests/hooks_unittest.cc
TEST_F(HooksDhcpv6SrvTest, ddns6Update) - new test
src/lib/asiolink/io_service.cc
src/lib/asiolink/io_service.h
- replaced unresolvable @ref with @c for boost::asio::io_service,
(boost code does not use doxygen)
src/lib/dns/tsigkey.h
Replaced @class with @ref, at @class needs to point to a file
Andrei Pavel [Mon, 29 Apr 2024 17:03:15 +0000 (20:03 +0300)]
[#3163] fix warnings on modified files
- ctrl_dhcp4_srv_unittest.cc:145:6: warning: extra ‘;’ after in-class function definition [-Wextra-semi]
- ctrl_dhcp4_srv_unittest.cc:2172:28: warning: comparison of integer expressions of different signedness: ‘std::streamoff’ {aka ‘long int’} and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
- ctrl_dhcp4_srv_unittest.cc:2191:33: warning: comparison of integer expressions of different signedness: ‘std::streamoff’ {aka ‘long int’} and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
- ctrl_dhcp4_srv_unittest.cc:2295:33: warning: comparison of integer expressions of different signedness: ‘std::streamoff’ {aka ‘long int’} and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
- ctrl_dhcp4_srv_unittest.cc:2352:28: warning: declaration of ‘timeout’ shadows a previous local [-Wshadow]
- ctrl_dhcp4_srv_unittest.cc:2402:28: warning: declaration of ‘timeout’ shadows a previous local [-Wshadow]
- ctrl_dhcp6_srv_unittest.cc:116:6: warning: extra ‘;’ after in-class function definition [-Wextra-semi]
- ctrl_dhcp6_srv_unittest.cc:181:6: warning: extra ‘;’ after in-class function definition [-Wextra-semi]
- ctrl_dhcp6_srv_unittest.cc:264:10: warning: ‘virtual void {anonymous}::CtrlChannelDhcpv6SrvTest::reset()’ can be marked override [-Wsuggest-override]
- ctrl_dhcp6_srv_unittest.cc:2210:28: warning: comparison of integer expressions of different signedness: ‘std::streamoff’ {aka ‘long int’} and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
- ctrl_dhcp6_srv_unittest.cc:2229:33: warning: comparison of integer expressions of different signedness: ‘std::streamoff’ {aka ‘long int’} and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
- ctrl_dhcp6_srv_unittest.cc:2333:33: warning: comparison of integer expressions of different signedness: ‘std::streamoff’ {aka ‘long int’} and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
- ctrl_dhcp6_srv_unittest.cc:2390:28: warning: declaration of ‘timeout’ shadows a previous local [-Wshadow]
- ctrl_dhcp6_srv_unittest.cc:2440:28: warning: declaration of ‘timeout’ shadows a previous local [-Wshadow]
- dhcp6_srv_unittest.cc:2420:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
- dhcp6_srv_unittest.cc:2440:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
- dhcp6_srv_unittest.cc:2932:28: warning: useless cast to type ‘const uint8_t*’ {aka ‘const unsigned char*’} [-Wuseless-cast]
- dhcp6_srv_unittest.cc:2964:26: warning: useless cast to type ‘const uint8_t*’ {aka ‘const unsigned char*’} [-Wuseless-cast]
Andrei Pavel [Tue, 23 Apr 2024 16:57:05 +0000 (19:57 +0300)]
[#3254] consistent version output across executables
- replace VERSION with PACKAGE_VERSION in src/bin/admin to avoid
overlap with VERSION used in src/share/database.
- add -V to kea-admin
- add -V to kea-shell
- add -V to keactrl
- add -V to perfdhcp
- removed getVersionAddendum from d2 and added the openssl version to
the output of other process versions since it's not only used by d2
- make all -V outputs consistent. Some are showing only core version and
are missing premium version which is fine since they are the
executables that don't have something to do with premium directly
anyway.
- fixing a bug where when postgresql used as hosts reservations backend and
when trying to delete only one reservation with host_cmds reservation-del
by ipv6 and subnet-id, all host reservations in given subnet were deleted
Marcin Siodelski [Mon, 15 Apr 2024 16:22:27 +0000 (18:22 +0200)]
[#3125] Pkt6 drop statistics not increased
The drop statistics should be maintained by the hook libraries rather than
the server. We had a discrepancy between the DHCPv4 and DHCPv6 server where
the latter increased the drop statistics when the hook library returned
the DROP status for the pkt6-receive or buffer6-receive callout. It
resulted in the increased drop stats for the load balanced packets. It was
not the case for the DHCPv4 server.
Andrei Pavel [Mon, 8 Apr 2024 14:59:38 +0000 (17:59 +0300)]
[#1743] fix circular dependency in src/lib/log
Fixes the problem where to generate log_messages.(cc|h), you need
kea-msg-compiler, but to compile kea-msg-compiler you need
log_messages.(cc|h). This halted compilation even when building
from scratch.
Simply only regenerate log_messages.(cc|h) only if kea-msg-compiler
exists. It will not regenerate the files on first pass, but one can
explicitly call `make messages -C src/lib/log` afterwards to regenerate
the files.