]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agoAllow encoding name_only attributes if the data is going to be consumed internally
Arran Cudbard-Bell [Wed, 13 Dec 2023 20:13:50 +0000 (14:13 -0600)] 
Allow encoding name_only attributes if the data is going to be consumed internally

2 years agoAlign function prototypes with the functions
Nick Porter [Wed, 13 Dec 2023 08:04:42 +0000 (08:04 +0000)] 
Align function prototypes with the functions

2 years agofunctions are single-thing expansions, too
Alan T. DeKok [Tue, 12 Dec 2023 12:18:58 +0000 (07:18 -0500)] 
functions are single-thing expansions, too

2 years agoCheck return (CID #1559169)
Nick Porter [Mon, 11 Dec 2023 20:20:41 +0000 (20:20 +0000)] 
Check return (CID #1559169)

2 years agoadd test for acct_unique policy
Alan T. DeKok [Mon, 11 Dec 2023 19:41:37 +0000 (14:41 -0500)] 
add test for acct_unique policy

and re-add commas in between fields.  Which makes it harder for
malicious actors to mangle multiple fields together.

The real solution is to make md5() take varargs, and then do the MD5
separately for each argument.  And to pass the values as raw
value-boxes, instead of as printable strings

2 years agoremove last vestige of %string(...)
Alan T. DeKok [Mon, 11 Dec 2023 19:58:13 +0000 (14:58 -0500)] 
remove last vestige of %string(...)

and correct the filter_password policy so that it works

2 years agodeprecate %string(...).
Alan T. DeKok [Mon, 11 Dec 2023 19:25:58 +0000 (14:25 -0500)] 
deprecate %string(...).

We should instead use %{(string) (...)}

2 years agoadd more upcast corner cases
Alan T. DeKok [Sun, 10 Dec 2023 13:23:02 +0000 (08:23 -0500)] 
add more upcast corner cases

2 years agoCorrect accouning unique id policy
Nick Porter [Mon, 11 Dec 2023 18:32:18 +0000 (18:32 +0000)] 
Correct accouning unique id policy

2 years agoFail sample load Cookie if no cookie retrieved
Nick Porter [Mon, 11 Dec 2023 17:30:47 +0000 (17:30 +0000)] 
Fail sample load Cookie if no cookie retrieved

2 years agoUpdate sample virtual server to reflect new load Cookie behaviour
Nick Porter [Mon, 11 Dec 2023 12:12:16 +0000 (12:12 +0000)] 
Update sample virtual server to reflect new load Cookie behaviour

2 years agoAdd a timed event to retry "load Cookie" on failure
Nick Porter [Mon, 11 Dec 2023 12:03:17 +0000 (12:03 +0000)] 
Add a timed event to retry "load Cookie" on failure

2 years agoIf "load Cookie" returns a failure code change reply packet type
Nick Porter [Mon, 11 Dec 2023 11:53:48 +0000 (11:53 +0000)] 
If "load Cookie" returns a failure code change reply packet type

2 years agoMove sending of fake "load Cookie" packets to a function
Nick Porter [Mon, 11 Dec 2023 10:03:49 +0000 (10:03 +0000)] 
Move sending of fake "load Cookie" packets to a function

So it can be used by a timer event if the initial load fails

2 years agoTypos
Nick Porter [Mon, 11 Dec 2023 09:50:24 +0000 (09:50 +0000)] 
Typos

2 years agoRevert "Tighten scope on addr"
Alan T. DeKok [Fri, 8 Dec 2023 19:17:42 +0000 (14:17 -0500)] 
Revert "Tighten scope on addr"

This reverts commit 3523ad74f62e23b7254a464c2e026d86a610acfe.

just leave it hoisted to the top of the function, where it causes
the least amount of problems.

2 years agoadd operations and upcast on combo-ips and prefixes
Alan T. DeKok [Fri, 8 Dec 2023 19:01:16 +0000 (14:01 -0500)] 
add operations and upcast on combo-ips and prefixes

2 years agoallow combo-ip/prefix to be input types
Alan T. DeKok [Fri, 8 Dec 2023 16:07:10 +0000 (11:07 -0500)] 
allow combo-ip/prefix to be input types

2 years agoAvoid misleading errors in tmpl tokenizing
Nick Porter [Fri, 8 Dec 2023 15:00:44 +0000 (15:00 +0000)] 
Avoid misleading errors in tmpl tokenizing

When resolving an internal attriubute, often a lookup will first have
been done in a protocol dictionary, which results in an error being
recorded.
However, if the attribute was subsequently found in the internal
dictionary, that error is meaningless - but will still be printed if
something else causes errors to print.

2 years agoInternal attributes can be inside group attributes
Nick Porter [Fri, 8 Dec 2023 14:57:33 +0000 (14:57 +0000)] 
Internal attributes can be inside group attributes

2 years agoEnsure pairs sent to internal encoder are nested correctly
Nick Porter [Fri, 8 Dec 2023 14:21:05 +0000 (14:21 +0000)] 
Ensure pairs sent to internal encoder are nested correctly

2 years agoIf we've got a cookie, send it back
Nick Porter [Fri, 8 Dec 2023 14:02:40 +0000 (14:02 +0000)] 
If we've got a cookie, send it back

Relying on the rcode does not match any other encoders.  If we need to
make the cookie return optional, it should be based on
request->reply->code

2 years agoclean up and normalize error messages
Alan T. DeKok [Fri, 8 Dec 2023 13:32:44 +0000 (08:32 -0500)] 
clean up and normalize error messages

2 years agomacro is unused
Alan T. DeKok [Fri, 8 Dec 2023 13:12:09 +0000 (08:12 -0500)] 
macro is unused

2 years agounused is used
Alan T. DeKok [Fri, 8 Dec 2023 13:11:26 +0000 (08:11 -0500)] 
unused is used

2 years agoremove unused variable
Alan T. DeKok [Fri, 8 Dec 2023 13:05:38 +0000 (08:05 -0500)] 
remove unused variable

2 years agoclean up error handling in exec oneshot
Alan T. DeKok [Fri, 8 Dec 2023 12:57:06 +0000 (07:57 -0500)] 
clean up error handling in exec oneshot

so that the it saves an fr_strerror(), and all callers use
RPEDEBUG() to describe the error.  This gives a consistent
behavior

2 years agoWS
Arran Cudbard-Bell [Thu, 7 Dec 2023 19:40:22 +0000 (13:40 -0600)] 
WS

2 years agoTighten scope on addr
Arran Cudbard-Bell [Thu, 7 Dec 2023 19:39:41 +0000 (13:39 -0600)] 
Tighten scope on addr

2 years agohoist declaration to quiet analyzer
Alan T. DeKok [Thu, 7 Dec 2023 19:22:26 +0000 (14:22 -0500)] 
hoist declaration to quiet analyzer

2 years agoFix support for outer, and fix support for caller and subrequests in conditions
Arran Cudbard-Bell [Thu, 7 Dec 2023 18:40:32 +0000 (12:40 -0600)] 
Fix support for outer, and fix support for caller and subrequests in conditions

2 years agoadd tests for combo-ip comparisons
Alan T. DeKok [Thu, 7 Dec 2023 17:32:59 +0000 (12:32 -0500)] 
add tests for combo-ip comparisons

2 years agoadd combo-ip and combo-prefix to upcast_cmp
Alan T. DeKok [Thu, 7 Dec 2023 17:26:24 +0000 (12:26 -0500)] 
add combo-ip and combo-prefix to upcast_cmp

2 years agoupdate fr_value_box_cmp_op() to handle combo-ip and combo-prefix
Alan T. DeKok [Thu, 7 Dec 2023 17:25:38 +0000 (12:25 -0500)] 
update fr_value_box_cmp_op() to handle combo-ip and combo-prefix

2 years agoparse combo-ip and combo-ip
Alan T. DeKok [Thu, 7 Dec 2023 17:25:01 +0000 (12:25 -0500)] 
parse combo-ip and combo-ip

2 years agoAdd timer slop to redis tests for macOS
Arran Cudbard-Bell [Thu, 7 Dec 2023 15:12:17 +0000 (09:12 -0600)] 
Add timer slop to redis tests for macOS

2 years agoIt's fine/useful to be able to cast to combo ip addr/prefix attributes and back again
Arran Cudbard-Bell [Thu, 7 Dec 2023 15:11:17 +0000 (09:11 -0600)] 
It's fine/useful to be able to cast to combo ip addr/prefix attributes and back again

We usually don't care what address family an IP is unless we're putting it on the wire.

2 years agocall_env needs to manipulate rules too
Arran Cudbard-Bell [Thu, 7 Dec 2023 14:59:42 +0000 (08:59 -0600)] 
call_env needs to manipulate rules too

2 years agoParse requested addr as an IP address
Arran Cudbard-Bell [Thu, 7 Dec 2023 04:08:19 +0000 (22:08 -0600)] 
Parse requested addr as an IP address

2 years agoNested subrequest test
Arran Cudbard-Bell [Thu, 7 Dec 2023 04:07:45 +0000 (22:07 -0600)] 
Nested subrequest test

2 years agoUse exec with env passthrough so PATH works for local testing for redis tests
Arran Cudbard-Bell [Thu, 7 Dec 2023 04:07:08 +0000 (22:07 -0600)] 
Use exec with env passthrough so PATH works for local testing for redis tests

2 years agoJust cast...
Arran Cudbard-Bell [Thu, 7 Dec 2023 04:06:36 +0000 (22:06 -0600)] 
Just cast...

2 years agoFixup compile so that caller and subrequest autoload dictionaries if they're not...
Arran Cudbard-Bell [Wed, 6 Dec 2023 23:20:07 +0000 (17:20 -0600)] 
Fixup compile so that caller and subrequest autoload dictionaries if they're not already loaded

2 years agoAdd utility function to allow dictionaries to be dynamically autoloaded
Arran Cudbard-Bell [Wed, 6 Dec 2023 23:19:45 +0000 (17:19 -0600)] 
Add utility function to allow dictionaries to be dynamically autoloaded

2 years agoUse tmpl_rules_t when compiling call-envs
Arran Cudbard-Bell [Wed, 6 Dec 2023 23:19:22 +0000 (17:19 -0600)] 
Use tmpl_rules_t when compiling call-envs

This allows parent and caller to work correctly

2 years agoclarify behavior
Alan T. DeKok [Wed, 6 Dec 2023 19:42:37 +0000 (14:42 -0500)] 
clarify behavior

2 years agotpo
Alan T. DeKok [Tue, 5 Dec 2023 00:51:55 +0000 (19:51 -0500)] 
tpo

2 years agomake function static
Alan T. DeKok [Tue, 5 Dec 2023 00:34:40 +0000 (19:34 -0500)] 
make function static

it's only called from log.c, so it doesn't need to be public.

And avoid one extra malloc / free where possible

2 years agoremove unnecessary function
Alan T. DeKok [Mon, 4 Dec 2023 16:59:55 +0000 (11:59 -0500)] 
remove unnecessary function

and use more descriptive message in the one place where the
function was used

2 years agofile may be NULL on newer versions of OpenSSL
Alan T. DeKok [Mon, 4 Dec 2023 12:11:15 +0000 (07:11 -0500)] 
file may be NULL on newer versions of OpenSSL

2 years agoDoesn't need field specifier
Arran Cudbard-Bell [Mon, 4 Dec 2023 22:30:55 +0000 (16:30 -0600)] 
Doesn't need field specifier

2 years agoantora fixes
Alan T. DeKok [Sun, 3 Dec 2023 15:02:03 +0000 (10:02 -0500)] 
antora fixes

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Sun, 3 Dec 2023 09:34:43 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Sun, 3 Dec 2023 09:34:40 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Sun, 3 Dec 2023 09:34:37 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Sun, 3 Dec 2023 09:34:35 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Sun, 3 Dec 2023 09:34:31 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Sun, 3 Dec 2023 09:34:28 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Sun, 3 Dec 2023 09:34:25 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Sun, 3 Dec 2023 09:34:22 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Sun, 3 Dec 2023 09:34:19 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

2 years agotypos
Alan T. DeKok [Mon, 27 Nov 2023 17:01:08 +0000 (12:01 -0500)] 
typos

2 years agoremove extra ;
Alan T. DeKok [Mon, 27 Nov 2023 15:53:17 +0000 (10:53 -0500)] 
remove extra ;

2 years agomove to using new function syntax
Alan T. DeKok [Mon, 27 Nov 2023 15:50:17 +0000 (10:50 -0500)] 
move to using new function syntax

and regularize the names.

2 years agoadd copyright
Alan T. DeKok [Mon, 27 Nov 2023 15:25:54 +0000 (10:25 -0500)] 
add copyright

2 years agodepend on, and build, local files, too
Alan T. DeKok [Mon, 27 Nov 2023 14:29:01 +0000 (09:29 -0500)] 
depend on, and build, local files, too

2 years agoAdd documentation sections
Arran Cudbard-Bell [Sat, 25 Nov 2023 23:42:44 +0000 (17:42 -0600)] 
Add  documentation sections

2 years agoWe need to let section callbacks handle multi indexes
Arran Cudbard-Bell [Sat, 25 Nov 2023 23:35:55 +0000 (17:35 -0600)] 
We need to let section callbacks handle multi indexes

2 years ago...move forward from out position
Arran Cudbard-Bell [Sat, 25 Nov 2023 23:27:36 +0000 (17:27 -0600)] 
...move forward from out position

2 years agoVarious fixes for LDAP
Arran Cudbard-Bell [Sat, 25 Nov 2023 03:32:04 +0000 (21:32 -0600)] 
Various fixes for LDAP

2 years agoOnly validate tmpls
Arran Cudbard-Bell [Sat, 25 Nov 2023 03:31:40 +0000 (21:31 -0600)] 
Only validate tmpls

2 years agoInit expect_password
Arran Cudbard-Bell [Sat, 25 Nov 2023 02:49:32 +0000 (20:49 -0600)] 
Init expect_password

2 years agoSwitch LDAP map compilation to using call envs too
Arran Cudbard-Bell [Sat, 25 Nov 2023 02:37:39 +0000 (20:37 -0600)] 
Switch LDAP map compilation to using call envs too

2 years agocall env const fixes...
Arran Cudbard-Bell [Sat, 25 Nov 2023 02:34:06 +0000 (20:34 -0600)] 
call env const fixes...

and support for literal data

2 years agoQuiet GCC
Arran Cudbard-Bell [Sat, 25 Nov 2023 01:34:15 +0000 (19:34 -0600)] 
Quiet GCC

2 years agoRename cache update section parse function
Arran Cudbard-Bell [Sat, 25 Nov 2023 01:33:21 +0000 (19:33 -0600)] 
Rename cache update section parse function

2 years agoAlways initialise count and multi_index
Arran Cudbard-Bell [Sat, 25 Nov 2023 01:33:06 +0000 (19:33 -0600)] 
Always initialise count and multi_index

2 years agoAdd support for call_env callbacks
Arran Cudbard-Bell [Fri, 24 Nov 2023 22:52:41 +0000 (16:52 -0600)] 
Add support for call_env callbacks

These can either emit a tmpl_t which'll later be processed during evaluation, or emit a custom structure, which the module or xlat can access at runtime.

2 years agorearrange call env structures to make them more like conf_parser_t
Arran Cudbard-Bell [Fri, 24 Nov 2023 20:08:02 +0000 (14:08 -0600)] 
rearrange call env structures to make them more like conf_parser_t

2 years agoFix macro usage in sigtran
Arran Cudbard-Bell [Fri, 24 Nov 2023 15:52:31 +0000 (09:52 -0600)] 
Fix macro usage in sigtran

2 years agoFix typo
Arran Cudbard-Bell [Fri, 24 Nov 2023 15:52:19 +0000 (09:52 -0600)] 
Fix typo

2 years agoMigrate more CONF_PARSER macros
Arran Cudbard-Bell [Fri, 24 Nov 2023 15:42:09 +0000 (09:42 -0600)] 
Migrate more CONF_PARSER macros

2 years agoshut up static analyzer
Alan T. DeKok [Fri, 24 Nov 2023 14:35:15 +0000 (09:35 -0500)] 
shut up static analyzer

2 years agoattribute names should have at least one alphanumeric character
Alan T. DeKok [Fri, 24 Nov 2023 14:07:52 +0000 (09:07 -0500)] 
attribute names should have at least one alphanumeric character

---.../// is not a valid attribute name

2 years agodon't allow alternation, it's confusing
Alan T. DeKok [Fri, 24 Nov 2023 13:59:27 +0000 (08:59 -0500)] 
don't allow alternation, it's confusing

2 years agoinitialize log level here, too
Alan T. DeKok [Fri, 24 Nov 2023 13:37:21 +0000 (08:37 -0500)] 
initialize log level here, too

2 years agoFirst round of conf_parser_t simplifications
Arran Cudbard-Bell [Thu, 23 Nov 2023 15:59:02 +0000 (09:59 -0600)] 
First round of conf_parser_t simplifications

2 years agoEnsure correct python-config is used on RHEL 8
Nick Porter [Thu, 23 Nov 2023 12:54:19 +0000 (12:54 +0000)] 
Ensure correct python-config is used on RHEL 8

2 years agomore convert to new function syntax
Alan T. DeKok [Thu, 23 Nov 2023 12:42:30 +0000 (07:42 -0500)] 
more convert to new function syntax

2 years agoShould be a comparison with flags not types...
Arran Cudbard-Bell [Wed, 22 Nov 2023 23:20:06 +0000 (17:20 -0600)] 
Should be a comparison with flags not types...

2 years agoGCC specific typo
Arran Cudbard-Bell [Wed, 22 Nov 2023 23:06:29 +0000 (17:06 -0600)] 
GCC specific typo

2 years agoAdd macro for mapping C types to FR_TYPE_* values
Arran Cudbard-Bell [Wed, 22 Nov 2023 22:56:48 +0000 (16:56 -0600)] 
Add macro for mapping C types to FR_TYPE_* values

2 years agoTypo
Arran Cudbard-Bell [Wed, 22 Nov 2023 22:56:22 +0000 (16:56 -0600)] 
Typo

2 years agoFixup a bunch of legacy non-struct based C type to FR type mappings
Arran Cudbard-Bell [Wed, 22 Nov 2023 22:42:37 +0000 (16:42 -0600)] 
Fixup a bunch of legacy non-struct based C type to FR type mappings

...don't know how this was missed for so long.   This just leaves size_t as ambiguous.

2 years agoAll these tmpls probably want moving to call envs...
Arran Cudbard-Bell [Wed, 22 Nov 2023 22:40:55 +0000 (16:40 -0600)] 
All these tmpls probably want moving to call envs...

But for the moment just remove the horrible mass of duplicated code that's failing...

2 years agoSplit type and flags fields in conf_parser_t
Arran Cudbard-Bell [Sat, 18 Nov 2023 03:25:32 +0000 (22:25 -0500)] 
Split type and flags fields in conf_parser_t

2 years agosupport syslog, stdout, and stderr
Alan T. DeKok [Wed, 22 Nov 2023 21:49:31 +0000 (16:49 -0500)] 
support syslog, stdout, and stderr

2 years agodon't init / free logs any more. it's not in main config
Alan T. DeKok [Wed, 22 Nov 2023 18:52:07 +0000 (13:52 -0500)] 
don't init / free logs any more.  it's not in main config

2 years agomove log_global_free() to main_config
Alan T. DeKok [Wed, 22 Nov 2023 18:26:37 +0000 (13:26 -0500)] 
move log_global_free() to main_config

as log_global_init() is now there too

2 years agoadd creation flags for file open
Alan T. DeKok [Wed, 22 Nov 2023 18:21:42 +0000 (13:21 -0500)] 
add creation flags for file open