]>
git.ipfire.org Git - thirdparty/freeradius-server.git/log
Alan T. DeKok [Fri, 17 Mar 2023 14:06:06 +0000 (10:06 -0400)]
remove "other" from here, too
Jorge Pereira [Thu, 16 Mar 2023 16:43:34 +0000 (13:43 -0300)]
Fix missing prototype parameter in ssl_version()
Jorge Pereira [Thu, 16 Mar 2023 21:57:15 +0000 (18:57 -0300)]
Suppress GCC unknown pragma warnings in rlm_perl
Jorge Pereira [Wed, 15 Mar 2023 23:48:32 +0000 (20:48 -0300)]
ci: Bump OpenSSL for 3.0.8
Alan T. DeKok [Fri, 17 Mar 2023 13:40:19 +0000 (09:40 -0400)]
disallow CoA for fake packets. Fixes #4929
The CoA handling in process.c requires that the CoA packet be
associated with a "real" request. i.e. one that was received from
the network, and is therefore long-lived.
"fake" packets, such as ones sent to a virtual home server, or
packets used in the "inner-tunnel" virtual server can't do CoA.
This is because the fake packets are freed immediately after they
are processed, and there is no way for them to push the CoA child
into the main event loop.
Alan T. DeKok [Fri, 17 Mar 2023 13:28:58 +0000 (09:28 -0400)]
just remove the file, as it's entirely unused
Jorge Pereira [Tue, 14 Mar 2023 19:09:56 +0000 (16:09 -0300)]
Fix runtime error in file_common()
Such error:
src/modules/rlm_files/rlm_files.c:431:49: runtime error: null pointer passed as argument 3, which is declared to never be null
src/freeradius-devel/radiusd.h:603:89: note: nonnull attribute specified here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/modules/rlm_files/rlm_files.c:431:49 in
Jorge Pereira [Tue, 14 Mar 2023 19:05:42 +0000 (16:05 -0300)]
Fix runtime error in cf_file_open()
Such error:
src/main/conffile.c:333:22: runtime error: load of value 190, which is not a valid value for type 'bool'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/main/conffile.c:333:22 in
Jorge Pereira [Tue, 14 Mar 2023 18:44:21 +0000 (15:44 -0300)]
Fix runtime error: load of misaligned address in xlat_integer()
Such error:
src/main/xlat.c:206:38: runtime error: load of misaligned address 0x00010410ba72 for type 'uint32_t' (aka 'unsigned int'), which requires 4 byte alignment
0x00010410ba72: note: pointer points here
00 00 00 20 39 38 37 3e 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
^
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/main/xlat.c:206:38 in
Jorge Pereira [Tue, 14 Mar 2023 18:27:21 +0000 (15:27 -0300)]
Fix runtime LSAN/ASAN error in fr_in6addr_mask()
Such error:
src/lib/misc.c:1266:34: runtime error: load of misaligned address 0x00016f8b1d54 for type 'const uint64_t' (aka 'const unsigned long long'), which requires 8 byte alignment
0x00016f8b1d54: note: pointer points here
e0 89 29 05 00 00 00 00 00 00 00 00 00 00 ff ff cb 00 71 00 00 00 00 00 e0 89 29 05 01 00 00 00
^
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/lib/misc.c:1266:34 in
Jorge Pereira [Tue, 14 Mar 2023 17:51:56 +0000 (14:51 -0300)]
Fix AddressSanitizer: odr-violation in 'radiusd_version'
That's why we are backing port the 'HIDDEN' macro.
Jorge Pereira [Tue, 14 Mar 2023 16:26:16 +0000 (13:26 -0300)]
Fix LSAN/ASAN memory-leak in lib/radius
Jorge Pereira [Wed, 8 Mar 2023 15:20:21 +0000 (12:20 -0300)]
Fix runtime LSAN/ASAN error in src/lib/dict.c
src/lib/dict.c:1365:9: runtime error: signed integer overflow:
429496729 * 10 cannot be represented in type 'int'
Jorge Pereira [Wed, 8 Mar 2023 15:17:44 +0000 (12:17 -0300)]
Fix runtime LSAN/ASAN error in src/main/conffile.c
src/main/conffile.c:1831:49: runtime error: applying zero offset to null pointer
Jorge Pereira [Tue, 14 Mar 2023 17:26:55 +0000 (14:26 -0300)]
radattr: Fix several memory-leaks reported by LSAN
Alan T. DeKok [Fri, 17 Mar 2023 13:20:00 +0000 (09:20 -0400)]
juste use fr_hash() instead of hand-rolled hash from 2002
Jorge Pereira [Wed, 8 Mar 2023 15:40:14 +0000 (12:40 -0300)]
Backport m4/ax_cc.m4 from v4
Jorge Pereira [Thu, 16 Mar 2023 21:56:34 +0000 (18:56 -0300)]
Backport 'DIAG_UNKNOWN_PRAGMAS' macro from v4
Jorge Pereira [Wed, 15 Mar 2023 19:13:23 +0000 (16:13 -0300)]
Fix mismatched bound size in eapsim_checkmac()
Jorge Pereira [Thu, 16 Mar 2023 16:12:43 +0000 (13:12 -0300)]
Fix memory leak in client_add()
Such error when we run: radiusd -CX
Configuration appears to be OK
Allocated memory at time of report:
Current state of talloced memory:
full talloc report on 'null_context' (total 1057 bytes in 4 blocks)
autofree_context contains 1 bytes in 2 blocks (ref 0) 0x608000000400
bool contains 1 bytes in 1 blocks (ref 0) 0x60b000044a90
RADCLIENT_LIST contains 1056 bytes in 1 blocks (ref 0) 0x6190000032e0
=================================================================
==43730==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 1152 byte(s) in 1 object(s) allocated from:
#0 0x5603d1a170be in malloc (/__w/freeradius-server/freeradius-server/build/bin/local/radiusd+0x20b0be) (BuildId:
acbe3a0941626cf6f01ae6b2c12df877fb8fc009 )
#1 0x7f2c07e40c86 in _talloc_zero (/lib/x86_64-linux-gnu/libtalloc.so.2+0x6c86) (BuildId:
f3c1074a602981acb4683b4df6b7733b104ba7d4 )
#2 0x5603d1a62780 in client_list_init (/__w/freeradius-server/freeradius-server/build/bin/local/radiusd+0x256780) (BuildId:
acbe3a0941626cf6f01ae6b2c12df877fb8fc009 )
#3 0x5603d1a62a4a in client_add (/__w/freeradius-server/freeradius-server/build/bin/local/radiusd+0x256a4a) (BuildId:
acbe3a0941626cf6f01ae6b2c12df877fb8fc009 )
#4 0x5603d1a6b713 in client_list_parse_section (/__w/freeradius-server/freeradius-server/build/bin/local/radiusd+0x25f713) (BuildId:
acbe3a0941626cf6f01ae6b2c12df877fb8fc009 )
#5 0x5603d1ae8532 in main_config_init (/__w/freeradius-server/freeradius-server/build/bin/local/radiusd+0x2dc532) (BuildId:
acbe3a0941626cf6f01ae6b2c12df877fb8fc009 )
#6 0x5603d1b45bc4 in main (/__w/freeradius-server/freeradius-server/build/bin/local/radiusd+0x339bc4) (BuildId:
acbe3a0941626cf6f01ae6b2c12df877fb8fc009 )
#7 0x7f2c07981082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082) (BuildId:
1878e6b475720c7c51969e69ab2d276fae6d1dee )
#8 0x5603d19924fd in _start (/__w/freeradius-server/freeradius-server/build/bin/local/radiusd+0x1864fd) (BuildId:
acbe3a0941626cf6f01ae6b2c12df877fb8fc009 )
SUMMARY: AddressSanitizer: 1152 byte(s) leaked in 1 allocation(s).
Jorge Pereira [Tue, 14 Mar 2023 21:36:01 +0000 (18:36 -0300)]
Fix heap-buffer-overflow in pap_auth_pbkdf2_parse()
==
3061536 ==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6100000053f9 at pc 0x7f3eb4ff6bbe bp 0x7fff630b7770 sp 0x7fff630b7768
READ of size 1 at 0x6100000053f9 thread T0
#0 0x7f3eb4ff6bbd in strlcpy /home/jpereira/Devel/FreeRADIUS/freeradius-server-v3.2.x.git-linux/src/lib/strlcpy.c:56:10
Alan T. DeKok [Thu, 16 Mar 2023 17:01:56 +0000 (13:01 -0400)]
coa->home_server may be NULL. Fixes #4929
It's not clear _why_ home_server==NULL. Nothing resets it.
And it should only be NULL if the CoA packet is sent through a
virtual home server
Alan T. DeKok [Wed, 15 Mar 2023 17:52:34 +0000 (13:52 -0400)]
Update dictionary.wifialliance (#4928)
Discovered HS20-Roaming-Consortium being mentioned here:
https://wiki.geant.org/pages/viewpage.action?pageId=
133763844
Jorge Pereira [Tue, 14 Mar 2023 21:29:14 +0000 (18:29 -0300)]
Fix rlm_unbound build (#4927)
Alan T. DeKok [Thu, 9 Mar 2023 20:15:48 +0000 (15:15 -0500)]
call proxy_send() for sending proxied packets
which works for all packet types, including TLS ones.
Alan T. DeKok [Wed, 8 Mar 2023 18:29:01 +0000 (13:29 -0500)]
fix use of DIAG in macro
Alan T. DeKok [Wed, 8 Mar 2023 18:16:57 +0000 (13:16 -0500)]
more fixes for talloc_autofree_context() deprecation
Alan T. DeKok [Wed, 8 Mar 2023 18:02:27 +0000 (13:02 -0500)]
talloc_autofree_context() is deprecated in newer versions of talloc
Alan T. DeKok [Wed, 8 Mar 2023 17:49:00 +0000 (12:49 -0500)]
note TLS 1.2 or smaller for EAP-FAST
Alan T. DeKok [Wed, 8 Mar 2023 17:41:48 +0000 (12:41 -0500)]
Warn if libldap uses NSS. Fixes #4918
Instead of letting things break, or have random crashes, give a big
warning on startup.
Alan T. DeKok [Wed, 8 Mar 2023 13:15:08 +0000 (08:15 -0500)]
shift 32-bit words, not 8-bit words.
Manual port of
cc49e17c80b6
Alan T. DeKok [Thu, 2 Mar 2023 23:48:40 +0000 (18:48 -0500)]
add more DEBUG3
Nick Porter [Tue, 28 Feb 2023 07:52:29 +0000 (07:52 +0000)]
Update ciena dictionary
Nick Porter [Fri, 24 Feb 2023 11:34:00 +0000 (11:34 +0000)]
Document max_retries in ChangeLog
Nick Porter [Thu, 23 Feb 2023 18:25:33 +0000 (18:25 +0000)]
Define max_retries for pool connections (#4908)
Allows control over the number of times a connection operation can be
retried before the module call fails.
Previously this was always set to the number of connections in the pool
- so on a system with a large number of open connections, and a remote
server going slow, this would easily block threads.
Jorge Pereira [Mon, 20 Feb 2023 15:13:19 +0000 (12:13 -0300)]
Destroy MD context, causing leaks with OpenSSL >= 3.0 (#4899)
* rlm_pap: Destroy MD context, causing leaks with OpenSSL >= 3.0
* rlm_ippool: Destroy MD context, causing leaks with OpenSSL >= 3.0
* radius: Destroy MD context, causing leaks with OpenSSL >= 3.0
Alan T. DeKok [Thu, 16 Feb 2023 20:17:35 +0000 (15:17 -0500)]
bump TLS buffer size to 64K.
Which should be enough for high-load connections.
And move the "used" field to the start of the record_t structure,
because most of the time we're only looking at the start of the
buffer.
Matthew Newton [Thu, 16 Feb 2023 15:33:00 +0000 (15:33 +0000)]
Bump for 3.2.3
Matthew Newton [Wed, 15 Feb 2023 14:11:39 +0000 (14:11 +0000)]
release 3.2.2
Terry Burton [Thu, 16 Feb 2023 13:39:37 +0000 (13:39 +0000)]
Remove broken Dockerfiles for centos8 and debian9 (#4901)
These distros are no longer supported.
Terry Burton [Thu, 16 Feb 2023 13:36:26 +0000 (13:36 +0000)]
Ensure service user has stable uid/gid between Docker distro versions (#4900)
Changing UID between image versions is deprecated because modern container
workflows involve automated image upgrade / rollback using the same mounted-in
volume (i.e. with persistent filesystem permissions).
Terry Burton [Wed, 15 Feb 2023 17:53:28 +0000 (17:53 +0000)]
md5 xlat: Destroy MD context, causing leaks with OpenSSL >= 3.0 (#4893)
Alan T. DeKok [Wed, 15 Feb 2023 15:23:51 +0000 (10:23 -0500)]
more commented-out docs for Auth-Type LDAP
Nick Porter [Tue, 14 Feb 2023 16:34:02 +0000 (16:34 +0000)]
rest: Add test of request timeout
Nick Porter [Fri, 10 Feb 2023 17:01:41 +0000 (17:01 +0000)]
Add tests of rlm_rest
Nick Porter [Fri, 10 Feb 2023 16:59:29 +0000 (16:59 +0000)]
rest: Add option for rest xlat body data to be encoded or not
All inputs to the xlat are URI encoded. That really messes with the
body data if it's JSON or the like
Nick Porter [Fri, 10 Feb 2023 12:08:17 +0000 (12:08 +0000)]
Add OpenResty to CI test servers
Nick Porter [Fri, 10 Feb 2023 09:54:57 +0000 (09:54 +0000)]
Add rest xlat "section" config
Without this, rest xlats don't have a timeout set (other than the module
connection_timeout), have no TLS options and no authentication options.
This makes xlats more consistent with other section rest calls.
Nick Porter [Fri, 10 Feb 2023 20:56:44 +0000 (20:56 +0000)]
Quiet module test warnings
Alan T. DeKok [Fri, 10 Feb 2023 15:47:17 +0000 (10:47 -0500)]
Revert "sql.accounting needs Acct-Status-Type"
This reverts commit
85faf6285d11e2e1f8ad40f298694cd667040702 .
Alan T. DeKok [Fri, 10 Feb 2023 15:47:14 +0000 (10:47 -0500)]
Revert "run the accounting "post-auth" query for sql_session_start"
This reverts commit
5b7e4d4d031a6574a6bafd4faafb6cb9a7752192 .
Alan T. DeKok [Fri, 10 Feb 2023 15:46:54 +0000 (10:46 -0500)]
Nick Porter [Thu, 9 Feb 2023 12:03:39 +0000 (12:03 +0000)]
Package rlm_unbound for RedHat based systems
Nick Porter [Thu, 9 Feb 2023 11:40:57 +0000 (11:40 +0000)]
Package rlm_unbound for Debian based systems
Nick Porter [Thu, 9 Feb 2023 13:42:25 +0000 (13:42 +0000)]
Move man page to correct location
Nick Porter [Thu, 9 Feb 2023 13:23:04 +0000 (13:23 +0000)]
Add resolvconf and hosts options to rlm_unbound man page
Nick Porter [Thu, 9 Feb 2023 12:26:49 +0000 (12:26 +0000)]
Add rlm_unbound to stable module list
Alan T. DeKok [Thu, 9 Feb 2023 16:00:23 +0000 (11:00 -0500)]
typo
Alan T. DeKok [Thu, 9 Feb 2023 15:49:15 +0000 (10:49 -0500)]
run the accounting "post-auth" query for sql_session_start
Which should make it work again. However, it's not a good idea
to have admins mangle the default queries. We should have a
better way of "just doing the right thing"
Nick Porter [Wed, 8 Feb 2023 17:35:03 +0000 (17:35 +0000)]
Clarify pre and post proxy behaviour when proxying to a virtual server
Alan T. DeKok [Wed, 8 Feb 2023 14:50:06 +0000 (09:50 -0500)]
note recent changes
Alan T. DeKok [Wed, 1 Feb 2023 19:38:53 +0000 (14:38 -0500)]
be more careful about session established. Fixes #4878
Terry Burton [Tue, 31 Jan 2023 12:55:32 +0000 (12:55 +0000)]
Include thread stats in Status-Server attributes (#4870)
Alan T. DeKok [Mon, 30 Jan 2023 13:49:03 +0000 (08:49 -0500)]
note recent changes
Alan T. DeKok [Mon, 30 Jan 2023 13:43:17 +0000 (08:43 -0500)]
support cipher_list
Alan T. DeKok [Mon, 30 Jan 2023 13:20:40 +0000 (08:20 -0500)]
don't assert on configuration typos
Terry Burton [Wed, 25 Jan 2023 18:41:08 +0000 (18:41 +0000)]
Switch Ubuntu Docker images to 22.04
Terry Burton [Wed, 25 Jan 2023 18:40:17 +0000 (18:40 +0000)]
New Ubuntu 22.04 Docker image
Terry Burton [Fri, 27 Jan 2023 14:37:17 +0000 (14:37 +0000)]
stats: Make Status-Server stats attributes available within the virtual server (#4868)
Terry Burton [Fri, 27 Jan 2023 13:02:08 +0000 (13:02 +0000)]
check-eap-tls: Set Reply-Message in the right request's list (#4869)
Terry Burton [Thu, 26 Jan 2023 14:31:47 +0000 (14:31 +0000)]
coa-relay: Typos (#4867)
Terry Burton [Thu, 26 Jan 2023 14:05:22 +0000 (14:05 +0000)]
pap: Only look for passwords amongst non-vendor attributes (#4865)
Otherwise, the following will trigger a "Don't set
control:User-Password" warning:
VENDOR ABC 42
BEGIN-VENDOR ABC
ATTRIBUTE Not-A-Password 2 string
END-VENDOR ABC
update { &control:Not-A-Password := "x" }
pap
Jorge Pereira [Mon, 16 Jan 2023 22:08:56 +0000 (19:08 -0300)]
Close FD on error (#4848)
* Close FD on error
* Fix indent
Co-authored-by: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Nick Porter [Wed, 11 Jan 2023 08:52:27 +0000 (08:52 +0000)]
Typo
Jorge Pereira [Tue, 10 Jan 2023 16:49:57 +0000 (13:49 -0300)]
Fix typo. refs #4836 (#4842)
Alan T. DeKok [Sun, 8 Jan 2023 02:46:31 +0000 (21:46 -0500)]
this isn't an error
Alan T. DeKok [Thu, 29 Dec 2022 13:23:39 +0000 (08:23 -0500)]
typo
Alan T. DeKok [Wed, 28 Dec 2022 21:53:52 +0000 (16:53 -0500)]
minor tweaks and document how to use it with IPv6 addresses
Alan T. DeKok [Wed, 28 Dec 2022 21:53:29 +0000 (16:53 -0500)]
use CoA instead of COA
Alan T. DeKok [Wed, 28 Dec 2022 21:53:06 +0000 (16:53 -0500)]
typos
Alan T. DeKok [Wed, 14 Dec 2022 20:44:44 +0000 (15:44 -0500)]
note recent changes
Alan T. DeKok [Wed, 14 Dec 2022 20:32:56 +0000 (15:32 -0500)]
Add TLS-PSK-Identity to sock->certs
Herwin [Fri, 30 Dec 2022 15:47:25 +0000 (16:47 +0100)]
Replace magic values in rlm_pap.c with symbolic constants (#4832)
Alan T. DeKok [Wed, 14 Dec 2022 16:19:03 +0000 (11:19 -0500)]
give better error messages for %{listen:TLS-*}
Alan T. DeKok [Wed, 14 Dec 2022 16:16:46 +0000 (11:16 -0500)]
fix various build warnings with newer compilers
Alan T. DeKok [Fri, 9 Dec 2022 16:17:05 +0000 (11:17 -0500)]
don't remove the .d file, it's an output file
which is needed by the target rule
Nick Porter [Fri, 9 Dec 2022 13:22:05 +0000 (13:22 +0000)]
Handle changes in libcurl options
Nick Porter [Mon, 5 Dec 2022 13:59:42 +0000 (13:59 +0000)]
Protect calls to rlm_files where no packet for check items exists
This can happen, for exanple, if proxying fails and files is called in
the Fail-Authentication section.
Nick Porter [Fri, 2 Dec 2022 14:14:04 +0000 (14:14 +0000)]
PostgreSQL can distinguish between duplicate key and other erros
Nick Porter [Thu, 1 Dec 2022 17:51:00 +0000 (17:51 +0000)]
Ensure responses are sent to accounting packets written to detail files
Nick Porter [Thu, 1 Dec 2022 14:42:46 +0000 (14:42 +0000)]
Add basic VS Code config
Alan T. DeKok [Wed, 30 Nov 2022 12:26:41 +0000 (07:26 -0500)]
notes on setcap
Alan T. DeKok [Wed, 30 Nov 2022 12:22:10 +0000 (07:22 -0500)]
whitespace
Alan T. DeKok [Wed, 30 Nov 2022 12:20:39 +0000 (07:20 -0500)]
remove useless debug message
Matthew Newton [Tue, 29 Nov 2022 21:18:03 +0000 (21:18 +0000)]
and the same for protocols
Matthew Newton [Tue, 29 Nov 2022 15:47:30 +0000 (15:47 +0000)]
Add module README.md files
Alan T. DeKok [Tue, 29 Nov 2022 15:54:41 +0000 (10:54 -0500)]
more docs, add tracking, and send packets more quickly
Nick Porter [Fri, 18 Nov 2022 16:56:01 +0000 (16:56 +0000)]
Ensure acctupdatetime is always populated
This helps with queries used to identify sessions which have stopped but
no accounting stop has been received.
Alan T. DeKok [Mon, 14 Nov 2022 16:26:06 +0000 (11:26 -0500)]
use "data" from tree, not "context" from caller
Alan T. DeKok [Fri, 11 Nov 2022 13:10:43 +0000 (13:10 +0000)]
use rad_assert