]>
git.ipfire.org Git - thirdparty/zlib-ng.git/log
Nathan Moinvaziri [Mon, 15 Feb 2021 02:14:43 +0000 (18:14 -0800)]
Prevent parallel test jobs from initializing Wine at the same time and erroring out.
Nathan Moinvaziri [Sat, 13 Feb 2021 20:51:02 +0000 (12:51 -0800)]
Improve compiler detection of code coverage flags.
Pass -coverage or flag to linker for mingw-gcc.
Nathan Moinvaziri [Sun, 14 Feb 2021 00:25:52 +0000 (16:25 -0800)]
Disable leak sanitizer for cross-compilation since it is not supported.
Nathan Moinvaziri [Sat, 13 Feb 2021 20:23:48 +0000 (12:23 -0800)]
Fixed qemu test runs for Ubuntu 20.
Nathan Moinvaziri [Sat, 30 Jan 2021 23:36:04 +0000 (15:36 -0800)]
Fixed clang tools package error in static analysis CI workflow.
Mark Adler [Fri, 5 Apr 2019 22:27:47 +0000 (15:27 -0700)]
Explicitly note that the 32-bit check values are 32 bits.
Mark Adler [Mon, 31 Aug 2020 19:53:58 +0000 (12:53 -0700)]
Clarify gz* function interfaces, referring to parameter names.
Mark Adler [Tue, 9 Jul 2019 15:55:13 +0000 (08:55 -0700)]
Fix error in comment on the polynomial representation of a byte.
Hans Kristian Rosbach [Fri, 29 Jan 2021 08:48:01 +0000 (09:48 +0100)]
Version 2.0.0 Release Candidate 2
Nathan Moinvaziri [Thu, 28 Jan 2021 08:06:08 +0000 (00:06 -0800)]
Store result of early exit trigger at the top of longest_match.
Nathan Moinvaziri [Mon, 25 Jan 2021 06:26:51 +0000 (22:26 -0800)]
Always canonicalize CHOST when building original zlib even after automatic CHOST detection.
Nathan Moinvaziri [Mon, 25 Jan 2021 06:25:07 +0000 (22:25 -0800)]
Re-enable 32-bit machine ABI check in CI.
Nathan Moinvaziri [Mon, 25 Jan 2021 06:23:21 +0000 (22:23 -0800)]
Fixed missing large file defines in zconf.in that exist in zconf-ng.in. Accidentally removed from api cleanup.
https://github.com/zlib-ng/zlib-ng/commit/
6dcc7bf815c803fe7712e449b3c8fee8f3ab6dda #diff-
ce3e5ac484a4ca73e6533421950dbe15
Nathan Moinvaziri [Tue, 26 Jan 2021 00:47:37 +0000 (16:47 -0800)]
Remove debug check for match beginning at start of window.
Nathan Moinvaziri [Tue, 26 Jan 2021 00:20:56 +0000 (16:20 -0800)]
Use a version of Xcode that supports ZERO_AR_DATE in pkgcheck script.
Nathan Moinvaziri [Mon, 25 Jan 2021 22:17:58 +0000 (14:17 -0800)]
Disable homebrew auto cleanup on macOS CIs.
https://www.scivision.dev/macos-ci-homebrew-disable-cleanup/
Hans Kristian Rosbach [Fri, 15 Jan 2021 13:29:58 +0000 (14:29 +0100)]
Add extra space in deflate internal_state struct for future expansion.
Also make internal_state struct have a static size regardless of what features have been activated.
Internal_state is now always 6040 bytes on Linux/x86-64, and 5952 bytes on Linux/x86-32.
Hans Kristian Rosbach [Thu, 14 Jan 2021 14:39:41 +0000 (15:39 +0100)]
Sync cmake variable names with names already used by %cmake macros in
rpm-specs on redhat-based distros, making it easier to build corect packages.
Nathan Moinvaziri [Tue, 12 Jan 2021 00:22:08 +0000 (16:22 -0800)]
Set tag environment variable using new GHA environment files.
Hans Kristian Rosbach [Mon, 11 Jan 2021 23:25:52 +0000 (00:25 +0100)]
Update abicheck git commit reference
Hans Kristian Rosbach [Mon, 11 Jan 2021 23:01:56 +0000 (00:01 +0100)]
Fix SONAME version
Hans Kristian Rosbach [Mon, 11 Jan 2021 20:38:18 +0000 (21:38 +0100)]
Version 2.0.0 Release Candidate 1
Hans Kristian Rosbach [Mon, 11 Jan 2021 17:44:09 +0000 (18:44 +0100)]
Disallow semantic interposition in ELF shared libraries if supported by the compiler.
This disallows calls to our own exported functions being replaced by LD_PRELOAD, thus
avoiding the potential bugs and allowing the compiler to optimize better.
Nathan Moinvaziri [Mon, 4 Jan 2021 05:16:40 +0000 (21:16 -0800)]
Fixed previous match length not reset when match start reset.
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24294
Nathan Moinvaziri [Mon, 4 Jan 2021 05:56:50 +0000 (21:56 -0800)]
Add check in check_match for invalid match position.
Nathan Moinvaziri [Mon, 4 Jan 2021 05:34:57 +0000 (21:34 -0800)]
Improve check_match output to print hex values of mismatch characters and character index.
Tim Gates [Mon, 14 Dec 2020 11:51:12 +0000 (22:51 +1100)]
docs: fix simple typo, stragety -> strategy
There is a small typo in INDEX.md.
Should read `strategy` rather than `stragety`.
Nathan Moinvaziri [Wed, 2 Dec 2020 06:58:19 +0000 (22:58 -0800)]
Fixed macOS CI instance to use GCC
David CARLIER [Fri, 1 Jan 2021 08:56:10 +0000 (08:56 +0000)]
darwin ios/mac m1 cpu features detection update proposal
Nathan Moinvaziri [Sun, 22 Nov 2020 22:28:12 +0000 (14:28 -0800)]
Separate sanitizers so they can be run independently.
Nathan Moinvaziri [Wed, 4 Nov 2020 07:16:10 +0000 (23:16 -0800)]
Set verbosity to 0 to limit CI log output.
Nathan Moinvaziri [Wed, 4 Nov 2020 03:57:25 +0000 (19:57 -0800)]
Disable codecov in MinGW i686 due to gcov locking error when multiple tests run at the same time.
profiling:gzlib.c.gcda:Data file mismatch - some data files may have been concurrently updated without locking support
Hans Kristian Rosbach [Mon, 2 Nov 2020 16:58:42 +0000 (17:58 +0100)]
Add check that tests UNALIGNED_OK without UNALIGNED64_OK.
Co-authored-by: Nathan Moinvaziri <nathan@nathanm.com>
Nathan Moinvaziri [Tue, 10 Nov 2020 01:02:38 +0000 (17:02 -0800)]
Separate crc32 and crc32_combine tables so the crc32_combine tables are not included when not used if statically linking. Reduces code size by 4k.
Greg V [Sat, 14 Nov 2020 11:29:17 +0000 (14:29 +0300)]
Add AArch64 feature detection support for FreeBSD
Greg V [Sat, 14 Nov 2020 11:14:36 +0000 (14:14 +0300)]
CMake: fix 'ALDER32' typo in feature info message
Nathan Moinvaziri [Mon, 9 Nov 2020 02:26:06 +0000 (18:26 -0800)]
Fixed coverity dereference after null check in gz_compress CID 303796.
Nathan Moinvaziri [Sat, 31 Oct 2020 01:40:28 +0000 (18:40 -0700)]
Fixed ubsan error when building tree with no symbols. #782
When there are no symbols in the tree we skip build_tree calculations and emit a block using static tree with no codes.
trees.c:357:19: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'unsigned long'
#0 0x1000ed79b in build_tree trees.c:357
#1 0x1000ea3f5 in zng_tr_flush_block trees.c:649
#2 0x100090ab0 in deflate_slow deflate_slow.c:131
#3 0x1000572bc in zng_deflate deflate.c:990
#4 0x1000aecd3 in gz_comp gzwrite.c:125
#5 0x1000b05df in zng_gzclose_w gzwrite.c:511
#6 0x1000967a4 in zng_gzclose gzlib.c:253
#7 0x100004f70 in test_gzio example.c:133
#8 0x100010c5b in main example.c:1034
#9 0x7fff71f57cc8 in start+0x0 (libdyld.dylib:x86_64+0x1acc8)
Nathan Moinvaziri [Fri, 2 Oct 2020 06:10:19 +0000 (23:10 -0700)]
Fixed conditional expression is constant maintainer warnings.
chunkset_tpl.h(42,47): warning C4127: conditional expression is constant
functable.c(381,44): warning C4127: conditional expression is constant
Nathan Moinvaziri [Fri, 2 Oct 2020 05:57:38 +0000 (22:57 -0700)]
Fixed casting warnings when comparing MAX_DIST.
deflate_medium.c(127,76): warning C4244: '=': conversion from 'unsigned int' to 'Pos', possible loss of data
Nathan Moinvaziri [Fri, 2 Oct 2020 05:59:27 +0000 (22:59 -0700)]
Fixed conversion warning when assigning wsize to Pos variable.
deflate.c(218,1): warning C4244: 'initializing': conversion from 'unsigned int' to 'Pos', possible loss of data
deflate.c(241,1): warning C4244: 'initializing': conversion from 'unsigned int' to 'Pos', possible loss of data
Nathan Moinvaziri [Fri, 2 Oct 2020 05:53:50 +0000 (22:53 -0700)]
Fixed conversion warning when calling zng_tr_tally_dist. Signature for dist and len now match zng_emit_dist.
deflate.c(1575,67): warning C4244: 'function': conversion from 'uint32_t' to 'unsigned char', possible loss of data
deflate_fast.c(60,94): warning C4244: 'function': conversion from 'uint32_t' to 'unsigned char', possible loss of data
deflate_medium.c(39,102): warning C4244: 'function': conversion from 'int' to 'unsigned char', possible loss of data
deflate_slow.c(75,101): warning C4244: 'function': conversion from 'unsigned int' to 'unsigned char', possible loss of data
Nathan Moinvaziri [Fri, 2 Oct 2020 05:49:28 +0000 (22:49 -0700)]
Fixed str uint32_t to uint16_t casting warnings in inflate_string_tpl.h
insert_string_tpl.h(50,26): warning C4244: '=': conversion from 'const uint32_t' to 'Pos', possible loss of data
insert_string_tpl.h(67,1): warning C4244: 'initializing': conversion from 'const uint32_t' to 'Pos', possible loss of data
Nathan Moinvaziri [Fri, 2 Oct 2020 05:47:22 +0000 (22:47 -0700)]
Fixed match_start uint32_t to uint16_t casting warnings in deflate_medium.c
deflate_medium.c(204,49): warning C4244: '=': conversion from 'unsigned int' to 'uint16_t', possible loss of data
deflate_medium.c(217,59): warning C4244: '=': conversion from 'unsigned int' to 'uint16_t', possible loss of data
deflate_medium.c(238,46): warning C4244: '=': conversion from 'unsigned int' to 'uint16_t', possible loss of data
deflate_medium.c(250,56): warning C4244: '=': conversion from 'unsigned int' to 'uint16_t', possible loss of data
Nathan Moinvaziri [Sat, 31 Oct 2020 04:14:42 +0000 (21:14 -0700)]
Fixed ubsan warning in gzfread due to size_t overflow. #783
gzread.c:398:18: runtime error: unsigned integer overflow: 2 *
18446744073709551615 cannot be represented in type 'unsigned long'
#0 0x10009d31e in zng_gzfread gzread.c:398
#1 0x100005b1a in test_gzio example.c:213
#2 0x10001093b in main example.c:1034
#3 0x7fff71f57cc8 in start+0x0 (libdyld.dylib:x86_64+0x1acc8)
Nathan Moinvaziri [Sat, 31 Oct 2020 01:47:10 +0000 (18:47 -0700)]
Fixed format specifier warning in build_tree call to Tracev.
Format specifies type 'unsigned long' but the argument has type 'uint32_t' (aka 'unsigned int')
Nathan Moinvaziri [Sat, 31 Oct 2020 02:33:11 +0000 (19:33 -0700)]
Fixed minigzip_fuzzer not compiling on latest macOS due to missing _POSIX_C_SOURCE.
Nathan Moinvaziri [Mon, 2 Nov 2020 03:12:13 +0000 (19:12 -0800)]
Remove unnecessary name array from matrix.
Nathan Moinvaziri [Sun, 20 Sep 2020 19:22:44 +0000 (12:22 -0700)]
Combine option and add_feature_info in CMake.
Hans Kristian Rosbach [Sun, 18 Oct 2020 15:31:51 +0000 (17:31 +0200)]
Small formatting changes in inflate.c, inflate.h and inffast.c
Hans Kristian Rosbach [Sun, 18 Oct 2020 14:19:51 +0000 (16:19 +0200)]
inflate: add SET_BAD macro, to make inflate.c a little cleaner.
Nathan Moinvaziri [Sat, 17 Oct 2020 21:47:31 +0000 (14:47 -0700)]
Fixed formatting in check_c_source_compiles checks for consistency.
Nathan Moinvaziri [Sat, 17 Oct 2020 21:31:07 +0000 (14:31 -0700)]
Fixed ptrdiff_t redefined static analysis warning on GCC. Failing ptrdiff_t detection due to variable unused warning combined with -Werror.
In file included from zlib-ng/zlib-ng.h:33,
from zlib-ng/zutil.h:38,
from zlib-ng/adler32.c:7:
zlib-ng/zconf-ng.h:118:18: error: conflicting types for ‘ptrdiff_t’
118 | typedef uint64_t ptrdiff_t;
| ^~~~~~~~~
In file included from zlib-ng/zutil.h:31,
from zlib-ng/adler32.c:7:
stddef.h:143:26: note: previous declaration of ‘ptrdiff_t’ was here
143 | typedef __PTRDIFF_TYPE__ ptrdiff_t;
| ^~~~~~~~~
Nathan Moinvaziri [Fri, 2 Oct 2020 05:10:40 +0000 (22:10 -0700)]
Added verbose flag to CI to see sanitizer output.
Nathan Moinvaziri [Sun, 20 Sep 2020 02:39:42 +0000 (19:39 -0700)]
Fixed unsigned integer overflow ASAN error when hash_head > s->strstart.
zlib-ng/deflate_medium.c:244:47: runtime error: unsigned integer overflow: 58442 - 58452 cannot be represented in type 'unsigned int'
Co-authored-by: Mika Lindqvist <postmaster@raasu.org>
Co-authored-by: Hans Kristian Rosbach <hk-git@circlestorm.org>
Gabriel A. Devenyi [Tue, 29 Sep 2020 01:45:28 +0000 (21:45 -0400)]
Elevate warnings to errors to trigger failure on static analyzer
Ilya Leoshkevich [Mon, 28 Sep 2020 19:54:54 +0000 (21:54 +0200)]
Fix switchlevels calling deflateParams() with a stale buffer
Fixes: #776
Ilya Leoshkevich [Mon, 28 Sep 2020 19:21:49 +0000 (21:21 +0200)]
Fix incorrect inflateSyncPoint() return value with DFLTCC
DFLTCC does not provide the necessary information to implement
inflateSyncPoint() - Incomplete-Function Status and Incomplete-Function
Length are the fields that provide the relevant information, but
unfortunately it's not enough. If DFLTCC is in use, the current code
checks software decompression state and always returns 0. This
(rightfully) confuses rsync, so fix by returning Z_STREAM_ERROR
instead.
Nathan Moinvaziri [Mon, 5 Oct 2020 01:36:25 +0000 (18:36 -0700)]
Fixed left shift ubsan warning in PULLBYTE.
infback.c:200:13: runtime error: left shift of 255 by 24 places cannot be represented in type 'int'
624: SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/runner/work/zlib-ng/zlib-ng/infback.c:200:13 in
Mark Adler [Sun, 6 Sep 2015 00:45:55 +0000 (17:45 -0700)]
Avoid shifts of negative values inflateMark().
The C standard says that bit shifts of negative integers is
undefined. This casts to unsigned values to assure a known
result.
Nathan Moinvaziri [Sat, 3 Oct 2020 21:34:08 +0000 (14:34 -0700)]
Abort CI tests on sanitizer error.
Mika Lindqvist [Sat, 3 Oct 2020 23:52:56 +0000 (02:52 +0300)]
Fix memory leak in gz_compress() and add NULL check.
Mika Lindqvist [Sat, 3 Oct 2020 23:05:05 +0000 (02:05 +0300)]
Fix memory leak in gz_uncompress().
Nathan Moinvaziri [Mon, 28 Sep 2020 23:43:50 +0000 (16:43 -0700)]
Fixed dereference of possibly null head variable in test_deflate_set_header.
example.c:920:16: warning: dereference of possibly-NULL ‘head’ [CWE-690] [-Wanalyzer-possible-null-dereference]
920 | head->text = 1;
| ~~~~~~~~~~~^~~
‘test_deflate_set_header’: event 1
|
| 906 | PREFIX(gz_header) *head = calloc(1, sizeof(PREFIX(gz_header)));
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| | |
| | (1) this call could return NULL
Ilya Leoshkevich [Mon, 28 Sep 2020 20:33:02 +0000 (22:33 +0200)]
Fix constness in DFLTCC code
Use z_const instead of const in order to fix compiler warnings.
Mika Lindqvist [Thu, 24 Sep 2020 17:19:48 +0000 (20:19 +0300)]
Add 'diffoscope' for MacOS in pkgcheck.yml
* Disable ABI check for MacOS as the runner doesn't contain abigail
Mika Lindqvist [Thu, 24 Sep 2020 14:45:09 +0000 (17:45 +0300)]
Add missing 'diffoscope' package to pkgcheck.yml
Mika Lindqvist [Sun, 20 Sep 2020 01:25:21 +0000 (18:25 -0700)]
Fix unsigned integer overflow ASAN error for align_diff in crc_folding.c.
zlib-ng/arch/x86/crc_folding.c:252:31: runtime error: unsigned integer overflow: 0 -
108370614813184 cannot be represented in type 'unsigned long'
Nathan Moinvaziri [Sun, 20 Sep 2020 23:31:59 +0000 (16:31 -0700)]
Fixed tab indentation for inffixed_tbl.h.
Nathan Moinvaziri [Sun, 20 Sep 2020 23:02:38 +0000 (16:02 -0700)]
Remove package caching for Windows since we no longer downgrade to MinGW 7.
Nathan Moinvaziri [Sun, 20 Sep 2020 23:01:03 +0000 (16:01 -0700)]
Added option to normalize line-endings in CMake run-and-compare script.
Nathan Moinvaziri [Sun, 20 Sep 2020 20:32:13 +0000 (13:32 -0700)]
Move tests closer to add_executable in CMake to make them easier to find.
Nathan Moinvaziri [Sun, 20 Sep 2020 19:54:20 +0000 (12:54 -0700)]
Fixed cmake script directory for out of source builds.
Nathan Moinvaziri [Sun, 20 Sep 2020 17:36:19 +0000 (10:36 -0700)]
Fixed parallel test runs on macOS by always appending unique id, since with corpora repository, multiple tests can have the same output name.
Nathan Moinvaziri [Sun, 20 Sep 2020 17:13:41 +0000 (10:13 -0700)]
Ignore hidden test files with ctest on macOS.
Nathan Moinvaziri [Sun, 20 Sep 2020 02:55:46 +0000 (19:55 -0700)]
Use latest stable version of codecov rather that git repo.
Nathan Moinvaziri [Sat, 19 Sep 2020 23:15:41 +0000 (16:15 -0700)]
Checkout corpora into a separate directory to prevent overwriting.
(cherry picked from commit
b25c7202afdbd8e4270908c65598464f31063d51 )
Nathan Moinvaziri [Sat, 19 Sep 2020 23:04:58 +0000 (16:04 -0700)]
Add checks to cmake scripts to see if input files exist.
Nathan Moinvaziri [Sat, 19 Sep 2020 01:43:42 +0000 (18:43 -0700)]
Turn off compare and gzip verify in GH-536 tests due to switchlevels.
Nathan Moinvaziri [Sat, 19 Sep 2020 01:42:27 +0000 (18:42 -0700)]
Add ability to turn off compare step in test-compare script.
Nathan Moinvaziri [Sat, 19 Sep 2020 01:41:45 +0000 (18:41 -0700)]
Check if input variables are defined in cmake scripts.
Nathan Moinvaziri [Sat, 19 Sep 2020 01:39:02 +0000 (18:39 -0700)]
Check exit code from execute_process in run-and-compare cmake script.
Nathan Moinvaziri [Sat, 19 Sep 2020 01:13:28 +0000 (18:13 -0700)]
Removed extra whitespace in CMakeLists.txt.
Nathan Moinvaziri [Sat, 19 Sep 2020 01:10:03 +0000 (18:10 -0700)]
Remove exit code 1 from SUCCESS_EXIT for normal compression tests.
Nathan Moinvaziri [Sat, 19 Sep 2020 01:08:49 +0000 (18:08 -0700)]
Fixed passing fixed/filtered arguments in TEST_CONFIGS.
Nathan Moinvaziri [Sat, 19 Sep 2020 01:04:30 +0000 (18:04 -0700)]
Cleanup temporary files before fatal error in test-compress cmake script.
Nathan Moinvaziri [Sat, 19 Sep 2020 01:03:38 +0000 (18:03 -0700)]
Check exit code from execute_process in test-compare cmake script.
Nathan Moinvaziri [Sat, 19 Sep 2020 00:52:43 +0000 (17:52 -0700)]
Fixed don't run tests against temporary files.
Nathan Moinvaziri [Thu, 17 Sep 2020 02:30:59 +0000 (19:30 -0700)]
Fixed compression args for GH-361 unit test.
Nathan Moinvaziri [Sun, 20 Sep 2020 17:51:05 +0000 (10:51 -0700)]
Remove NIL preprocessor macro which isn't consistently enforced.
Nathan Moinvaziri [Mon, 21 Sep 2020 03:44:55 +0000 (20:44 -0700)]
Fixed deference null return value in gz_uncompress (CID 301524)
Nathan Moinvaziri [Sun, 20 Sep 2020 01:50:10 +0000 (18:50 -0700)]
Remove unused F_OPEN preprocessor macro.
Nathan Moinvaziri [Sat, 19 Sep 2020 23:27:54 +0000 (16:27 -0700)]
Remove gcov-7 install since warnings on gcov-8 no longer occur in Windows CI.
Mika Lindqvist [Mon, 14 Sep 2020 15:40:35 +0000 (18:40 +0300)]
Remove chunkmemset_3 and chunkmemset_6 on ARM/AArch64 as they need 3 chunks...
* Don't unroll distances smaller than chunk size.
Mika Lindqvist [Mon, 14 Sep 2020 19:13:09 +0000 (22:13 +0300)]
Add missing z_const to fuzzers.
Nathan Moinvaziri [Mon, 14 Sep 2020 05:12:40 +0000 (22:12 -0700)]
Fixed match_byte casting warning in compare256_unaligned_64_static.
compare258.c(158,36): warning C4244: 'return': conversion from 'uint64_t' to 'uint32_t', possible loss of data
Nathan Moinvaziri [Mon, 14 Sep 2020 04:58:57 +0000 (21:58 -0700)]
Move gzclose() to gzlib.c. Modern linkers should be smart enough to link it in only if it is used.
Nathan Moinvaziri [Mon, 14 Sep 2020 04:16:36 +0000 (21:16 -0700)]
Optionally include gzguts.h with WITH_GZFILEOP flag.
Nathan Moinvaziri [Sun, 13 Sep 2020 04:08:00 +0000 (21:08 -0700)]
Added ubuntu mingw cross-compile CI instances to cmake GHA.
Nathan Moinvaziri [Sun, 13 Sep 2020 04:20:36 +0000 (21:20 -0700)]
Fixed buf resource leak in gz_compress when USE_MMAP is defined. (CID 298965)