]> git.ipfire.org Git - thirdparty/hostap.git/log
thirdparty/hostap.git
20 months agoMLD: Add a TEST_FAIL to fail one link in an MLD association.
Benjamin Berg [Mon, 20 Nov 2023 23:51:26 +0000 (01:51 +0200)] 
MLD: Add a TEST_FAIL to fail one link in an MLD association.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
20 months agoMLD: Return status code for links when rejecting association
Benjamin Berg [Mon, 20 Nov 2023 23:51:26 +0000 (01:51 +0200)] 
MLD: Return status code for links when rejecting association

When the TX link rejects the association, return a status code for all
requested links. For simplicity, just return "TX link not accepted" so
that clients may try to connect to other links. This could be improved
to explicitly reject each link if directly associating to the link will
not work either.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
20 months agoMLD: Also mark links as failed after association failure
Benjamin Berg [Mon, 20 Nov 2023 23:51:25 +0000 (01:51 +0200)] 
MLD: Also mark links as failed after association failure

Parse the link status values out of Multi-Link association response. If
the AP rejects ML association and marks the links as failed with a
reason code other than TX_LINK_NOT_ACCEPTED, also report these links to
wpas_connection_failed() and ignore them.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
20 months agoEHT: Define status codes from IEEE P802.11be/D4.0
Benjamin Berg [Mon, 20 Nov 2023 23:51:24 +0000 (01:51 +0200)] 
EHT: Define status codes from IEEE P802.11be/D4.0

Add the new status code that had not yet been defined.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
20 months agoAP: Add support for testing ML link removal
Ilan Peer [Mon, 20 Nov 2023 23:51:23 +0000 (01:51 +0200)] 
AP: Add support for testing ML link removal

Add support for testing ML link removal to hostapd. While such support
should inherently be integrated with the underlining driver, simulate
the inclusion of the ML reconfiguration element in hostapd.

Signed-off-by: Ilan Peer <ilan.peer@intel.com>
Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
20 months agoAP MLD: Make BSS parameter change variable
Ilan Peer [Mon, 20 Nov 2023 23:51:22 +0000 (01:51 +0200)] 
AP MLD: Make BSS parameter change variable

As a preparation to support link removal, make the BSS parameter
change count variable.

Signed-off-by: Ilan Peer <ilan.peer@intel.com>
20 months agowpa_supplicant: Fix ml_ie_len type in wpa_bss_parse_basic_ml_element()
Andrei Otcheretianski [Mon, 20 Nov 2023 23:51:21 +0000 (01:51 +0200)] 
wpa_supplicant: Fix ml_ie_len type in wpa_bss_parse_basic_ml_element()

Since the Multi-Link element can be fragmented, use size_t instead of
u8.

Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
20 months agowpa_supplicant: Remove duplicate logic in wpas_ml_element()
Andrei Otcheretianski [Mon, 20 Nov 2023 23:51:20 +0000 (01:51 +0200)] 
wpa_supplicant: Remove duplicate logic in wpas_ml_element()

Parsing multiple RNR elements already exists in
wpa_bss_parse_basic_ml_element(), so wpas_ml_element() just duplicates
the same code. Combine the functionality of both these functions and
remove the duplicate.

Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
20 months agowpa_supplicant: Add config parameters for MLD testing
Andrei Otcheretianski [Mon, 20 Nov 2023 23:51:19 +0000 (01:51 +0200)] 
wpa_supplicant: Add config parameters for MLD testing

Add band preference, BSSID preference, and single link enforcement
testing options. This is needed for testing MLO.

Signed-off-by: Ilan Peer <ilan.peer@intel.com>
Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
20 months agodbus: Increase XML buffer size for an interface introspection data
Jouni Malinen [Sat, 25 Nov 2023 09:13:42 +0000 (11:13 +0200)] 
dbus: Increase XML buffer size for an interface introspection data

The current set of global configuration fields is getting close to the
previously used 15000 byte limit, so increase this size to 16000 and add
a note about the potential need to change this size when adding new
fields.

Signed-off-by: Jouni Malinen <j@w1.fi>
20 months agocommon: Simplify and avoid confusing defragmentation API
Benjamin Berg [Mon, 20 Nov 2023 23:51:18 +0000 (01:51 +0200)] 
common: Simplify and avoid confusing defragmentation API

Three functions were provided for defragmentation. First
ieee802_11_defrag(), ieee802_11_defrag_mle() and then
ieee802_11_defrag_data() which would do the actual job. With
ieee802_11_defrag() picking the member in the elements struct for an
EID. The problem with this is, that for the Multi-Link element, there
are multiple entries in the elems struct depending on its type. As such,
remove the intermediate function and simply pass the correct members
directly.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
20 months agoieee802_11_defs: Fix EHT_ML_PRES_BM_PROBE_REQ_AP_MLD_ID
Johannes Berg [Mon, 20 Nov 2023 23:51:17 +0000 (01:51 +0200)] 
ieee802_11_defs: Fix EHT_ML_PRES_BM_PROBE_REQ_AP_MLD_ID

This Presence Bitmap field is B4..B15 of the Multi-Link Control field
and the value used here is for that full 16-bit field, not just within
the Presence Bitmap field.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
20 months agoSME: Drop old disassoc_while_authenticating workaround
Benjamin Berg [Mon, 20 Nov 2023 23:51:16 +0000 (01:51 +0200)] 
SME: Drop old disassoc_while_authenticating workaround

This workaround from commit 6d6f4bb87f33 ("nl80211: Work around mac80211
limitation on (re)auth when authenticated") pre-dates the code that
supresses the deauth or disconnect event from nl80211. Should this code
be called it would not actually work at this point, as important
internal state for the authentication attempt has already been lost.

Simply drop the code. This might also fix issues where we could get
into a bad state if a proper deauth/disconnect event happens while we
are authenticating or associating.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
20 months agonl80211: Do a roundtrip to reset event supressions
Benjamin Berg [Mon, 20 Nov 2023 23:51:15 +0000 (01:51 +0200)] 
nl80211: Do a roundtrip to reset event supressions

With nl80211 we need to supress the kernel generated event for any
disconnect and deauthenticate. This code is a bit fragile, as it
assumes that an event will happen. Commit b898b655824a ("nl80211: Do
not ignore disconnect event in case of !drv->associated") changed this
to only disconnect when the driver knows it is associated (apparently
required for P2P), however, deauthentication may also occur without
being associated yet.

Looking at the issue, what we are really interested in is whether the
event belongs to a disconnect/deauth command that we have send
ourselves. Any event happening after the disconnect/deauth completes
should not be suppressed (or after the next connect/auth as that would
be sufficient). We therefore need to know from the event stream
whether events were generated before or after disconnect/deauth
command completion.

To do so, send a simple command on the nl_event socket. As this will
be returned back to us in the correct order with regard to the events.
We can therefore use it to safely reset our internal
ignore_next_local_{deauth,disconnect} variables.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
20 months agotests: Give some operations more time
Johannes Berg [Fri, 24 Nov 2023 20:25:18 +0000 (21:25 +0100)] 
tests: Give some operations more time

With more channels now available in some regulatory domains, some scan
operations can take longer. Give them more time to complete in tests.

For two cases this required adding a timeout parameter to connect(),
which is then passed through.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
20 months agotests: Set wpa_s->global for module tests
Jouni Malinen [Fri, 24 Nov 2023 18:59:37 +0000 (20:59 +0200)] 
tests: Set wpa_s->global for module tests

This is needed to avoid NULL pointer deferencing in
wpa_supplicant_ctrl_iface_msg_cb() if any of the functions called from
wpas_bssid_ignore_module_tests_() ends up using wpa_msg().

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agonl80211: Update port authorized indication for MLO address
Vinayak Yadawad [Mon, 20 Nov 2023 12:39:33 +0000 (18:09 +0530)] 
nl80211: Update port authorized indication for MLO address

Handling of port authorized event for STA currently handles the
connected BSSID. This needs additional handling to support the AP MLD
address in case of MLO connection. The connected_addr expected by
cfg80211_port_authorized() is mld_addr for ML connection case.

Signed-off-by: Vinayak Yadawad <vinayak.yadawad@broadcom.com>
20 months agoACS: Add 320 MHz support for EHT
Nicolas Escande [Mon, 13 Nov 2023 08:55:55 +0000 (09:55 +0100)] 
ACS: Add 320 MHz support for EHT

Enable support for ACS in the IEEE 802.11be/320 MHz case. To do so we
just:
  - add channel definitions for the 320 MHz blocks of the 6 GHz band
  - handle CONF_OPER_CHWIDTH_320MHZ in the different cases
  - restrict 320 MHz to ieee80211be=1 only

Signed-off-by: Nicolas Escande <nico.escande@gmail.com>
20 months agoEHT: Fix HE Channel Center Freq Seg0/Seg1 for 6 GHz 320 MHz cases
Jurijs Soloveckis [Wed, 15 Nov 2023 08:48:05 +0000 (08:48 +0000)] 
EHT: Fix HE Channel Center Freq Seg0/Seg1 for 6 GHz 320 MHz cases

Fix for the HE Channel Center Freq Seg0/Seg1 within the HE 6GHz
Operation Information field. As downgrade of bandwidths for VHT and HE
when using puncturing is TODO for 320 MHz and/or if puncturing is
disabled and bandwidth is 320 MHz, the same rules as for 160 MHz should
be applied for Channel Center Freq Seg0/Seg1 within 6 GHz Operation
Information field.

Signed-off-by: Jurijs Soloveckis <jsoloveckis@maxlinear.com>
20 months agoEHT: Fix conditions for including EHT Operation Information field
Jurijs Soloveckis [Tue, 14 Nov 2023 12:47:05 +0000 (12:47 +0000)] 
EHT: Fix conditions for including EHT Operation Information field

Include EHT Operation Information field only if the operating bandwidth
is 320 MHz or there is at least one punctured 20 MHz subchannel. This
behavior is defined in IEEE P802.11be/D4.0, 35.15.1 (Basic EHT BSS
operation).

Signed-off-by: Jurijs Soloveckis <jsoloveckis@maxlinear.com>
20 months agoSAE: prime_len means length in bytes not bits
Juliusz Sosinowicz [Fri, 24 Nov 2023 14:36:49 +0000 (15:36 +0100)] 
SAE: prime_len means length in bytes not bits

The prime_len variable is used as the length in bytes but it is set as
the length in bits. This fixes the sae DH group tests with wolfSSL.

Fixes: f8f20717f87e ("SAE: Use const_time selection for PWE in FFC")
Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
20 months agotests: MBSSID beacon protection
Jouni Malinen [Fri, 24 Nov 2023 10:55:18 +0000 (12:55 +0200)] 
tests: MBSSID beacon protection

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agoMBSSID: Use BIGTK from the transmitted BSS for beacon protection
Jouni Malinen [Fri, 24 Nov 2023 10:53:09 +0000 (12:53 +0200)] 
MBSSID: Use BIGTK from the transmitted BSS for beacon protection

MBSSID shares a single Beacon frame with multiple BSSs. This implies
that the key used for beacon protection (BIGTK) needs to be shared. The
nontransmitted BSSs managed their own BIGTK previously and that resulted
in providing incorrect value to the stations associated with those BSSs.
Use the BIGTK from the transmitted BSS to fix this.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agotests: MBSSID with a single SSID and different AKMs
Jouni Malinen [Thu, 23 Nov 2023 21:17:06 +0000 (23:17 +0200)] 
tests: MBSSID with a single SSID and different AKMs

Test functionality in cases where MBSSID is used with a WPA2-Personal
only BSS as the transmitted BSS and WPA3-Personal BSS as the
nontransmitted BSS.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agoPrefer SAE over PSK in WPA3-Personal transition mode cases
Jouni Malinen [Thu, 23 Nov 2023 21:13:51 +0000 (23:13 +0200)] 
Prefer SAE over PSK in WPA3-Personal transition mode cases

Order scan results in a manner that prefers BSSs that support SAE over
ones that support PSK without SAE if the SNR of the SAE BSS is good or
at least at the same level as the SNR for the PSK BSS. This improves
likelihood of using SAE when the local network profile allows
WPA3-Personal transition mode and the ESS uses a mix BSSs with different
sets of AKMs.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agotests: OWE transition mode disabled on STA and AP using transition mode
Jouni Malinen [Thu, 23 Nov 2023 18:43:04 +0000 (20:43 +0200)] 
tests: OWE transition mode disabled on STA and AP using transition mode

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agoOWE: Optimize transition mode AP scan with owe_only=1 STA configuration
Jouni Malinen [Thu, 23 Nov 2023 18:41:35 +0000 (20:41 +0200)] 
OWE: Optimize transition mode AP scan with owe_only=1 STA configuration

Extend the optimization from commit 9c97126576b7 ("OWE: Optimize
transition mode scan to use known channels") to cover cases where the
STA is configued with OWE transition mode disabled, but the AP uses OWE
transition mode.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agoP2P: Do not skip updating BSS table when frequency is changed
Ainy Kumari [Thu, 16 Nov 2023 02:47:10 +0000 (08:17 +0530)] 
P2P: Do not skip updating BSS table when frequency is changed

BSS table is not updated when a non-P2P station runs a scan without P2P
IE in Probe Response frame, since that would remove P2P IE information.
However, this results also in not updating mandatory rates in Supported
Rates and BSS Membership Selectors element even though AP/GO changes
frequency from 2.4 GHz to 5 GHz band.

This is causing connection failure since BSS table has 1 Mbps as
mandatory rate for AP connection but minimum supported rate in 5 GHz
band is 6 Mbps.

To avoid connection failures in such cases, don't skip updating BSS
table when the BSS frequency is changed. This covers the most important
case addressed in commit ff57398fcab8 ("P2P: Do not drop P2P IEs from
BSS table on non-P2P scans") while still allowing other changes to be
taken into account if the GO were to actually change channels (or band,
which would be the most likely case needing the update).

Signed-off-by: Ainy Kumari <quic_ainykuma@quicinc.com>
20 months agoFix references to correct driver capability flag for PSK/OWE offloads
Vinayak Yadawad [Wed, 22 Nov 2023 09:19:52 +0000 (14:49 +0530)] 
Fix references to correct driver capability flag for PSK/OWE offloads

Fix references to the appropriate driver capability drv_flags2. The
initial version used the incorrect drv_flags value and by doing so,
ended up using incorrect driver capabilities (DEAUTH_TX_STATUS,
BSS_SELECT, TDLS_SUPPORT) which could result in incorrect OWE
functionality for both AP and STA cases.

Fixes: d984c7b29801 ("hostapd: Add support for OWE offload for STA/AP interface")
Fixes: da364180fba6 ("hostapd: Support 4-way handshake offload for AP/P2P GO")
Signed-off-by: Vinayak Yadawad <vinayak.yadawad@broadcom.com>
20 months agotests: Disable IPv6 in WNM keep-alive test
Benjamin Berg [Tue, 21 Nov 2023 15:40:06 +0000 (17:40 +0200)] 
tests: Disable IPv6 in WNM keep-alive test

Otherwise the station or AP might be doing router advertisements,
causing keep alive already without the mechnism that is being tested.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
20 months agotests: Suite B 192-bit level RSA failing (no CS match)
Jouni Malinen [Wed, 22 Nov 2023 17:42:06 +0000 (19:42 +0200)] 
tests: Suite B 192-bit level RSA failing (no CS match)

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agoOpenSSL: Allow openssl_ciphers override with Suite B config on server
Jouni Malinen [Wed, 22 Nov 2023 17:39:45 +0000 (19:39 +0200)] 
OpenSSL: Allow openssl_ciphers override with Suite B config on server

The openssl_ciphers parameter is a global data entry on the server
instead of the per-connection design on client. As such, hostapd needs
to make a local copy of the global value and use that whenever setting
per-connection parameters. This is needed particularly when testing
Suite B functionality where the Suite B specific parameters might end up
overriding the cipher list.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agoAdd EHT mode support for ratemask configuration vendor command
Prasanna JS [Fri, 27 Oct 2023 07:38:21 +0000 (00:38 -0700)] 
Add EHT mode support for ratemask configuration vendor command

Extend enum qca_wlan_ratemask_params_type to configure ratemask for EHT
mode.

Signed-off-by: Prasanna JS <quic_pjs@quicinc.com>
20 months agoDefine new command in qca_tsf_cmd to get AP channel switch TSF time
Purushottam Kushwaha [Mon, 16 Oct 2023 10:21:08 +0000 (15:51 +0530)] 
Define new command in qca_tsf_cmd to get AP channel switch TSF time

Define a new command QCA_TSF_SYNC_GET_CSA_TIMESTAMP in qca_tsf_cmd to
retrieve the TSF time value at which the AP will move and starts
beaconing on a new channel. Userspace queries this TSF after receiving
NL80211_CMD_CH_SWITCH_STARTED_NOTIFY event on the AP interface. This TSF
can be communicated via an OOB mechanism to connected STAs which may
fail to receive the CSA frames due to channel congestion.

Signed-off-by: Purushottam Kushwaha <quic_pkushwah@quicinc.com>
20 months agoSAE: Require PMKID match to PMKSA with SAE-EXT-KEY
Jouni Malinen [Sat, 11 Nov 2023 21:44:52 +0000 (23:44 +0200)] 
SAE: Require PMKID match to PMKSA with SAE-EXT-KEY

This check was supposed to be done for all SAE cases other than FT
roaming.

Signed-off-by: Jouni Malinen <j@w1.fi>
20 months agotests: WNM Disassociation Imminent and bssid set
Jouni Malinen [Sat, 11 Nov 2023 21:22:48 +0000 (23:22 +0200)] 
tests: WNM Disassociation Imminent and bssid set

Signed-off-by: Jouni Malinen <j@w1.fi>
20 months agoWNM: Do not start scan on disassociation imminent if BSSID is set
Jouni Malinen [Sat, 11 Nov 2023 21:20:32 +0000 (23:20 +0200)] 
WNM: Do not start scan on disassociation imminent if BSSID is set

If the local network profile specifies a specific BSSID, there will not
be an acceptable alternative AP for the current one. As such, there is
not much point in trying to scan and wait for the results to make this
conclusion. Skip the scan and reject the BSS transition management
request even if that ends up getting disassociated from the BSS that
happens the be the only one that the local configuration allows to be
used.

Signed-off-by: Jouni Malinen <j@w1.fi>
20 months agohostapd: Add support for SAE offload for AP interface
Vinayak Yadawad [Fri, 10 Nov 2023 14:23:06 +0000 (19:53 +0530)] 
hostapd: Add support for SAE offload for AP interface

The driver advertising SAE AP offload support would take care of SAE
authentication and PMK generation at the driver/firmware. This feature
requires the driver to be supporting 4-way handshake offload to process
the generated PMK at the driver level for 4-way handshake.

Signed-off-by: Vinayak Yadawad <vinayak.yadawad@broadcom.com>
20 months agohostapd: Add support for OWE offload for STA/AP interface
Vinayak Yadawad [Thu, 9 Nov 2023 05:02:23 +0000 (10:32 +0530)] 
hostapd: Add support for OWE offload for STA/AP interface

The driver advertising OWE offload support would take care of
Diffie-Hellman Parameter element generation and processing part. The
driver would be responsible for OWE PMK generation in this case.

Avoid the Diffie-Hellman Parameter element handling in
wpa_supplicant/hostapd for drivers advertising OWE offload support. This
change is applicable only for drivers supporting 4-way handshake
offload.

Signed-off-by: Vinayak Yadawad <vinayak.yadawad@broadcom.com>
20 months agohostapd: Support 4-way handshake offload for AP/P2P GO
Vinayak Yadawad [Wed, 8 Nov 2023 12:56:09 +0000 (18:26 +0530)] 
hostapd: Support 4-way handshake offload for AP/P2P GO

Add support for offloaded 4-way handshake in AP/P2P GO mode. For drivers
supporting the AP PSK offload, wpa_supplicant/hostapd passes down the
PSK for the driver to handle the 4-way handshake. The driver is expected
to indicate port authorized event to indicate that the 4-way handshake
is completed successfully.

Signed-off-by: Vinayak Yadawad <vinayak.yadawad@broadcom.com>
20 months agoAdjust the RSSI and throughput estimate in roaming algorithm
Kaidong Wang [Wed, 8 Nov 2023 03:58:06 +0000 (03:58 +0000)] 
Adjust the RSSI and throughput estimate in roaming algorithm

The max transmit power of Standard Power (SP) Access Points (AP) on
6 GHz band and APs on 2.4 GHz and 5 GHz bands is limited by effective
isotropic radiated power (EIRP), while the max transmit power of Low
Power Indoor (LPI) APs on 6 GHz Band is limited by power spectral
density (PSD). Therefore the max transmit power of LPI APs grows as the
channel width increases, similar to the noise power which has constant
PSD.

Adjust the RSSI, SNR and throughput estimate based on max transmit power
config and max channel width in the roaming algorithm.

Signed-off-by: Kaidong Wang <kaidong@chromium.org>
20 months agoAdjust the SNR when comparing BSSes based on Tx power config
Kaidong Wang [Wed, 8 Nov 2023 03:58:05 +0000 (03:58 +0000)] 
Adjust the SNR when comparing BSSes based on Tx power config

The max transmit power of Standard Power (SP) Access Points (AP) on
6 GHz band and APs on 2.4 GHz and 5 GHz bands is limited by effective
isotropic radiated power (EIRP), while the max transmit power of Low
Power Indoor (LPI) APs on 6 GHz Band is limited by power spectral
density (PSD). Therefore the max transmit power of LPI APs grows as the
channel width increases, similar to the noise power which has constant
PSD.

Adjust the SNR of BSSes based on the transmit power config and max
channel width. EIRP limited APs usually have constant max transmit power
on different channel widths, their SNR decreases on larger channel width
because the noise power is higher, while PSD limited APs have constant
SNR over all channel widths.

Signed-off-by: Kaidong Wang <kaidong@chromium.org>
20 months agotests: OWE and BSS entries after multiple scans/associations
Jouni Malinen [Wed, 8 Nov 2023 11:31:19 +0000 (13:31 +0200)] 
tests: OWE and BSS entries after multiple scans/associations

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agoOWE: Remove now unnecessary attempt to update transition mode BSS
Jouni Malinen [Wed, 8 Nov 2023 11:38:38 +0000 (13:38 +0200)] 
OWE: Remove now unnecessary attempt to update transition mode BSS

With the SSID updating of a BSS entry removed from owe_trans_ssid(),
this call to owe_trans_ssid() is not really doing anything, so remove
it. This reverts 6972b0fa2bb8 ("OWE: Update transition mode information
on selecting a new BSS").

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agoOWE: Do not update the BSS entry with zero length SSID for transition
Andrzej Ostruszka [Tue, 7 Nov 2023 12:30:57 +0000 (13:30 +0100)] 
OWE: Do not update the BSS entry with zero length SSID for transition

Overwriting of SSID for the hidden OWE BSS entry has some side effects:
- first the entry is notified over DBus with empty SSID and the update
  of SSID is never signaled (it is not even possible at the moment to
  notify the SSID change - see wpas_dbus_bss_signal_prop_changed()),
- during (and after) association there will be multiple entries
  referring to the same BSSID/SSID pair.

Stop overwriting the SSID in an existing BSS entry based on OWE
transition mode information. Instead, depend on a new BSS entry getting
added for the hidden OWE BSS based on active scans for the SSID learned
from the open BSS. This would not have been sufficient for the initial
OWE design, but with the optimized scanning behavior from commit
c04562e67edd ("OWE: Improve discovery of OWE transition mode AP"), this
can now depend on the exact same mechanism as other uses of hidden
SSIDs. This helps in keeping the D-Bus interface in sync with the BSS
parameters.

Signed-off-by: Andrzej Ostruszka <andrzejo@chromium.org>
20 months agoOWE: Optimize transition mode scan to use known channels
Jouni Malinen [Wed, 8 Nov 2023 12:19:03 +0000 (14:19 +0200)] 
OWE: Optimize transition mode scan to use known channels

If the currently available scan results include OWE transition mode BSS
with an unknown SSID, optimize the following scan for OWE to use only
the channels on which a known transition mode BSS has been seen.

This is needed to be able to remove the design that updates BSS entries
with the learned OWE SSID in manner that does not result in regression
to scanning latencies.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agoUse SSID from driver when finding the current BSS entry
Jouni Malinen [Wed, 8 Nov 2023 09:56:03 +0000 (11:56 +0200)] 
Use SSID from driver when finding the current BSS entry

The local network profile may not have matching SSID (it could be either
the wildcard 0-length SSID or visible SSID in case of OWE transition
mode), so check whether an exact match with a BSS entry can be made
using the current SSID information from the driver (i.e., the SSID of
the current association) when picking the BSS entry to use as the
current one for an association.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agoMLD: Use BSS Parameters in TBTT Info to check SSID match
Ben Greear [Sat, 28 Oct 2023 23:24:35 +0000 (16:24 -0700)] 
MLD: Use BSS Parameters in TBTT Info to check SSID match

Use the Same SSID and Colocated AP bits as an alternative way of finding
a match on the current SSID.

Signed-off-by: Ben Greear <greearb@candelatech.com>
20 months agoMLD: Support multiple TBTT Information fields in RNR elements
Ben Greear [Sat, 28 Oct 2023 23:24:35 +0000 (16:24 -0700)] 
MLD: Support multiple TBTT Information fields in RNR elements

The Reduced Neighbor Report element can include one or more TBTT
Information fields.  Only the first one was parsed previously. Extend
this to use a loop to go through all included TBTT Information fields.

Signed-off-by: Ben Greear <greearb@candelatech.com>
20 months agoMLD: Move TBTT Information field parsing into a helper function
Jouni Malinen [Tue, 7 Nov 2023 17:06:16 +0000 (19:06 +0200)] 
MLD: Move TBTT Information field parsing into a helper function

This makes it more convenient to process multiple TBTT Information
fields within an RNR element.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
20 months agoMLD: Support multiple RNR elements
Ben Greear [Sat, 28 Oct 2023 23:24:35 +0000 (16:24 -0700)] 
MLD: Support multiple RNR elements

Beacon frames are allowed to optionally include one more more Reduced
Neighbor Report elements. Only the first one was parsed previously.
Extend this to use a loop to go through all included RNR elements.

Signed-off-by: Ben Greear <greearb@candelatech.com>
20 months agoMLD: Move RNR element parsing into a helper function
Jouni Malinen [Tue, 7 Nov 2023 16:43:40 +0000 (18:43 +0200)] 
MLD: Move RNR element parsing into a helper function

This makes it more convenient to process multiple elements.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
21 months agoMBSSID: Use DTIM Count 0 in the Beacon template for nontransmitted BSSID
Jouni Malinen [Tue, 7 Nov 2023 08:44:28 +0000 (10:44 +0200)] 
MBSSID: Use DTIM Count 0 in the Beacon template for nontransmitted BSSID

The driver is expected to update the DTIM Count field for each BSS that
corresponds to a nontransmitted BSSID. Initialized this value to 0 in
the Beacon frame template so that the DTIM count would be somewhat
functional even if the driver were not to update this.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
21 months agodragonfly: Fix legendre symbol calculation failure handling
Chaitanya Tata [Mon, 6 Nov 2023 17:19:15 +0000 (22:49 +0530)] 
dragonfly: Fix legendre symbol calculation failure handling

In case of low-memory conditions, the computation for legendre symbol
can fail and return -2 as per documentation, but the check for that
was missed here. And this can can cause an infinite loop searching for
qr and qnr if the error repeats for each attempt.

Break the loop if calculation fails, we can leave retry to the callers
or user. This is similar to the way allocation and generation of a new
random number was handled in this loop.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
21 months agoRemove QCA_WLAN_VENDOR_ATTR_CONFIG_MLO_LINK_ID constraint
Mohan Prabu [Fri, 3 Nov 2023 01:18:33 +0000 (06:48 +0530)] 
Remove QCA_WLAN_VENDOR_ATTR_CONFIG_MLO_LINK_ID constraint

Currently the documentation for QCA_WLAN_VENDOR_ATTR_CONFIG_MLO_LINK_ID
indicates it is only for use inside nest attribute
QCA_WLAN_VENDOR_ATTR_CONFIG_MLO_LINKS.  Update the documentation to
allow it to be used outside that nest as well.

Signed-off-by: Mohan Prabu <quic_mprabub@quicinc.com>
21 months agoMLD STA: Use MLD MAC address as destination for EAPOL-Key request
Jouni Malinen [Mon, 6 Nov 2023 18:01:14 +0000 (20:01 +0200)] 
MLD STA: Use MLD MAC address as destination for EAPOL-Key request

Also this EAPOL frame uses the MLD MAC address of the AP MLD when sent
during an MLO association.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
21 months agoMLD STA: Fix destination address for Group Key handshake msg 2/2
Rohan Dutta [Tue, 10 Oct 2023 05:12:00 +0000 (10:42 +0530)] 
MLD STA: Fix destination address for Group Key handshake msg 2/2

For MLO association, specify destination address as the MLD MAC address
for sending Group Key msg 2/2.

Signed-off-by: Rohan Dutta <quic_drohan@quicinc.com>
21 months agotests: AP MLD and GTK rekeying with MLD client connection using two links
Jouni Malinen [Mon, 6 Nov 2023 17:56:41 +0000 (19:56 +0200)] 
tests: AP MLD and GTK rekeying with MLD client connection using two links

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
21 months agowpa_cli/hostapd_cli: Add driver_flags2 command
Gokul Sivakumar [Wed, 26 Apr 2023 10:45:56 +0000 (16:15 +0530)] 
wpa_cli/hostapd_cli: Add driver_flags2 command

Leverage the already available control socket cmd "DRIVER_FLAGS2" and
dump the driver capab "flags2" bitmask on triggering the new CLI CMD
"driver_flags2", similar to the already existing CLI CMD "driver_flags".

$ hostapd_cli -i wlan0 driver_flags2
(OR)
$ wpa_cli -i wlan0 driver_flags2
0000000000000020:
BEACON_RATE_HE

Signed-off-by: Gokul Sivakumar <gokulkumar.sivakumar@infineon.com>
21 months agonl80211: Add capa.flags2 to STATUS-DRIVER
Gokul Sivakumar [Wed, 26 Apr 2023 10:45:56 +0000 (16:15 +0530)] 
nl80211: Add capa.flags2 to STATUS-DRIVER

This adds the newer driver capability "flags2" bitmask to the
hostapd_cli/wpa_cli "status driver" result.

Signed-off-by: Gokul Sivakumar <gokulkumar.sivakumar@infineon.com>
21 months agonl80211: Dump driver_flags2 in debug prints
Gokul Sivakumar [Wed, 26 Apr 2023 10:45:56 +0000 (16:15 +0530)] 
nl80211: Dump driver_flags2 in debug prints

This was already done for driver_flags, but the newer driver_flags2 was
not covered here.

Signed-off-by: Gokul Sivakumar <gokulkumar.sivakumar@infineon.com>
21 months agoUpdate the driver_flags2 to string conversion
Gokul Sivakumar [Wed, 26 Apr 2023 10:45:56 +0000 (16:15 +0530)] 
Update the driver_flags2 to string conversion

Populate the switch case in the driver_flag2_to_string() function with
the full list of feature MACROs represented with the "flags2" bitmask.

Signed-off-by: Gokul Sivakumar <gokulkumar.sivakumar@infineon.com>
21 months agoRename driver capability for radar background detection
Gokul Sivakumar [Wed, 26 Apr 2023 10:45:56 +0000 (16:15 +0530)] 
Rename driver capability for radar background detection

Use the WPA_DRIVER_FLAGS2_ prefer for this to be more consistent.

Signed-off-by: Gokul Sivakumar <gokulkumar.sivakumar@infineon.com>
21 months agoFix use after free warning introduced by gcc 12.1
krishna T [Thu, 20 Apr 2023 19:28:21 +0000 (00:58 +0530)] 
Fix use after free warning introduced by gcc 12.1

gcc 12.1 complains about using pointer after realloc as it could
potentially be moved/freed, causing any uses after UB.

Fix this by doing checks before realloc and use those statuses and
update with new BSS.

Signed-off-by: Krishna T <krishna.t@nordicsemi.no>
21 months agoSAE: Pass SAE password on connect for SAE authentication offload support
Chung-Hsien Hsu [Wed, 19 Jul 2023 05:22:27 +0000 (14:22 +0900)] 
SAE: Pass SAE password on connect for SAE authentication offload support

Pass SAE password on connect if driver advertises SAE authentication
offload support.

Signed-off-by: Chung-Hsien Hsu <chung-hsien.hsu@infineon.com>
Signed-off-by: Daisuke Mizobuchi <mizo@atmark-techno.com>
21 months agonl80211: Set NL80211_WPA_VERSION_2 vs. _3 based on AKM
Chung-Hsien Hsu [Wed, 19 Jul 2023 05:22:27 +0000 (14:22 +0900)] 
nl80211: Set NL80211_WPA_VERSION_2 vs. _3 based on AKM

Signed-off-by: Chung-Hsien Hsu <chung-hsien.hsu@infineon.com>
Signed-off-by: Daisuke Mizobuchi <mizo@atmark-techno.com>
21 months agonl80211: SAE authentication offload support
Chung-Hsien Hsu [Wed, 19 Jul 2023 05:22:26 +0000 (14:22 +0900)] 
nl80211: SAE authentication offload support

Set WPA_DRIVER_FLAGS2_SAE_OFFLOAD flag if the driver indicates SAE
authentication offload support for STA mode. Allow SAE password to be
provided to the driver in such cases when using the CONNECT command.

Signed-off-by: Chung-Hsien Hsu <chung-hsien.hsu@infineon.com>
Signed-off-by: Daisuke Mizobuchi <mizo@atmark-techno.com>
21 months agomka: Fix re-establishment by resetting MI
Ze Gan [Sun, 23 Apr 2023 16:50:09 +0000 (00:50 +0800)] 
mka: Fix re-establishment by resetting MI

The key server may be removed due to the ingress packets delay. In this
situation, the endpoint of the key server may not be aware of this
participant who has removed the key server from the peer list. Because
the egress traffic is normal, the key server will not remove this
participant from the peer list of the key server. So in the next MKA
message, the key server will not dispatch a new SAK to this participant.
And this participant cannot be aware of that that is a new round of
communication so that it will not update its MI at re-adding the key
server to its peer list. So we need to update MI to avoid the failure of
re-establishment MKA session.

Signed-off-by: Ze Gan <ganze718@gmail.com>
21 months agomka: Fix unexpected cleanup on missing MKA_LIFE_TIME while installing SC/SA
Ze Gan [Sun, 23 Apr 2023 16:50:46 +0000 (00:50 +0800)] 
mka: Fix unexpected cleanup on missing MKA_LIFE_TIME while installing SC/SA

The key server may not include dist sak and use sak in one packet.
Meanwhile, after dist sak, the current participant (non-key server) will
install SC or SA(s) after decoding the dist sak which may take few
seconds in real physical platforms. Meanwhile, the peer expire time is
always initialized at adding the key server to peer list. The gap
between adding the key server to peer list and processing next use sak
packet may exceed the threshold of MKA_LIFE_TIME (6 s). It will cause an
unexpected cleanup (delete SC and SA(s)), so update the expire timeout
at dist sak also.

Signed-off-by: Ze Gan <ganze718@gmail.com>
21 months agoCompile-time config for dynamically loading libraries in wpa_supplicant
David Ruth [Tue, 4 Apr 2023 23:35:35 +0000 (23:35 +0000)] 
Compile-time config for dynamically loading libraries in wpa_supplicant

Prevent loading arbitrary executable code based on config at runtime,
while allowing libraries to be specified at compile time when they are
known in advance.

Add the ability to configure libraries to load at compile time.
* CONFIG_PKCS11_ENGINE_PATH - pkcs11_engine library location.
* CONFIG_PKCS11_MODULE_PATH - pkcs11_module library location.
* CONFIG_OPENSC_ENGINE_PATH - opensc_engine library location.

Add flags with the ability to set each of the libraries to NULL and
prevent loading them at runtime.
* CONFIG_NO_PKCS11_ENGINE_PATH - prevents loading pkcs11_engine
  library.
* CONFIG_NO_PKCS11_MODULE_PATH - prevents loading pkcs11_module
  library.
* CONFIG_NO_OPENSC_ENGINE_PATH - prevents loading opensc_engine
  library.
* CONFIG_NO_LOAD_DYNAMIC_EAP - prevents loading EAP libraries at
  runtime.

Signed-off-by: David Ruth <druth@chromium.org>
21 months agowolfSSL: Old FIPS APIs have void return
Juliusz Sosinowicz [Thu, 23 Mar 2023 15:58:50 +0000 (16:58 +0100)] 
wolfSSL: Old FIPS APIs have void return

Fix the calls to wc_AesEncryptDirect(). Old versions of wolfCrypt FIPS
had wc_AesEncryptDirect() return void instead of int. Fix this build
issue.

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Implement DPP backend functions
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:49 +0000 (18:18 +0100)] 
wolfSSL: Implement DPP backend functions

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Set up generator manually in FIPS build
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:50 +0000 (18:18 +0100)] 
wolfSSL: Set up generator manually in FIPS build

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Get EC generator for DPP
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:49 +0000 (18:18 +0100)] 
wolfSSL: Get EC generator for DPP

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Add crypto_ecdh_init2()
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:48 +0000 (18:18 +0100)] 
wolfSSL: Add crypto_ecdh_init2()

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Refactor crypto ECC section
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:48 +0000 (18:18 +0100)] 
wolfSSL: Refactor crypto ECC section

Use heap allocated objects and improve error checking.

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Use wc_ecc_get_curve_size_from_id()
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:48 +0000 (18:18 +0100)] 
wolfSSL: Use wc_ecc_get_curve_size_from_id()

Avoid use of direct member access.

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Use wc_ecc_forcezero_point() in non-FIPS builds
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:48 +0000 (18:18 +0100)] 
wolfSSL: Use wc_ecc_forcezero_point() in non-FIPS builds

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: More complete crypto_ec_key_group()
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:48 +0000 (18:18 +0100)] 
wolfSSL: More complete crypto_ec_key_group()

Add more curves and check if brainpool support is built.

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: EC group-to-id conversion into a helper function
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:48 +0000 (18:18 +0100)] 
wolfSSL: EC group-to-id conversion into a helper function

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Improve logging
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:48 +0000 (18:18 +0100)] 
wolfSSL: Improve logging

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Improve error checking and logging in AES functions
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:47 +0000 (18:18 +0100)] 
wolfSSL: Improve error checking and logging in AES functions

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Better error message in pbkdf2_sha1() for FIPS password failure
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:46 +0000 (18:18 +0100)] 
wolfSSL: Better error message in pbkdf2_sha1() for FIPS password failure

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Always clean up resources and log errors in wolfssl_hmac_vector()
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:45 +0000 (18:18 +0100)] 
wolfSSL: Always clean up resources and log errors in wolfssl_hmac_vector()

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Improve error checking in vector hashing functions
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:44 +0000 (18:18 +0100)] 
wolfSSL: Improve error checking in vector hashing functions

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Add crypto logging macros
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:43 +0000 (18:18 +0100)] 
wolfSSL: Add crypto logging macros

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Add FIPS warning
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:42 +0000 (18:18 +0100)] 
wolfSSL: Add FIPS warning

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Put wolfSSL headers in alphabetical order
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:41 +0000 (18:18 +0100)] 
wolfSSL: Put wolfSSL headers in alphabetical order

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Add more precise logging in wolfssl_handshake()
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:40 +0000 (18:18 +0100)] 
wolfSSL: Add more precise logging in wolfssl_handshake()

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agowolfSSL: Debug print ciphersuites
Juliusz Sosinowicz [Wed, 8 Mar 2023 17:18:39 +0000 (18:18 +0100)] 
wolfSSL: Debug print ciphersuites

Signed-off-by: Juliusz Sosinowicz <juliusz@wolfssl.com>
21 months agotests: Fix DPP test case skipping without CONFIG_DPP
Jouni Malinen [Sat, 4 Nov 2023 16:14:41 +0000 (18:14 +0200)] 
tests: Fix DPP test case skipping without CONFIG_DPP

dpp_config_legacy_gen_two_conf_psk and dpp_config_legacy_gen_two_conf
tried to set a DPP parameter before having verified that CONFIG_DPP was
used in the build.

Signed-off-by: Jouni Malinen <j@w1.fi>
21 months agoEHT: Include crypto.h to avoid implicit function definition
Jouni Malinen [Sat, 4 Nov 2023 13:05:15 +0000 (15:05 +0200)] 
EHT: Include crypto.h to avoid implicit function definition

crypto_ec_*() were not defined in some build configuration cases.

Signed-off-by: Jouni Malinen <j@w1.fi>
21 months agotests: Wait before initiating DPP from thread in sigma_dut testing
Jouni Malinen [Sat, 4 Nov 2023 10:41:02 +0000 (12:41 +0200)] 
tests: Wait before initiating DPP from thread in sigma_dut testing

Starting a thread to initiate DPP before starting the responder through
sigma_dut can result in unexpected testing behavior since there may not
be enough time to get the responder enabled before timing out som
initiator actions. Wait a second at the beginning of the initiator
thread in dpp_init_conf() similarly to how this was handled in other
initiator-from-thread cases.

Signed-off-by: Jouni Malinen <j@w1.fi>
21 months agotests: Terminate sigma_dut more forcefully if needed
Jouni Malinen [Sat, 4 Nov 2023 10:31:23 +0000 (12:31 +0200)] 
tests: Terminate sigma_dut more forcefully if needed

Wait for stdout/stderr in a more robust manner to avoid blocking the
pipes and kill the sigma_dut process if it fails to terminate cleanly.

Signed-off-by: Jouni Malinen <j@w1.fi>
21 months agoDPP: Handle wpas_dpp_connected() processing in eloop callback
Jouni Malinen [Sat, 4 Nov 2023 09:58:14 +0000 (11:58 +0200)] 
DPP: Handle wpas_dpp_connected() processing in eloop callback

wpas_dpp_connected() is called from wpa_supplicant_set_state(), i.e.,
from the middle of processing of the post 4-way handshake steps. Sending
a DPP Public Action frame at that point can delay other operations, so
allow those steps to be completed first before sending out the DPP
connection status result.

Signed-off-by: Jouni Malinen <j@w1.fi>
21 months agotests: Avoid race condition in DPP GAS protocol testing
Jouni Malinen [Sat, 4 Nov 2023 09:33:15 +0000 (11:33 +0200)] 
tests: Avoid race condition in DPP GAS protocol testing

Responder receives Authentication Request and Config Request in a
sequence and it is possible for the Config Request to be received before
MGMT_RX_PROCESS has been processed for Authentication Request in the
cases where the test script is in the middle of RX processing. This can
result in DPP-AUTH-SUCCESS being delivered only after the MGMT-RX event
for Config Reques which means that wait_auth_success() would lose that
MGMT-RX event.

Avoid this issue by caching the "extra" MGMT-RX event within
wait_auth_success() and having the caller verify if the Config Request
(GAS Initial Request) has already been received before waiting to
receive it.

This makes dpp_gas, dpp_gas_comeback_after_failure, and
dpp_gas_timeout_handling more robust.

Signed-off-by: Jouni Malinen <j@w1.fi>
21 months agoDPP: Start next auth init from driver event to avoid race condition
Jouni Malinen [Sat, 4 Nov 2023 09:11:46 +0000 (11:11 +0200)] 
DPP: Start next auth init from driver event to avoid race condition

It looks like mac80211 ROC handling can end up postponing offchannel TX
operation by the previously started and already canceled wait time if
the new NL80211_CMD_FRAME is issued immediately after
NL80211_CMD_FRAME_WAIT_CANCEL. Make this more robust by waiting for the
driver event that indicates completion of the cancel operation (i.e.,
NL80211_CMD_FRAME_WAIT_CANCEL as an event) before issuing
NL80211_CMD_FRAME for another channel. If the driver event is not
received within 10 ms, start the operation anyway to avoid unexpected
behavior if there are drivers that do not end up notifying end of the
wait.

This fixes some issues with authentication initiation for cases where
multiple channels are iterated. This can also significantly speed up
that process.

Signed-off-by: Jouni Malinen <j@w1.fi>
21 months agotests: Handle race condition in eap_proto_md5_server
Jouni Malinen [Sat, 4 Nov 2023 07:53:58 +0000 (09:53 +0200)] 
tests: Handle race condition in eap_proto_md5_server

UML time travel allows the deauthentication event to be processed more
quickly than the delivery of EAP-Success to the client through the test
script, so accept either sequence here.

Signed-off-by: Jouni Malinen <j@w1.fi>
21 months agotests: Do not dump pending monitor events after connection
Jouni Malinen [Fri, 3 Nov 2023 20:59:33 +0000 (22:59 +0200)] 
tests: Do not dump pending monitor events after connection

connect_network() tried to make test log more readable with a
dump_monitor() call at the end of the function. However, this could end
up practically dropping an event that arrives more or less immediately
after CTRL-EVENT-CONNECTED. This could happen with UML time travel,
e.g., in suite_b_192_pmksa_caching_roam.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>
21 months agotests: ap_hs20_remediation_required_ctrl with UML time travel
Jouni Malinen [Fri, 3 Nov 2023 20:28:22 +0000 (22:28 +0200)] 
tests: ap_hs20_remediation_required_ctrl with UML time travel

Wait for hostapd connection event before issue HS20_WNM_NOTIF to avoid a
race condition with UML time travel.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>