]>
git.ipfire.org Git - thirdparty/asterisk.git/log
Richard Mudgett [Mon, 16 May 2011 20:33:37 +0000 (20:33 +0000)]
Deadlock between generic CCSS agent and native ISDN CCSS.
Deadlock can occur when the generic CCSS agent is deleting duplicate CC
offers and the native ISDN CC driver is processing an incoming CC message.
The cc_core_instances container lock cannot be held when an agent or
monitor callback is invoked without the possibility of a deadlock.
* Make kill_duplicate_offers() remove the reference in cc_core_instances
outside of the container lock.
JIRA AST-566
JIRA SWP-3469
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@319259
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Mon, 16 May 2011 18:17:43 +0000 (18:17 +0000)]
Merged revisions 319202 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r319202 | twilson | 2011-05-16 11:00:21 -0700 (Mon, 16 May 2011) | 4 lines
Unlink a peer from peers_by_ip when expiring a registration
Review: https://reviewboard.asterisk.org/r/1218/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@319204
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 16 May 2011 15:57:26 +0000 (15:57 +0000)]
Merged revisions 319144 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r319144 | dvossel | 2011-05-16 10:56:16 -0500 (Mon, 16 May 2011) | 2 lines
Fixes issue with peer ref-counting during handle_request_subscribe.
(closes issue #19293)
Reported by: irroot
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@319145
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Mon, 16 May 2011 15:53:26 +0000 (15:53 +0000)]
Make sure tcptls_session exists before dereferencing it.
(closes issue #19192)
Reported by: stknob
Patches:
10-tcptls-unreachable-peer-segfault.patch uploaded by Chainsaw (license 723)
Tested by: vois, Chainsaw
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@319142
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Mon, 16 May 2011 14:35:21 +0000 (14:35 +0000)]
Support gmime-2.4
(closes issue #18863)
Reported by: tzafrir
Patches:
gmime-2.4-18.diff uploaded by tzafrir (license 46)
Tested by: tzafrir
Review: https://reviewboard.asterisk.org/r/1213/
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@319085
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 16 May 2011 14:26:33 +0000 (14:26 +0000)]
Fixes Big Endian build issue.
(closes issue #19298)
Reported by: tzafrir
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@319083
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Fri, 13 May 2011 18:09:34 +0000 (18:09 +0000)]
Fixes a segmentation fault in dynamic hints when a channel technology isn't
loaded for a hint.
(closes issue #18495)
Reported by: bertrand
Tested by: bertrand
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318921
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Fri, 13 May 2011 18:04:50 +0000 (18:04 +0000)]
This patch fixes an issue with SRTP which makes HOLD/UNHOLD impossible when too
much time has passed between sending audio.
(closes issue #18206)
Reported by: bernhardsi
Patches:
res_srtp_unhold.patch uploaded by bernhards (license 1138)
Tested by: bernhards, notthematrix
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318919
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Fri, 13 May 2011 17:56:04 +0000 (17:56 +0000)]
This patch allows TCP peers into the ast_db where they were previously
restricted.
(closes issue #18882)
Reported by: cmaj
Patches:
patch-chan_sip-1.8.3-rc2-allow-tcp-peer-store-db-and-readonly-rt-backend.diff.txt
uploaded by cmaj (license 830)
Tested by: cmaj
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318917
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 13 May 2011 16:28:26 +0000 (16:28 +0000)]
CDR's are being written immediately on caller hangup.
CDR's are being written immediately on caller hangup. The dialplan is not
able to modify it in the h exten. The h exten in the initial context is
not run before closing CDR's when the bridge is unlinked if a macro is
active and does not have an h exten.
* Make ast_bridge_call() check for an h exten in the current context and
if a macro is active then the initial context. The first h exten found is
then run before closing the CDR.
(closes issue #18212)
Reported by: leearcher
Patches:
issue18212_v1.8.patch uploaded by rmudgett (license 664)
Tested by: rmudgett
Review: https://reviewboard.asterisk.org/r/1206/
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318868
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 13 May 2011 01:47:05 +0000 (01:47 +0000)]
PRI early media won't ring.
And another way to pass early media. Don't indicate that there is inband
information present, just assume that the B channel is connected.
* Restore clearing the dialing flag Rx squelch unconditionally when a
PROCEEDING message comes in.
(closes issue #19268)
Reported by: tbsky
Patches:
issue19268_v1.8.patch uploaded by rmudgett (license 664)
Tested by: tbsky
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318783
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Thu, 12 May 2011 23:35:51 +0000 (23:35 +0000)]
Handle ipv6 addresses in the sent-by Via: field.
This change fixes a regression in via header parsing and ipv6 handling.
(closes issue #18951)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318720
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Alec L Davis [Thu, 12 May 2011 22:52:08 +0000 (22:52 +0000)]
Fix directed group pickup feature code *8 with pickupsounds enabled
Since 1.6.2, the new pickupsound and pickupfailsound in features.conf cause many issues.
1). chan_sip:handle_request_invite() shouldn't be playing out the fail/success audio, as it has 'netlock' locked.
2). dialplan applications for directed_pickups shouldn't beep.
3). feature code for directed pickup should beep on success/failure if configured.
Created a sip_pickup() thread to handle the pickup and playout the audio, spawned from handle_request_invite.
Moved app_directed:pickup_do() to features:ast_do_pickup().
Functions below, all now use the new ast_do_pickup()
app_directed_pickup.c:
pickup_by_channel()
pickup_by_exten()
pickup_by_mark()
pickup_by_part()
features.c:
ast_pickup_call()
(closes issue #18654)
Reported by: Docent
Patches:
ast_do_pickup_1.8_trunk.diff.txt uploaded by alecdavis (license 585)
Tested by: lmadsen, francesco_r, amilcar, isis242, alecdavis, irroot, rymkus, loloski, rmudgett
Review: https://reviewboard.asterisk.org/r/1185/
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318671
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Wed, 11 May 2011 18:47:33 +0000 (18:47 +0000)]
Comment out the REF_DEBUG that slipped in during debugging
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318550
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Wed, 11 May 2011 18:39:48 +0000 (18:39 +0000)]
Merged revisions 318548 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r318548 | twilson | 2011-05-11 12:15:39 -0500 (Wed, 11 May 2011) | 19 lines
Clean up several chan_sip reference leaks
Several situations in the code could lead to peers or sip_pvt references
being leaked. This would cause RTP ports to never be destroyed (leading
to exhaustion of all available RTP ports) and memory leaks.
The original patch for this issue from rgagnon was the result of an
obscene amount of testing and hard work, for which I am very grateful. I
did some cleanup and added a few additional refcount fixes that I found.
(closes issue #17255)
Reported by: kvveltho
Patches:
tag-1.6.2.17-r309252-sip-dos-mem-leak-fix.diff uploaded by rgagnon (license 1202)
Tested by: rgagnon, twilson, wdoekes, loloski
Review: https://reviewboard.asterisk.org/r/1101/
Review: https://reviewboard.asterisk.org/r/1207/
Review: https://reviewboard.asterisk.org/r/1210/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318549
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 10 May 2011 23:41:08 +0000 (23:41 +0000)]
Unable to pickup DAHDI/PRI call because call state is reported as DIALING.
The channel state is not updated to RINGING when an ALERTING message is
received. Regression caused when sig_pri.c (also sig_ss7.c) extracted
from chan_dahdi.c.
* Added missing channel state update to RINGING when the
AST_CONTROL_RINGING frame is queued for ISDN and SS7.
(closes issue #19257)
Reported by: alecdavis
Patches:
issue19257_v1.8_v2.patch uploaded by rmudgett (license 664)
Tested by: alecdavis, rmudgett
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318499
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Tue, 10 May 2011 18:46:25 +0000 (18:46 +0000)]
Filter out blacklisted manager events when using eventfilter.
Merging change from trunk in revision 306432.
(closes issue #19260)
Reported by: dhubbard
Tested by: dhubbard
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318485
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 10 May 2011 15:13:16 +0000 (15:13 +0000)]
chan_iax2: change LOG_NOTICE to LOG_DEBUG in iax2_read().
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318436
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 9 May 2011 23:15:32 +0000 (23:15 +0000)]
Remove references to res_features and its export file.
The contents of res/res_features.c was moved to into main/features.c
awhile ago. There is no longer any need for the res/Makefile to reference
res_features or the res_features linker exports file to exist.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318351
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Mon, 9 May 2011 20:23:15 +0000 (20:23 +0000)]
Merged revisions 318331 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r318331 | twilson | 2011-05-09 15:04:41 -0500 (Mon, 09 May 2011) | 12 lines
Don't offer video to directmedia callee unless caller offered it as well
Make sure that when directmedia is enabled, that video is not offered to the
callee even if it supports it. p->vrtp will not exist since the caller didn't
offer video.
(closes issue #19195)
Reported by: one47
Patches:
sip_cant_add_video_rtp uploaded by one47 (license 23)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318337
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 9 May 2011 19:07:01 +0000 (19:07 +0000)]
Hangup extension executed twice.
When a user hangs up a call, in certain circumstances, the hangup
extension can end up being executed twice:
1) If a call is bridged and the 'h' extension executes the Hangup
application, then the 'h' extension will be executed twice.
2) If a call is bridged within a macro (Dial or Queue), it has its own 'h'
extension, the main context also has an 'h' extension, and the macro 'h'
extension executes the Hangup application, then both 'h' extensions will
be executed.
* Revert originally commited fix for #16106 and just set
AST_FLAG_BRIDGE_HANGUP_RUN unconditionally in ast_bridge_call(). The
bridge code just executed an 'h' extension so the main PBX loop does not
need to execute one as well.
(issue #16106)
Reported by: ajohnson
(issue #16548)
Reported by: hajekd
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318282
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 9 May 2011 17:09:55 +0000 (17:09 +0000)]
Merged revisions 318230 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r318230 | dvossel | 2011-05-09 11:51:45 -0500 (Mon, 09 May 2011) | 7 lines
Fixes cases where sip_set_rtp_peer can return too early during media path reset.
(closes issue #19225)
Reported by: one47
Patches:
sip_set_rtp_peer.patch uploaded by one47 (license 23)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318233
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 9 May 2011 16:57:18 +0000 (16:57 +0000)]
Don't get early media for ISDN on outgoing calls.
It looks to be a long-standing misinterpretation of the progress indicator
ie values:
1 - Call is not end-to-end ISDN; further call progress information may be
available in-band.
8 - In-band information or an appropriate pattern is now available.
Only value 8 is handled by chan_dahdi/sig_pri. The 1 value is not handled
as early media probably because the meaning of the second half of it's
description was overlooked.
* Test to see if either PRI_PROG_CALL_NOT_E2E_ISDN(1) or
PRI_PROG_INBAND_AVAILABLE(8) bits are set to open the media path.
(closes issue #18868)
Reported by: isrl
Patches:
issue18868_19246_v1.8.patch uploaded by rmudgett (license 664)
Tested by: satish_lx
..........
No inband progress on PRI_EVENT_RINGING even if inband flag set.
My ISDN-PRI provider sends an ALERTING with "Inband information or
appropriate pattern now available", but Asterisk only generates and passes
the RING to the SIP extension, not the inband message. Unfortunately, the
inband message is not a ringback tone but a prompt that says the number is
not in service. The SIP extension then hears two rings and the call is
hungup which confuses the caller.
* Post an AST_CONTROL_PROGRESS as well as opening the media path if inband
audio is indicated with an ALERTING message.
(closes issue #19246)
Reported by: cristiandimache
Patches:
issue19246_v1.8.patch uploaded by rmudgett (license 664)
Tested by: cristiandimache
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318231
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Mon, 9 May 2011 14:18:14 +0000 (14:18 +0000)]
Documenting an observed behavior of features in features.conf. Since parkinglots use an
integer for the parkinglot extensions, leading zeros specified in the configuration file
are ignored.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318148
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Mon, 9 May 2011 14:09:38 +0000 (14:09 +0000)]
Make indicate/control frames WRITE events on framehooks. Also, if a framehook
returns a non-control frame, don't forward it to the channel.
(closes issue #19251)
Reported by: irroot
Patches:
(modified) framehook_indicate.patch2 uploaded by irroot (license 52)
Tested by: irroot
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318142
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sat, 7 May 2011 23:35:37 +0000 (23:35 +0000)]
res_config_curl: fix a crash with static realtime.
(closes issue #18413)
Reported by: jmls
Patches:
20101202__issue18413.diff.txt uploaded by tilghman (license 14)
Tested by: jmls
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318057
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sat, 7 May 2011 23:24:18 +0000 (23:24 +0000)]
chan_iax2: Don't overwrite port found with an SRV lookup.
(closes issue #17291)
Reported by: jcovert
Patches:
chan_iax2.c.1.8.3-srvlookup-corrected.patch uploaded by jcovert (license 551)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318055
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 21:49:01 +0000 (21:49 +0000)]
Use the right variable to print the time in a debug message.
The original patch also increased some buffer sizes, but that was already
done in this version.
(closes issue #17034)
Reported by: sysreq
Patches:
asterisk-issue-17034.patch uploaded by sysreq (license 1009)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317969
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 21:38:54 +0000 (21:38 +0000)]
Fix some more "set but unused" compiler warnings.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317967
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Fri, 6 May 2011 21:06:55 +0000 (21:06 +0000)]
Fixes missing colon from To/From headers in RTCP manager events.
(closes issue #18221)
Reported by: clegall_proformatique
Patches:
18221_1.patch uploaded by ebroad (license 878)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317918
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 21:06:33 +0000 (21:06 +0000)]
Fix calculation of free RAM to make minmemfree option work.
(closes issue #17124)
Reported by: loic
Patches:
pbx_c.diff uploaded by loic (license 1020)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317917
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 20:01:16 +0000 (20:01 +0000)]
chan_sip: Destroy variables on a sip_pvt before copying vars from the sip_peer.
Don't duplicate variables on the sip_pvt. Just reset the variable list each
time.
(closes issue #19202)
Reported by: wdoekes
Patches:
issue19202_destroy_challenged_invite_chanvars.patch uploaded by wdoekes (license 717)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317867
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 19:46:49 +0000 (19:46 +0000)]
chan_sip: fix a deadlock in check_rtp_timeout.
Don't block doing silly deadlock avoidance. Just return and try again later.
The funciton gets called often enough that it's fine. Also, this change was
already made in trunk.
(closes issue #18791)
Reported by: irroot
Patches:
chan_sip.rtptimeout.patch uploaded by irroot (license 52)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317865
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 19:35:00 +0000 (19:35 +0000)]
URI encode less characters in the RPID and Contact headers.
If this change causes any problems, we will need to backport the more extensive
uri encoding and decoding handling changes that are in trunk/1.10.
(closes issue #18686)
Reported by: wolfgang
Patches:
quick-and-dirty.patch uploaded by wdoekes (license 717)
Tested by: wdoekes, devellow, wolfgang, mav3rick
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317861
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Fri, 6 May 2011 19:31:50 +0000 (19:31 +0000)]
pbx_lua autoservice fixes
Don't start an autoservice in pbx_lua if pbx_lua already started one and don't
stop one if we didn't start one. Also start and stop the autoservice when
transferring control from and to the pbx.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317858
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 19:24:11 +0000 (19:24 +0000)]
Fix a crash in the MySQL() application.
This code was not handling channel datastores safely. The channel
must be locked.
(closes issue #17964)
Reported by: wuwu
Patches:
issue17964_addon_1.6.2_svn.patch uploaded by seanbright (license 71)
Tested by: wuwu
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317837
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 19:14:39 +0000 (19:14 +0000)]
Add a new sipfriends.sql for MySQL that has more fields in it.
(closes issue #16399)
Reported by: pabelanger
Patches:
sipfriends.sql.v3 uploaded by pabelanger (license 224)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317805
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 6 May 2011 16:19:18 +0000 (16:19 +0000)]
Fix SIP connected line updates.
This patch fixes a couple SIP connected line update problems:
1) The connected line needs to be updated when the initial INVITE is sent
if there is a peer callerid configured. Previously, the connected line
information did not get reported until the call was connected so SIP could
not report connected line information in ringing or progress messages.
2) The connected line should not be updated on initial connect if there is
no connected line information. Previously, all it did was wipe out any
default preset CONNECTEDLINE information set by the dialplan with empty
strings.
(closes issue #18367)
Reported by: GeorgeKonopacki
Patches:
issue18367_v1.8.patch uploaded by rmudgett (license 664)
Tested by: rmudgett
Review: https://reviewboard.asterisk.org/r/1199/
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317670
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 6 May 2011 08:18:53 +0000 (08:18 +0000)]
Merged revisions 317575 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r317575 | twilson | 2011-05-06 01:04:17 -0700 (Fri, 06 May 2011) | 13 lines
Merged revisions 317574 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r317574 | twilson | 2011-05-06 00:55:21 -0700 (Fri, 06 May 2011) | 6 lines
Re-fix queue round-robin
This part of the change for r315596 was incorrect. No bridge occurs
when doing a roundrobin dial and no one answers, so this code shouldn't
have been removed.
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317584
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 23:46:54 +0000 (23:46 +0000)]
If the configure script runs, force a rebuild of menuselect-tree.
Some contents in the menuselect tree are dependent on configure script
parameters, namely --enable-dev-mode.
(closes issue #17219)
Reported by: Nick_Lewis
Patches:
issue_17219.rev1.txt uploaded by russell (license 2)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317530
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 23:15:53 +0000 (23:15 +0000)]
Fix some more realtime MySQL schema issues.
(closes issue #18537)
Reported by: denzs
Patches:
sipfriends.sql.svndiff uploaded by denzs (license 1182)
queue_log.sql.svndiff uploaded by denzs (license 1182)
meetme.sql.svndiff uploaded by denzs (license 1182)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317486
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 23:12:35 +0000 (23:12 +0000)]
Fix some errors in sample MySQL realtime schema files.
(closes issue #18915)
Reported by: Dovid
Patches:
sipfriends.patch uploaded by Dovid (license 652)
meetme.patch uploaded by Dovid (license 652)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317484
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 23:00:55 +0000 (23:00 +0000)]
Don't lose cdr_syslog config on a reload.
(closes issue #18679)
Reported by: enegaard
Patches:
issue18679_seanbright.patch uploaded by seanbright (license 71)
Tested by: enegaard
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317480
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 22:53:45 +0000 (22:53 +0000)]
Fix some consistency issues with jitterbuffer config.
Store the defaults noted in the sample config files in the jitterbuffer config
data structure. This makes the CLI commands that output these settings show
the right thing. Also only show the settings that are relevant in the settings
CLI commands, based on which jitterbuffer is selected and whether it's enabled.
(closes issue #19083)
Reported by: rgagnon
Patches:
issue-19083-trunk-r313139.diff uploaded by rgagnon (license 1202)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317478
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 22:47:57 +0000 (22:47 +0000)]
Add a datastore fixup to fix a pbx_lua crash.
(closes issue #19055)
Reported by: jamhed
Patches:
lua_datastore_fixup1.diff uploaded by mnicholson (license 96)
Tested by: mnicholson, jamhed
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317476
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 22:36:33 +0000 (22:36 +0000)]
Fix more "set but unused" warnings.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317474
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 22:11:19 +0000 (22:11 +0000)]
Only display inband DTMF warning if inband DTMF detection is enabled.
(closes issue #18901)
Reported by: irroot
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317429
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 21:58:45 +0000 (21:58 +0000)]
Fix potential memory leak, and use of uninitialized memory.
(closes issue #16476)
Reported by: junky
Patches:
M16476.diff uploaded by junky (license 177)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317427
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 21:53:13 +0000 (21:53 +0000)]
Add missing ActioID handling to Events action.
(closes issue #18949)
Reported by: edersohe
Patches:
0018949 .patch uploaded by edersohe (license 1228)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317425
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 5 May 2011 20:25:52 +0000 (20:25 +0000)]
Don't duplicate our data on the stack and just use the MYSQL_ROW directly.
With large result sets we were blowing out the stack.
(closes issue #19090)
Reported by: mickecarlsson
Patches:
issue19090_trunk_svn.patch uploaded by seanbright (license 71)
Tested by: mickecarlsson
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317370
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 19:55:58 +0000 (19:55 +0000)]
Increase buffer size to be PATH_MAX for a path.
(closes issue #19239)
Reported by: byronclark
Patches:
queue_announce_length.patch uploaded by byronclark (license 1200)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317336
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Thu, 5 May 2011 19:09:13 +0000 (19:09 +0000)]
Resolves a deadlock that occurs during sip_new
This is based on an uncommitted patch by jpeeler for the issue. Instead of
relocking and then unlocking the channel though, we keep the lock on the channel
until we are finished doing what we need to the channel.
(closes issue #18441)
Reported by: Alric
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317283
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 18:39:44 +0000 (18:39 +0000)]
Merged revisions 317255 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r317255 | russell | 2011-05-05 13:29:53 -0500 (Thu, 05 May 2011) | 22 lines
Merged revisions 317211 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r317211 | russell | 2011-05-05 13:20:29 -0500 (Thu, 05 May 2011) | 15 lines
chan_sip: fix broken realtime peer count, fix memory leak
This patch addresses two bugs in chan_sip:
1) The count of realtime peers and users was off. The increment checked the
value of the caching option, while the decrement did not.
2) Add a missing regfree() for a regex.
(closes issue #19108)
Reported by: vrban
Patches:
missing_regfree.patch uploaded by vrban (license 756)
sip_object_counter.patch uploaded by vrban (license 756)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317281
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 18:37:09 +0000 (18:37 +0000)]
Restore branch-1.6.2-merged and branch-1.6.2-blocked properties.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317280
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Thu, 5 May 2011 18:02:52 +0000 (18:02 +0000)]
Set SO_KEEPALIVE on SIP TCP sockets so that they eventually go away when a peer
abruptly disappears. This mostly occurs after a successful registration.
(closes issue #17544)
Reported by: marcelloceschia
Patches:
(modified) tcptls.patch uploaded by st (license 907)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317196
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Thu, 5 May 2011 15:04:24 +0000 (15:04 +0000)]
Merged revisions 317102 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r317102 | lmadsen | 2011-05-05 10:54:46 -0400 (Thu, 05 May 2011) | 8 lines
Disable console colourization inside safe_asterisk checks.
(closes issue #19213)
Reported by: lefoyer
Patches:
issue19213_strip_color_in_safe_asterisk-svn.patch uploaded by wdoekes (license 717)
Tested by: wdoekes, lefoyer
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317104
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Thu, 5 May 2011 12:27:56 +0000 (12:27 +0000)]
Remove unused directory and clear up some documentation.
(closes issue #19193)
Reported by: bchia
Patches:
cel-csv.diff uploaded by lathama (license 1028)
Tested by: lathama, Marquis42
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317058
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 5 May 2011 02:30:45 +0000 (02:30 +0000)]
Use the correct HTTP method when generating our digest, otherwise we always fail.
When calculating the 'A2' portion of our digest for verification, we need the
HTTP method that is currently in use. Unfortunately our mapping function was
incorrect, resulting in invalid hashes being generated and, in turn, failures
in authentication.
(closes issue #18598)
Reported by: ksn
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316919
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 5 May 2011 02:25:20 +0000 (02:25 +0000)]
Look at the correct buffer for our digest info instead of an empty one.
(issue #18598)
Reported by: ksn
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316918
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 5 May 2011 02:23:28 +0000 (02:23 +0000)]
Make sure that tcptls_session is properly initialized.
(issue #18598)
Reported by: ksn
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316917
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Alexandr Anikin [Wed, 4 May 2011 20:50:18 +0000 (20:50 +0000)]
Fix trivial bug in ooSocket.c codes
Revert condition for result code of
ast_gethostbyname
(closes issue #19185)
Reported by: dswartz
Patches:
issue19185-patch uploaded by may213 (license 454)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316874
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 4 May 2011 18:51:40 +0000 (18:51 +0000)]
Wait for leader with Music On Hold allows crosstalk between participants.
Parenthesis in the wrong position. Regression from issue #14365 when
expanding conference flags to use 64 bits.
(closes issue #18418)
Reported by: MrHanMan
Tested by: rmudgett
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316831
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Wed, 4 May 2011 16:15:32 +0000 (16:15 +0000)]
Merged revisions 316708 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r316708 | seanbright | 2011-05-04 12:10:59 -0400 (Wed, 04 May 2011) | 15 lines
Merged revisions 316707 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r316707 | seanbright | 2011-05-04 12:08:50 -0400 (Wed, 04 May 2011) | 8 lines
If sox fails when processing a voicemail, don't delete the original file.
(closes issue #18111)
Reported by: sysreq
Patches:
issue18111_trunk.patch uploaded by seanbright (license 71)
Tested by: seanbright
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316709
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Wed, 4 May 2011 14:35:05 +0000 (14:35 +0000)]
Only return a single error via AMI when requesting a forbidden action.
(closes issue #19216)
Reported by: oej
Patches:
issue19216-1.8-r316204.patch uploaded by seanbright (license 71)
Tested by: seanbright
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316663
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Wed, 4 May 2011 14:25:03 +0000 (14:25 +0000)]
Merged revisions 316644 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r316644 | dvossel | 2011-05-04 09:23:39 -0500 (Wed, 04 May 2011) | 9 lines
Fixes one-way-audio when chanspy activated with the 'o' option
(closes issue #18382)
Reported by: jkister
Patches:
0001-Bugfix-18382-one-way-audio-when-chanspy-activated.patch.txt uploaded by malin (license )
Tested by: firstsip, Greenlightcrm, malin, wdoekes, boroda, dvossel
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316650
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Wed, 4 May 2011 13:44:41 +0000 (13:44 +0000)]
Merged revisions 316616 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r316616 | dvossel | 2011-05-04 08:40:41 -0500 (Wed, 04 May 2011) | 12 lines
Fixes session-timers=refuse not being enforced for *caller*
During handle_request_invite, the session timer mode was retrieved from
a cached variable. This patch forces a peer lookup of the session timer
mode in the case of an incoming invite.
(closes issue #18804)
Reported by: wdoekes
Patches:
issue18804_session_timer_refuse_caller.patch uploaded by wdoekes (license 717)
issue_18804_v2.diff uploaded by dvossel (license 671)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316617
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Wed, 4 May 2011 02:34:01 +0000 (02:34 +0000)]
Merged revisions 316475 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r316475 | seanbright | 2011-05-03 22:23:01 -0400 (Tue, 03 May 2011) | 10 lines
Honor the C option to MeetMe when L is passed.
This fixes a case that r304773 and friends missed.
(closes issue #17317)
Reported by: var
Patches:
meetme-continue-on-l_16218.diff uploaded by var (license 1227)
Tested by: seanbright
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316476
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 4 May 2011 00:12:25 +0000 (00:12 +0000)]
Escape column names in case they contain illegal characters ('-') or reserved words.
(closes issue #19063)
Reported by: festr
Patches:
patch uploaded by festr (license 443)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316429
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 3 May 2011 22:13:31 +0000 (22:13 +0000)]
Use htons() instead of ntohs() in some places.
(closes issue #19200)
Reported by: wdoekes
Patches:
issue19200-trunk.patch uploaded by wdoekes (license 717)
issue19200-1.8.x.patch uploaded by wdoekes (license 717)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316336
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Tue, 3 May 2011 22:05:59 +0000 (22:05 +0000)]
Fixes framehook segfault on indicate
(closes issue #19215)
Reported by: irroot
Patches:
framehook_indicate.patch uploaded by irroot (license 52)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316334
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 3 May 2011 21:41:11 +0000 (21:41 +0000)]
Resolve another warning.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316331
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Tue, 3 May 2011 21:37:59 +0000 (21:37 +0000)]
Merged revisions 316329 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r316329 | dvossel | 2011-05-03 16:29:55 -0500 (Tue, 03 May 2011) | 17 lines
Merged revisions 316328 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r316328 | dvossel | 2011-05-03 16:27:59 -0500 (Tue, 03 May 2011) | 10 lines
Fixes chan_local crashs in local_fixup()
Thanks OEJ for tracking down the issue and submitting the patch.
(closes issue #19053)
Reported by: oej
Tested by: oej
Review: https://reviewboard.asterisk.org/r/1158/
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316330
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 3 May 2011 19:55:49 +0000 (19:55 +0000)]
Fix a bunch of compiler warnings generated by gcc 4.6.0.
Most of these are -Wunused-but-set-variable, but there were a few others
mixed in here, as well.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316265
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 3 May 2011 19:18:30 +0000 (19:18 +0000)]
The dahdi_hangup() call does not clean up the channel fully.
After dahdi_hangup() has supposedly hungup an ISDN channel there is still
traffic on the S0-bus because the channel was not cleaned up fully.
Shuffled the hangup code to include some missing cleanup. Also fixed some
code formatting in the area. I think the primary missing clean up code
was the call to tone_zone_play_tone() to turn off any active tones on the
channel.
(closes issue #19188)
Reported by: jg1234
Patches:
issue19188_v1.8.patch uploaded by rmudgett (license 664)
Tested by: jg1234
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316224
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Tue, 3 May 2011 18:59:06 +0000 (18:59 +0000)]
Never put the Require: timer header in an Invite.
This has already been discussed and should have been resolved earlier. View
revsion 285565's log for more information about why it is important to not
put timer in the Require header.
(closes issue #18704)
Reported by: mfrager
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316217
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Tue, 3 May 2011 18:49:48 +0000 (18:49 +0000)]
Fixes a random crash (NULL reference) in res_odbc.c.
(closes issue #19180)
Reported by: pruiz
Patches:
tmp.diff uploaded by pruiz (license 1152)
Tested by: pruiz, seanbright
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316215
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Tue, 3 May 2011 18:17:36 +0000 (18:17 +0000)]
If we aren't interested in events, don't generate the FullyBooted event on AMI login.
(closes issue #19089)
Reported by: bklang
Patches:
issue19089-1.8-r316204.patch uploaded by seanbright (license 71)
Tested by: seanbright
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316206
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Tzafrir Cohen [Tue, 3 May 2011 10:57:16 +0000 (10:57 +0000)]
Re-fix bashism in ./configure: s/let/$(( ))/
A forward-port in r278985 accidentally re-introduced issue 17485. Fixing
it. Thanks to Jilles Tjoelker for the good report.
(closes issue #17485)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316193
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 2 May 2011 19:09:55 +0000 (19:09 +0000)]
Merged revisions 316093 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r316093 | tilghman | 2011-05-02 14:04:36 -0500 (Mon, 02 May 2011) | 8 lines
More possible crashes based upon invalid inputs.
(closes issue #18161)
Reported by: wdoekes
Patches:
20110301__issue18161.diff.txt uploaded by tilghman (license 14)
Tested by: wdoekes
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316094
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Wed, 27 Apr 2011 19:14:27 +0000 (19:14 +0000)]
Merged revisions 315893 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r315893 | mnicholson | 2011-04-27 14:03:05 -0500 (Wed, 27 Apr 2011) | 21 lines
Merged revisions 315891 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r315891 | mnicholson | 2011-04-27 13:57:56 -0500 (Wed, 27 Apr 2011) | 14 lines
Fix our compliance with RFC 3261 section 18.2.2.
This change optimizes the free_via() function and removes some redundant null
checking. It also fixes compliance with RFC 3261 section 18.2.2 by always using
the port specified in the Via header for routing responses (even when maddr is
not set). Also the htons() function is now used when setting the port.
Additional documentation comments have been added in various places to make the
logic in the code clearer.
(closes issue #18951)
Reported by: jmls
Patches:
issue18951_set_proper_port_from_via.patch uploaded by wdoekes (license 717) (modified)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315894
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 27 Apr 2011 15:55:48 +0000 (15:55 +0000)]
Set the copyright year to 2011 in the startup message.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315810
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Wed, 27 Apr 2011 12:36:17 +0000 (12:36 +0000)]
Enable Russian core sound selection in menuselect.
(closes issue #18724)
Reported by: pbxware
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315765
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Tue, 26 Apr 2011 22:56:19 +0000 (22:56 +0000)]
Merged revisions 315672 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r315672 | twilson | 2011-04-26 15:52:25 -0700 (Tue, 26 Apr 2011) | 18 lines
Merged revisions 315671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r315671 | twilson | 2011-04-26 15:47:56 -0700 (Tue, 26 Apr 2011) | 11 lines
Make sure unregistering a peer unlinks it from the peer container
Instead of mostly copying the code from expire_register, just use the function
that "does the right thing".
(closes issue #16033)
Reported by: kkm
Patches:
016033-tilgman-fixed-refcount.diff uploaded by kkm (license 888)
Tested by: kkm, tilghman, twilson
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315673
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 26 Apr 2011 22:14:31 +0000 (22:14 +0000)]
The 'e' special extension fails to trigger in at least two cases.
The 'e' extension is a fall back for the 'i', 't', or 'T' extensions if
any of them do not exist. Many of the places the 'e' extension was
supposed to be invoked fail because the priority was set wrong. There
were two places where the 'e' extension was not even checked for fall
back.
* Made invoke the 'e' extension similarly to the previous 'i', 't', or 'T'
extension check and added the 'e' extension as a fall back to the two
missing locations.
* Prioritized and optimized some hangup tests associated with the 'e'
extension.
(closes issue #19136)
Reported by: kshumard
Tested by: rmudgett
Review: https://reviewboard.asterisk.org/r/1196/
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315645
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Tue, 26 Apr 2011 21:39:01 +0000 (21:39 +0000)]
Merged revisions 315643 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r315643 | twilson | 2011-04-26 14:27:44 -0700 (Tue, 26 Apr 2011) | 25 lines
Merged revisions 315596 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r315596 | twilson | 2011-04-26 14:16:10 -0700 (Tue, 26 Apr 2011) | 18 lines
Allow transfer loops without allowing forwarding loops
We try to avoid the situation where two phones may be forwarded to each other
causing an infinite loop by storing each dialed interface in a channel
datastore and checking the list before dialing out. This works, but currently
breaks situations like A calls B, A transfers B to C, B transfers C to A, and A
transfers C to B. Since human interaction is happening here and not an
automated forwarding loop, it should be allowed.
This patch removes the dialed_interfaces datastore when a call is bridged (a
suggestion from the brilliant mmichelson). If a call is being bridged, it
should be safe to assume that we aren't stuck in a loop.
Since we are now handling this is the bridge code, the previous attempts at
handling it in app_dial and app_queue are removed.
Review: https://reviewboard.asterisk.org/r/1195/
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315644
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 26 Apr 2011 19:32:50 +0000 (19:32 +0000)]
Merged revisions 315502 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r315502 | tilghman | 2011-04-26 14:22:52 -0500 (Tue, 26 Apr 2011) | 21 lines
Merged revisions 315501 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r315501 | tilghman | 2011-04-26 14:18:46 -0500 (Tue, 26 Apr 2011) | 14 lines
Fix the bounds-checking code.
The code that set the bit within the select bitfield was correct, but the
bounds-checking code was not. The change to that line uses the new _bitsize
macro for clarity. Also, FD_ZERO macro did not zero-out anything but the
first word of the bitfield, so this could have caused problems with modules
using that macro with the expanded bitfield.
(closes issue #18773)
Reported by: jamicque
Patches:
20110423__issue18773.diff.txt uploaded by tilghman (license 14)
Tested by: chris-mac
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315503
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 26 Apr 2011 18:00:34 +0000 (18:00 +0000)]
Add missing set of name valid flag when dialing.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315452
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 26 Apr 2011 17:40:23 +0000 (17:40 +0000)]
chan_local: resolve a deadlock.
This patch resolves a fairly complex deadlock that can occur with the
combination of chan_local and a dialplan switch, such as dynamic realtime
extensions, which pulls autoservice into the picture when doing a dialplan
lookup.
(closes issue #18818)
Reported by: nic
Patches:
issue18818.patch uploaded by jthurman (license 614)
18818.v1.txt uploaded by russell (license 2)
Tested by: nic, jthurman, kterzi, steve-howes, sysreq, IshMalik
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315446
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Tue, 26 Apr 2011 02:18:50 +0000 (02:18 +0000)]
Merged revisions 315393 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r315393 | pabelanger | 2011-04-25 22:17:43 -0400 (Mon, 25 Apr 2011) | 7 lines
Add back CLI command 'dialplan save'
(closes issue #19140)
Reported by: lmadsen
Patches:
__20110419_dialplan_save.patch.txt uploaded by lmadsen (license 10)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315394
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 25 Apr 2011 21:49:00 +0000 (21:49 +0000)]
When using MGCP realtime gateway definitions, random crashes occur.
Fixed incorrect linked list node removal for realtime gateways.
(closes issue #18291)
Reported by: nahuelgreco
Patches:
dangling-pointers-when-pruning.patch uploaded by nahuelgreco (license 162)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315349
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Mon, 25 Apr 2011 19:37:32 +0000 (19:37 +0000)]
Merged revisions 315258 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r315258 | russell | 2011-04-25 14:31:44 -0500 (Mon, 25 Apr 2011) | 17 lines
Merged revisions 315257 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r315257 | russell | 2011-04-25 14:28:41 -0500 (Mon, 25 Apr 2011) | 10 lines
Be more flexible with unknown chunks in wav files.
This patch makes format_wav ignore unknown chunks instead of erroring
out on them.
(closes issue #18306)
Reported by: jhirsch
Patches:
wav_skip_unknown_blocks.diff uploaded by jhirsch (license 1156)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315259
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Mon, 25 Apr 2011 19:04:28 +0000 (19:04 +0000)]
Merged revisions 315212 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r315212 | russell | 2011-04-25 14:00:24 -0500 (Mon, 25 Apr 2011) | 7 lines
Don't link non-cached realtime peers into the peers_by_ip container.
(closes issue #18924)
Reported by: wdoekes
Patches:
issue18924_uncached_realtime_peers_leak-1.6.2.17.patch uploaded by wdoekes (license 717)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315213
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Alec L Davis [Mon, 25 Apr 2011 07:14:32 +0000 (07:14 +0000)]
Merged revisions 315052 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r315052 | alecdavis | 2011-04-25 19:11:12 +1200 (Mon, 25 Apr 2011) | 16 lines
Merged revisions 315051 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r315051 | alecdavis | 2011-04-25 19:06:29 +1200 (Mon, 25 Apr 2011) | 11 lines
chan_local:check_bridge() misplaced misplaced ast_mutex_unlock
if !p->chan->_bridge->_softhangup path isn't followed, brigde remains locked.
(closes issue #19176)
Reported by: alecdavis
Patches:
bug19176.diff.txt uploaded by alecdavis (license 585)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315053
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Alec L Davis [Fri, 22 Apr 2011 22:59:18 +0000 (22:59 +0000)]
chan_dahdi: Can't return to normal ring after distinctive ring on FXS
clear a previous distinctivering pattern before each new call
(closes issue #18985)
Reported by: bromont
Patches:
bug18985.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis, bromont
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315001
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Fri, 22 Apr 2011 21:20:08 +0000 (21:20 +0000)]
Merged revisions 314958 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r314958 | mnicholson | 2011-04-22 15:49:45 -0500 (Fri, 22 Apr 2011) | 17 lines
Merged revisions 311203,314908 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r311203 | mnicholson | 2011-03-17 14:14:37 -0500 (Thu, 17 Mar 2011) | 4 lines
Don't hold the pvt lock while streaming a file.
ABE-2756
........
r314908 | mnicholson | 2011-04-22 15:01:48 -0500 (Fri, 22 Apr 2011) | 4 lines
Prevent the login thread and the app threads from using the asterisk channel at the same time.
ABE-2756
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314959
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 22 Apr 2011 14:02:23 +0000 (14:02 +0000)]
Merged revisions 314778 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r314778 | russell | 2011-04-22 08:58:03 -0500 (Fri, 22 Apr 2011) | 11 lines
Initialize buffers in getvar and getvarfull.
Initialize the buffers used to hold the result from GET VARIABLE or
GET VARIABLE FULL. The bug report shows func_read returning garbage in
the result. It assumed that the buffer passed in was initialized, like many
other functions do. In the more common code path (through the dialplan), it
is initialized, so just initialize it here too.
(closes issue #19050)
Reported by: johnz
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314780
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Tzafrir Cohen [Fri, 22 Apr 2011 13:59:43 +0000 (13:59 +0000)]
Fix a few typos (shown by Lintian)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314779
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 22 Apr 2011 13:35:59 +0000 (13:35 +0000)]
Recorded merge of revisions 314776 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r314776 | russell | 2011-04-22 08:35:22 -0500 (Fri, 22 Apr 2011) | 10 lines
Fix handling of some call parking config options.
This patch adjusts the handling of some call parking config options to fix some
issues that have already been addressed in 1.8 and trunk.
(closes issue #19167)
Reported by: bluecrow76
Patches:
asterisk-1.6.2.17.2-fix-build-parkinglot-parked-AST_FEATURE_FLAGS.diff uploaded by bluecrow76 (license 270)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314777
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Thu, 21 Apr 2011 22:38:44 +0000 (22:38 +0000)]
Correct DAHDIShowChannels XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314732
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Thu, 21 Apr 2011 18:24:05 +0000 (18:24 +0000)]
Merged revisions 314620 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r314620 | mnicholson | 2011-04-21 13:22:19 -0500 (Thu, 21 Apr 2011) | 20 lines
Merged revisions 314607 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r314607 | mnicholson | 2011-04-21 13:19:21 -0500 (Thu, 21 Apr 2011) | 14 lines
Added limits to the number of unauthenticated sessions TCP based protocols are allowed to have open simultaneously. Also added timeouts for unauthenticated sessions where it made sense to do so.
Unrelated, the manager interface now properly checks if the user has the "system" privilege before executing shell commands via the Originate action.
AST-2011-005
AST-2011-006
(closes issue #18787)
Reported by: kobaz
(related to issue #18996)
Reported by: tzafrir
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314628
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3